replaced type input by getRenderType method

This commit is contained in:
lotte
2019-10-04 16:06:59 +02:00
parent 9badabade6
commit a1f144aa0b
102 changed files with 452 additions and 755 deletions

View File

@@ -1,6 +1,6 @@
<div class="row" *ngIf="item"> <div class="row" *ngIf="item">
<div class="col-10 relationship"> <div class="col-10 relationship">
<ds-item-type-switcher [object]="item" [viewMode]="viewMode"></ds-item-type-switcher> <ds-listable-object-component-loader [object]="item" [viewMode]="viewMode"></ds-listable-object-component-loader>
</div> </div>
<div class="col-2"> <div class="col-2">
<div class="btn-group relationship-action-buttons"> <div class="btn-group relationship-action-buttons">

View File

@@ -1,7 +1,7 @@
<div class="container" *ngVar="(itemRD$ | async) as itemRD"> <div class="container" *ngVar="(itemRD$ | async) as itemRD">
<div class="item-page" *ngIf="itemRD?.hasSucceeded" @fadeInOut> <div class="item-page" *ngIf="itemRD?.hasSucceeded" @fadeInOut>
<div *ngIf="itemRD?.payload as item"> <div *ngIf="itemRD?.payload as item">
<ds-item-type-switcher [object]="item" [viewMode]="viewMode"></ds-item-type-switcher> <ds-listable-object-component-loader [object]="item" [viewMode]="viewMode"></ds-listable-object-component-loader>
</div> </div>
</div> </div>
<ds-error *ngIf="itemRD?.hasFailed" message="{{'error.item' | translate}}"></ds-error> <ds-error *ngIf="itemRD?.hasFailed" message="{{'error.item' | translate}}"></ds-error>

View File

@@ -1,5 +1,5 @@
<ds-metadata-field-wrapper *ngIf="representations && representations.length > 0" [label]="label"> <ds-metadata-field-wrapper *ngIf="representations && representations.length > 0" [label]="label">
<ds-item-type-switcher *ngFor="let rep of representations" <ds-listable-object-component-loader *ngFor="let rep of representations"
[object]="rep" [viewMode]="viewMode"> [object]="rep" [viewMode]="viewMode">
</ds-item-type-switcher> </ds-listable-object-component-loader>
</ds-metadata-field-wrapper> </ds-metadata-field-wrapper>

View File

@@ -33,7 +33,7 @@ describe('MetadataRepresentationListComponent', () => {
})); }));
it(`should load ${representations.length} item-type-switcher components`, () => { it(`should load ${representations.length} item-type-switcher components`, () => {
const fields = fixture.debugElement.queryAll(By.css('ds-item-type-switcher')); const fields = fixture.debugElement.queryAll(By.css('ds-listable-object-component-loader'));
expect(fields.length).toBe(representations.length); expect(fields.length).toBe(representations.length);
}); });

View File

@@ -1,5 +1,5 @@
<ds-metadata-field-wrapper *ngIf="items && items.length > 0" [label]="label"> <ds-metadata-field-wrapper *ngIf="items && items.length > 0" [label]="label">
<ds-item-type-switcher *ngFor="let item of items" <ds-listable-object-component-loader *ngFor="let item of items"
[object]="item" [viewMode]="viewMode"> [object]="item" [viewMode]="viewMode">
</ds-item-type-switcher> </ds-listable-object-component-loader>
</ds-metadata-field-wrapper> </ds-metadata-field-wrapper>

View File

@@ -45,7 +45,7 @@ describe('RelatedItemsComponent', () => {
})); }));
it(`should load ${mockItems.length} item-type-switcher components`, () => { it(`should load ${mockItems.length} item-type-switcher components`, () => {
const fields = fixture.debugElement.queryAll(By.css('ds-item-type-switcher')); const fields = fixture.debugElement.queryAll(By.css('ds-listable-object-component-loader'));
expect(fields.length).toBe(mockItems.length); expect(fields.length).toBe(mockItems.length);
}); });

View File

@@ -16,4 +16,7 @@ export class MyDSpaceResult<T extends DSpaceObject> implements ListableObject {
*/ */
hitHighlights: MetadataMap; hitHighlights: MetadataMap;
getRenderType(): string {
return this.indexableObject.getRenderType() + 'MyDSpaceResult';
}
} }

View File

@@ -1,13 +1,12 @@
import { autoserialize, inheritSerialization } from 'cerialize'; import { autoserialize, inheritSerialization } from 'cerialize';
import { MetadataMap } from '../core/shared/metadata.models'; import { MetadataMap } from '../core/shared/metadata.models';
import { ListableObject } from '../shared/object-collection/shared/listable-object.model';
import { NormalizedObject } from '../core/cache/models/normalized-object.model'; import { NormalizedObject } from '../core/cache/models/normalized-object.model';
/** /**
* Represents a normalized version of a search result object of a certain DSpaceObject * Represents a normalized version of a search result object of a certain DSpaceObject
*/ */
@inheritSerialization(NormalizedObject) @inheritSerialization(NormalizedObject)
export class NormalizedSearchResult implements ListableObject { export class NormalizedSearchResult {
/** /**
* The UUID of the DSpaceObject that was found * The UUID of the DSpaceObject that was found
*/ */
@@ -19,5 +18,4 @@ export class NormalizedSearchResult implements ListableObject {
*/ */
@autoserialize @autoserialize
hitHighlights: MetadataMap; hitHighlights: MetadataMap;
} }

View File

@@ -5,7 +5,6 @@ import { SharedModule } from '../shared/shared.module';
import { SearchPageRoutingModule } from './search-page-routing.module'; import { SearchPageRoutingModule } from './search-page-routing.module';
import { SearchPageComponent } from './search-page.component'; import { SearchPageComponent } from './search-page.component';
import { SearchResultsComponent } from './search-results/search-results.component'; import { SearchResultsComponent } from './search-results/search-results.component';
import { ItemSearchResultGridElementComponent } from '../shared/object-grid/search-result-grid-element/item-search-result/item-search-result-grid-element.component';
import { CommunitySearchResultGridElementComponent } from '../shared/object-grid/search-result-grid-element/community-search-result/community-search-result-grid-element.component' import { CommunitySearchResultGridElementComponent } from '../shared/object-grid/search-result-grid-element/community-search-result/community-search-result-grid-element.component'
import { CollectionSearchResultGridElementComponent } from '../shared/object-grid/search-result-grid-element/collection-search-result/collection-search-result-grid-element.component'; import { CollectionSearchResultGridElementComponent } from '../shared/object-grid/search-result-grid-element/collection-search-result/collection-search-result-grid-element.component';
import { SearchSidebarComponent } from './search-sidebar/search-sidebar.component'; import { SearchSidebarComponent } from './search-sidebar/search-sidebar.component';
@@ -44,7 +43,6 @@ const components = [
SearchResultsComponent, SearchResultsComponent,
SearchSidebarComponent, SearchSidebarComponent,
SearchSettingsComponent, SearchSettingsComponent,
ItemSearchResultGridElementComponent,
CollectionSearchResultGridElementComponent, CollectionSearchResultGridElementComponent,
CommunitySearchResultGridElementComponent, CommunitySearchResultGridElementComponent,
SearchFiltersComponent, SearchFiltersComponent,
@@ -85,7 +83,6 @@ const components = [
SearchConfigurationService SearchConfigurationService
], ],
entryComponents: [ entryComponents: [
ItemSearchResultGridElementComponent,
CollectionSearchResultGridElementComponent, CollectionSearchResultGridElementComponent,
CommunitySearchResultGridElementComponent, CommunitySearchResultGridElementComponent,
SearchFacetFilterComponent, SearchFacetFilterComponent,

View File

@@ -16,4 +16,7 @@ export class SearchResult<T extends DSpaceObject> implements ListableObject {
*/ */
hitHighlights: MetadataMap; hitHighlights: MetadataMap;
getRenderType(): string {
return this.indexableObject.getRenderType() + 'SearchResult';
}
} }

View File

@@ -9,7 +9,7 @@ import { Group } from './group.model';
@mapsTo(EPerson) @mapsTo(EPerson)
@inheritSerialization(NormalizedDSpaceObject) @inheritSerialization(NormalizedDSpaceObject)
export class NormalizedEPerson extends NormalizedDSpaceObject<EPerson> implements CacheableObject, ListableObject { export class NormalizedEPerson extends NormalizedDSpaceObject<EPerson> implements CacheableObject {
/** /**
* A string representing the unique handle of this EPerson * A string representing the unique handle of this EPerson
*/ */

View File

@@ -8,7 +8,7 @@ import { Group } from './group.model';
@mapsTo(Group) @mapsTo(Group)
@inheritSerialization(NormalizedDSpaceObject) @inheritSerialization(NormalizedDSpaceObject)
export class NormalizedGroup extends NormalizedDSpaceObject<Group> implements CacheableObject, ListableObject { export class NormalizedGroup extends NormalizedDSpaceObject<Group> implements CacheableObject {
/** /**
* List of Groups that this Group belong to * List of Groups that this Group belong to

View File

@@ -50,4 +50,8 @@ export class MetadataField implements ListableObject {
} }
return key; return key;
} }
getRenderType(): string {
return this.constructor.name;
}
} }

View File

@@ -26,4 +26,8 @@ export class MetadataSchema implements ListableObject {
* The namespace of this metadata schema * The namespace of this metadata schema
*/ */
namespace: string; namespace: string;
getRenderType(): string {
return this.constructor.name;
}
} }

View File

@@ -10,7 +10,7 @@ import { MetadataSchema } from './metadata-schema.model';
*/ */
@mapsTo(MetadataField) @mapsTo(MetadataField)
@inheritSerialization(NormalizedObject) @inheritSerialization(NormalizedObject)
export class NormalizedMetadataField extends NormalizedObject<MetadataField> implements ListableObject { export class NormalizedMetadataField extends NormalizedObject<MetadataField> {
/** /**
* The identifier of this normalized metadata field * The identifier of this normalized metadata field

View File

@@ -9,7 +9,7 @@ import { MetadataSchema } from './metadata-schema.model';
*/ */
@mapsTo(MetadataSchema) @mapsTo(MetadataSchema)
@inheritSerialization(NormalizedObject) @inheritSerialization(NormalizedObject)
export class NormalizedMetadataSchema extends NormalizedObject<MetadataSchema> implements ListableObject { export class NormalizedMetadataSchema extends NormalizedObject<MetadataSchema> {
/** /**
* The unique identifier for this schema * The unique identifier for this schema
*/ */

View File

@@ -400,7 +400,7 @@ export class RegistryService {
distinctUntilChanged() distinctUntilChanged()
); );
const serializedSchema = new DSpaceRESTv2Serializer(getMapsToType(MetadataSchema.type)).serialize(schema as NormalizedMetadataSchema); const serializedSchema = new DSpaceRESTv2Serializer(getMapsToType(MetadataSchema.type)).serialize(schema);
const request$ = endpoint$.pipe( const request$ = endpoint$.pipe(
take(1), take(1),

View File

@@ -6,7 +6,7 @@ import { ResourceType } from './resource-type';
* Class object representing a browse entry * Class object representing a browse entry
* This class is not normalized because browse entries do not have self links * This class is not normalized because browse entries do not have self links
*/ */
export class BrowseEntry implements ListableObject, TypedObject { export class BrowseEntry implements ListableObject {
static type = new ResourceType('browseEntry'); static type = new ResourceType('browseEntry');
/** /**
@@ -28,4 +28,8 @@ export class BrowseEntry implements ListableObject, TypedObject {
* The count of this browse entry * The count of this browse entry
*/ */
count: number; count: number;
getRenderType(): string {
return (this as any).type.value;
}
} }

View File

@@ -146,4 +146,7 @@ export class DSpaceObject implements CacheableObject, ListableObject {
}); });
} }
getRenderType(): string {
return this.constructor.name;
}
} }

View File

@@ -110,4 +110,11 @@ export class Item extends DSpaceObject {
})); }));
} }
getRenderType(): string {
const entityType = this.firstMetadataValue('relationship.type');
if (isNotEmpty(entityType)) {
return entityType;
}
return 'Publication';
}
} }

View File

@@ -1,11 +1,10 @@
import { ItemSearchResult } from '../../../../shared/object-collection/shared/item-search-result.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { of as observableOf } from 'rxjs/internal/observable/of'; import { createSuccessfulRemoteDataObject$ } from '../../../../../shared/testing/utils';
import { getEntityGridElementTestComponent } from '../../../../shared/object-grid/item-grid-element/item-types/publication/publication-grid-element.component.spec'; import { PaginatedList } from '../../../../../core/data/paginated-list';
import { JournalIssueSearchResultGridElementComponent } from './journal-issue-grid-element.component'; import { PageInfo } from '../../../../../core/shared/page-info.model';
import { createSuccessfulRemoteDataObject$ } from '../../../../shared/testing/utils'; import { getEntityGridElementTestComponent } from '../../../../../shared/object-grid/search-result-grid-element/item-search-result/publication/publication-search-result-grid-element.component.spec';
import { PaginatedList } from '../../../../core/data/paginated-list'; import { JournalIssueSearchResultGridElementComponent } from './journal-issue-search-result-grid-element.component';
import { PageInfo } from '../../../../core/shared/page-info.model';
const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult(); const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult();
mockItemWithMetadata.hitHighlights = {}; mockItemWithMetadata.hitHighlights = {};

View File

@@ -1,11 +1,10 @@
import { ItemSearchResult } from '../../../../shared/object-collection/shared/item-search-result.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { of as observableOf } from 'rxjs/internal/observable/of'; import { createSuccessfulRemoteDataObject$ } from '../../../../../shared/testing/utils';
import { getEntityGridElementTestComponent } from '../../../../shared/object-grid/item-grid-element/item-types/publication/publication-grid-element.component.spec'; import { PaginatedList } from '../../../../../core/data/paginated-list';
import { JournalVolumeSearchResultGridElementComponent } from './journal-volume-grid-element.component'; import { PageInfo } from '../../../../../core/shared/page-info.model';
import { createSuccessfulRemoteDataObject$ } from '../../../../shared/testing/utils'; import { getEntityGridElementTestComponent } from '../../../../../shared/object-grid/search-result-grid-element/item-search-result/publication/publication-search-result-grid-element.component.spec';
import { PaginatedList } from '../../../../core/data/paginated-list'; import { JournalVolumeSearchResultGridElementComponent } from './journal-volume-search-result-grid-element.component';
import { PageInfo } from '../../../../core/shared/page-info.model';
const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult(); const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult();
mockItemWithMetadata.hitHighlights = {}; mockItemWithMetadata.hitHighlights = {};

View File

@@ -1,11 +1,10 @@
import { ItemSearchResult } from '../../../../shared/object-collection/shared/item-search-result.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { of as observableOf } from 'rxjs/internal/observable/of'; import { createSuccessfulRemoteDataObject$ } from '../../../../../shared/testing/utils';
import { getEntityGridElementTestComponent } from '../../../../shared/object-grid/item-grid-element/item-types/publication/publication-grid-element.component.spec'; import { PaginatedList } from '../../../../../core/data/paginated-list';
import { JournalSearchResultGridElementComponent } from './journal-grid-element.component'; import { PageInfo } from '../../../../../core/shared/page-info.model';
import { createSuccessfulRemoteDataObject$ } from '../../../../shared/testing/utils'; import { getEntityGridElementTestComponent } from '../../../../../shared/object-grid/search-result-grid-element/item-search-result/publication/publication-search-result-grid-element.component.spec';
import { PaginatedList } from '../../../../core/data/paginated-list'; import { JournalSearchResultGridElementComponent } from './journal-search-result-grid-element.component';
import { PageInfo } from '../../../../core/shared/page-info.model';
const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult(); const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult();
mockItemWithMetadata.hitHighlights = {}; mockItemWithMetadata.hitHighlights = {};

View File

@@ -5,7 +5,6 @@ import { JournalIssueListElementComponent } from './journal-issue-list-element.c
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../core/shared/item.model';
import { TruncatePipe } from '../../../../shared/utils/truncate.pipe'; import { TruncatePipe } from '../../../../shared/utils/truncate.pipe';
import { ITEM } from '../../../../shared/items/switcher/listable-object-component-loader.component';
import { TruncatableService } from '../../../../shared/truncatable/truncatable.service'; import { TruncatableService } from '../../../../shared/truncatable/truncatable.service';
let journalIssueListElementComponent: JournalIssueListElementComponent; let journalIssueListElementComponent: JournalIssueListElementComponent;
@@ -51,7 +50,6 @@ describe('JournalIssueListElementComponent', () => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
declarations: [ JournalIssueListElementComponent , TruncatePipe], declarations: [ JournalIssueListElementComponent , TruncatePipe],
providers: [ providers: [
{ provide: ITEM, useValue: mockItemWithMetadata},
{ provide: TruncatableService, useValue: {} } { provide: TruncatableService, useValue: {} }
], ],

View File

@@ -5,7 +5,6 @@ import { JournalVolumeListElementComponent } from './journal-volume-list-element
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../core/shared/item.model';
import { TruncatePipe } from '../../../../shared/utils/truncate.pipe'; import { TruncatePipe } from '../../../../shared/utils/truncate.pipe';
import { ITEM } from '../../../../shared/items/switcher/listable-object-component-loader.component';
import { TruncatableService } from '../../../../shared/truncatable/truncatable.service'; import { TruncatableService } from '../../../../shared/truncatable/truncatable.service';
let journalVolumeListElementComponent: JournalVolumeListElementComponent; let journalVolumeListElementComponent: JournalVolumeListElementComponent;
@@ -51,7 +50,6 @@ describe('JournalVolumeListElementComponent', () => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
declarations: [ JournalVolumeListElementComponent , TruncatePipe], declarations: [ JournalVolumeListElementComponent , TruncatePipe],
providers: [ providers: [
{ provide: ITEM, useValue: mockItemWithMetadata},
{ provide: TruncatableService, useValue: {} } { provide: TruncatableService, useValue: {} }
], ],

View File

@@ -1,4 +1,5 @@
<ng-container *ngVar="object.indexableObject as item"> <ng-container *ngVar="object.indexableObject as item">
<ds-item-type-badge [object]="item"></ds-item-type-badge>
<ds-truncatable [id]="item.id"> <ds-truncatable [id]="item.id">
<a <a
[routerLink]="['/items/' + item.id]" class="lead" [routerLink]="['/items/' + item.id]" class="lead"

View File

@@ -1,61 +1,69 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core'; import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { JournalIssueSearchResultListElementComponent } from './journal-issue-list-element.component';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Item } from '../../../../core/shared/item.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { TruncatePipe } from '../../../../shared/utils/truncate.pipe'; import { JournalIssueSearchResultListElementComponent } from './journal-issue-search-result-list-element.component';
import { ITEM } from '../../../../shared/items/switcher/listable-object-component-loader.component'; import { Item } from '../../../../../core/shared/item.model';
import { TruncatableService } from '../../../../shared/truncatable/truncatable.service'; import { TruncatePipe } from '../../../../../shared/utils/truncate.pipe';
import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service';
let journalIssueListElementComponent: JournalIssueSearchResultListElementComponent; let journalIssueListElementComponent: JournalIssueSearchResultListElementComponent;
let fixture: ComponentFixture<JournalIssueSearchResultListElementComponent>; let fixture: ComponentFixture<JournalIssueSearchResultListElementComponent>;
const mockItemWithMetadata: Item = Object.assign(new Item(), { const mockItemWithMetadata: ItemSearchResult = Object.assign(
bitstreams: observableOf({}), new ItemSearchResult(),
metadata: { {
'dc.title': [ indexableObject: Object.assign(new Item(), {
{ bitstreams: observableOf({}),
language: 'en_US', metadata: {
value: 'This is just another title' 'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
],
'publicationvolume.volumeNumber': [
{
language: 'en_US',
value: '1234'
}
],
'publicationissue.issueNumber': [
{
language: 'en_US',
value: '5678'
}
]
} }
], })
'publicationvolume.volumeNumber': [ });
{
language: 'en_US', const mockItemWithoutMetadata: ItemSearchResult = Object.assign(
value: '1234' new ItemSearchResult(),
{
indexableObject: Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
} }
], })
'publicationissue.issueNumber': [ });
{
language: 'en_US',
value: '5678'
}
]
}
});
const mockItemWithoutMetadata: Item = Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
}
});
describe('JournalIssueListElementComponent', () => { describe('JournalIssueListElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
declarations: [ JournalIssueSearchResultListElementComponent , TruncatePipe], declarations: [JournalIssueSearchResultListElementComponent, TruncatePipe],
providers: [ providers: [
{ provide: ITEM, useValue: mockItemWithMetadata},
{ provide: TruncatableService, useValue: {} } { provide: TruncatableService, useValue: {} }
], ],
schemas: [ NO_ERRORS_SCHEMA ] schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(JournalIssueSearchResultListElementComponent, { }).overrideComponent(JournalIssueSearchResultListElementComponent, {
set: { changeDetection: ChangeDetectionStrategy.Default } set: { changeDetection: ChangeDetectionStrategy.Default }
}).compileComponents(); }).compileComponents();

View File

@@ -1,4 +1,5 @@
<ng-container *ngVar="object.indexableObject as item"> <ng-container *ngVar="object.indexableObject as item">
<ds-item-type-badge [object]="item"></ds-item-type-badge>
<ds-truncatable [id]="item.id"> <ds-truncatable [id]="item.id">
<a <a
[routerLink]="['/items/' + item.id]" class="lead" [routerLink]="['/items/' + item.id]" class="lead"

View File

@@ -1,61 +1,68 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core'; import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { JournalVolumeSearchResultListElementComponent } from './journal-volume-list-element.component';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Item } from '../../../../core/shared/item.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { TruncatePipe } from '../../../../shared/utils/truncate.pipe'; import { Item } from '../../../../../core/shared/item.model';
import { ITEM } from '../../../../shared/items/switcher/listable-object-component-loader.component'; import { JournalVolumeSearchResultListElementComponent } from './journal-volume-search-result-list-element.component';
import { TruncatableService } from '../../../../shared/truncatable/truncatable.service'; import { TruncatePipe } from '../../../../../shared/utils/truncate.pipe';
import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service';
let journalVolumeListElementComponent: JournalVolumeSearchResultListElementComponent; let journalVolumeListElementComponent: JournalVolumeSearchResultListElementComponent;
let fixture: ComponentFixture<JournalVolumeSearchResultListElementComponent>; let fixture: ComponentFixture<JournalVolumeSearchResultListElementComponent>;
const mockItemWithMetadata: Item = Object.assign(new Item(), { const mockItemWithMetadata: ItemSearchResult = Object.assign(
bitstreams: observableOf({}), new ItemSearchResult(),
metadata: { {
'dc.title': [ indexableObject: Object.assign(new Item(), {
{ bitstreams: observableOf({}),
language: 'en_US', metadata: {
value: 'This is just another title' 'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
],
'journal.title': [
{
language: 'en_US',
value: 'This is just another journal title'
}
],
'publicationvolume.volumeNumber': [
{
language: 'en_US',
value: '1234'
}
]
} }
], })
'journal.title': [ });
{ const mockItemWithoutMetadata: ItemSearchResult = Object.assign(
language: 'en_US', new ItemSearchResult(),
value: 'This is just another journal title' {
indexableObject: Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
} }
], })
'publicationvolume.volumeNumber': [ });
{
language: 'en_US',
value: '1234'
}
]
}
});
const mockItemWithoutMetadata: Item = Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
}
});
describe('JournalVolumeListElementComponent', () => { describe('JournalVolumeListElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
declarations: [ JournalVolumeSearchResultListElementComponent , TruncatePipe], declarations: [JournalVolumeSearchResultListElementComponent, TruncatePipe],
providers: [ providers: [
{ provide: ITEM, useValue: mockItemWithMetadata},
{ provide: TruncatableService, useValue: {} } { provide: TruncatableService, useValue: {} }
], ],
schemas: [ NO_ERRORS_SCHEMA ] schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(JournalVolumeSearchResultListElementComponent, { }).overrideComponent(JournalVolumeSearchResultListElementComponent, {
set: { changeDetection: ChangeDetectionStrategy.Default } set: { changeDetection: ChangeDetectionStrategy.Default }
}).compileComponents(); }).compileComponents();

View File

@@ -1,4 +1,5 @@
<ng-container *ngVar="object.indexableObject as item"> <ng-container *ngVar="object.indexableObject as item">
<ds-item-type-badge [object]="item"></ds-item-type-badge>
<ds-truncatable [id]="item.id"> <ds-truncatable [id]="item.id">
<a <a
[routerLink]="['/items/' + item.id]" class="lead" [routerLink]="['/items/' + item.id]" class="lead"

View File

@@ -1,55 +1,64 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core'; import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { JournalSearchResultListElementComponent } from './journal-list-element.component';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Item } from '../../../../core/shared/item.model'; import { JournalSearchResultListElementComponent } from './journal-search-result-list-element.component';
import { TruncatePipe } from '../../../../shared/utils/truncate.pipe'; import { Item } from '../../../../../core/shared/item.model';
import { ITEM } from '../../../../shared/items/switcher/listable-object-component-loader.component'; import { TruncatePipe } from '../../../../../shared/utils/truncate.pipe';
import { TruncatableService } from '../../../../shared/truncatable/truncatable.service'; import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service';
import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
let journalListElementComponent: JournalSearchResultListElementComponent; let journalListElementComponent: JournalSearchResultListElementComponent;
let fixture: ComponentFixture<JournalSearchResultListElementComponent>; let fixture: ComponentFixture<JournalSearchResultListElementComponent>;
const mockItemWithMetadata: Item = Object.assign(new Item(), { const mockItemWithMetadata: ItemSearchResult = Object.assign(
bitstreams: observableOf({}), new ItemSearchResult(),
metadata: { {
'dc.title': [ indexableObject: Object.assign(new Item(), {
{ bitstreams: observableOf({}),
language: 'en_US', metadata: {
value: 'This is just another title' 'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
],
'creativeworkseries.issn': [
{
language: 'en_US',
value: '1234'
}
]
} }
], })
'creativeworkseries.issn': [ });
{
language: 'en_US', const mockItemWithoutMetadata: ItemSearchResult = Object.assign(
value: '1234' new ItemSearchResult(),
{
indexableObject: Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
} }
] })
} }
}); );
const mockItemWithoutMetadata: Item = Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
}
});
describe('JournalListElementComponent', () => { describe('JournalListElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
declarations: [ JournalSearchResultListElementComponent , TruncatePipe], declarations: [JournalSearchResultListElementComponent, TruncatePipe],
providers: [ providers: [
{ provide: ITEM, useValue: mockItemWithMetadata},
{ provide: TruncatableService, useValue: {} } { provide: TruncatableService, useValue: {} }
], ],
schemas: [ NO_ERRORS_SCHEMA ] schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(JournalSearchResultListElementComponent, { }).overrideComponent(JournalSearchResultListElementComponent, {
set: { changeDetection: ChangeDetectionStrategy.Default } set: { changeDetection: ChangeDetectionStrategy.Default }
}).compileComponents(); }).compileComponents();

View File

@@ -1,11 +1,10 @@
import { ItemSearchResult } from '../../../../shared/object-collection/shared/item-search-result.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { of as observableOf } from 'rxjs/internal/observable/of'; import { createSuccessfulRemoteDataObject$ } from '../../../../../shared/testing/utils';
import { getEntityGridElementTestComponent } from '../../../../shared/object-grid/item-grid-element/item-types/publication/publication-grid-element.component.spec'; import { PaginatedList } from '../../../../../core/data/paginated-list';
import { OrgunitSearchResultGridElementComponent } from './orgunit-grid-element.component'; import { PageInfo } from '../../../../../core/shared/page-info.model';
import { createSuccessfulRemoteDataObject$ } from '../../../../shared/testing/utils'; import { OrgunitSearchResultGridElementComponent } from './orgunit-search-result-grid-element.component';
import { PaginatedList } from '../../../../core/data/paginated-list'; import { getEntityGridElementTestComponent } from '../../../../../shared/object-grid/search-result-grid-element/item-search-result/publication/publication-search-result-grid-element.component.spec';
import { PageInfo } from '../../../../core/shared/page-info.model';
const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult(); const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult();
mockItemWithMetadata.hitHighlights = {}; mockItemWithMetadata.hitHighlights = {};

View File

@@ -1,11 +1,10 @@
import { ItemSearchResult } from '../../../../shared/object-collection/shared/item-search-result.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { of as observableOf } from 'rxjs/internal/observable/of'; import { createSuccessfulRemoteDataObject$ } from '../../../../../shared/testing/utils';
import { getEntityGridElementTestComponent } from '../../../../shared/object-grid/item-grid-element/item-types/publication/publication-grid-element.component.spec'; import { PaginatedList } from '../../../../../core/data/paginated-list';
import { PersonSearchResultGridElementComponent } from './person-grid-element.component'; import { PageInfo } from '../../../../../core/shared/page-info.model';
import { createSuccessfulRemoteDataObject$ } from '../../../../shared/testing/utils'; import { getEntityGridElementTestComponent } from '../../../../../shared/object-grid/search-result-grid-element/item-search-result/publication/publication-search-result-grid-element.component.spec';
import { PaginatedList } from '../../../../core/data/paginated-list'; import { PersonSearchResultGridElementComponent } from './person-search-result-grid-element.component';
import { PageInfo } from '../../../../core/shared/page-info.model';
const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult(); const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult();
mockItemWithMetadata.hitHighlights = {}; mockItemWithMetadata.hitHighlights = {};

View File

@@ -1,11 +1,10 @@
import { ItemSearchResult } from '../../../../shared/object-collection/shared/item-search-result.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { of as observableOf } from 'rxjs/internal/observable/of'; import { createSuccessfulRemoteDataObject$ } from '../../../../../shared/testing/utils';
import { getEntityGridElementTestComponent } from '../../../../shared/object-grid/item-grid-element/item-types/publication/publication-grid-element.component.spec'; import { PaginatedList } from '../../../../../core/data/paginated-list';
import { ProjectSearchResultGridElementComponent } from './project-grid-element.component'; import { PageInfo } from '../../../../../core/shared/page-info.model';
import { createSuccessfulRemoteDataObject$ } from '../../../../shared/testing/utils'; import { getEntityGridElementTestComponent } from '../../../../../shared/object-grid/search-result-grid-element/item-search-result/publication/publication-search-result-grid-element.component.spec';
import { PaginatedList } from '../../../../core/data/paginated-list'; import { ProjectSearchResultGridElementComponent } from './project-search-result-grid-element.component';
import { PageInfo } from '../../../../core/shared/page-info.model';
const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult(); const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult();
mockItemWithMetadata.hitHighlights = {}; mockItemWithMetadata.hitHighlights = {};

View File

@@ -1,4 +1,5 @@
<ng-container *ngVar="object.indexableObject as item"> <ng-container *ngVar="object.indexableObject as item">
<ds-item-type-badge [object]="item"></ds-item-type-badge>
<ds-truncatable [id]="item.id"> <ds-truncatable [id]="item.id">
<a <a
[routerLink]="['/items/' + item.id]" class="lead" [routerLink]="['/items/' + item.id]" class="lead"

View File

@@ -1,51 +1,58 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core'; import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { OrgunitSearchResultListElementComponent } from './orgunit-list-element.component';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Item } from '../../../../core/shared/item.model'; import { OrgunitSearchResultListElementComponent } from './orgunit-search-result-list-element.component';
import { TruncatePipe } from '../../../../shared/utils/truncate.pipe'; import { Item } from '../../../../../core/shared/item.model';
import { ITEM } from '../../../../shared/items/switcher/listable-object-component-loader.component'; import { TruncatePipe } from '../../../../../shared/utils/truncate.pipe';
import { TruncatableService } from '../../../../shared/truncatable/truncatable.service'; import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service';
import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
let orgUnitListElementComponent: OrgunitSearchResultListElementComponent; let orgUnitListElementComponent: OrgunitSearchResultListElementComponent;
let fixture: ComponentFixture<OrgunitSearchResultListElementComponent>; let fixture: ComponentFixture<OrgunitSearchResultListElementComponent>;
const mockItemWithMetadata: Item = Object.assign(new Item(), { const mockItemWithMetadata: ItemSearchResult = Object.assign(
bitstreams: observableOf({}), new ItemSearchResult(),
metadata: { {
'dc.title': [ indexableObject: Object.assign(new Item(), {
{ bitstreams: observableOf({}),
language: 'en_US', metadata: {
value: 'This is just another title' 'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
],
'dc.description': [
{
language: 'en_US',
value: 'A description about the OrgUnit'
}
]
} }
], })
'dc.description': [ });
{ const mockItemWithoutMetadata: ItemSearchResult = Object.assign(
language: 'en_US', new ItemSearchResult(),
value: 'A description about the OrgUnit' {
indexableObject: Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
} }
] })
} });
});
const mockItemWithoutMetadata: Item = Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
}
});
describe('OrgUnitListElementComponent', () => { describe('OrgUnitListElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
declarations: [ OrgunitSearchResultListElementComponent , TruncatePipe], declarations: [ OrgunitSearchResultListElementComponent , TruncatePipe],
providers: [ providers: [
{ provide: ITEM, useValue: mockItemWithMetadata},
{ provide: TruncatableService, useValue: {} } { provide: TruncatableService, useValue: {} }
], ],

View File

@@ -1,4 +1,5 @@
<ng-container *ngVar="object.indexableObject as item"> <ng-container *ngVar="object.indexableObject as item">
<ds-item-type-badge [object]="item"></ds-item-type-badge>
<ds-truncatable [id]="item.id"> <ds-truncatable [id]="item.id">
<a <a
[routerLink]="['/items/' + item.id]" class="lead" [routerLink]="['/items/' + item.id]" class="lead"

View File

@@ -1,53 +1,62 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core'; import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { PersonSearchResultListElementComponent } from './person-list-element.component';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Item } from '../../../../core/shared/item.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { TruncatePipe } from '../../../../shared/utils/truncate.pipe'; import { PersonSearchResultListElementComponent } from './person-search-result-list-element.component';
import { TruncatableService } from '../../../../shared/truncatable/truncatable.service'; import { Item } from '../../../../../core/shared/item.model';
import { TruncatePipe } from '../../../../../shared/utils/truncate.pipe';
import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service';
let personListElementComponent: PersonSearchResultListElementComponent; let personListElementComponent: PersonSearchResultListElementComponent;
let fixture: ComponentFixture<PersonSearchResultListElementComponent>; let fixture: ComponentFixture<PersonSearchResultListElementComponent>;
const mockItemWithMetadata: Item = Object.assign(new Item(), { const mockItemWithMetadata: ItemSearchResult = Object.assign(
bitstreams: observableOf({}), new ItemSearchResult(),
metadata: { {
'dc.title': [ indexableObject: Object.assign(new Item(), {
{ bitstreams: observableOf({}),
language: 'en_US', metadata: {
value: 'This is just another title' 'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
],
'person.jobTitle': [
{
language: 'en_US',
value: 'Developer'
}
]
} }
], })
'person.jobTitle': [ });
{ const mockItemWithoutMetadata: ItemSearchResult = Object.assign(
language: 'en_US', new ItemSearchResult(),
value: 'Developer' {
indexableObject: Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
} }
] })
} });
});
const mockItemWithoutMetadata: Item = Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
]
}
});
describe('PersonListElementComponent', () => { describe('PersonListElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
declarations: [ PersonSearchResultListElementComponent , TruncatePipe], declarations: [PersonSearchResultListElementComponent, TruncatePipe],
providers: [ providers: [
{ provide: TruncatableService, useValue: {} } { provide: TruncatableService, useValue: {} }
], ],
schemas: [ NO_ERRORS_SCHEMA ] schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(PersonSearchResultListElementComponent, { }).overrideComponent(PersonSearchResultListElementComponent, {
set: { changeDetection: ChangeDetectionStrategy.Default } set: { changeDetection: ChangeDetectionStrategy.Default }
}).compileComponents(); }).compileComponents();

View File

@@ -1,16 +1,18 @@
<ds-truncatable [id]="object.id"> <ng-container *ngVar="object.indexableObject as item">
<a <ds-truncatable [id]="item.id">
[routerLink]="['/items/' + object.id]" class="lead" <ds-item-type-badge [object]="item"></ds-item-type-badge>
[innerHTML]="firstMetadataValue('dc.title')"></a> <a
<!--<span class="text-muted">--> [routerLink]="['/items/' + item.id]" class="lead"
<!--<ds-truncatable-part [id]="item.id" [minLines]="1">--> [innerHTML]="firstMetadataValue('dc.title')"></a>
<!--<span *ngIf="item.allMetadata(['project.identifier.status']).length > 0"--> <!--<span class="text-muted">-->
<!--class="item-list-status">--> <!--<ds-truncatable-part [id]="item.id" [minLines]="1">-->
<!--<span *ngFor="let value of allMetadataValues(['project.identifier.status']); let last=last;">--> <!--<span *ngIf="item.allMetadata(['project.identifier.status']).length > 0"-->
<!--<span [innerHTML]="value"><span [innerHTML]="value"></span></span>--> <!--class="item-list-status">-->
<!--</span>--> <!--<span *ngFor="let value of allMetadataValues(['project.identifier.status']); let last=last;">-->
<!--</span>--> <!--<span [innerHTML]="value"><span [innerHTML]="value"></span></span>-->
<!--</span>-->
<!--</span>-->
<!--</ds-truncatable-part>--> <!--</ds-truncatable-part>-->
<!--</span>--> <!--</span>-->
</ds-truncatable> </ds-truncatable>
</ng-container>

View File

@@ -1,55 +1,62 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core'; import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser';
import { ProjectSearchResultListElementComponent } from './project-list-element.component';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Item } from '../../../../core/shared/item.model'; import { ItemSearchResult } from '../../../../../shared/object-collection/shared/item-search-result.model';
import { TruncatePipe } from '../../../../shared/utils/truncate.pipe'; import { ProjectSearchResultListElementComponent } from './project-search-result-list-element.component';
import { ITEM } from '../../../../shared/items/switcher/listable-object-component-loader.component'; import { Item } from '../../../../../core/shared/item.model';
import { TruncatableService } from '../../../../shared/truncatable/truncatable.service'; import { TruncatePipe } from '../../../../../shared/utils/truncate.pipe';
import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service';
let projectListElementComponent: ProjectSearchResultListElementComponent; let projectListElementComponent: ProjectSearchResultListElementComponent;
let fixture: ComponentFixture<ProjectSearchResultListElementComponent>; let fixture: ComponentFixture<ProjectSearchResultListElementComponent>;
const mockItemWithMetadata: Item = Object.assign(new Item(), { const mockItemWithMetadata: ItemSearchResult = Object.assign(
bitstreams: observableOf({}), new ItemSearchResult(),
metadata: { {
'dc.title': [ indexableObject: Object.assign(new Item(), {
{ bitstreams: observableOf({}),
language: 'en_US', metadata: {
value: 'This is just another title' 'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
],
// 'project.identifier.status': [
// {
// language: 'en_US',
// value: 'A status about the project'
// }
// ]
} }
], })
// 'project.identifier.status': [ });
// {
// language: 'en_US', const mockItemWithoutMetadata: ItemSearchResult = Object.assign(
// value: 'A status about the project' new ItemSearchResult(),
// } {
// ] indexableObject: Object.assign(new Item(), {
} bitstreams: observableOf({}),
}); metadata: {
const mockItemWithoutMetadata: Item = Object.assign(new Item(), { 'dc.title': [
bitstreams: observableOf({}), {
metadata: { language: 'en_US',
'dc.title': [ value: 'This is just another title'
{ }
language: 'en_US', ]
value: 'This is just another title'
} }
] })
} });
});
describe('ProjectListElementComponent', () => { describe('ProjectListElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
declarations: [ ProjectSearchResultListElementComponent , TruncatePipe], declarations: [ProjectSearchResultListElementComponent, TruncatePipe],
providers: [ providers: [
{ provide: ITEM, useValue: mockItemWithMetadata},
{ provide: TruncatableService, useValue: {} } { provide: TruncatableService, useValue: {} }
], ],
schemas: [ NO_ERRORS_SCHEMA ] schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(ProjectSearchResultListElementComponent, { }).overrideComponent(ProjectSearchResultListElementComponent, {
set: { changeDetection: ChangeDetectionStrategy.Default } set: { changeDetection: ChangeDetectionStrategy.Default }
}).compileComponents(); }).compileComponents();

View File

@@ -25,7 +25,7 @@
</div> </div>
<ul class="list-unstyled"> <ul class="list-unstyled">
<li *ngFor="let object of objects?.payload?.page" class="mt-4 mb-4"> <li *ngFor="let object of objects?.payload?.page" class="mt-4 mb-4">
<ds-wrapper-list-element [object]="object"></ds-wrapper-list-element> <ds-listable-object-component-loader [object]="object"></ds-listable-object-component-loader>
</li> </li>
</ul> </ul>
<div> <div>

View File

@@ -15,6 +15,6 @@
class="list-group-item list-group-item-action border-0 list-entry" class="list-group-item list-group-item-action border-0 list-entry"
title="{{ listEntry.indexableObject.name }}" title="{{ listEntry.indexableObject.name }}"
(click)="onSelect.emit(listEntry.indexableObject)" #listEntryElement> (click)="onSelect.emit(listEntry.indexableObject)" #listEntryElement>
<ds-wrapper-list-element [object]="listEntry"></ds-wrapper-list-element> <ds-listable-object-component-loader [object]="listEntry" [viewMode]="viewMode"></ds-listable-object-component-loader>
</button> </button>
</div> </div>

View File

@@ -19,6 +19,7 @@ import { RemoteData } from '../../../core/data/remote-data';
import { PaginatedList } from '../../../core/data/paginated-list'; import { PaginatedList } from '../../../core/data/paginated-list';
import { SearchResult } from '../../../+search-page/search-result.model'; import { SearchResult } from '../../../+search-page/search-result.model';
import { DSpaceObject } from '../../../core/shared/dspace-object.model'; import { DSpaceObject } from '../../../core/shared/dspace-object.model';
import { ViewMode } from '../../../core/shared/view-mode.model';
@Component({ @Component({
selector: 'ds-dso-selector', selector: 'ds-dso-selector',
@@ -31,7 +32,7 @@ import { DSpaceObject } from '../../../core/shared/dspace-object.model';
* The user can search the list by using the input field * The user can search the list by using the input field
*/ */
export class DSOSelectorComponent implements OnInit { export class DSOSelectorComponent implements OnInit {
viewMode = ViewMode.ListElement;
/** /**
* The initially selected DSO's uuid * The initially selected DSO's uuid
*/ */

View File

@@ -16,7 +16,7 @@
<button class="d-block dropdown-item" (click)="onClickSuggestion(suggestionOption)" #suggestion> <button class="d-block dropdown-item" (click)="onClickSuggestion(suggestionOption)" #suggestion>
<div class="click-blocker"> <div class="click-blocker">
</div> </div>
<ds-wrapper-list-element [object]="suggestionOption"></ds-wrapper-list-element> <ds-listable-object-component-loader [object]="suggestionOption" [viewMode]="viewMode"></ds-listable-object-component-loader>
</button> </button>
</div> </div>
</div> </div>

View File

@@ -2,6 +2,7 @@ import { Component, forwardRef, Input } from '@angular/core';
import { NG_VALUE_ACCESSOR } from '@angular/forms'; import { NG_VALUE_ACCESSOR } from '@angular/forms';
import { InputSuggestionsComponent } from '../input-suggestions.component'; import { InputSuggestionsComponent } from '../input-suggestions.component';
import { DSpaceObject } from '../../../core/shared/dspace-object.model'; import { DSpaceObject } from '../../../core/shared/dspace-object.model';
import { ViewMode } from '../../../core/shared/view-mode.model';
@Component({ @Component({
selector: 'ds-dso-input-suggestions', selector: 'ds-dso-input-suggestions',
@@ -22,6 +23,7 @@ import { DSpaceObject } from '../../../core/shared/dspace-object.model';
* Component representing a form with a autocomplete functionality for DSpaceObjects * Component representing a form with a autocomplete functionality for DSpaceObjects
*/ */
export class DsoInputSuggestionsComponent extends InputSuggestionsComponent { export class DsoInputSuggestionsComponent extends InputSuggestionsComponent {
viewMode = ViewMode.ListElement;
/** /**
* The suggestions that should be shown * The suggestions that should be shown
*/ */

View File

@@ -8,4 +8,7 @@ import { MyDSpaceConfigurationValueType } from '../../../+my-dspace-page/my-dspa
*/ */
@searchResultFor(Item, MyDSpaceConfigurationValueType.Workspace) @searchResultFor(Item, MyDSpaceConfigurationValueType.Workspace)
export class ItemMyDSpaceResult extends SearchResult<Item> { export class ItemMyDSpaceResult extends SearchResult<Item> {
getRenderType(): string {
return ItemMyDSpaceResult.name;
}
} }

View File

@@ -1 +1,5 @@
export interface ListableObject {} import { TypedObject } from '../../../core/cache/object-cache.reducer';
export interface ListableObject extends TypedObject {
getRenderType(): string;
}

View File

@@ -1 +1 @@
<ng-container listableObjectComponentLoader></ng-container> <ng-template dsListableObject></ng-template>

View File

@@ -5,24 +5,23 @@ import { Context } from '../../../../core/shared/context.model';
import { getListableObjectComponent } from './listable-object.decorator'; import { getListableObjectComponent } from './listable-object.decorator';
import { GenericConstructor } from '../../../../core/shared/generic-constructor'; import { GenericConstructor } from '../../../../core/shared/generic-constructor';
import { ListableObjectDirective } from './listable-object.directive'; import { ListableObjectDirective } from './listable-object.directive';
import { hasValue, isNotEmpty } from '../../../empty.util';
@Component({ @Component({
selector: 'ds-listable-object-component-loader', selector: 'ds-listable-object-component-loader',
styleUrls: ['./listable-object-component-loader.component.scss'], // styleUrls: ['./listable-object-component-loader.component.scss'],
templateUrl: './listable-object-component-loader.component.html' templateUrl: './listable-object-component-loader.component.html'
}) })
/** /**
* Component for determining what component to use depending on the item's relationship type (relationship.type) * Component for determining what component to use depending on the item's relationship type (relationship.type)
*/ */
export class ListableObjectComponentLoaderComponent implements OnInit { export class ListableObjectComponentLoaderComponent implements OnInit {
@Input() type?: string;
/** /**
* The item or metadata to determine the component for * The item or metadata to determine the component for
*/ */
@Input() object: ListableObject; @Input() object: ListableObject;
//TODO DO SOMETHING WITH THIS
@Input() index: number;
/** /**
* The preferred view-mode to display * The preferred view-mode to display
*/ */
@@ -49,9 +48,6 @@ export class ListableObjectComponentLoaderComponent implements OnInit {
* @returns {string} * @returns {string}
*/ */
private getComponent(): GenericConstructor<Component> { private getComponent(): GenericConstructor<Component> {
if (isNotEmpty(this.type)) { return getListableObjectComponent(this.object.getRenderType(), this.viewMode)
return getListableObjectComponent(this.type, this.viewMode)
}
return getListableObjectComponent(this.object.constructor as GenericConstructor<ListableObject>, this.viewMode);
} }
} }

View File

@@ -16,7 +16,7 @@ const listElementMap = new Map();
* @param type * @param type
* @param viewMode * @param viewMode
*/ */
export function listableObjectComponent(objectType: GenericConstructor<ListableObject> | string, viewMode: ViewMode, context: Context = DEFAULT_CONTEXT) { export function listableObjectComponent(objectType: string, viewMode: ViewMode, context: Context = DEFAULT_CONTEXT) {
return function decorator(component: any) { return function decorator(component: any) {
if (hasNoValue(objectType)) { if (hasNoValue(objectType)) {
return; return;

View File

@@ -1,10 +1,11 @@
import { Component, Inject, Input } from '@angular/core'; import { Component, Inject, Input } from '@angular/core';
import { ListableObject } from '../listable-object.model'; import { ListableObject } from '../listable-object.model';
import { ViewMode } from '../../../../core/shared/view-mode.model';
@Component({ @Component({
selector: 'ds-abstract-object-element', selector: 'ds-abstract-object-element',
template: ``, template: ``,
}) })
export class AbstractListableElementComponent <T extends ListableObject> { export class AbstractListableElementComponent<T extends ListableObject> {
@Input() object: T; @Input() object: T;
} }

View File

@@ -13,6 +13,7 @@ import { ClaimedTaskMyDSpaceResult } from '../../../object-collection/shared/cla
import { MyDSpaceResultDetailElementComponent } from '../my-dspace-result-detail-element.component'; import { MyDSpaceResultDetailElementComponent } from '../my-dspace-result-detail-element.component';
import { MyDspaceItemStatusType } from '../../../object-collection/shared/mydspace-item-status/my-dspace-item-status-type'; import { MyDspaceItemStatusType } from '../../../object-collection/shared/mydspace-item-status/my-dspace-item-status-type';
import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator'; import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator';
import { Context } from '../../../../core/shared/context.model';
/** /**
* This component renders claimed task object for the mydspace result in the detail view. * This component renders claimed task object for the mydspace result in the detail view.
@@ -23,8 +24,8 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: './claimed-my-dspace-result-detail-element.component.html' templateUrl: './claimed-my-dspace-result-detail-element.component.html'
}) })
@listableObjectComponent(ClaimedTaskMyDSpaceResult, ViewMode.DetailedListElement) @listableObjectComponent(ClaimedTaskMyDSpaceResult.name, ViewMode.DetailedListElement)
@listableObjectComponent(ClaimedTask, ViewMode.DetailedListElement) @listableObjectComponent(ClaimedTask.name, ViewMode.DetailedListElement)
export class ClaimedMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<ClaimedTaskMyDSpaceResult, ClaimedTask> { export class ClaimedMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<ClaimedTaskMyDSpaceResult, ClaimedTask> {
/** /**

View File

@@ -16,7 +16,7 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: './item-my-dspace-result-detail-element.component.html' templateUrl: './item-my-dspace-result-detail-element.component.html'
}) })
@listableObjectComponent(ItemMyDSpaceResult, ViewMode.DetailedListElement) @listableObjectComponent(ItemMyDSpaceResult.name, ViewMode.DetailedListElement)
export class ItemMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<ItemMyDSpaceResult, Item> { export class ItemMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<ItemMyDSpaceResult, Item> {
/** /**

View File

@@ -22,8 +22,8 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: './pool-my-dspace-result-detail-element.component.html', templateUrl: './pool-my-dspace-result-detail-element.component.html',
}) })
@listableObjectComponent(PoolTaskMyDSpaceResult, ViewMode.DetailedListElement) @listableObjectComponent(PoolTaskMyDSpaceResult.name, ViewMode.DetailedListElement)
@listableObjectComponent(PoolTask, ViewMode.DetailedListElement) @listableObjectComponent(PoolTask.name, ViewMode.DetailedListElement)
export class PoolMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<PoolTaskMyDSpaceResult, PoolTask> { export class PoolMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<PoolTaskMyDSpaceResult, PoolTask> {
/** /**

View File

@@ -22,8 +22,8 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: './workflowitem-my-dspace-result-detail-element.component.html', templateUrl: './workflowitem-my-dspace-result-detail-element.component.html',
}) })
@listableObjectComponent(WorkflowitemMyDSpaceResult, ViewMode.DetailedListElement) @listableObjectComponent(WorkflowitemMyDSpaceResult.name, ViewMode.DetailedListElement)
@listableObjectComponent(WorkflowItem, ViewMode.DetailedListElement) @listableObjectComponent(WorkflowItem.name, ViewMode.DetailedListElement)
export class WorkflowitemMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<WorkflowitemMyDSpaceResult, WorkflowItem> { export class WorkflowitemMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<WorkflowitemMyDSpaceResult, WorkflowItem> {
/** /**

View File

@@ -10,7 +10,6 @@ import { WorkspaceitemMyDSpaceResult } from '../../../object-collection/shared/w
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../core/shared/item.model';
import { RemoteData } from '../../../../core/data/remote-data'; import { RemoteData } from '../../../../core/data/remote-data';
import { isNotUndefined } from '../../../empty.util'; import { isNotUndefined } from '../../../empty.util';
import { ListableObject } from '../../../object-collection/shared/listable-object.model';
import { MyDSpaceResultDetailElementComponent } from '../my-dspace-result-detail-element.component'; import { MyDSpaceResultDetailElementComponent } from '../my-dspace-result-detail-element.component';
import { MyDspaceItemStatusType } from '../../../object-collection/shared/mydspace-item-status/my-dspace-item-status-type'; import { MyDspaceItemStatusType } from '../../../object-collection/shared/mydspace-item-status/my-dspace-item-status-type';
import { ViewMode } from '../../../../core/shared/view-mode.model'; import { ViewMode } from '../../../../core/shared/view-mode.model';
@@ -25,8 +24,8 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: './workspaceitem-my-dspace-result-detail-element.component.html', templateUrl: './workspaceitem-my-dspace-result-detail-element.component.html',
}) })
@listableObjectComponent(WorkspaceitemMyDSpaceResult, ViewMode.DetailedListElement) @listableObjectComponent(WorkspaceitemMyDSpaceResult.name, ViewMode.DetailedListElement)
@listableObjectComponent(WorkspaceItem, ViewMode.DetailedListElement) @listableObjectComponent(WorkspaceItem.name, ViewMode.DetailedListElement)
export class WorkspaceitemMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<WorkspaceitemMyDSpaceResult, WorkspaceItem> { export class WorkspaceitemMyDSpaceResultDetailElementComponent extends MyDSpaceResultDetailElementComponent<WorkspaceitemMyDSpaceResult, WorkspaceItem> {
/** /**

View File

@@ -14,7 +14,7 @@
<div class="row mt-2" *ngIf="objects?.hasSucceeded" @fadeIn> <div class="row mt-2" *ngIf="objects?.hasSucceeded" @fadeIn>
<div class="col" <div class="col"
*ngFor="let object of objects?.payload?.page"> *ngFor="let object of objects?.payload?.page">
<ds-wrapper-detail-element [object]="object"></ds-wrapper-detail-element> <ds-listable-object-component-loader [object]="object" [viewMode]="viewMode"></ds-listable-object-component-loader>
</div> </div>
</div> </div>
<ds-error *ngIf="objects.hasFailed | async" message="{{'error.objects' | translate}}"></ds-error> <ds-error *ngIf="objects.hasFailed | async" message="{{'error.objects' | translate}}"></ds-error>

View File

@@ -15,6 +15,7 @@ import { fadeIn } from '../animations/fade';
import { ListableObject } from '../object-collection/shared/listable-object.model'; import { ListableObject } from '../object-collection/shared/listable-object.model';
import { PaginationComponentOptions } from '../pagination/pagination-component-options.model'; import { PaginationComponentOptions } from '../pagination/pagination-component-options.model';
import { ViewMode } from '../../core/shared/view-mode.model';
/** /**
* This component renders a paginated set of results in the detail view. * This component renders a paginated set of results in the detail view.
@@ -28,6 +29,7 @@ import { PaginationComponentOptions } from '../pagination/pagination-component-o
animations: [fadeIn] animations: [fadeIn]
}) })
export class ObjectDetailComponent { export class ObjectDetailComponent {
viewMode = ViewMode.DetailedListElement;
/** /**
* Pagination options object * Pagination options object

View File

@@ -11,5 +11,5 @@ import { listableObjectComponent } from '../../object-collection/shared/listable
templateUrl: './collection-grid-element.component.html' templateUrl: './collection-grid-element.component.html'
}) })
@listableObjectComponent(Collection, ViewMode.GridElement) @listableObjectComponent(Collection.name, ViewMode.GridElement)
export class CollectionGridElementComponent extends AbstractListableElementComponent<Collection> {} export class CollectionGridElementComponent extends AbstractListableElementComponent<Collection> {}

View File

@@ -11,5 +11,5 @@ import { listableObjectComponent } from '../../object-collection/shared/listable
templateUrl: './community-grid-element.component.html' templateUrl: './community-grid-element.component.html'
}) })
@listableObjectComponent(Community, ViewMode.GridElement) @listableObjectComponent(Community.name, ViewMode.GridElement)
export class CommunityGridElementComponent extends AbstractListableElementComponent<Community> {} export class CommunityGridElementComponent extends AbstractListableElementComponent<Community> {}

View File

@@ -1 +0,0 @@
<ds-listable-object-component-loader [type]="object.firstMetadataValue('relationship.type')" [object]="object" [viewMode]="viewMode"></ds-listable-object-component-loader>

View File

@@ -1,114 +0,0 @@
import { ItemGridElementComponent } from './item-grid-element.component';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser';
import { TruncatePipe } from '../../utils/truncate.pipe';
import { Item } from '../../../core/shared/item.model';
import { of as observableOf } from 'rxjs';
let itemGridElementComponent: ItemGridElementComponent;
let fixture: ComponentFixture<ItemGridElementComponent>;
const mockItemWithAuthorAndDate: Item = Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.contributor.author': [
{
language: 'en_US',
value: 'Smith, Donald'
}
],
'dc.date.issued': [
{
language: null,
value: '2015-06-26'
}
]
}
});
const mockItemWithoutAuthorAndDate: Item = Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'dc.title': [
{
language: 'en_US',
value: 'This is just another title'
}
],
'dc.type': [
{
language: null,
value: 'Article'
}
]
}
});
describe('ItemGridElementComponent', () => {
beforeEach(async(() => {
TestBed.configureTestingModule({
declarations: [ ItemGridElementComponent , TruncatePipe],
providers: [
{ provide: 'objectElementProvider', useValue: {mockItemWithAuthorAndDate}}
],
schemas: [ NO_ERRORS_SCHEMA ]
}).overrideComponent(ItemGridElementComponent, {
set: { changeDetection: ChangeDetectionStrategy.Default }
}).compileComponents();
}));
beforeEach(async(() => {
fixture = TestBed.createComponent(ItemGridElementComponent);
itemGridElementComponent = fixture.componentInstance;
}));
describe('When the item has an author', () => {
beforeEach(() => {
itemGridElementComponent.object = mockItemWithAuthorAndDate;
fixture.detectChanges();
});
it('should show the author paragraph', () => {
const itemAuthorField = fixture.debugElement.query(By.css('p.item-authors'));
expect(itemAuthorField).not.toBeNull();
});
});
describe('When the item has no author', () => {
beforeEach(() => {
itemGridElementComponent.object = mockItemWithoutAuthorAndDate;
fixture.detectChanges();
});
it('should not show the author paragraph', () => {
const itemAuthorField = fixture.debugElement.query(By.css('p.item-authors'));
expect(itemAuthorField).toBeNull();
});
});
describe('When the item has an issuedate', () => {
beforeEach(() => {
itemGridElementComponent.object = mockItemWithAuthorAndDate;
fixture.detectChanges();
});
it('should show the issuedate span', () => {
const itemAuthorField = fixture.debugElement.query(By.css('span.item-date'));
expect(itemAuthorField).not.toBeNull();
});
});
describe('When the item has no issuedate', () => {
beforeEach(() => {
itemGridElementComponent.object = mockItemWithoutAuthorAndDate;
fixture.detectChanges();
});
it('should not show the issuedate span', () => {
const dateField = fixture.debugElement.query(By.css('span.item-date'));
expect(dateField).toBeNull();
});
});
});

View File

@@ -1,15 +0,0 @@
import { Component } from '@angular/core';
import { Item } from '../../../core/shared/item.model';
import { AbstractListableElementComponent } from '../../object-collection/shared/object-collection-element/abstract-listable-element.component';
import { ViewMode } from '../../../core/shared/view-mode.model';
import { listableObjectComponent } from '../../object-collection/shared/listable-object/listable-object.decorator';
@Component({
selector: 'ds-item-grid-element',
styleUrls: ['./item-grid-element.component.scss'],
templateUrl: './item-grid-element.component.html'
})
@listableObjectComponent(Item, ViewMode.GridElement)
export class ItemGridElementComponent extends AbstractListableElementComponent<Item> {}

View File

@@ -13,7 +13,7 @@
<div class="card-columns row" *ngIf="objects?.hasSucceeded"> <div class="card-columns row" *ngIf="objects?.hasSucceeded">
<div class="card-column col col-sm-6 col-lg-4" *ngFor="let column of (columns$ | async)" @fadeIn> <div class="card-column col col-sm-6 col-lg-4" *ngFor="let column of (columns$ | async)" @fadeIn>
<div class="card-element" *ngFor="let object of column"> <div class="card-element" *ngFor="let object of column">
<ds-wrapper-grid-element [object]="object"></ds-wrapper-grid-element> <ds-listable-object-component-loader [object]="object" [viewMode]="viewMode"></ds-listable-object-component-loader>
</div> </div>
</div> </div>
</div> </div>

View File

@@ -20,6 +20,7 @@ import { HostWindowService, WidthCategory } from '../host-window.service';
import { ListableObject } from '../object-collection/shared/listable-object.model'; import { ListableObject } from '../object-collection/shared/listable-object.model';
import { PaginationComponentOptions } from '../pagination/pagination-component-options.model'; import { PaginationComponentOptions } from '../pagination/pagination-component-options.model';
import { ViewMode } from '../../core/shared/view-mode.model';
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.Default, changeDetection: ChangeDetectionStrategy.Default,
@@ -31,6 +32,7 @@ import { PaginationComponentOptions } from '../pagination/pagination-component-o
}) })
export class ObjectGridComponent implements OnInit { export class ObjectGridComponent implements OnInit {
viewMode = ViewMode.ListElement;
@Input() config: PaginationComponentOptions; @Input() config: PaginationComponentOptions;
@Input() sortConfig: SortOptions; @Input() sortConfig: SortOptions;

View File

@@ -12,5 +12,5 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: 'collection-search-result-grid-element.component.html' templateUrl: 'collection-search-result-grid-element.component.html'
}) })
@listableObjectComponent(CollectionSearchResult, ViewMode.GridElement) @listableObjectComponent(CollectionSearchResult.name, ViewMode.GridElement)
export class CollectionSearchResultGridElementComponent extends SearchResultGridElementComponent<CollectionSearchResult, Collection> {} export class CollectionSearchResultGridElementComponent extends SearchResultGridElementComponent<CollectionSearchResult, Collection> {}

View File

@@ -11,7 +11,7 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: 'community-search-result-grid-element.component.html' templateUrl: 'community-search-result-grid-element.component.html'
}) })
@listableObjectComponent(CommunitySearchResult, ViewMode.GridElement) @listableObjectComponent(CommunitySearchResult.name, ViewMode.GridElement)
export class CommunitySearchResultGridElementComponent extends SearchResultGridElementComponent<CommunitySearchResult, Community> { export class CommunitySearchResultGridElementComponent extends SearchResultGridElementComponent<CommunitySearchResult, Community> {
} }

View File

@@ -1 +0,0 @@
<ds-listable-object-component-loader [type]="object.indexableObject.firstMetadataValue('relationship.type') + 'SearchResult'" [object]="object" [viewMode]="viewMode"></ds-listable-object-component-loader>

View File

@@ -1,12 +0,0 @@
.card {
a > div {
position: relative;
.thumbnail-overlay {
height: 100%;
position: absolute;
top: 0;
width: 100%;
background-color: map-get($theme-colors, primary);
}
}
}

View File

@@ -1,61 +0,0 @@
import { ItemSearchResultGridElementComponent } from './item-search-result-grid-element.component';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { of as observableOf } from 'rxjs';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser';
import { TruncatePipe } from '../../../utils/truncate.pipe';
import { Item } from '../../../../core/shared/item.model';
import { TruncatableService } from '../../../truncatable/truncatable.service';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { ItemSearchResult } from '../../../object-collection/shared/item-search-result.model';
import { ViewMode } from '../../../../core/shared/view-mode.model';
let itemSearchResultGridElementComponent: ItemSearchResultGridElementComponent;
let fixture: ComponentFixture<ItemSearchResultGridElementComponent>;
const truncatableServiceStub: any = {
isCollapsed: (id: number) => observableOf(true),
};
const type = 'authorOfPublication';
const mockItemWithRelationshipType: ItemSearchResult = new ItemSearchResult();
mockItemWithRelationshipType.hitHighlights = {};
mockItemWithRelationshipType.indexableObject = Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'relationship.type': [
{
language: 'en_US',
value: type
}
]
}
});
describe('ItemSearchResultGridElementComponent', () => {
beforeEach(async(() => {
TestBed.configureTestingModule({
imports: [NoopAnimationsModule],
declarations: [ItemSearchResultGridElementComponent, TruncatePipe],
providers: [
{ provide: TruncatableService, useValue: truncatableServiceStub },
{ provide: 'objectElementProvider', useValue: (mockItemWithRelationshipType) }
],
schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(ItemSearchResultGridElementComponent, {
set: { changeDetection: ChangeDetectionStrategy.Default }
}).compileComponents();
}));
beforeEach(async(() => {
fixture = TestBed.createComponent(ItemSearchResultGridElementComponent);
itemSearchResultGridElementComponent = fixture.componentInstance;
}));
it('should show send the object to item-type-switcher using viewMode "Card"', () => {
const itemTypeSwitcherComp = fixture.debugElement.query(By.css('ds-item-type-switcher')).componentInstance;
expect(itemTypeSwitcherComp.object).toBe(mockItemWithRelationshipType);
expect(itemTypeSwitcherComp.viewMode).toEqual(ViewMode.GridElement);
});
});

View File

@@ -1,20 +0,0 @@
import { Component } from '@angular/core';
import { SearchResultGridElementComponent } from '../search-result-grid-element.component';
import { Item } from '../../../../core/shared/item.model';
import { ItemSearchResult } from '../../../object-collection/shared/item-search-result.model';
import { focusShadow } from '../../../animations/focus';
import { ViewMode } from '../../../../core/shared/view-mode.model';
import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator';
@Component({
selector: 'ds-item-search-result-grid-element',
styleUrls: ['../search-result-grid-element.component.scss', 'item-search-result-grid-element.component.scss'],
templateUrl: 'item-search-result-grid-element.component.html',
animations: [focusShadow],
})
@listableObjectComponent(ItemSearchResult, ViewMode.GridElement)
export class ItemSearchResultGridElementComponent extends SearchResultGridElementComponent<ItemSearchResult, Item> {
viewMode = ViewMode.GridElement;
}

View File

@@ -4,14 +4,13 @@ import { TruncatePipe } from '../../../../utils/truncate.pipe';
import { TruncatableService } from '../../../../truncatable/truncatable.service'; import { TruncatableService } from '../../../../truncatable/truncatable.service';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core'; import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { PublicationSearchResultGridElementComponent } from './publication-grid-element.component';
import { of as observableOf } from 'rxjs/internal/observable/of'; import { of as observableOf } from 'rxjs/internal/observable/of';
import { ItemSearchResult } from '../../../../object-collection/shared/item-search-result.model'; import { ItemSearchResult } from '../../../../object-collection/shared/item-search-result.model';
import { Item } from '../../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { ITEM } from '../../../../items/switcher/listable-object-component-loader.component';
import { createSuccessfulRemoteDataObject$ } from '../../../../testing/utils'; import { createSuccessfulRemoteDataObject$ } from '../../../../testing/utils';
import { PaginatedList } from '../../../../../core/data/paginated-list'; import { PaginatedList } from '../../../../../core/data/paginated-list';
import { PageInfo } from '../../../../../core/shared/page-info.model'; import { PageInfo } from '../../../../../core/shared/page-info.model';
import { PublicationSearchResultGridElementComponent } from './publication-search-result-grid-element.component';
const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult(); const mockItemWithMetadata: ItemSearchResult = new ItemSearchResult();
mockItemWithMetadata.hitHighlights = {}; mockItemWithMetadata.hitHighlights = {};
@@ -85,7 +84,6 @@ export function getEntityGridElementTestComponent(component, searchResultWithMet
declarations: [component, TruncatePipe], declarations: [component, TruncatePipe],
providers: [ providers: [
{ provide: TruncatableService, useValue: truncatableServiceStub }, { provide: TruncatableService, useValue: truncatableServiceStub },
{provide: ITEM, useValue: searchResultWithoutMetadata}
], ],
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(component, { }).overrideComponent(component, {

View File

@@ -14,5 +14,5 @@ import { listableObjectComponent } from '../../object-collection/shared/listable
/** /**
* This component is automatically used to create a list view for BrowseEntry objects when used in ObjectCollectionComponent * This component is automatically used to create a list view for BrowseEntry objects when used in ObjectCollectionComponent
*/ */
@listableObjectComponent(BrowseEntry, ViewMode.ListElement) @listableObjectComponent(BrowseEntry.name, ViewMode.ListElement)
export class BrowseEntryListElementComponent extends AbstractListableElementComponent<BrowseEntry> {} export class BrowseEntryListElementComponent extends AbstractListableElementComponent<BrowseEntry> {}

View File

@@ -11,5 +11,5 @@ import { listableObjectComponent } from '../../object-collection/shared/listable
templateUrl: './collection-list-element.component.html' templateUrl: './collection-list-element.component.html'
}) })
@listableObjectComponent(Collection, ViewMode.ListElement) @listableObjectComponent(Collection.name, ViewMode.ListElement)
export class CollectionListElementComponent extends AbstractListableElementComponent<Collection> {} export class CollectionListElementComponent extends AbstractListableElementComponent<Collection> {}

View File

@@ -11,5 +11,5 @@ import { listableObjectComponent } from '../../object-collection/shared/listable
templateUrl: './community-list-element.component.html' templateUrl: './community-list-element.component.html'
}) })
@listableObjectComponent(Community, ViewMode.ListElement) @listableObjectComponent(Community.name, ViewMode.ListElement)
export class CommunityListElementComponent extends AbstractListableElementComponent<Community> {} export class CommunityListElementComponent extends AbstractListableElementComponent<Community> {}

View File

@@ -1 +0,0 @@
<ds-listable-object-component-loader [type]="object.firstMetadataValue('relationship.type')" [object]="object" [viewMode]="viewMode"></ds-listable-object-component-loader>

View File

@@ -1,47 +0,0 @@
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { ItemListElementComponent } from './item-list-element.component';
import { Item } from '../../../core/shared/item.model';
import { RemoteData } from '../../../core/data/remote-data';
import { PaginatedList } from '../../../core/data/paginated-list';
import { PageInfo } from '../../../core/shared/page-info.model';
import { By } from '@angular/platform-browser';
import { createRelationshipsObservable } from '../../../+item-page/simple/item-types/shared/item.component.spec';
import { of as observableOf } from 'rxjs';
import { createSuccessfulRemoteDataObject$ } from '../../testing/utils';
const mockItem: Item = Object.assign(new Item(), {
bitstreams: createSuccessfulRemoteDataObject$(new PaginatedList(new PageInfo(), [])),
metadata: [],
relationships: createRelationshipsObservable()
});
describe('ItemListElementComponent', () => {
let comp: ItemListElementComponent;
let fixture: ComponentFixture<ItemListElementComponent>;
beforeEach(async(() => {
TestBed.configureTestingModule({
imports: [],
declarations: [ItemListElementComponent],
providers: [
{ provide: 'objectElementProvider', useValue: mockItem }
],
schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(ItemListElementComponent, {
set: {changeDetection: ChangeDetectionStrategy.Default}
}).compileComponents();
}));
beforeEach(async(() => {
fixture = TestBed.createComponent(ItemListElementComponent);
comp = fixture.componentInstance;
fixture.detectChanges();
}));
it('should call an item-type-switcher component and pass the item', () => {
const itemTypeSwitcher = fixture.debugElement.query(By.css('ds-item-type-switcher')).componentInstance;
expect(itemTypeSwitcher.object).toBe(mockItem);
});
});

View File

@@ -1,21 +0,0 @@
import { Component } from '@angular/core';
import { Item } from '../../../core/shared/item.model';
import { AbstractListableElementComponent } from '../../object-collection/shared/object-collection-element/abstract-listable-element.component';
import { ViewMode } from '../../../core/shared/view-mode.model';
import { listableObjectComponent } from '../../object-collection/shared/listable-object/listable-object.decorator';
@Component({
selector: 'ds-item-list-element',
styleUrls: ['./item-list-element.component.scss'],
templateUrl: './item-list-element.component.html'
})
/**
* The component used to list items depending on type
* Uses item-type-switcher to determine which components to use for displaying the list
*/
@listableObjectComponent(Item, ViewMode.ListElement)
export class ItemListElementComponent extends AbstractListableElementComponent<Item> {
viewMode = ViewMode.ListElement;
}

View File

@@ -8,5 +8,5 @@ import { DSpaceObject } from '../../../core/shared/dspace-object.model';
templateUrl: './item-type-badge.component.html' templateUrl: './item-type-badge.component.html'
}) })
export class ItemTypeBadgeComponent { export class ItemTypeBadgeComponent {
@Input() object: SearchResult<DSpaceObject>; @Input() object: DSpaceObject;
} }

View File

@@ -1,2 +1,2 @@
<ds-item-type-switcher [object]="metadataRepresentation" [viewMode]="viewMode"> <ds-listable-object-component-loader [object]="metadataRepresentation" [viewMode]="viewMode">
</ds-item-type-switcher> </ds-listable-object-component-loader>

View File

@@ -31,7 +31,7 @@ describe('ItemMetadataListElementComponent', () => {
})); }));
it('should call an item-type-switcher component and pass the item-metadata-representation', () => { it('should call an item-type-switcher component and pass the item-metadata-representation', () => {
const itemTypeSwitcher = fixture.debugElement.query(By.css('ds-item-type-switcher')).nativeElement; const itemTypeSwitcher = fixture.debugElement.query(By.css('ds-listable-object-component-loader')).nativeElement;
expect(itemTypeSwitcher.object).toBe(mockItemMetadataRepresentation); expect(itemTypeSwitcher.object).toBe(mockItemMetadataRepresentation);
}); });

View File

@@ -24,8 +24,8 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
providers: [Location, { provide: LocationStrategy, useClass: PathLocationStrategy }] providers: [Location, { provide: LocationStrategy, useClass: PathLocationStrategy }]
}) })
@listableObjectComponent(ClaimedTaskMyDSpaceResult, ViewMode.ListElement) @listableObjectComponent(ClaimedTaskMyDSpaceResult.name, ViewMode.ListElement)
@listableObjectComponent(ClaimedTask, ViewMode.ListElement) @listableObjectComponent(ClaimedTask.name, ViewMode.ListElement)
export class ClaimedMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<ClaimedTaskMyDSpaceResult, ClaimedTask> { export class ClaimedMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<ClaimedTaskMyDSpaceResult, ClaimedTask> {
/** /**

View File

@@ -6,6 +6,7 @@ import { ItemMyDSpaceResult } from '../../../object-collection/shared/item-my-ds
import { MyDspaceItemStatusType } from '../../../object-collection/shared/mydspace-item-status/my-dspace-item-status-type'; import { MyDspaceItemStatusType } from '../../../object-collection/shared/mydspace-item-status/my-dspace-item-status-type';
import { ViewMode } from '../../../../core/shared/view-mode.model'; import { ViewMode } from '../../../../core/shared/view-mode.model';
import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator'; import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator';
import { Context } from '../../../../core/shared/context.model';
/** /**
* This component renders item object for the mydspace result in the list view. * This component renders item object for the mydspace result in the list view.
@@ -16,7 +17,7 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: './item-my-dspace-result-list-element.component.html' templateUrl: './item-my-dspace-result-list-element.component.html'
}) })
@listableObjectComponent(ItemMyDSpaceResult, ViewMode.ListElement) @listableObjectComponent('PublicationSearchResult', ViewMode.ListElement, Context.Submission)
export class ItemMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<ItemMyDSpaceResult, Item> { export class ItemMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<ItemMyDSpaceResult, Item> {
/** /**

View File

@@ -13,6 +13,7 @@ import { PoolTask } from '../../../../core/tasks/models/pool-task-object.model';
import { PoolTaskMyDSpaceResult } from '../../../object-collection/shared/pool-task-my-dspace-result.model'; import { PoolTaskMyDSpaceResult } from '../../../object-collection/shared/pool-task-my-dspace-result.model';
import { MyDspaceItemStatusType } from '../../../object-collection/shared/mydspace-item-status/my-dspace-item-status-type'; import { MyDspaceItemStatusType } from '../../../object-collection/shared/mydspace-item-status/my-dspace-item-status-type';
import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator'; import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator';
import { ClaimedTaskMyDSpaceResult } from '../../../object-collection/shared/claimed-task-my-dspace-result.model';
/** /**
* This component renders pool task object for the mydspace result in the list view. * This component renders pool task object for the mydspace result in the list view.
@@ -23,8 +24,8 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: './pool-my-dspace-result-list-element.component.html', templateUrl: './pool-my-dspace-result-list-element.component.html',
}) })
@listableObjectComponent(PoolTaskMyDSpaceResult, ViewMode.ListElement) @listableObjectComponent(PoolTaskMyDSpaceResult.name, ViewMode.ListElement)
@listableObjectComponent(PoolTask, ViewMode.ListElement) @listableObjectComponent(PoolTask.name, ViewMode.ListElement)
export class PoolMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<PoolTaskMyDSpaceResult, PoolTask> implements OnInit { export class PoolMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<PoolTaskMyDSpaceResult, PoolTask> implements OnInit {
/** /**

View File

@@ -22,8 +22,8 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: './workflowitem-my-dspace-result-list-element.component.html', templateUrl: './workflowitem-my-dspace-result-list-element.component.html',
}) })
@listableObjectComponent(WorkflowitemMyDSpaceResult, ViewMode.ListElement) @listableObjectComponent(WorkflowitemMyDSpaceResult.name, ViewMode.ListElement)
@listableObjectComponent(WorkflowItem, ViewMode.ListElement) @listableObjectComponent(WorkflowItem.name, ViewMode.ListElement)
export class WorkflowitemMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<WorkflowitemMyDSpaceResult, WorkflowItem> { export class WorkflowitemMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<WorkflowitemMyDSpaceResult, WorkflowItem> {
/** /**

View File

@@ -22,7 +22,7 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: './workspaceitem-my-dspace-result-list-element.component.html', templateUrl: './workspaceitem-my-dspace-result-list-element.component.html',
}) })
@listableObjectComponent(WorkspaceitemMyDSpaceResult, ViewMode.ListElement) @listableObjectComponent(WorkspaceitemMyDSpaceResult.name, ViewMode.ListElement)
export class WorkspaceitemMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<WorkspaceitemMyDSpaceResult, WorkspaceItem> { export class WorkspaceitemMyDSpaceResultListElementComponent extends MyDSpaceResultListElementComponent<WorkspaceitemMyDSpaceResult, WorkspaceItem> {
/** /**

View File

@@ -12,7 +12,7 @@
(paginationChange)="onPaginationChange($event)"> (paginationChange)="onPaginationChange($event)">
<ul *ngIf="objects?.hasSucceeded" class="list-unstyled"> <ul *ngIf="objects?.hasSucceeded" class="list-unstyled">
<li *ngFor="let object of objects?.payload?.page; let i = index; let last = last" class="mt-4 mb-4" [class.border-bottom]="hasBorder && !last"> <li *ngFor="let object of objects?.payload?.page; let i = index; let last = last" class="mt-4 mb-4" [class.border-bottom]="hasBorder && !last">
<ds-wrapper-list-element [object]="object" [index]="i"></ds-wrapper-list-element> <ds-listable-object-component-loader [object]="object" [viewMode]="viewMode" [index]="i"></ds-listable-object-component-loader>
</li> </li>
</ul> </ul>
</ds-pagination> </ds-pagination>

View File

@@ -12,6 +12,7 @@ import { RemoteData } from '../../core/data/remote-data';
import { fadeIn } from '../animations/fade'; import { fadeIn } from '../animations/fade';
import { ListableObject } from '../object-collection/shared/listable-object.model'; import { ListableObject } from '../object-collection/shared/listable-object.model';
import { PaginationComponentOptions } from '../pagination/pagination-component-options.model'; import { PaginationComponentOptions } from '../pagination/pagination-component-options.model';
import { ViewMode } from '../../core/shared/view-mode.model';
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.Default, changeDetection: ChangeDetectionStrategy.Default,
@@ -22,7 +23,7 @@ import { PaginationComponentOptions } from '../pagination/pagination-component-o
animations: [fadeIn] animations: [fadeIn]
}) })
export class ObjectListComponent { export class ObjectListComponent {
viewMode = ViewMode.ListElement;
@Input() config: PaginationComponentOptions; @Input() config: PaginationComponentOptions;
@Input() sortConfig: SortOptions; @Input() sortConfig: SortOptions;
@Input() hasBorder = false; @Input() hasBorder = false;

View File

@@ -6,6 +6,7 @@ import { Collection } from '../../../../core/shared/collection.model';
import { CollectionSearchResult } from '../../../object-collection/shared/collection-search-result.model'; import { CollectionSearchResult } from '../../../object-collection/shared/collection-search-result.model';
import { ViewMode } from '../../../../core/shared/view-mode.model'; import { ViewMode } from '../../../../core/shared/view-mode.model';
import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator'; import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator';
import { BrowseEntry } from '../../../../core/shared/browse-entry.model';
@Component({ @Component({
selector: 'ds-collection-search-result-list-element', selector: 'ds-collection-search-result-list-element',
@@ -13,5 +14,5 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: 'collection-search-result-list-element.component.html' templateUrl: 'collection-search-result-list-element.component.html'
}) })
@listableObjectComponent(CollectionSearchResult, ViewMode.ListElement) @listableObjectComponent(CollectionSearchResult.name, ViewMode.ListElement)
export class CollectionSearchResultListElementComponent extends SearchResultListElementComponent<CollectionSearchResult, Collection> {} export class CollectionSearchResultListElementComponent extends SearchResultListElementComponent<CollectionSearchResult, Collection> {}

View File

@@ -6,6 +6,7 @@ import { Community } from '../../../../core/shared/community.model';
import { CommunitySearchResult } from '../../../object-collection/shared/community-search-result.model'; import { CommunitySearchResult } from '../../../object-collection/shared/community-search-result.model';
import { ViewMode } from '../../../../core/shared/view-mode.model'; import { ViewMode } from '../../../../core/shared/view-mode.model';
import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator'; import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator';
import { BrowseEntry } from '../../../../core/shared/browse-entry.model';
@Component({ @Component({
selector: 'ds-community-search-result-list-element', selector: 'ds-community-search-result-list-element',
@@ -13,7 +14,7 @@ import { listableObjectComponent } from '../../../object-collection/shared/lista
templateUrl: 'community-search-result-list-element.component.html' templateUrl: 'community-search-result-list-element.component.html'
}) })
@listableObjectComponent(CommunitySearchResult, ViewMode.ListElement) @listableObjectComponent(CommunitySearchResult.name, ViewMode.ListElement)
export class CommunitySearchResultListElementComponent extends SearchResultListElementComponent<CommunitySearchResult, Community> { export class CommunitySearchResultListElementComponent extends SearchResultListElementComponent<CommunitySearchResult, Community> {
} }

View File

@@ -1,2 +0,0 @@
<ds-item-type-badge [object]="object"></ds-item-type-badge>
<ds-listable-object-component-loader [type]="object.indexableObject.firstMetadataValue('relationship.type') + 'SearchResult'" [object]="object" [viewMode]="viewMode"></ds-listable-object-component-loader>

View File

@@ -1,60 +0,0 @@
import { ItemSearchResultListElementComponent } from './item-search-result-list-element.component';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { of as observableOf } from 'rxjs';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser';
import { TruncatePipe } from '../../../utils/truncate.pipe';
import { Item } from '../../../../core/shared/item.model';
import { TruncatableService } from '../../../truncatable/truncatable.service';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { ItemSearchResult } from '../../../object-collection/shared/item-search-result.model';
import { TranslateModule } from '@ngx-translate/core';
let itemSearchResultListElementComponent: ItemSearchResultListElementComponent;
let fixture: ComponentFixture<ItemSearchResultListElementComponent>;
const truncatableServiceStub: any = {
isCollapsed: (id: number) => observableOf(true),
};
const type = 'authorOfPublication';
const mockItemWithRelationshipType: ItemSearchResult = new ItemSearchResult();
mockItemWithRelationshipType.hitHighlights = {};
mockItemWithRelationshipType.indexableObject = Object.assign(new Item(), {
bitstreams: observableOf({}),
metadata: {
'relationship.type': [
{
language: 'en_US',
value: type
}
]
}
});
describe('ItemSearchResultListElementComponent', () => {
beforeEach(async(() => {
TestBed.configureTestingModule({
imports: [TranslateModule.forRoot(), NoopAnimationsModule],
declarations: [ItemSearchResultListElementComponent, TruncatePipe],
providers: [
{ provide: TruncatableService, useValue: truncatableServiceStub },
{ provide: 'objectElementProvider', useValue: (mockItemWithRelationshipType) }
],
schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(ItemSearchResultListElementComponent, {
set: { changeDetection: ChangeDetectionStrategy.Default }
}).compileComponents();
}));
beforeEach(async(() => {
fixture = TestBed.createComponent(ItemSearchResultListElementComponent);
itemSearchResultListElementComponent = fixture.componentInstance;
}));
it('should show a badge on top of the list element', () => {
const badge = fixture.debugElement.query(By.css('ds-item-type-badge')).componentInstance;
expect(badge.object).toBe(mockItemWithRelationshipType);
});
});

View File

@@ -1,22 +0,0 @@
import { Component } from '@angular/core';
import { Item } from '../../../../core/shared/item.model';
import { focusBackground } from '../../../animations/focus';
import { ItemSearchResult } from '../../../object-collection/shared/item-search-result.model';
import { SearchResultListElementComponent } from '../search-result-list-element.component';
import { ViewMode } from '../../../../core/shared/view-mode.model';
import { listableObjectComponent } from '../../../object-collection/shared/listable-object/listable-object.decorator';
@Component({
selector: 'ds-item-search-result-list-element',
styleUrls: ['../search-result-list-element.component.scss', 'item-search-result-list-element.component.scss'],
templateUrl: 'item-search-result-list-element.component.html',
animations: [focusBackground],
})
@listableObjectComponent(ItemSearchResult, ViewMode.ListElement)
export class ItemSearchResultListElementComponent extends SearchResultListElementComponent<ItemSearchResult, Item> {
viewMode = ViewMode.ListElement;
}

View File

@@ -1,12 +1,14 @@
<ng-container *ngVar="object.indexableObject as item"> <ng-container *ngVar="object.indexableObject as item">
<ds-truncatable [id]="item.id" *ngIf="object !== undefined && object !== null"> <ds-item-type-badge [object]="item"></ds-item-type-badge>
<a
[routerLink]="['/items/' + item.id]" class="lead" <ds-truncatable [id]="item.id" *ngIf="object !== undefined && object !== null">
[innerHTML]="firstMetadataValue('dc.title')"></a> <a
<span class="text-muted"> [routerLink]="['/items/' + item.id]" class="lead"
[innerHTML]="firstMetadataValue('dc.title')"></a>
<span class="text-muted">
<ds-truncatable-part [id]="item.id" [minLines]="1"> <ds-truncatable-part [id]="item.id" [minLines]="1">
<ng-container *ngIf="item.firstMetadataValue('dc.publisher') || item.firstMetadataValue('dc.date.issued')">(<span class="item-list-publisher" <ng-container *ngIf="item.firstMetadataValue('dc.publisher') || item.firstMetadataValue('dc.date.issued')">(<span class="item-list-publisher"
[innerHTML]="firstMetadataValue('dc.publisher')">, </span><span [innerHTML]="firstMetadataValue('dc.publisher')">, </span><span
*ngIf="item.firstMetadataValue('dc.date.issued')" class="item-list-date" *ngIf="item.firstMetadataValue('dc.date.issued')" class="item-list-date"
[innerHTML]="firstMetadataValue('dc.date.issued')"></span>)</ng-container> [innerHTML]="firstMetadataValue('dc.date.issued')"></span>)</ng-container>
<span *ngIf="item.allMetadata(['dc.contributor.author', 'dc.creator', 'dc.contributor.*']).length > 0" <span *ngIf="item.allMetadata(['dc.contributor.author', 'dc.creator', 'dc.contributor.*']).length > 0"
@@ -18,10 +20,10 @@
</span> </span>
</ds-truncatable-part> </ds-truncatable-part>
</span> </span>
<div *ngIf="item.firstMetadataValue('dc.description.abstract')" class="item-list-abstract"> <div *ngIf="item.firstMetadataValue('dc.description.abstract')" class="item-list-abstract">
<ds-truncatable-part [id]="item.id" [minLines]="3"><span <ds-truncatable-part [id]="item.id" [minLines]="3"><span
[innerHTML]="firstMetadataValue('dc.description.abstract')"></span> [innerHTML]="firstMetadataValue('dc.description.abstract')"></span>
</ds-truncatable-part> </ds-truncatable-part>
</div> </div>
</ds-truncatable> </ds-truncatable>
</ng-container> </ng-container>

Some files were not shown because too many files have changed in this diff Show More