fix tests

This commit is contained in:
Andrea Barbasso
2024-01-11 09:46:44 +01:00
parent 2d879bd3fe
commit a3fefc20a7
13 changed files with 2 additions and 31 deletions

View File

@@ -30,7 +30,6 @@ import { ThumbnailComponent } from '../../../../../thumbnail/thumbnail.component
import { CollectionElementLinkType } from '../../../../../shared/object-collection/collection-element-link.type'; import { CollectionElementLinkType } from '../../../../../shared/object-collection/collection-element-link.type';
import { AuthService } from '../../../../../core/auth/auth.service'; import { AuthService } from '../../../../../core/auth/auth.service';
import { REQUEST } from '@nguniversal/express-engine/tokens'; import { REQUEST } from '@nguniversal/express-engine/tokens';
import { BrowseByRoutingModule } from '../../../../../browse-by/browse-by-routing.module';
import { ThemeService } from '../../../../../shared/theme-support/theme.service'; import { ThemeService } from '../../../../../shared/theme-support/theme.service';
import { getMockThemeService } from '../../../../../shared/mocks/theme-service.mock'; import { getMockThemeService } from '../../../../../shared/mocks/theme-service.mock';
@@ -111,7 +110,7 @@ describe('PersonSearchResultListElementSubmissionComponent', () => {
beforeEach(waitForAsync(async () => { beforeEach(waitForAsync(async () => {
init(); init();
await TestBed.configureTestingModule({ await TestBed.configureTestingModule({
imports: [PersonSearchResultListSubmissionElementComponent, TruncatePipe, BrowseByRoutingModule], imports: [PersonSearchResultListSubmissionElementComponent, TruncatePipe],
providers: [ providers: [
{ provide: TruncatableService, useValue: {} }, { provide: TruncatableService, useValue: {} },
{ provide: RelationshipDataService, useValue: mockRelationshipService }, { provide: RelationshipDataService, useValue: mockRelationshipService },
@@ -210,7 +209,7 @@ describe('PersonSearchResultListElementSubmissionComponent', () => {
beforeEach(waitForAsync(() => { beforeEach(waitForAsync(() => {
init(); init();
TestBed.configureTestingModule({ TestBed.configureTestingModule({
imports: [PersonSearchResultListSubmissionElementComponent, TruncatePipe, BrowseByRoutingModule], imports: [PersonSearchResultListSubmissionElementComponent, TruncatePipe],
providers: [ providers: [
{ provide: TruncatableService, useValue: {} }, { provide: TruncatableService, useValue: {} },
{ provide: RelationshipDataService, useValue: mockRelationshipService }, { provide: RelationshipDataService, useValue: mockRelationshipService },

View File

@@ -12,7 +12,6 @@ import { ResponsiveColumnSizes } from '../../../../shared/responsive-table-sizes
import { createSuccessfulRemoteDataObject$ } from '../../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../../../shared/remote-data.utils';
import { getBitstreamDownloadRoute } from '../../../../app-routing-paths'; import { getBitstreamDownloadRoute } from '../../../../app-routing-paths';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { BrowserOnlyMockPipe } from '../../../../shared/testing/browser-only-mock.pipe';
import { ActivatedRoute } from '@angular/router'; import { ActivatedRoute } from '@angular/router';
import { ActivatedRouteStub } from '../../../../shared/testing/active-router.stub'; import { ActivatedRouteStub } from '../../../../shared/testing/active-router.stub';
import { RouterTestingModule } from '@angular/router/testing'; import { RouterTestingModule } from '@angular/router/testing';
@@ -81,7 +80,6 @@ describe('ItemEditBitstreamComponent', () => {
ItemEditBitstreamComponent, ItemEditBitstreamComponent,
VarDirective VarDirective
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: ObjectUpdatesService, useValue: objectUpdatesService }, { provide: ObjectUpdatesService, useValue: objectUpdatesService },
{ provide: ActivatedRoute, useValue: new ActivatedRouteStub() } { provide: ActivatedRoute, useValue: new ActivatedRouteStub() }

View File

@@ -13,7 +13,6 @@ import { ResourceType } from '../../../core/shared/resource-type';
import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
import { PageInfo } from '../../../core/shared/page-info.model'; import { PageInfo } from '../../../core/shared/page-info.model';
import { RouterStub } from '../../../shared/testing/router.stub'; import { RouterStub } from '../../../shared/testing/router.stub';
import { BrowserOnlyMockPipe } from '../../../shared/testing/browser-only-mock.pipe';
export function getMockEntityTypeService(): EntityTypeDataService { export function getMockEntityTypeService(): EntityTypeDataService {
const pageInfo = { elementsPerPage: 20, totalElements: 4, totalPages: 1, currentPage: 0 } as PageInfo; const pageInfo = { elementsPerPage: 20, totalElements: 4, totalPages: 1, currentPage: 0 } as PageInfo;
@@ -84,7 +83,6 @@ describe('MyDSpaceNewExternalDropdownComponent test', () => {
MyDSpaceNewExternalDropdownComponent, MyDSpaceNewExternalDropdownComponent,
TestComponent TestComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: EntityTypeDataService, useValue: getMockEmptyEntityTypeService() }, { provide: EntityTypeDataService, useValue: getMockEmptyEntityTypeService() },
{ provide: Router, useValue: new RouterStub() }, { provide: Router, useValue: new RouterStub() },
@@ -134,7 +132,6 @@ describe('MyDSpaceNewExternalDropdownComponent test', () => {
MyDSpaceNewExternalDropdownComponent, MyDSpaceNewExternalDropdownComponent,
TestComponent TestComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: EntityTypeDataService, useValue: getMockEntityTypeService() }, { provide: EntityTypeDataService, useValue: getMockEntityTypeService() },
{ provide: Router, useValue: new RouterStub() }, { provide: Router, useValue: new RouterStub() },

View File

@@ -12,7 +12,6 @@ import { ItemType } from '../../../core/shared/item-relationships/item-type.mode
import { ResourceType } from '../../../core/shared/resource-type'; import { ResourceType } from '../../../core/shared/resource-type';
import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
import { PageInfo } from '../../../core/shared/page-info.model'; import { PageInfo } from '../../../core/shared/page-info.model';
import { BrowserOnlyMockPipe } from '../../../shared/testing/browser-only-mock.pipe';
export function getMockEntityTypeService(): EntityTypeDataService { export function getMockEntityTypeService(): EntityTypeDataService {
const type1: ItemType = { const type1: ItemType = {
@@ -88,7 +87,6 @@ describe('MyDSpaceNewSubmissionDropdownComponent test', () => {
MyDSpaceNewSubmissionDropdownComponent, MyDSpaceNewSubmissionDropdownComponent,
TestComponent TestComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: EntityTypeDataService, useValue: getMockEmptyEntityTypeService() }, { provide: EntityTypeDataService, useValue: getMockEmptyEntityTypeService() },
{ provide: NgbModal, useValue: modalStub }, { provide: NgbModal, useValue: modalStub },
@@ -138,7 +136,6 @@ describe('MyDSpaceNewSubmissionDropdownComponent test', () => {
MyDSpaceNewSubmissionDropdownComponent, MyDSpaceNewSubmissionDropdownComponent,
TestComponent TestComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: EntityTypeDataService, useValue: getMockEntityTypeService() }, { provide: EntityTypeDataService, useValue: getMockEntityTypeService() },
{ provide: NgbModal, useValue: modalStub }, { provide: NgbModal, useValue: modalStub },

View File

@@ -9,7 +9,6 @@ import { TranslateLoaderMock } from '../shared/mocks/translate-loader.mock';
import { SearchNavbarComponent } from './search-navbar.component'; import { SearchNavbarComponent } from './search-navbar.component';
import { RouterTestingModule } from '@angular/router/testing'; import { RouterTestingModule } from '@angular/router/testing';
import { BrowserOnlyMockPipe } from '../shared/testing/browser-only-mock.pipe';
describe('SearchNavbarComponent', () => { describe('SearchNavbarComponent', () => {
let component: SearchNavbarComponent; let component: SearchNavbarComponent;
@@ -38,7 +37,6 @@ describe('SearchNavbarComponent', () => {
}), }),
SearchNavbarComponent SearchNavbarComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: SearchService, useValue: mockSearchService } { provide: SearchService, useValue: mockSearchService }
] ]

View File

@@ -15,7 +15,6 @@ import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { AuthTokenInfo } from '../../core/auth/models/auth-token-info.model'; import { AuthTokenInfo } from '../../core/auth/models/auth-token-info.model';
import { AuthService } from '../../core/auth/auth.service'; import { AuthService } from '../../core/auth/auth.service';
import { of } from 'rxjs'; import { of } from 'rxjs';
import { BrowserOnlyMockPipe } from '../testing/browser-only-mock.pipe';
import { ActivatedRoute } from '@angular/router'; import { ActivatedRoute } from '@angular/router';
import { ActivatedRouteStub } from '../testing/active-router.stub'; import { ActivatedRouteStub } from '../testing/active-router.stub';
@@ -80,7 +79,6 @@ describe('AuthNavMenuComponent', () => {
TranslateModule.forRoot(), TranslateModule.forRoot(),
AuthNavMenuComponent AuthNavMenuComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: HostWindowService, useValue: window }, { provide: HostWindowService, useValue: window },
{ provide: AuthService, useValue: authService }, { provide: AuthService, useValue: authService },

View File

@@ -44,8 +44,6 @@ import { ConfigurationProperty } from '../../core/shared/configuration-property.
import { SearchConfigurationServiceStub } from '../testing/search-configuration-service.stub'; import { SearchConfigurationServiceStub } from '../testing/search-configuration-service.stub';
import { SearchConfigurationService } from '../../core/shared/search/search-configuration.service'; import { SearchConfigurationService } from '../../core/shared/search/search-configuration.service';
import { getMockThemeService } from '../mocks/theme-service.mock'; import { getMockThemeService } from '../mocks/theme-service.mock';
import { BrowseByRoutingModule } from '../../browse-by/browse-by-routing.module';
import { AccessControlRoutingModule } from '../../access-control/access-control-routing.module';
@listableObjectComponent(BrowseEntry, ViewMode.ListElement, DEFAULT_CONTEXT, 'custom') @listableObjectComponent(BrowseEntry, ViewMode.ListElement, DEFAULT_CONTEXT, 'custom')
@Component({ @Component({
@@ -115,8 +113,6 @@ describe('BrowseByComponent', () => {
themeService = getMockThemeService('dspace'); themeService = getMockThemeService('dspace');
TestBed.configureTestingModule({ TestBed.configureTestingModule({
imports: [ imports: [
BrowseByRoutingModule,
AccessControlRoutingModule,
CommonModule, CommonModule,
NgbModule, NgbModule,
TranslateModule.forRoot({ TranslateModule.forRoot({

View File

@@ -15,7 +15,6 @@ import { storeModuleConfig } from '../../../../app.reducer';
import { AuthMethod } from '../../../../core/auth/models/auth.method'; import { AuthMethod } from '../../../../core/auth/models/auth.method';
import { AuthMethodType } from '../../../../core/auth/models/auth.method-type'; import { AuthMethodType } from '../../../../core/auth/models/auth.method-type';
import { HardRedirectService } from '../../../../core/services/hard-redirect.service'; import { HardRedirectService } from '../../../../core/services/hard-redirect.service';
import { BrowserOnlyMockPipe } from '../../../testing/browser-only-mock.pipe';
import { AuthorizationDataService } from '../../../../core/data/feature-authorization/authorization-data.service'; import { AuthorizationDataService } from '../../../../core/data/feature-authorization/authorization-data.service';
import { AuthorizationDataServiceStub } from '../../../testing/authorization-service.stub'; import { AuthorizationDataServiceStub } from '../../../testing/authorization-service.stub';
import { ActivatedRouteStub } from '../../../testing/active-router.stub'; import { ActivatedRouteStub } from '../../../testing/active-router.stub';
@@ -60,7 +59,6 @@ describe('LogInPasswordComponent', () => {
TranslateModule.forRoot(), TranslateModule.forRoot(),
LogInPasswordComponent LogInPasswordComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: AuthService, useClass: AuthServiceStub }, { provide: AuthService, useClass: AuthServiceStub },
{ provide: AuthorizationDataService, useClass: AuthorizationDataServiceStub }, { provide: AuthorizationDataService, useClass: AuthorizationDataServiceStub },

View File

@@ -12,7 +12,6 @@ import { Router } from '@angular/router';
import { AppState } from '../../app.reducer'; import { AppState } from '../../app.reducer';
import { LogOutComponent } from './log-out.component'; import { LogOutComponent } from './log-out.component';
import { RouterStub } from '../testing/router.stub'; import { RouterStub } from '../testing/router.stub';
import { BrowserOnlyMockPipe } from '../testing/browser-only-mock.pipe';
describe('LogOutComponent', () => { describe('LogOutComponent', () => {
@@ -47,7 +46,6 @@ describe('LogOutComponent', () => {
TranslateModule.forRoot(), TranslateModule.forRoot(),
LogOutComponent LogOutComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: Router, useValue: routerStub }, { provide: Router, useValue: routerStub },
], ],

View File

@@ -13,7 +13,6 @@ import { SearchConfigurationService } from '../../core/shared/search/search-conf
import { PaginationServiceStub } from '../testing/pagination-service.stub'; import { PaginationServiceStub } from '../testing/pagination-service.stub';
import { DSpaceObjectDataService } from '../../core/data/dspace-object-data.service'; import { DSpaceObjectDataService } from '../../core/data/dspace-object-data.service';
import { createSuccessfulRemoteDataObject$ } from '../remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../remote-data.utils';
import { BrowserOnlyMockPipe } from '../testing/browser-only-mock.pipe';
import { SearchServiceStub } from '../testing/search-service.stub'; import { SearchServiceStub } from '../testing/search-service.stub';
import { Router } from '@angular/router'; import { Router } from '@angular/router';
import { RouterStub } from '../testing/router.stub'; import { RouterStub } from '../testing/router.stub';
@@ -43,7 +42,6 @@ describe('SearchFormComponent', () => {
{ provide: SearchConfigurationService, useValue: searchConfigService }, { provide: SearchConfigurationService, useValue: searchConfigService },
{ provide: DSpaceObjectDataService, useValue: dspaceObjectService }, { provide: DSpaceObjectDataService, useValue: dspaceObjectService },
], ],
declarations: [BrowserOnlyMockPipe]
}).compileComponents(); }).compileComponents();
})); }));

View File

@@ -13,7 +13,6 @@ import { FilterType } from '../../models/filter-type.model';
import { SearchConfigurationServiceStub } from '../../../testing/search-configuration-service.stub'; import { SearchConfigurationServiceStub } from '../../../testing/search-configuration-service.stub';
import { SEARCH_CONFIG_SERVICE } from '../../../../my-dspace-page/my-dspace-page.component'; import { SEARCH_CONFIG_SERVICE } from '../../../../my-dspace-page/my-dspace-page.component';
import { SequenceService } from '../../../../core/shared/sequence.service'; import { SequenceService } from '../../../../core/shared/sequence.service';
import { BrowserOnlyMockPipe } from '../../../testing/browser-only-mock.pipe';
import { SearchFacetFilterWrapperComponent } from './search-facet-filter-wrapper/search-facet-filter-wrapper.component'; import { SearchFacetFilterWrapperComponent } from './search-facet-filter-wrapper/search-facet-filter-wrapper.component';
describe('SearchFilterComponent', () => { describe('SearchFilterComponent', () => {
@@ -64,7 +63,6 @@ describe('SearchFilterComponent', () => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
imports: [TranslateModule.forRoot(), RouterTestingModule.withRoutes([]), NoopAnimationsModule, SearchFilterComponent], imports: [TranslateModule.forRoot(), RouterTestingModule.withRoutes([]), NoopAnimationsModule, SearchFilterComponent],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: SearchService, useValue: searchServiceStub }, { provide: SearchService, useValue: searchServiceStub },
{ {

View File

@@ -9,7 +9,6 @@ import { SearchService } from '../../core/shared/search/search.service';
import { ViewModeSwitchComponent } from './view-mode-switch.component'; import { ViewModeSwitchComponent } from './view-mode-switch.component';
import { SearchServiceStub } from '../testing/search-service.stub'; import { SearchServiceStub } from '../testing/search-service.stub';
import { ViewMode } from '../../core/shared/view-mode.model'; import { ViewMode } from '../../core/shared/view-mode.model';
import { BrowserOnlyMockPipe } from '../testing/browser-only-mock.pipe';
@Component({ @Component({
template: '', template: '',
@@ -40,7 +39,6 @@ describe('ViewModeSwitchComponent', () => {
ViewModeSwitchComponent, ViewModeSwitchComponent,
DummyComponent DummyComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: SearchService, useValue: searchService }, { provide: SearchService, useValue: searchService },
] ]

View File

@@ -15,7 +15,6 @@ import { SubmissionRestServiceStub } from '../../../shared/testing/submission-re
import { SubmissionFormFooterComponent } from './submission-form-footer.component'; import { SubmissionFormFooterComponent } from './submission-form-footer.component';
import { SubmissionRestService } from '../../../core/submission/submission-rest.service'; import { SubmissionRestService } from '../../../core/submission/submission-rest.service';
import { createTestComponent } from '../../../shared/testing/utils.test'; import { createTestComponent } from '../../../shared/testing/utils.test';
import { BrowserOnlyMockPipe } from '../../../shared/testing/browser-only-mock.pipe';
const submissionServiceStub: SubmissionServiceStub = new SubmissionServiceStub(); const submissionServiceStub: SubmissionServiceStub = new SubmissionServiceStub();
@@ -37,7 +36,6 @@ describe('SubmissionFormFooterComponent', () => {
SubmissionFormFooterComponent, SubmissionFormFooterComponent,
TestComponent TestComponent
], ],
declarations: [BrowserOnlyMockPipe],
providers: [ providers: [
{ provide: SubmissionService, useValue: submissionServiceStub }, { provide: SubmissionService, useValue: submissionServiceStub },
{ provide: SubmissionRestService, useClass: SubmissionRestServiceStub }, { provide: SubmissionRestService, useClass: SubmissionRestServiceStub },