hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 18:14:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix issue where thumbnail would sometimes keep loading indefinitely

Browse Source
This commit is contained in:
Art Lowel
2025-05-06 14:38:45 +02:00
parent 54ed550f4a
commit a7bcddf597
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/app/thumbnail/thumbnail.component.ts
View File

@@ -97,13 +97,6 @@ export class ThumbnailComponent implements OnChanges {
*/ */
ngOnChanges(changes: SimpleChanges): void { ngOnChanges(changes: SimpleChanges): void {
if (isPlatformBrowser(this.platformID)) { if (isPlatformBrowser(this.platformID)) {
// every time the inputs change we need to start the loading animation again, as it's possible
// that thumbnail is first set to null when the parent component initializes and then set to
// the actual value
if (this.isLoading$.getValue() === false) {
this.isLoading$.next(true);
}
if (hasNoValue(this.thumbnail)) { if (hasNoValue(this.thumbnail)) {
this.setSrc(this.defaultImage); this.setSrc(this.defaultImage);
return; return;
@@ -196,11 +189,24 @@ export class ThumbnailComponent implements OnChanges {
* @param src * @param src
*/ */
setSrc(src: string): void { setSrc(src: string): void {
// only update the src if it has changed (the parent component may fire the same one multiple times
if (this.src$.getValue() !== src) {
// every time the src changes we need to start the loading animation again, as it's possible
// that it is first set to null when the parent component initializes and then set to
// the actual value
//
// isLoading$ will be set to false by the error or success handler afterwards, except in the
// case where src is null, then we have to set it manually here (because those handlers won't
// trigger)
if (this.isLoading$.getValue() === false) {
this.isLoading$.next(true);
}
this.src$.next(src); this.src$.next(src);
if (src === null) { if (src === null) {
this.isLoading$.next(false); this.isLoading$.next(false);
} }
} }
}
/** /**
* Stop the loading animation once the thumbnail is successfully loaded * Stop the loading animation once the thumbnail is successfully loaded