hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-12 20:43:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1146 from atmire/w2p-79220_fix-edit-group-navigation-bug

Browse Source 
Fix edit group navigation bug
This commit is contained in:
Tim Donohue
2021-05-07 09:42:35 -05:00
committed by GitHub
parent a69033917d 042afd9bb8
commit a87bf009ef
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/app/access-control/group-registry/group-form/group-form.component.spec.ts
View File

@@ -210,4 +210,11 @@ describe('GroupFormComponent', () => {
});
});
describe('ngOnDestroy', () => {
it('does NOT call router.navigate', () => {
component.ngOnDestroy();
expect(router.navigate).toHaveBeenCalledTimes(0);
});
});
});

2
src/app/access-control/group-registry/group-form/group-form.component.ts
View File

@@ -405,7 +405,7 @@ export class GroupFormComponent implements OnInit, OnDestroy {
*/
@HostListener('window:beforeunload')
ngOnDestroy(): void {
this.onCancel();
this.groupDataService.cancelEditGroup();
this.subs.filter((sub) => hasValue(sub)).forEach((sub) => sub.unsubscribe());
}