From abc8640b5e35b1abdaad181b7f26feed9b624d77 Mon Sep 17 00:00:00 2001 From: Alexandre Vryghem Date: Sat, 1 Jul 2023 13:13:27 +0200 Subject: [PATCH] Fix MetadataRepresentationListElementComponent no expectation tests Also fixed incorrect regex in isLink() --- ...adata-representation-list-element.component.spec.ts | 10 +++------- .../metadata-representation-list-element.component.ts | 2 +- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/app/shared/object-list/metadata-representation-list-element/metadata-representation-list-element.component.spec.ts b/src/app/shared/object-list/metadata-representation-list-element/metadata-representation-list-element.component.spec.ts index dc8febe84a..cf85154a19 100644 --- a/src/app/shared/object-list/metadata-representation-list-element/metadata-representation-list-element.component.spec.ts +++ b/src/app/shared/object-list/metadata-representation-list-element/metadata-representation-list-element.component.spec.ts @@ -19,7 +19,7 @@ describe('MetadataRepresentationListElementComponent', () => { let fixture: ComponentFixture; beforeEach(waitForAsync(() => { - TestBed.configureTestingModule({ + return TestBed.configureTestingModule({ imports: [], declarations: [MetadataRepresentationListElementComponent], schemas: [NO_ERRORS_SCHEMA] @@ -39,9 +39,7 @@ describe('MetadataRepresentationListElementComponent', () => { comp.mdRepresentation = mockMetadataRepresentation; }); it('isLink correctly detects a non-URL string as false', () => { - waitForAsync(() => { - expect(comp.isLink()).toBe(false); - }); + expect(comp.isLink()).toBe(false); }); }); @@ -50,9 +48,7 @@ describe('MetadataRepresentationListElementComponent', () => { comp.mdRepresentation = mockMetadataRepresentationUrl; }); it('isLink correctly detects a URL string as true', () => { - waitForAsync(() => { - expect(comp.isLink()).toBe(true); - }); + expect(comp.isLink()).toBe(true); }); }); diff --git a/src/app/shared/object-list/metadata-representation-list-element/metadata-representation-list-element.component.ts b/src/app/shared/object-list/metadata-representation-list-element/metadata-representation-list-element.component.ts index d8f8621ca6..3539502843 100644 --- a/src/app/shared/object-list/metadata-representation-list-element/metadata-representation-list-element.component.ts +++ b/src/app/shared/object-list/metadata-representation-list-element/metadata-representation-list-element.component.ts @@ -25,7 +25,7 @@ export class MetadataRepresentationListElementComponent { */ isLink(): boolean { // Match any string that begins with http:// or https:// - const linkPattern = new RegExp(/^https?\/\/.*/); + const linkPattern = new RegExp(/^https?:\/\/.*/); return linkPattern.test(this.mdRepresentation.getValue()); }