hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 10:04:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed feedback form page accessibility issue

Browse Source 
- The form used a fieldset tag instead of a form tag
This commit is contained in:
Alexandre Vryghem
2023-12-16 15:33:07 +01:00
committed by Tim Donohue
parent 37803e9330
commit ac743c5138
1 changed files with 33 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/info/feedback/feedback-form/feedback-form.component.html
View File

@@ -1,9 +1,8 @@
<div class="row row-offcanvas row-offcanvas-right"> <div class="row row-offcanvas row-offcanvas-right">
<div class="col-xs-12 col-sm-12 col-md-9"> <div class="col-xs-12 col-sm-12 col-md-9">
<form class="primary" [formGroup]="feedbackForm" (ngSubmit)="createFeedback()">
<h1>{{ 'info.feedback.head' | translate }}</h1> <h1>{{ 'info.feedback.head' | translate }}</h1>
<p>{{ 'info.feedback.info' | translate }}</p> <p>{{ 'info.feedback.info' | translate }}</p>
<fieldset class="col p-0"> <form [formGroup]="feedbackForm" (ngSubmit)="createFeedback()" class="col p-0">
<div class="row"> <div class="row">
<div class="control-group col-sm-12"> <div class="control-group col-sm-12">
<label class="control-label" for="email">{{ 'info.feedback.email-label' | translate }}&nbsp;</label> <label class="control-label" for="email">{{ 'info.feedback.email-label' | translate }}&nbsp;</label>
@@ -39,7 +38,6 @@
<button [disabled]="!feedbackForm.valid" class="btn btn-primary" name="submit" type="submit">{{ 'info.feedback.send' | translate }}</button> <button [disabled]="!feedbackForm.valid" class="btn btn-primary" name="submit" type="submit">{{ 'info.feedback.send' | translate }}</button>
</div> </div>
</div> </div>
</fieldset>
</form> </form>
</div> </div>
</div> </div>