From acfcf51e34a11f34531aca574b95ce7eaee44ee3 Mon Sep 17 00:00:00 2001
From: Giuseppe Digilio <giuseppe.digilio@4science.com>
Date: Mon, 18 Mar 2024 16:08:35 +0100
Subject: [PATCH] [DURACOM-191] Remove DataService decorator

---
 .../data/base/data-service.decorator.spec.ts  | 60 -------------------
 .../core/data/base/data-service.decorator.ts  | 55 -----------------
 2 files changed, 115 deletions(-)
 delete mode 100644 src/app/core/data/base/data-service.decorator.spec.ts
 delete mode 100644 src/app/core/data/base/data-service.decorator.ts

diff --git a/src/app/core/data/base/data-service.decorator.spec.ts b/src/app/core/data/base/data-service.decorator.spec.ts
deleted file mode 100644
index 296371be69..0000000000
--- a/src/app/core/data/base/data-service.decorator.spec.ts
+++ /dev/null
@@ -1,60 +0,0 @@
-/* eslint-disable max-classes-per-file */
-/**
- * The contents of this file are subject to the license and copyright
- * detailed in the LICENSE and NOTICE files at the root of the source
- * tree and available online at
- *
- * http://www.dspace.org/license/
- */
-import { v4 as uuidv4 } from 'uuid';
-
-import { ResourceType } from '../../shared/resource-type';
-import { BaseDataService } from './base-data.service';
-import {
-  dataService,
-  getDataServiceFor,
-} from './data-service.decorator';
-import { HALDataService } from './hal-data-service.interface';
-
-class TestService extends BaseDataService<any> {
-}
-
-class AnotherTestService implements HALDataService<any> {
-  public findListByHref(href$, findListOptions, useCachedVersionIfAvailable, reRequestOnStale, ...linksToFollow): any {
-    return undefined;
-  }
-
-  public findByHref(href$, useCachedVersionIfAvailable, reRequestOnStale, ...linksToFollow): any {
-    return undefined;
-  }
-}
-
-let testType;
-
-describe('@dataService/getDataServiceFor', () => {
-  beforeEach(() => {
-    testType = new ResourceType(`testType-${uuidv4()}`);
-  });
-
-  it('should register a resourcetype for a dataservice', () => {
-    dataService(testType)(TestService);
-    expect(getDataServiceFor(testType)).toBe(TestService);
-  });
-
-  describe(`when the resource type isn't specified`, () => {
-    it(`should throw an error`, () => {
-      expect(() => {
-        dataService(undefined)(TestService);
-      }).toThrow();
-    });
-  });
-
-  describe(`when there already is a registered dataservice for a resourcetype`, () => {
-    it(`should throw an error`, () => {
-      dataService(testType)(TestService);
-      expect(() => {
-        dataService(testType)(AnotherTestService);
-      }).toThrow();
-    });
-  });
-});
diff --git a/src/app/core/data/base/data-service.decorator.ts b/src/app/core/data/base/data-service.decorator.ts
deleted file mode 100644
index 600fb5e3e3..0000000000
--- a/src/app/core/data/base/data-service.decorator.ts
+++ /dev/null
@@ -1,55 +0,0 @@
-/**
- * The contents of this file are subject to the license and copyright
- * detailed in the LICENSE and NOTICE files at the root of the source
- * tree and available online at
- *
- * http://www.dspace.org/license/
- */
-import { InjectionToken } from '@angular/core';
-
-import {
-  hasNoValue,
-  hasValue,
-} from '../../../shared/empty.util';
-import { CacheableObject } from '../../cache/cacheable-object.model';
-import { GenericConstructor } from '../../shared/generic-constructor';
-import { ResourceType } from '../../shared/resource-type';
-import { HALDataService } from './hal-data-service.interface';
-
-export const DATA_SERVICE_FACTORY = new InjectionToken<(resourceType: ResourceType) => GenericConstructor<HALDataService<any>>>('getDataServiceFor', {
-  providedIn: 'root',
-  factory: () => getDataServiceFor,
-});
-const dataServiceMap = new Map();
-
-/**
- * A class decorator to indicate that this class is a data service for a given HAL resource type.
- *
- * In most cases, a data service should extend {@link BaseDataService}.
- * At the very least it must implement {@link HALDataService} in order for it to work with {@link LinkService}.
- *
- * @param resourceType the resource type the class is a dataservice for
- */
-export function dataService(resourceType: ResourceType) {
-  return (target: GenericConstructor<HALDataService<any>>): void => {
-    if (hasNoValue(resourceType)) {
-      throw new Error(`Invalid @dataService annotation on ${target}, resourceType needs to be defined`);
-    }
-    const existingDataservice = dataServiceMap.get(resourceType.value);
-
-    if (hasValue(existingDataservice)) {
-      throw new Error(`Multiple dataservices for ${resourceType.value}: ${existingDataservice} and ${target}`);
-    }
-
-    dataServiceMap.set(resourceType.value, target);
-  };
-}
-
-/**
- * Return the dataservice matching the given resource type
- *
- * @param resourceType the resource type you want the matching dataservice for
- */
-export function getDataServiceFor<T extends CacheableObject>(resourceType: ResourceType): GenericConstructor<HALDataService<any>> {
-  return dataServiceMap.get(resourceType.value);
-}