[CST-15074][#3355] PR review

src/app/external-log-in/email-confirmation/confirm-email/confirm-email.component.ts

@@ -1,18 +1,46 @@
 import { NgIf } from '@angular/common';
-import { ChangeDetectionStrategy, Component, Inject, Input, OnDestroy, OnInit, } from '@angular/core';
+import {
-import { FormBuilder, FormGroup, ReactiveFormsModule, Validators, } from '@angular/forms';
+  ChangeDetectionStrategy,
-import { TranslateModule, TranslateService, } from '@ngx-translate/core';
+  Component,
+  Inject,
+  Input,
+  OnDestroy,
+  OnInit,
+} from '@angular/core';
+import {
+  FormBuilder,
+  FormGroup,
+  ReactiveFormsModule,
+  Validators,
+} from '@angular/forms';
+import {
+  TranslateModule,
+  TranslateService,
+} from '@ngx-translate/core';
 import isEqual from 'lodash/isEqual';
-import { combineLatest, Subscription, take, } from 'rxjs';
+import {
+  combineLatest,
+  Subscription,
+  take,
+} from 'rxjs';
 
 import { AuthService } from '../../../core/auth/auth.service';
 import { EPersonDataService } from '../../../core/eperson/eperson-data.service';
 import { EPerson } from '../../../core/eperson/models/eperson.model';
 import { HardRedirectService } from '../../../core/services/hard-redirect.service';
-import { NativeWindowRef, NativeWindowService, } from '../../../core/services/window.service';
+import {
-import { getFirstCompletedRemoteData, getRemoteDataPayload, } from '../../../core/shared/operators';
+  NativeWindowRef,
+  NativeWindowService,
+} from '../../../core/services/window.service';
+import {
+  getFirstCompletedRemoteData,
+  getRemoteDataPayload,
+} from '../../../core/shared/operators';
 import { Registration } from '../../../core/shared/registration.model';
-import { hasNoValue, hasValue, } from '../../../shared/empty.util';
+import {
+  hasNoValue,
+  hasValue,
+} from '../../../shared/empty.util';
 import { NotificationsService } from '../../../shared/notifications/notifications.service';
 import { ExternalLoginService } from '../../services/external-login.service';
 

src/app/external-log-in/email-confirmation/confirmation-sent/confirmation-sent.component.ts

@@ -1,4 +1,7 @@
-import { ChangeDetectionStrategy, Component, } from '@angular/core';
+import {
+  ChangeDetectionStrategy,
+  Component,
+} from '@angular/core';
 import { TranslateModule } from '@ngx-translate/core';
 
 @Component({

src/app/external-log-in/email-confirmation/provide-email/provide-email.component.spec.ts

@@ -1,8 +1,14 @@
 import { CommonModule } from '@angular/common';
 import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
-import { ComponentFixture, TestBed, } from '@angular/core/testing';
+import {
+  ComponentFixture,
+  TestBed,
+} from '@angular/core/testing';
 import { FormBuilder } from '@angular/forms';
-import { TranslateLoader, TranslateModule, } from '@ngx-translate/core';
+import {
+  TranslateLoader,
+  TranslateModule,
+} from '@ngx-translate/core';
 
 import { TranslateLoaderMock } from '../../../shared/mocks/translate-loader.mock';
 import { ExternalLoginService } from '../../services/external-login.service';

src/app/external-log-in/email-confirmation/provide-email/provide-email.component.ts

@@ -1,6 +1,16 @@
 import { NgIf } from '@angular/common';
-import { ChangeDetectionStrategy, Component, Input, OnDestroy, } from '@angular/core';
+import {
-import { FormBuilder, FormGroup, ReactiveFormsModule, Validators, } from '@angular/forms';
+  ChangeDetectionStrategy,
+  Component,
+  Input,
+  OnDestroy,
+} from '@angular/core';
+import {
+  FormBuilder,
+  FormGroup,
+  ReactiveFormsModule,
+  Validators,
+} from '@angular/forms';
 import { TranslateModule } from '@ngx-translate/core';
 import { Subscription } from 'rxjs';
 

src/app/external-log-in/external-log-in/external-log-in.component.ts

@@ -1,7 +1,23 @@
-import { NgComponentOutlet, NgIf, } from '@angular/common';
+import {
-import { ChangeDetectionStrategy, Component, Injector, Input, OnDestroy, OnInit, } from '@angular/core';
+  NgComponentOutlet,
-import { NgbModal, NgbModalRef, } from '@ng-bootstrap/ng-bootstrap';
+  NgIf,
-import { TranslateModule, TranslateService, } from '@ngx-translate/core';
+} from '@angular/common';
+import {
+  ChangeDetectionStrategy,
+  Component,
+  Injector,
+  Input,
+  OnDestroy,
+  OnInit,
+} from '@angular/core';
+import {
+  NgbModal,
+  NgbModalRef,
+} from '@ng-bootstrap/ng-bootstrap';
+import {
+  TranslateModule,
+  TranslateService,
+} from '@ngx-translate/core';
 
 import { AuthService } from '../../core/auth/auth.service';
 import { AuthMethodType } from '../../core/auth/models/auth.method-type';
@@ -9,7 +25,10 @@ import { AuthRegistrationType } from '../../core/auth/models/auth.registration-t
 import { Registration } from '../../core/shared/registration.model';
 import { AlertComponent } from '../../shared/alert/alert.component';
 import { AlertType } from '../../shared/alert/alert-type';
-import { hasValue, isEmpty, } from '../../shared/empty.util';
+import {
+  hasValue,
+  isEmpty,
+} from '../../shared/empty.util';
 import { ThemedLogInComponent } from '../../shared/log-in/themed-log-in.component';
 import {
   ExternalLoginTypeComponent,

src/app/external-log-in/registration-types/orcid-confirmation/orcid-confirmation.component.ts

@@ -1,6 +1,15 @@
 import { NgIf } from '@angular/common';
-import { ChangeDetectionStrategy, Component, Inject, OnInit, } from '@angular/core';
+import {
-import { FormBuilder, FormGroup, ReactiveFormsModule, } from '@angular/forms';
+  ChangeDetectionStrategy,
+  Component,
+  Inject,
+  OnInit,
+} from '@angular/core';
+import {
+  FormBuilder,
+  FormGroup,
+  ReactiveFormsModule,
+} from '@angular/forms';
 import { TranslateModule } from '@ngx-translate/core';
 
 import { Registration } from '../../../core/shared/registration.model';

src/app/external-log-in/services/external-login.service.ts

@@ -1,8 +1,15 @@
 import { Injectable } from '@angular/core';
 import { Router } from '@angular/router';
-import { select, Store, } from '@ngrx/store';
+import {
+  select,
+  Store,
+} from '@ngrx/store';
 import { TranslateService } from '@ngx-translate/core';
-import { filter, map, Observable, } from 'rxjs';
+import {
+  filter,
+  map,
+  Observable,
+} from 'rxjs';
 import { AuthMethod } from 'src/app/core/auth/models/auth.method';
 import { getAuthenticationMethods } from 'src/app/core/auth/selectors';
 import { CoreState } from 'src/app/core/core-state.model';

src/app/external-login-page/external-login-page.component.ts

@@ -1,8 +1,19 @@
-import { AsyncPipe, NgIf, } from '@angular/common';
+import {
-import { Component, OnInit, } from '@angular/core';
+  AsyncPipe,
+  NgIf,
+} from '@angular/common';
+import {
+  Component,
+  OnInit,
+} from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 import { TranslateModule } from '@ngx-translate/core';
-import { first, map, Observable, tap, } from 'rxjs';
+import {
+  first,
+  map,
+  Observable,
+  tap,
+} from 'rxjs';
 
 import { RemoteData } from '../core/data/remote-data';
 import { Registration } from '../core/shared/registration.model';

src/app/external-login-review-account-info-page/external-login-review-account-info-page.component.ts

@@ -1,7 +1,18 @@
-import { AsyncPipe, NgIf, } from '@angular/common';
+import {
-import { Component, OnInit, } from '@angular/core';
+  AsyncPipe,
+  NgIf,
+} from '@angular/common';
+import {
+  Component,
+  OnInit,
+} from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
-import { first, map, Observable, tap, } from 'rxjs';
+import {
+  first,
+  map,
+  Observable,
+  tap,
+} from 'rxjs';
 
 import { RemoteData } from '../core/data/remote-data';
 import { Registration } from '../core/shared/registration.model';

src/assets/i18n/it.json5

@@ -8010,5 +8010,5 @@
 
   // "external-login-page.orcid-confirmation.email.label": "Email"
   // TODO New key - Add a translation
-  "external-login-page.orcid-confirmation.email.label": "Email"
+  "external-login-page.orcid-confirmation.email.label": "Email",
 }