hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 10:04:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix unit tests for bitstream-data.service.ts

Browse Source
This commit is contained in:
Jesiel Viana
2025-04-24 10:04:41 -03:00
committed by Tim Donohue
parent eac787f1f4
commit b184db7a99
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/app/core/data/bitstream-data.service.spec.ts
View File

@@ -22,6 +22,8 @@ import objectContaining = jasmine.objectContaining;
import { RemoteData } from './remote-data'; import { RemoteData } from './remote-data';
import { FollowLinkConfig } from '../../shared/utils/follow-link-config.model'; import { FollowLinkConfig } from '../../shared/utils/follow-link-config.model';
import { RequestParam } from '../cache/models/request-param.model'; import { RequestParam } from '../cache/models/request-param.model';
import { RestResponse } from '../cache/response.models';
import { RequestEntry } from './request-entry.model';
describe('BitstreamDataService', () => { describe('BitstreamDataService', () => {
let service: BitstreamDataService; let service: BitstreamDataService;
@@ -31,6 +33,7 @@ describe('BitstreamDataService', () => {
let bitstreamFormatService: BitstreamFormatDataService; let bitstreamFormatService: BitstreamFormatDataService;
let rdbService: RemoteDataBuildService; let rdbService: RemoteDataBuildService;
const bitstreamFormatHref = 'rest-api/bitstreamformats'; const bitstreamFormatHref = 'rest-api/bitstreamformats';
let responseCacheEntry: RequestEntry;
const bitstream1 = Object.assign(new Bitstream(), { const bitstream1 = Object.assign(new Bitstream(), {
id: 'fake-bitstream1', id: 'fake-bitstream1',
@@ -55,8 +58,13 @@ describe('BitstreamDataService', () => {
const url = 'fake-bitstream-url'; const url = 'fake-bitstream-url';
beforeEach(() => { beforeEach(() => {
responseCacheEntry = new RequestEntry();
responseCacheEntry.request = { href: 'https://rest.api/' } as any;
responseCacheEntry.response = new RestResponse(true, 200, 'Success');
objectCache = jasmine.createSpyObj('objectCache', { objectCache = jasmine.createSpyObj('objectCache', {
remove: jasmine.createSpy('remove') remove: jasmine.createSpy('remove'),
getByHref: observableOf(responseCacheEntry),
}); });
requestService = getMockRequestService(); requestService = getMockRequestService();
halService = Object.assign(new HALEndpointServiceStub(url)); halService = Object.assign(new HALEndpointServiceStub(url));

8
src/app/core/data/bitstream-data.service.ts
View File

@@ -147,9 +147,11 @@ export class BitstreamDataService extends IdentifiableDataService<Bitstream> imp
this.requestService.setStaleByHrefSubstring(bitsreamFormatUrl); this.requestService.setStaleByHrefSubstring(bitsreamFormatUrl);
// Delete also cache by uuid as the format could be cached also there // Delete also cache by uuid as the format could be cached also there
this.objectCache.getByHref(bitsreamFormatUrl).pipe(take(1)).subscribe((cachedRequest) => { this.objectCache.getByHref(bitsreamFormatUrl).pipe(take(1)).subscribe((cachedRequest) => {
const requestUuid = cachedRequest.requestUUIDs[0]; if (cachedRequest.requestUUIDs && cachedRequest.requestUUIDs.length > 0){
if (this.requestService.hasByUUID(requestUuid)) { const requestUuid = cachedRequest.requestUUIDs[0];
this.requestService.setStaleByUUID(requestUuid); if (this.requestService.hasByUUID(requestUuid)) {
this.requestService.setStaleByUUID(requestUuid);
}
} }
}); });
} }