From b352137fb3bb91ffc361704d640aa7223d0de9c8 Mon Sep 17 00:00:00 2001
From: Art Lowel <art.lowel@atmire.com>
Date: Wed, 29 May 2019 18:05:30 +0200
Subject: [PATCH] add i18n labels for person facets

---
 resources/i18n/en.json                        | 12 +++++++
 .../search-filter/search-filter.component.ts  | 35 ++++++++++---------
 2 files changed, 30 insertions(+), 17 deletions(-)

diff --git a/resources/i18n/en.json b/resources/i18n/en.json
index 4260568a7e..8b4b38fa25 100644
--- a/resources/i18n/en.json
+++ b/resources/i18n/en.json
@@ -597,6 +597,18 @@
         "objectpeople": {
           "placeholder": "People",
           "head": "People"
+        },
+        "jobTitle": {
+          "placeholder": "Job Title",
+          "head": "Job Title"
+        },
+        "knowsLanguage": {
+          "placeholder": "Known language",
+          "head": "Known language"
+        },
+        "birthDate": {
+          "placeholder": "Birth Date",
+          "head": "Birth Date"
         }
       }
     }
diff --git a/src/app/+search-page/search-filters/search-filter/search-filter.component.ts b/src/app/+search-page/search-filters/search-filter/search-filter.component.ts
index bfe9f3be63..1e3270a7d0 100644
--- a/src/app/+search-page/search-filters/search-filter/search-filter.component.ts
+++ b/src/app/+search-page/search-filters/search-filter/search-filter.component.ts
@@ -129,22 +129,23 @@ export class SearchFilterComponent implements OnInit {
    * @returns {Observable<boolean>} Emits true whenever a given filter config should be shown
    */
   private isActive(): Observable<boolean> {
-    return this.selectedValues$.pipe(
-      switchMap((isActive) => {
-        if (isNotEmpty(isActive)) {
-          return observableOf(true);
-        } else {
-          return this.searchConfigService.searchOptions.pipe(
-            switchMap((options) => {
-                return this.searchService.getFacetValuesFor(this.filter, 1, options).pipe(
-                  filter((RD) => !RD.isLoading),
-                  map((valuesRD) => {
-                    return valuesRD.payload.totalElements > 0
-                  }),)
-              }
-            ))
-        }
-      }),
-      startWith(true));
+    return observableOf(true);
+    // return this.selectedValues$.pipe(
+    //   switchMap((isActive) => {
+    //     if (isNotEmpty(isActive)) {
+    //       return observableOf(true);
+    //     } else {
+    //       return this.searchConfigService.searchOptions.pipe(
+    //         switchMap((options) => {
+    //             return this.searchService.getFacetValuesFor(this.filter, 1, options).pipe(
+    //               filter((RD) => !RD.isLoading),
+    //               map((valuesRD) => {
+    //                 return valuesRD.payload.totalElements > 0
+    //               }),)
+    //           }
+    //         ))
+    //     }
+    //   }),
+    //   startWith(true));
   }
 }