diff --git a/src/app/+search-page/search-page.component.html b/src/app/+search-page/search-page.component.html index 1a1f379920..e8dee94139 100644 --- a/src/app/+search-page/search-page.component.html +++ b/src/app/+search-page/search-page.component.html @@ -1,8 +1,8 @@
- +
- { provide: HostWindowService, useValue: jasmine.createSpyObj('hostWindowService', { isXs: Observable.of(true), - isSm: Observable.of(false) + isSm: Observable.of(false), + isXsOrSm: Observable.of(true) }) }, { diff --git a/src/app/+search-page/search-page.component.ts b/src/app/+search-page/search-page.component.ts index 4f50723ced..63e72960d8 100644 --- a/src/app/+search-page/search-page.component.ts +++ b/src/app/+search-page/search-page.component.ts @@ -34,7 +34,7 @@ export class SearchPageComponent implements OnInit { searchOptions$: Observable; sortConfig: SortOptions; scopeListRD$: Observable>>; - isMobileView$: Observable; + isXsOrSm$: Observable; pageSize; pageSizeOptions; defaults = { @@ -52,11 +52,7 @@ export class SearchPageComponent implements OnInit { private sidebarService: SearchSidebarService, private windowService: HostWindowService, private filterService: SearchFilterService) { - this.isMobileView$ = Observable.combineLatest( - this.windowService.isXs(), - this.windowService.isSm(), - ((isXs, isSm) => isXs || isSm) - ); + this.isXsOrSm$ = this.windowService.isXsOrSm(); this.scopeListRD$ = communityService.findAll(); } diff --git a/src/app/+search-page/search-sidebar/search-sidebar.service.spec.ts b/src/app/+search-page/search-sidebar/search-sidebar.service.spec.ts index 8b817d5523..b6439be4df 100644 --- a/src/app/+search-page/search-sidebar/search-sidebar.service.spec.ts +++ b/src/app/+search-page/search-sidebar/search-sidebar.service.spec.ts @@ -3,6 +3,7 @@ import { SearchSidebarService } from './search-sidebar.service'; import { AppState } from '../../app.reducer'; import { async, inject, TestBed } from '@angular/core/testing'; import { Observable } from 'rxjs/Observable'; +import 'rxjs/add/observable/of'; import { SearchSidebarCollapseAction, SearchSidebarExpandAction } from './search-sidebar.actions'; import { HostWindowService } from '../../shared/host-window.service'; @@ -17,7 +18,8 @@ describe('SearchSidebarService', () => { const windowService = jasmine.createSpyObj('hostWindowService', { isXs: Observable.of(true), - isSm: Observable.of(false) + isSm: Observable.of(false), + isXsOrSm: Observable.of(true) }); beforeEach(async(() => { TestBed.configureTestingModule({ diff --git a/src/app/+search-page/search-sidebar/search-sidebar.service.ts b/src/app/+search-page/search-sidebar/search-sidebar.service.ts index e2ad5e0960..3a17dc87ab 100644 --- a/src/app/+search-page/search-sidebar/search-sidebar.service.ts +++ b/src/app/+search-page/search-sidebar/search-sidebar.service.ts @@ -11,22 +11,17 @@ const sidebarCollapsedSelector = createSelector(sidebarStateSelector, (sidebar: @Injectable() export class SearchSidebarService { - private isMobileView: Observable; + private isXsOrSm$: Observable; private isCollapsdeInStored: Observable; constructor(private store: Store, private windowService: HostWindowService) { - this.isMobileView = - Observable.combineLatest( - this.windowService.isXs(), - this.windowService.isSm(), - ((isXs, isSm) => isXs || isSm) - ); + this.isXsOrSm$ = this.windowService.isXsOrSm(); this.isCollapsdeInStored = this.store.select(sidebarCollapsedSelector); } get isCollapsed(): Observable { return Observable.combineLatest( - this.isMobileView, + this.isXsOrSm$, this.isCollapsdeInStored, (mobile, store) => mobile ? store : true); } diff --git a/src/app/shared/auth-nav-menu/auth-nav-menu.component.html b/src/app/shared/auth-nav-menu/auth-nav-menu.component.html index 7203dc07ab..cc9b8c410b 100644 --- a/src/app/shared/auth-nav-menu/auth-nav-menu.component.html +++ b/src/app/shared/auth-nav-menu/auth-nav-menu.component.html @@ -1,5 +1,5 @@ -