From b4a3882dcf410dc14fb34f1c112659474a5b10ca Mon Sep 17 00:00:00 2001 From: Alexandre Vryghem Date: Sat, 1 Jul 2023 15:22:13 +0200 Subject: [PATCH] Fix findSuccessfulAccordingTo no expectation tests - The isWithdrawn was set twice to mockItem1 - The expected observable was not correctly compared --- src/app/item-page/edit-item-page/edit-item-operators.spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/item-page/edit-item-page/edit-item-operators.spec.ts b/src/app/item-page/edit-item-page/edit-item-operators.spec.ts index e7bd5b98ce..f72ace495f 100644 --- a/src/app/item-page/edit-item-page/edit-item-operators.spec.ts +++ b/src/app/item-page/edit-item-page/edit-item-operators.spec.ts @@ -18,7 +18,7 @@ describe('findSuccessfulAccordingTo', () => { mockItem1.isWithdrawn = true; mockItem2 = new Item(); - mockItem1.isWithdrawn = false; + mockItem2.isWithdrawn = false; predicate = (rd: RemoteData) => isNotEmpty(rd.payload) ? rd.payload.isWithdrawn : false; }); @@ -34,7 +34,7 @@ describe('findSuccessfulAccordingTo', () => { const source = hot('abcde', testRD); const result = source.pipe(findSuccessfulAccordingTo(predicate)); - result.subscribe((value) => expect(value).toEqual(testRD.d)); + expect(result).toBeObservable(hot('---(d|)', { d: testRD.d })); }); });