From ba46f243c8dd68b3ab41b8b23bf964d2a2d114ab Mon Sep 17 00:00:00 2001 From: Matteo Perelli Date: Wed, 24 Jun 2020 15:38:45 +0200 Subject: [PATCH] Test fix for CI --- ...ion-import-external-preview.component.html | 2 +- ...-import-external-preview.component.spec.ts | 5 ++-- src/assets/i18n/en.json5 | 25 ++++++++++++++++++- 3 files changed, 27 insertions(+), 5 deletions(-) diff --git a/src/app/submission/import-external/import-external-preview/submission-import-external-preview.component.html b/src/app/submission/import-external/import-external-preview/submission-import-external-preview.component.html index 0f155286ce..83c1ed82b6 100644 --- a/src/app/submission/import-external/import-external-preview/submission-import-external-preview.component.html +++ b/src/app/submission/import-external/import-external-preview/submission-import-external-preview.component.html @@ -19,7 +19,7 @@
- {{metadata.key}} + {{'item.preview.' + metadata.key | translate}}

{{metadata.value.value}}

diff --git a/src/app/submission/import-external/import-external-preview/submission-import-external-preview.component.spec.ts b/src/app/submission/import-external/import-external-preview/submission-import-external-preview.component.spec.ts index 66dfc72e6b..71360b9cc3 100644 --- a/src/app/submission/import-external/import-external-preview/submission-import-external-preview.component.spec.ts +++ b/src/app/submission/import-external/import-external-preview/submission-import-external-preview.component.spec.ts @@ -48,8 +48,8 @@ describe('SubmissionImportExternalPreviewComponent test suite', () => { { provide: Router, useValue: new RouterStub() }, { provide: SubmissionService, useValue: new SubmissionServiceStub() }, { provide: NotificationsService, useValue: new NotificationsServiceStub() }, - NgbModal, - NgbActiveModal, + { provide: NgbModal, useValue: { open: () => {/*comment*/} } }, + { provide: NgbActiveModal, useValue: { dismiss: () => {/*comment*/} } }, SubmissionImportExternalPreviewComponent ], schemas: [NO_ERRORS_SCHEMA] @@ -97,7 +97,6 @@ describe('SubmissionImportExternalPreviewComponent test suite', () => { const expected = [ { key: 'dc.identifier.uri', value: Metadata.first(comp.externalSourceEntry.metadata, 'dc.identifier.uri') } ]; - comp.ngOnInit(); fixture.detectChanges(); expect(comp.metadataList).toEqual(expected); diff --git a/src/assets/i18n/en.json5 b/src/assets/i18n/en.json5 index d5c761dae1..cb5a5b956a 100644 --- a/src/assets/i18n/en.json5 +++ b/src/assets/i18n/en.json5 @@ -1425,6 +1425,28 @@ "item.page.uri": "URI", + "item.preview.dc.identifier.uri": "Identifier:", + + "item.preview.dc.contributor.author": "Authors:", + + "item.preview.dc.date.issued": "Published date:", + + "item.preview.dc.description.abstract": "Abstract:", + + "item.preview.dc.identifier.other": "Other identifier:", + + "item.preview.dc.language.iso": "Language:", + + "item.preview.dc.subject": "Subjects:", + + "item.preview.dc.title": "Title:", + + "item.preview.person.familyName": "Surname:", + + "item.preview.person.givenName": "Name:", + + "item.preview.person.identifier.orcid": "ORCID:", + "item.select.confirm": "Confirm selected", @@ -2440,7 +2462,6 @@ "submission.import-external.preview.error.import.body": "An error occurs during the external source entry import process.", - "submission.sections.describe.relationship-lookup.close": "Close", "submission.sections.describe.relationship-lookup.external-source.added": "Successfully added local entry to the selection", @@ -2575,6 +2596,8 @@ "submission.sections.describe.relationship-lookup.selection-tab.title.lcname": "Search Results", + "submission.sections.describe.relationship-lookup.selection-tab.title.pubmed": "Search Results", + "submission.sections.describe.relationship-lookup.name-variant.notification.content": "Would you like to save \"{{ value }}\" as a name variant for this person so you and others can reuse it for future submissions? If you don\'t you can still use it for this submission.", "submission.sections.describe.relationship-lookup.name-variant.notification.confirm": "Save a new name variant",