From cc369bf7577201f244bb91d766f1a4e542b0fff3 Mon Sep 17 00:00:00 2001
From: Kristof De Langhe <kristof.delanghe@atmire.com>
Date: Tue, 23 Oct 2018 15:40:38 +0200
Subject: [PATCH] 56434: SearchResultsComponent and SearchConfigurationService
 test additions

---
 .../search-results.component.html             |  2 +-
 .../search-results.component.spec.ts          | 43 +++++++++++++++----
 .../search-configuration.service.spec.ts      | 25 +++++++++++
 3 files changed, 60 insertions(+), 10 deletions(-)

diff --git a/src/app/+search-page/search-results/search-results.component.html b/src/app/+search-page/search-results/search-results.component.html
index b685d0b28d..126efecbf9 100644
--- a/src/app/+search-page/search-results/search-results.component.html
+++ b/src/app/+search-page/search-results/search-results.component.html
@@ -1,4 +1,4 @@
-<h2 *ngIf="!disableHeader">{{ getTitleKey() | translate }}</h2>
+<h2 *ngIf="!disableHeader" class="search-results-title">{{ getTitleKey() | translate }}</h2>
 <div *ngIf="searchResults?.hasSucceeded && !searchResults?.isLoading && searchResults?.payload?.page.length > 0" @fadeIn>
 <ds-viewable-collection
   [config]="searchConfig.pagination"
diff --git a/src/app/+search-page/search-results/search-results.component.spec.ts b/src/app/+search-page/search-results/search-results.component.spec.ts
index 4f299c5c50..fed1c761a8 100644
--- a/src/app/+search-page/search-results/search-results.component.spec.ts
+++ b/src/app/+search-page/search-results/search-results.component.spec.ts
@@ -10,6 +10,7 @@ describe('SearchResultsComponent', () => {
   let comp: SearchResultsComponent;
   let fixture: ComponentFixture<SearchResultsComponent>;
   let heading: DebugElement;
+  let title: DebugElement;
 
   beforeEach(async(() => {
     TestBed.configureTestingModule({
@@ -23,18 +24,42 @@ describe('SearchResultsComponent', () => {
     fixture = TestBed.createComponent(SearchResultsComponent);
     comp = fixture.componentInstance; // SearchFormComponent test instance
     heading = fixture.debugElement.query(By.css('heading'));
+    title = fixture.debugElement.query(By.css('.search-results-title'));
   });
 
-  it('should display heading when results are not empty', fakeAsync(() => {
-    (comp as any).searchResults = 'test';
-    (comp as any).searchConfig = {pagination: ''};
-    fixture.detectChanges();
-    tick();
-    expect(heading).toBeDefined();
-  }));
+  describe('when results are not empty', () => {
+    beforeEach(() => {
+      (comp as any).searchResults = 'test';
+      (comp as any).searchConfig = {pagination: ''};
+      fixture.detectChanges();
+    });
 
-  it('should not display heading when results is empty', () => {
-    expect(heading).toBeNull();
+    it('should display heading',() => {
+      expect(heading).toBeDefined();
+    });
+
+    describe('when disableHeader is not set', () => {
+      it('should not display a title',() => {
+        expect(title).toBeNull();
+      });
+    });
+
+    describe('when disableHeader is set', () => {
+      beforeEach(() => {
+        comp.disableHeader = true;
+        fixture.detectChanges();
+      });
+
+      it('should display a title',() => {
+        expect(title).toBeDefined();
+      });
+    });
+  });
+
+  describe('when results are empty', () => {
+    it('should not display heading', () => {
+      expect(heading).toBeNull();
+    });
   });
 });
 
diff --git a/src/app/+search-page/search-service/search-configuration.service.spec.ts b/src/app/+search-page/search-service/search-configuration.service.spec.ts
index 6588da858f..9557fa9c1e 100644
--- a/src/app/+search-page/search-service/search-configuration.service.spec.ts
+++ b/src/app/+search-page/search-service/search-configuration.service.spec.ts
@@ -147,4 +147,29 @@ describe('SearchConfigurationService', () => {
       });
     });
   });
+
+  describe('when getCurrentFixedFilter is called', () => {
+    beforeEach(() => {
+      service.getCurrentFixedFilter();
+    });
+    it('should call getRouteParameterValue on the routeService with parameter name \'filter\'', () => {
+      expect((service as any).routeService.getRouteParameterValue).toHaveBeenCalledWith('filter');
+    });
+  });
+
+  describe('when updateFixedFilter is called', () => {
+    const filter = 'filter';
+
+    beforeEach(() => {
+      service.updateFixedFilter(filter);
+    });
+
+    it('should update the paginated search options with the correct fixed filter', () => {
+      expect(service.paginatedSearchOptions.getValue().fixedFilter).toEqual(filter);
+    });
+
+    it('should update the search options with the correct fixed filter', () => {
+      expect(service.searchOptions.getValue().fixedFilter).toEqual(filter);
+    });
+  });
 });