From cc4b7b215e0a9cef2024dff5c342cb0c9a524ffd Mon Sep 17 00:00:00 2001 From: Giuseppe Digilio Date: Fri, 7 Feb 2020 13:08:19 +0100 Subject: [PATCH] Prevent that RouteService is instantiated two times on both SSR and CSR --- src/app/core/core.module.ts | 8 +------- src/app/core/services/route.service.ts | 4 +++- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/app/core/core.module.ts b/src/app/core/core.module.ts index efd83d33d5..63c1ce37ba 100644 --- a/src/app/core/core.module.ts +++ b/src/app/core/core.module.ts @@ -3,11 +3,7 @@ import { CommonModule } from '@angular/common'; import { StoreModule } from '@ngrx/store'; import { EffectsModule } from '@ngrx/effects'; -import { - DynamicFormLayoutService, - DynamicFormService, - DynamicFormValidationService -} from '@ng-dynamic-forms/core'; +import { DynamicFormLayoutService, DynamicFormService, DynamicFormValidationService } from '@ng-dynamic-forms/core'; import { coreEffects } from './core.effects'; import { coreReducers } from './core.reducers'; @@ -39,7 +35,6 @@ import { NativeWindowFactory, NativeWindowService } from './services/window.serv import { BrowseService } from './browse/browse.service'; import { BrowseResponseParsingService } from './data/browse-response-parsing.service'; import { ConfigResponseParsingService } from './config/config-response-parsing.service'; -import { RouteService } from './services/route.service'; import { SubmissionDefinitionsConfigService } from './config/submission-definitions-config.service'; import { SubmissionFormsConfigService } from './config/submission-forms-config.service'; import { SubmissionSectionsConfigService } from './config/submission-sections-config.service'; @@ -211,7 +206,6 @@ const PROVIDERS = [ BrowseItemsResponseParsingService, BrowseService, ConfigResponseParsingService, - RouteService, SubmissionDefinitionsConfigService, SubmissionFormsConfigService, SubmissionRestService, diff --git a/src/app/core/services/route.service.ts b/src/app/core/services/route.service.ts index 661f4acf94..17828097e6 100644 --- a/src/app/core/services/route.service.ts +++ b/src/app/core/services/route.service.ts @@ -59,7 +59,9 @@ export function parameterSelector(key: string, paramsSelector: (state: CoreState /** * Service to keep track of the current query parameters */ -@Injectable() +@Injectable({ + providedIn: 'root' +}) export class RouteService { constructor(private route: ActivatedRoute, private router: Router, private store: Store) { this.saveRouting();