From d1dc8e6038673de22946fddc8d41b22862bcb5a6 Mon Sep 17 00:00:00 2001
From: Davide Negretti <davide.negretti@4science.com>
Date: Mon, 26 Feb 2024 20:32:31 +0100
Subject: [PATCH] [DURACOM-195] replace ul/li with div in sidebar

---
 .../admin-sidebar-section.component.html             |  4 ++--
 .../admin/admin-sidebar/admin-sidebar.component.html |  4 ++--
 .../expandable-admin-sidebar-section.component.html  | 12 ++++++------
 .../expandable-admin-sidebar-section.component.scss  |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/app/admin/admin-sidebar/admin-sidebar-section/admin-sidebar-section.component.html b/src/app/admin/admin-sidebar/admin-sidebar-section/admin-sidebar-section.component.html
index f0f7a49573..24ba17fff4 100644
--- a/src/app/admin/admin-sidebar/admin-sidebar-section/admin-sidebar-section.component.html
+++ b/src/app/admin/admin-sidebar/admin-sidebar-section/admin-sidebar-section.component.html
@@ -1,4 +1,4 @@
-<li role="presentation">
+<div>
   <a class="sidebar-section-wrapper"
      [ngClass]="{ disabled: isDisabled }"
      role="menuitem"
@@ -18,4 +18,4 @@
       </div>
     </div>
   </a>
-</li>
+</div>
diff --git a/src/app/admin/admin-sidebar/admin-sidebar.component.html b/src/app/admin/admin-sidebar/admin-sidebar.component.html
index 0179b27404..fcb33eb175 100644
--- a/src/app/admin/admin-sidebar/admin-sidebar.component.html
+++ b/src/app/admin/admin-sidebar/admin-sidebar.component.html
@@ -28,13 +28,13 @@
   <!-- ITEMS -->
 
   <div class="sidebar-full-width-container" id="sidebar-top-level-items-container">
-    <ul class="sidebar-full-width-container" id="sidebar-top-level-items" role="menubar"
+    <div class="sidebar-full-width-container" id="sidebar-top-level-items" role="menubar"
         [attr.aria-label]="'menu.header.admin.description' |translate">
       <ng-container *ngFor="let section of (sections | async)">
         <ng-container
           *ngComponentOutlet="(sectionMap$ | async).get(section.id).component; injector: (sectionMap$ | async).get(section.id).injector;"></ng-container>
       </ng-container>
-    </ul>
+    </div>
   </div>
 
   <!-- TOGGLER -->
diff --git a/src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.html b/src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.html
index cb8b87cfa2..636938b7b6 100644
--- a/src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.html
+++ b/src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.html
@@ -1,4 +1,4 @@
-<li [ngClass]="{'expanded': (isExpanded$ | async)}" role="presentation"
+<div [ngClass]="{'expanded': (isExpanded$ | async)}"
     [@bgColor]="{
      value: ((isExpanded$ | async) ? 'endBackground' : 'startBackground'),
      params: {endColor: (sidebarActiveBg$ | async)}
@@ -33,14 +33,14 @@
     <div class="sidebar-fixed-element-wrapper"></div>
     <div class="sidebar-collapsible-element-outer-wrapper">
       <div class="sidebar-collapsible-element-inner-wrapper">
-        <ul class="sidebar-sub-level-item-list" role="menu" [id]="adminMenuSectionId(section.id)" [attr.aria-label]="('menu.section.' + section.id) | translate">
-          <li class="sidebar-item" role="presentation" *ngFor="let subSection of (subSections$ | async)">
+        <div class="sidebar-sub-level-item-list" role="menu" [id]="adminMenuSectionId(section.id)" [attr.aria-label]="('menu.section.' + section.id) | translate">
+          <div class="sidebar-item" *ngFor="let subSection of (subSections$ | async)">
             {{ (sectionMap$ | async).get(subSection.id).component | json}}
             <ng-container
               *ngComponentOutlet="(sectionMap$ | async).get(subSection.id).component; injector: (sectionMap$ | async).get(subSection.id).injector;"></ng-container>
-          </li>
-        </ul>
+          </div>
+        </div>
       </div>
     </div>
   </div>
-</li>
+</div>
diff --git a/src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.scss b/src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.scss
index 5e76813abb..845ba734df 100644
--- a/src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.scss
+++ b/src/app/admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component.scss
@@ -1,5 +1,5 @@
 :host {
-  ul.sidebar-sub-level-item-list  {
+  .sidebar-sub-level-item-list  {
     list-style: none;
     margin: 0;
     padding: 0;