From d560e08b207ed8929c72fd71773103c91bf8d285 Mon Sep 17 00:00:00 2001 From: Art Lowel Date: Wed, 5 Aug 2020 16:03:51 +0200 Subject: [PATCH] only clone for add events --- .../sections/form/section-form-operations.service.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/app/submission/sections/form/section-form-operations.service.ts b/src/app/submission/sections/form/section-form-operations.service.ts index 8b6c2dc4d6..28bf71b210 100644 --- a/src/app/submission/sections/form/section-form-operations.service.ts +++ b/src/app/submission/sections/form/section-form-operations.service.ts @@ -250,10 +250,7 @@ export class SectionFormOperationsService { fieldValue = new FormFieldMetadataValueObject(value); } - // make a copy of fieldvalue for returning, - // so any changes to it can't influence the original. - // fixes #817 - return deepClone(fieldValue); + return fieldValue; } /** @@ -314,7 +311,7 @@ export class SectionFormOperationsService { event: DynamicFormControlEvent ): void { const path = this.getFieldPathSegmentedFromChangeEvent(event); - const value = this.getFieldValueFromChangeEvent(event); + const value = deepClone(this.getFieldValueFromChangeEvent(event)); if (isNotEmpty(value)) { value.place = this.getArrayIndexFromEvent(event); if (hasValue(event.group) && hasValue(event.group.value)) {