hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-08 10:34:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

50479: Google analytics only loaded when tracking id present

Browse Source
This commit is contained in:
Kristof De Langhe
2018-03-23 13:52:45 +01:00
parent 062f0f1a0e
commit dafe30f3c6
3 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/index.csr.html
View File

@@ -10,12 +10,6 @@
</head> </head>
<body> <body>
<script>
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','https://www.google-analytics.com/analytics.js','ga');
</script>
<ds-app></ds-app> <ds-app></ds-app>
</body> </body>

6
src/index.html
View File

@@ -10,12 +10,6 @@
</head> </head>
<body> <body>
<script>
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','https://www.google-analytics.com/analytics.js','ga');
</script>
<ds-app></ds-app> <ds-app></ds-app>
</body> </body>

19
src/main.browser.ts
View File

@@ -25,14 +25,25 @@ export function main() {
} }
}); });
// Add google analytics key addGoogleAnalytics();
const script = document.createElement('script');
script.innerHTML = 'ga(\'create\', \'' + ENV_CONFIG.gaTrackingId + '\', \'auto\');';
document.body.appendChild(script);
return platformBrowserDynamic().bootstrapModule(BrowserAppModule); return platformBrowserDynamic().bootstrapModule(BrowserAppModule);
} }
function addGoogleAnalytics() {
// Add google analytics if key is present in config
const trackingId = ENV_CONFIG.gaTrackingId;
if (trackingId !== '' && trackingId !== null) {
const keyScript = document.createElement('script');
keyScript.innerHTML = `(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','https://www.google-analytics.com/analytics.js','ga');`
+ 'ga(\'create\', \'' + ENV_CONFIG.gaTrackingId + '\', \'auto\');';
document.body.appendChild(keyScript);
}
}
// support async tag or hmr // support async tag or hmr
if (hasValue(ENV_CONFIG.universal) && ENV_CONFIG.universal.preboot === false) { if (hasValue(ENV_CONFIG.universal) && ENV_CONFIG.universal.preboot === false) {
bootloader(main); bootloader(main);