From e06ff5057a1b47ea9d3a5b76d46679d641eb1e9d Mon Sep 17 00:00:00 2001 From: Marie Verdonck Date: Tue, 28 Jul 2020 17:49:22 +0200 Subject: [PATCH] lint --- .../confirmation-modal.component.spec.ts | 15 ++++++++++++--- .../export-metadata-selector.component.spec.ts | 1 - .../export-metadata-selector.component.ts | 4 ++-- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/app/shared/confirmation-modal/confirmation-modal.component.spec.ts b/src/app/shared/confirmation-modal/confirmation-modal.component.spec.ts index 4d1de112cd..2aec37e31a 100644 --- a/src/app/shared/confirmation-modal/confirmation-modal.component.spec.ts +++ b/src/app/shared/confirmation-modal/confirmation-modal.component.spec.ts @@ -73,7 +73,10 @@ describe('ConfirmationModalComponent', () => { describe('when the click method emits on close button', () => { beforeEach(fakeAsync(() => { spyOn(component, 'close'); - debugElement.query(By.css('button.close')).triggerEventHandler('click', {}); + debugElement.query(By.css('button.close')).triggerEventHandler('click', { + preventDefault: () => {/**/ + } + }); tick(); fixture.detectChanges(); })); @@ -86,7 +89,10 @@ describe('ConfirmationModalComponent', () => { beforeEach(fakeAsync(() => { spyOn(component, 'close'); spyOn(component.response, 'next'); - debugElement.query(By.css('button.cancel')).triggerEventHandler('click', {}); + debugElement.query(By.css('button.cancel')).triggerEventHandler('click', { + preventDefault: () => {/**/ + } + }); tick(); fixture.detectChanges(); })); @@ -102,7 +108,10 @@ describe('ConfirmationModalComponent', () => { beforeEach(fakeAsync(() => { spyOn(component, 'close'); spyOn(component.response, 'next'); - debugElement.query(By.css('button.confirm')).triggerEventHandler('click', {}); + debugElement.query(By.css('button.confirm')).triggerEventHandler('click', { + preventDefault: () => {/**/ + } + }); tick(); fixture.detectChanges(); })); diff --git a/src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.spec.ts b/src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.spec.ts index c619217688..ca7a339a04 100644 --- a/src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.spec.ts +++ b/src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.spec.ts @@ -17,7 +17,6 @@ import { NotificationsServiceStub } from '../../../testing/notifications-service import { createSuccessfulRemoteDataObject } from '../../../remote-data.utils'; import { ExportMetadataSelectorComponent } from './export-metadata-selector.component'; - // No way to add entryComponents yet to testbed; alternative implemented; source: https://stackoverflow.com/questions/41689468/how-to-shallow-test-a-component-with-an-entrycomponents @NgModule({ imports: [ NgbModalModule, diff --git a/src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.ts b/src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.ts index fdc4e8344c..523c1c592a 100644 --- a/src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.ts +++ b/src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.ts @@ -59,8 +59,8 @@ export class ExportMetadataSelectorComponent extends DSOSelectorModalWrapperComp }) ) } else { - const modalRef = this.modalService.open(ExportMetadataSelectorComponent); - modalRef.componentInstance.dsoRD = createSuccessfulRemoteDataObject(dso); + const modalRefExport = this.modalService.open(ExportMetadataSelectorComponent); + modalRefExport.componentInstance.dsoRD = createSuccessfulRemoteDataObject(dso); } })); resp$.subscribe();