mirror of
https://github.com/DSpace/dspace-angular.git
synced 2025-10-07 10:04:11 +00:00
Clear cache in mydspace redirect and reload methods.
This commit is contained in:
@@ -15,7 +15,6 @@ import { SortDirection, SortOptions } from '../core/cache/models/sort-options.mo
|
|||||||
import { CommunityDataService } from '../core/data/community-data.service';
|
import { CommunityDataService } from '../core/data/community-data.service';
|
||||||
import { HostWindowService } from '../shared/host-window.service';
|
import { HostWindowService } from '../shared/host-window.service';
|
||||||
import { PaginationComponentOptions } from '../shared/pagination/pagination-component-options.model';
|
import { PaginationComponentOptions } from '../shared/pagination/pagination-component-options.model';
|
||||||
import { RemoteData } from '../core/data/remote-data';
|
|
||||||
import { MyDSpacePageComponent, SEARCH_CONFIG_SERVICE } from './my-dspace-page.component';
|
import { MyDSpacePageComponent, SEARCH_CONFIG_SERVICE } from './my-dspace-page.component';
|
||||||
import { RouteService } from '../core/services/route.service';
|
import { RouteService } from '../core/services/route.service';
|
||||||
import { routeServiceStub } from '../shared/testing/route-service-stub';
|
import { routeServiceStub } from '../shared/testing/route-service-stub';
|
||||||
@@ -30,8 +29,6 @@ import { RoleService } from '../core/roles/role.service';
|
|||||||
import { MockRoleService } from '../shared/mocks/mock-role-service';
|
import { MockRoleService } from '../shared/mocks/mock-role-service';
|
||||||
import { SearchFixedFilterService } from '../+search-page/search-filters/search-filter/search-fixed-filter.service';
|
import { SearchFixedFilterService } from '../+search-page/search-filters/search-filter/search-fixed-filter.service';
|
||||||
import { createSuccessfulRemoteDataObject$ } from '../shared/testing/utils';
|
import { createSuccessfulRemoteDataObject$ } from '../shared/testing/utils';
|
||||||
import { RequestService } from '../core/data/request.service';
|
|
||||||
import { getMockRequestService } from '../shared/mocks/mock-request.service';
|
|
||||||
|
|
||||||
describe('MyDSpacePageComponent', () => {
|
describe('MyDSpacePageComponent', () => {
|
||||||
let comp: MyDSpacePageComponent;
|
let comp: MyDSpacePageComponent;
|
||||||
@@ -129,10 +126,6 @@ describe('MyDSpacePageComponent', () => {
|
|||||||
{
|
{
|
||||||
provide: SearchFixedFilterService,
|
provide: SearchFixedFilterService,
|
||||||
useValue: mockFixedFilterService
|
useValue: mockFixedFilterService
|
||||||
},
|
|
||||||
{
|
|
||||||
provide: RequestService,
|
|
||||||
useValue: getMockRequestService()
|
|
||||||
}
|
}
|
||||||
],
|
],
|
||||||
schemas: [NO_ERRORS_SCHEMA]
|
schemas: [NO_ERRORS_SCHEMA]
|
||||||
|
@@ -97,7 +97,6 @@ export class MyDSpacePageComponent implements OnInit {
|
|||||||
viewModeList = [ViewMode.List, ViewMode.Detail];
|
viewModeList = [ViewMode.List, ViewMode.Detail];
|
||||||
|
|
||||||
constructor(private service: SearchService,
|
constructor(private service: SearchService,
|
||||||
private requestService: RequestService,
|
|
||||||
private sidebarService: SearchSidebarService,
|
private sidebarService: SearchSidebarService,
|
||||||
private windowService: HostWindowService,
|
private windowService: HostWindowService,
|
||||||
@Inject(SEARCH_CONFIG_SERVICE) public searchConfigService: MyDSpaceConfigurationService) {
|
@Inject(SEARCH_CONFIG_SERVICE) public searchConfigService: MyDSpaceConfigurationService) {
|
||||||
@@ -117,20 +116,12 @@ export class MyDSpacePageComponent implements OnInit {
|
|||||||
ngOnInit(): void {
|
ngOnInit(): void {
|
||||||
this.configurationList$ = this.searchConfigService.getAvailableConfigurationOptions();
|
this.configurationList$ = this.searchConfigService.getAvailableConfigurationOptions();
|
||||||
this.searchOptions$ = this.searchConfigService.paginatedSearchOptions;
|
this.searchOptions$ = this.searchConfigService.paginatedSearchOptions;
|
||||||
|
this.sub = this.searchOptions$.pipe(
|
||||||
this.sub = new Subscription();
|
|
||||||
// This assures that the search cache is empty for each onInit.
|
|
||||||
// See https://github.com/DSpace/dspace-angular/pull/468
|
|
||||||
const removeSub = this.service.getEndpoint()
|
|
||||||
.subscribe((url) => this.requestService.removeByHrefSubstring(url));
|
|
||||||
const searchSub = this.searchOptions$.pipe(
|
|
||||||
tap(() => this.resultsRD$.next(null)),
|
tap(() => this.resultsRD$.next(null)),
|
||||||
switchMap((options: PaginatedSearchOptions) => this.service.search(options).pipe(getSucceededRemoteData())))
|
switchMap((options: PaginatedSearchOptions) => this.service.search(options).pipe(getSucceededRemoteData())))
|
||||||
.subscribe((results) => {
|
.subscribe((results) => {
|
||||||
this.resultsRD$.next(results);
|
this.resultsRD$.next(results);
|
||||||
});
|
});
|
||||||
this.sub.add(removeSub);
|
|
||||||
this.sub.add(searchSub);
|
|
||||||
|
|
||||||
this.scopeListRD$ = this.searchConfigService.getCurrentScope('').pipe(
|
this.scopeListRD$ = this.searchConfigService.getCurrentScope('').pipe(
|
||||||
switchMap((scopeId) => this.service.getScopes(scopeId))
|
switchMap((scopeId) => this.service.getScopes(scopeId))
|
||||||
|
12
src/app/shared/mocks/mock-search-service.ts
Normal file
12
src/app/shared/mocks/mock-search-service.ts
Normal file
@@ -0,0 +1,12 @@
|
|||||||
|
import { of as observableOf } from 'rxjs';
|
||||||
|
import { SearchService } from '../../+search-page/search-service/search.service';
|
||||||
|
|
||||||
|
export function getMockSearchService(): SearchService {
|
||||||
|
return jasmine.createSpyObj('searchService', {
|
||||||
|
search: '',
|
||||||
|
getEndpoint: observableOf('discover/search/objects'),
|
||||||
|
getSearchLink: '/mydspace',
|
||||||
|
getScopes: observableOf(['test-scope']),
|
||||||
|
setServiceOptions: {}
|
||||||
|
});
|
||||||
|
}
|
@@ -18,6 +18,10 @@ import { ClaimedTask } from '../../../core/tasks/models/claimed-task-object.mode
|
|||||||
import { WorkflowItem } from '../../../core/submission/models/workflowitem.model';
|
import { WorkflowItem } from '../../../core/submission/models/workflowitem.model';
|
||||||
import { createSuccessfulRemoteDataObject } from '../../testing/utils';
|
import { createSuccessfulRemoteDataObject } from '../../testing/utils';
|
||||||
import { CoreModule } from '../../../core/core.module';
|
import { CoreModule } from '../../../core/core.module';
|
||||||
|
import { getMockSearchService } from '../../mocks/mock-search-service';
|
||||||
|
import { getMockRequestService } from '../../mocks/mock-request.service';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
|
||||||
let component: ClaimedTaskActionsComponent;
|
let component: ClaimedTaskActionsComponent;
|
||||||
let fixture: ComponentFixture<ClaimedTaskActionsComponent>;
|
let fixture: ComponentFixture<ClaimedTaskActionsComponent>;
|
||||||
@@ -32,6 +36,10 @@ const mockDataService = jasmine.createSpyObj('ClaimedTaskDataService', {
|
|||||||
returnToPoolTask: jasmine.createSpy('returnToPoolTask'),
|
returnToPoolTask: jasmine.createSpy('returnToPoolTask'),
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const searchService = getMockSearchService();
|
||||||
|
|
||||||
|
const requestServce = getMockRequestService();
|
||||||
|
|
||||||
const item = Object.assign(new Item(), {
|
const item = Object.assign(new Item(), {
|
||||||
bitstreams: observableOf({}),
|
bitstreams: observableOf({}),
|
||||||
metadata: {
|
metadata: {
|
||||||
@@ -83,6 +91,8 @@ describe('ClaimedTaskActionsComponent', () => {
|
|||||||
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
||||||
{ provide: Router, useValue: new RouterStub() },
|
{ provide: Router, useValue: new RouterStub() },
|
||||||
{ provide: ClaimedTaskDataService, useValue: mockDataService },
|
{ provide: ClaimedTaskDataService, useValue: mockDataService },
|
||||||
|
{ provide: SearchService, useValue: searchService },
|
||||||
|
{ provide: RequestService, useValue: requestServce }
|
||||||
],
|
],
|
||||||
schemas: [NO_ERRORS_SCHEMA]
|
schemas: [NO_ERRORS_SCHEMA]
|
||||||
}).overrideComponent(ClaimedTaskActionsComponent, {
|
}).overrideComponent(ClaimedTaskActionsComponent, {
|
||||||
|
@@ -13,6 +13,8 @@ import { WorkflowItem } from '../../../core/submission/models/workflowitem.model
|
|||||||
import { RemoteData } from '../../../core/data/remote-data';
|
import { RemoteData } from '../../../core/data/remote-data';
|
||||||
import { MyDSpaceActionsComponent } from '../mydspace-actions';
|
import { MyDSpaceActionsComponent } from '../mydspace-actions';
|
||||||
import { NotificationsService } from '../../notifications/notifications.service';
|
import { NotificationsService } from '../../notifications/notifications.service';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* This component represents mydspace actions related to ClaimedTask object.
|
* This component represents mydspace actions related to ClaimedTask object.
|
||||||
@@ -56,12 +58,16 @@ export class ClaimedTaskActionsComponent extends MyDSpaceActionsComponent<Claime
|
|||||||
* @param {Router} router
|
* @param {Router} router
|
||||||
* @param {NotificationsService} notificationsService
|
* @param {NotificationsService} notificationsService
|
||||||
* @param {TranslateService} translate
|
* @param {TranslateService} translate
|
||||||
|
* @param {SearchService} searchService
|
||||||
|
* @param {RequestService} requestService
|
||||||
*/
|
*/
|
||||||
constructor(protected injector: Injector,
|
constructor(protected injector: Injector,
|
||||||
protected router: Router,
|
protected router: Router,
|
||||||
protected notificationsService: NotificationsService,
|
protected notificationsService: NotificationsService,
|
||||||
protected translate: TranslateService) {
|
protected translate: TranslateService,
|
||||||
super(ClaimedTask.type, injector, router, notificationsService, translate);
|
protected searchService: SearchService,
|
||||||
|
protected requestService: RequestService) {
|
||||||
|
super(ClaimedTask.type, injector, router, notificationsService, translate, searchService, requestService);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@@ -12,6 +12,10 @@ import { ItemActionsComponent } from './item-actions.component';
|
|||||||
import { ItemDataService } from '../../../core/data/item-data.service';
|
import { ItemDataService } from '../../../core/data/item-data.service';
|
||||||
import { NotificationsService } from '../../notifications/notifications.service';
|
import { NotificationsService } from '../../notifications/notifications.service';
|
||||||
import { NotificationsServiceStub } from '../../testing/notifications-service-stub';
|
import { NotificationsServiceStub } from '../../testing/notifications-service-stub';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
import { getMockSearchService } from '../../mocks/mock-search-service';
|
||||||
|
import { getMockRequestService } from '../../mocks/mock-request.service';
|
||||||
|
|
||||||
let component: ItemActionsComponent;
|
let component: ItemActionsComponent;
|
||||||
let fixture: ComponentFixture<ItemActionsComponent>;
|
let fixture: ComponentFixture<ItemActionsComponent>;
|
||||||
@@ -50,6 +54,10 @@ mockObject = Object.assign(new Item(), {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const searchService = getMockSearchService()
|
||||||
|
|
||||||
|
const requestServce = getMockRequestService();
|
||||||
|
|
||||||
describe('ItemActionsComponent', () => {
|
describe('ItemActionsComponent', () => {
|
||||||
beforeEach(async(() => {
|
beforeEach(async(() => {
|
||||||
TestBed.configureTestingModule({
|
TestBed.configureTestingModule({
|
||||||
@@ -67,6 +75,8 @@ describe('ItemActionsComponent', () => {
|
|||||||
{ provide: Router, useValue: new RouterStub() },
|
{ provide: Router, useValue: new RouterStub() },
|
||||||
{ provide: ItemDataService, useValue: mockDataService },
|
{ provide: ItemDataService, useValue: mockDataService },
|
||||||
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
||||||
|
{ provide: SearchService, useValue: searchService },
|
||||||
|
{ provide: RequestService, useValue: requestServce }
|
||||||
],
|
],
|
||||||
schemas: [NO_ERRORS_SCHEMA]
|
schemas: [NO_ERRORS_SCHEMA]
|
||||||
}).overrideComponent(ItemActionsComponent, {
|
}).overrideComponent(ItemActionsComponent, {
|
||||||
|
@@ -7,6 +7,8 @@ import { MyDSpaceActionsComponent } from '../mydspace-actions';
|
|||||||
import { ItemDataService } from '../../../core/data/item-data.service';
|
import { ItemDataService } from '../../../core/data/item-data.service';
|
||||||
import { Item } from '../../../core/shared/item.model';
|
import { Item } from '../../../core/shared/item.model';
|
||||||
import { NotificationsService } from '../../notifications/notifications.service';
|
import { NotificationsService } from '../../notifications/notifications.service';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* This component represents mydspace actions related to Item object.
|
* This component represents mydspace actions related to Item object.
|
||||||
@@ -31,12 +33,16 @@ export class ItemActionsComponent extends MyDSpaceActionsComponent<Item, ItemDat
|
|||||||
* @param {Router} router
|
* @param {Router} router
|
||||||
* @param {NotificationsService} notificationsService
|
* @param {NotificationsService} notificationsService
|
||||||
* @param {TranslateService} translate
|
* @param {TranslateService} translate
|
||||||
|
* @param {SearchService} searchService
|
||||||
|
* @param {RequestService} requestService
|
||||||
*/
|
*/
|
||||||
constructor(protected injector: Injector,
|
constructor(protected injector: Injector,
|
||||||
protected router: Router,
|
protected router: Router,
|
||||||
protected notificationsService: NotificationsService,
|
protected notificationsService: NotificationsService,
|
||||||
protected translate: TranslateService) {
|
protected translate: TranslateService,
|
||||||
super(Item.type, injector, router, notificationsService, translate);
|
protected searchService: SearchService,
|
||||||
|
protected requestService: RequestService) {
|
||||||
|
super(Item.type, injector, router, notificationsService, translate, searchService, requestService);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@@ -1,7 +1,7 @@
|
|||||||
import { Router } from '@angular/router';
|
import { Router } from '@angular/router';
|
||||||
import { Injector, Input } from '@angular/core';
|
import { Injector, Input } from '@angular/core';
|
||||||
|
|
||||||
import { find } from 'rxjs/operators';
|
import { find, take, tap } from 'rxjs/operators';
|
||||||
|
|
||||||
import { MydspaceActionsServiceFactory } from './mydspace-actions-service.factory';
|
import { MydspaceActionsServiceFactory } from './mydspace-actions-service.factory';
|
||||||
import { RemoteData } from '../../core/data/remote-data';
|
import { RemoteData } from '../../core/data/remote-data';
|
||||||
@@ -11,6 +11,9 @@ import { ResourceType } from '../../core/shared/resource-type';
|
|||||||
import { NotificationOptions } from '../notifications/models/notification-options.model';
|
import { NotificationOptions } from '../notifications/models/notification-options.model';
|
||||||
import { NotificationsService } from '../notifications/notifications.service';
|
import { NotificationsService } from '../notifications/notifications.service';
|
||||||
import { TranslateService } from '@ngx-translate/core';
|
import { TranslateService } from '@ngx-translate/core';
|
||||||
|
import { SearchService } from '../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../core/data/request.service';
|
||||||
|
import { Subscription } from 'rxjs';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Abstract class for all different representations of mydspace actions
|
* Abstract class for all different representations of mydspace actions
|
||||||
@@ -27,6 +30,8 @@ export abstract class MyDSpaceActionsComponent<T extends DSpaceObject, TService
|
|||||||
*/
|
*/
|
||||||
protected objectDataService: TService;
|
protected objectDataService: TService;
|
||||||
|
|
||||||
|
protected subscription: Subscription;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Initialize instance variables
|
* Initialize instance variables
|
||||||
*
|
*
|
||||||
@@ -35,13 +40,17 @@ export abstract class MyDSpaceActionsComponent<T extends DSpaceObject, TService
|
|||||||
* @param {Router} router
|
* @param {Router} router
|
||||||
* @param {NotificationsService} notificationsService
|
* @param {NotificationsService} notificationsService
|
||||||
* @param {TranslateService} translate
|
* @param {TranslateService} translate
|
||||||
|
* @param {SearchService} searchService
|
||||||
|
* @param {RequestService} requestService
|
||||||
*/
|
*/
|
||||||
constructor(
|
constructor(
|
||||||
protected objectType: ResourceType,
|
protected objectType: ResourceType,
|
||||||
protected injector: Injector,
|
protected injector: Injector,
|
||||||
protected router: Router,
|
protected router: Router,
|
||||||
protected notificationsService: NotificationsService,
|
protected notificationsService: NotificationsService,
|
||||||
protected translate: TranslateService) {
|
protected translate: TranslateService,
|
||||||
|
protected searchService: SearchService,
|
||||||
|
protected requestService: RequestService) {
|
||||||
const factory = new MydspaceActionsServiceFactory<T, TService>();
|
const factory = new MydspaceActionsServiceFactory<T, TService>();
|
||||||
this.objectDataService = injector.get(factory.getConstructor(objectType));
|
this.objectDataService = injector.get(factory.getConstructor(objectType));
|
||||||
}
|
}
|
||||||
@@ -57,13 +66,18 @@ export abstract class MyDSpaceActionsComponent<T extends DSpaceObject, TService
|
|||||||
* Refresh current page
|
* Refresh current page
|
||||||
*/
|
*/
|
||||||
reload(): void {
|
reload(): void {
|
||||||
|
this.router.navigated = false;
|
||||||
|
const url = decodeURIComponent(this.router.url);
|
||||||
// override the route reuse strategy
|
// override the route reuse strategy
|
||||||
this.router.routeReuseStrategy.shouldReuseRoute = () => {
|
this.router.routeReuseStrategy.shouldReuseRoute = () => {
|
||||||
return false;
|
return false;
|
||||||
};
|
};
|
||||||
this.router.navigated = false;
|
// This assures that the search cache is empty before reloading mydspace.
|
||||||
const url = decodeURIComponent(this.router.url);
|
// See https://github.com/DSpace/dspace-angular/pull/468
|
||||||
this.router.navigateByUrl(url);
|
this.searchService.getEndpoint().pipe(
|
||||||
|
take(1),
|
||||||
|
tap((cachedHref) => this.requestService.removeByHrefSubstring(cachedHref))
|
||||||
|
).subscribe(() => this.router.navigateByUrl(url));
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@@ -17,6 +17,10 @@ import { PoolTaskActionsComponent } from './pool-task-actions.component';
|
|||||||
import { PoolTask } from '../../../core/tasks/models/pool-task-object.model';
|
import { PoolTask } from '../../../core/tasks/models/pool-task-object.model';
|
||||||
import { WorkflowItem } from '../../../core/submission/models/workflowitem.model';
|
import { WorkflowItem } from '../../../core/submission/models/workflowitem.model';
|
||||||
import { createSuccessfulRemoteDataObject } from '../../testing/utils';
|
import { createSuccessfulRemoteDataObject } from '../../testing/utils';
|
||||||
|
import { getMockRequestService } from '../../mocks/mock-request.service';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
import { getMockSearchService } from '../../mocks/mock-search-service';
|
||||||
|
|
||||||
let component: PoolTaskActionsComponent;
|
let component: PoolTaskActionsComponent;
|
||||||
let fixture: ComponentFixture<PoolTaskActionsComponent>;
|
let fixture: ComponentFixture<PoolTaskActionsComponent>;
|
||||||
@@ -29,6 +33,10 @@ const mockDataService = jasmine.createSpyObj('PoolTaskDataService', {
|
|||||||
claimTask: jasmine.createSpy('claimTask')
|
claimTask: jasmine.createSpy('claimTask')
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const searchService = getMockSearchService();
|
||||||
|
|
||||||
|
const requestServce = getMockRequestService();
|
||||||
|
|
||||||
const item = Object.assign(new Item(), {
|
const item = Object.assign(new Item(), {
|
||||||
bitstreams: observableOf({}),
|
bitstreams: observableOf({}),
|
||||||
metadata: {
|
metadata: {
|
||||||
@@ -80,6 +88,8 @@ describe('PoolTaskActionsComponent', () => {
|
|||||||
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
||||||
{ provide: Router, useValue: new RouterStub() },
|
{ provide: Router, useValue: new RouterStub() },
|
||||||
{ provide: PoolTaskDataService, useValue: mockDataService },
|
{ provide: PoolTaskDataService, useValue: mockDataService },
|
||||||
|
{ provide: SearchService, useValue: searchService },
|
||||||
|
{ provide: RequestService, useValue: requestServce }
|
||||||
],
|
],
|
||||||
schemas: [NO_ERRORS_SCHEMA]
|
schemas: [NO_ERRORS_SCHEMA]
|
||||||
}).overrideComponent(PoolTaskActionsComponent, {
|
}).overrideComponent(PoolTaskActionsComponent, {
|
||||||
@@ -167,4 +177,14 @@ describe('PoolTaskActionsComponent', () => {
|
|||||||
});
|
});
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
it('should clear the object cache by href', async(() => {
|
||||||
|
component.reload();
|
||||||
|
fixture.detectChanges();
|
||||||
|
|
||||||
|
fixture.whenStable().then(() => {
|
||||||
|
expect(searchService.getEndpoint).toHaveBeenCalled();
|
||||||
|
expect(requestServce.removeByHrefSubstring).toHaveBeenCalledWith('discover/search/objects');
|
||||||
|
});
|
||||||
|
}));
|
||||||
|
|
||||||
});
|
});
|
||||||
|
@@ -13,6 +13,8 @@ import { PoolTaskDataService } from '../../../core/tasks/pool-task-data.service'
|
|||||||
import { isNotUndefined } from '../../empty.util';
|
import { isNotUndefined } from '../../empty.util';
|
||||||
import { MyDSpaceActionsComponent } from '../mydspace-actions';
|
import { MyDSpaceActionsComponent } from '../mydspace-actions';
|
||||||
import { NotificationsService } from '../../notifications/notifications.service';
|
import { NotificationsService } from '../../notifications/notifications.service';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* This component represents mydspace actions related to PoolTask object.
|
* This component represents mydspace actions related to PoolTask object.
|
||||||
@@ -47,12 +49,16 @@ export class PoolTaskActionsComponent extends MyDSpaceActionsComponent<PoolTask,
|
|||||||
* @param {Router} router
|
* @param {Router} router
|
||||||
* @param {NotificationsService} notificationsService
|
* @param {NotificationsService} notificationsService
|
||||||
* @param {TranslateService} translate
|
* @param {TranslateService} translate
|
||||||
|
* @param {SearchService} searchService
|
||||||
|
* @param {RequestService} requestService
|
||||||
*/
|
*/
|
||||||
constructor(protected injector: Injector,
|
constructor(protected injector: Injector,
|
||||||
protected router: Router,
|
protected router: Router,
|
||||||
protected notificationsService: NotificationsService,
|
protected notificationsService: NotificationsService,
|
||||||
protected translate: TranslateService) {
|
protected translate: TranslateService,
|
||||||
super(PoolTask.type, injector, router, notificationsService, translate);
|
protected searchService: SearchService,
|
||||||
|
protected requestService: RequestService) {
|
||||||
|
super(PoolTask.type, injector, router, notificationsService, translate, searchService, requestService);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@@ -15,6 +15,10 @@ import { WorkflowItemDataService } from '../../../core/submission/workflowitem-d
|
|||||||
import { NotificationsService } from '../../notifications/notifications.service';
|
import { NotificationsService } from '../../notifications/notifications.service';
|
||||||
import { NotificationsServiceStub } from '../../testing/notifications-service-stub';
|
import { NotificationsServiceStub } from '../../testing/notifications-service-stub';
|
||||||
import { createSuccessfulRemoteDataObject } from '../../testing/utils';
|
import { createSuccessfulRemoteDataObject } from '../../testing/utils';
|
||||||
|
import { getMockRequestService } from '../../mocks/mock-request.service';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
import { getMockSearchService } from '../../mocks/mock-search-service';
|
||||||
|
|
||||||
let component: WorkflowitemActionsComponent;
|
let component: WorkflowitemActionsComponent;
|
||||||
let fixture: ComponentFixture<WorkflowitemActionsComponent>;
|
let fixture: ComponentFixture<WorkflowitemActionsComponent>;
|
||||||
@@ -23,6 +27,10 @@ let mockObject: WorkflowItem;
|
|||||||
|
|
||||||
const mockDataService = {};
|
const mockDataService = {};
|
||||||
|
|
||||||
|
const searchService = getMockSearchService();
|
||||||
|
|
||||||
|
const requestServce = getMockRequestService();
|
||||||
|
|
||||||
const item = Object.assign(new Item(), {
|
const item = Object.assign(new Item(), {
|
||||||
bitstreams: observableOf({}),
|
bitstreams: observableOf({}),
|
||||||
metadata: {
|
metadata: {
|
||||||
@@ -72,6 +80,8 @@ describe('WorkflowitemActionsComponent', () => {
|
|||||||
{ provide: Router, useValue: new RouterStub() },
|
{ provide: Router, useValue: new RouterStub() },
|
||||||
{ provide: WorkflowItemDataService, useValue: mockDataService },
|
{ provide: WorkflowItemDataService, useValue: mockDataService },
|
||||||
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
||||||
|
{ provide: SearchService, useValue: searchService },
|
||||||
|
{ provide: RequestService, useValue: requestServce }
|
||||||
],
|
],
|
||||||
schemas: [NO_ERRORS_SCHEMA]
|
schemas: [NO_ERRORS_SCHEMA]
|
||||||
}).overrideComponent(WorkflowitemActionsComponent, {
|
}).overrideComponent(WorkflowitemActionsComponent, {
|
||||||
|
@@ -7,6 +7,8 @@ import { MyDSpaceActionsComponent } from '../mydspace-actions';
|
|||||||
import { WorkflowItem } from '../../../core/submission/models/workflowitem.model';
|
import { WorkflowItem } from '../../../core/submission/models/workflowitem.model';
|
||||||
import { WorkflowItemDataService } from '../../../core/submission/workflowitem-data.service';
|
import { WorkflowItemDataService } from '../../../core/submission/workflowitem-data.service';
|
||||||
import { NotificationsService } from '../../notifications/notifications.service';
|
import { NotificationsService } from '../../notifications/notifications.service';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* This component represents mydspace actions related to WorkflowItem object.
|
* This component represents mydspace actions related to WorkflowItem object.
|
||||||
@@ -30,12 +32,16 @@ export class WorkflowitemActionsComponent extends MyDSpaceActionsComponent<Workf
|
|||||||
* @param {Router} router
|
* @param {Router} router
|
||||||
* @param {NotificationsService} notificationsService
|
* @param {NotificationsService} notificationsService
|
||||||
* @param {TranslateService} translate
|
* @param {TranslateService} translate
|
||||||
|
* @param {SearchService} searchService
|
||||||
|
* @param {RequestService} requestService
|
||||||
*/
|
*/
|
||||||
constructor(protected injector: Injector,
|
constructor(protected injector: Injector,
|
||||||
protected router: Router,
|
protected router: Router,
|
||||||
protected notificationsService: NotificationsService,
|
protected notificationsService: NotificationsService,
|
||||||
protected translate: TranslateService) {
|
protected translate: TranslateService,
|
||||||
super(WorkflowItem.type, injector, router, notificationsService, translate);
|
protected searchService: SearchService,
|
||||||
|
protected requestService: RequestService) {
|
||||||
|
super(WorkflowItem.type, injector, router, notificationsService, translate, searchService, requestService);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -46,5 +52,4 @@ export class WorkflowitemActionsComponent extends MyDSpaceActionsComponent<Workf
|
|||||||
initObjects(object: WorkflowItem) {
|
initObjects(object: WorkflowItem) {
|
||||||
this.object = object;
|
this.object = object;
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
@@ -17,6 +17,10 @@ import { WorkspaceItem } from '../../../core/submission/models/workspaceitem.mod
|
|||||||
import { WorkspaceitemActionsComponent } from './workspaceitem-actions.component';
|
import { WorkspaceitemActionsComponent } from './workspaceitem-actions.component';
|
||||||
import { WorkspaceitemDataService } from '../../../core/submission/workspaceitem-data.service';
|
import { WorkspaceitemDataService } from '../../../core/submission/workspaceitem-data.service';
|
||||||
import { createSuccessfulRemoteDataObject } from '../../testing/utils';
|
import { createSuccessfulRemoteDataObject } from '../../testing/utils';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
import { getMockRequestService } from '../../mocks/mock-request.service';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { getMockSearchService } from '../../mocks/mock-search-service';
|
||||||
|
|
||||||
let component: WorkspaceitemActionsComponent;
|
let component: WorkspaceitemActionsComponent;
|
||||||
let fixture: ComponentFixture<WorkspaceitemActionsComponent>;
|
let fixture: ComponentFixture<WorkspaceitemActionsComponent>;
|
||||||
@@ -28,6 +32,10 @@ const mockDataService = jasmine.createSpyObj('WorkspaceitemDataService', {
|
|||||||
delete: jasmine.createSpy('delete')
|
delete: jasmine.createSpy('delete')
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const searchService = getMockSearchService();
|
||||||
|
|
||||||
|
const requestServce = getMockRequestService();
|
||||||
|
|
||||||
const item = Object.assign(new Item(), {
|
const item = Object.assign(new Item(), {
|
||||||
bitstreams: observableOf({}),
|
bitstreams: observableOf({}),
|
||||||
metadata: {
|
metadata: {
|
||||||
@@ -62,6 +70,7 @@ mockObject = Object.assign(new WorkspaceItem(), { item: observableOf(rd), id: '1
|
|||||||
|
|
||||||
describe('WorkspaceitemActionsComponent', () => {
|
describe('WorkspaceitemActionsComponent', () => {
|
||||||
beforeEach(async(() => {
|
beforeEach(async(() => {
|
||||||
|
|
||||||
TestBed.configureTestingModule({
|
TestBed.configureTestingModule({
|
||||||
imports: [
|
imports: [
|
||||||
NgbModule.forRoot(),
|
NgbModule.forRoot(),
|
||||||
@@ -78,6 +87,8 @@ describe('WorkspaceitemActionsComponent', () => {
|
|||||||
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
{ provide: NotificationsService, useValue: new NotificationsServiceStub() },
|
||||||
{ provide: Router, useValue: new RouterStub() },
|
{ provide: Router, useValue: new RouterStub() },
|
||||||
{ provide: WorkspaceitemDataService, useValue: mockDataService },
|
{ provide: WorkspaceitemDataService, useValue: mockDataService },
|
||||||
|
{ provide: SearchService, useValue: searchService },
|
||||||
|
{ provide: RequestService, useValue: requestServce },
|
||||||
NgbModal
|
NgbModal
|
||||||
],
|
],
|
||||||
schemas: [NO_ERRORS_SCHEMA]
|
schemas: [NO_ERRORS_SCHEMA]
|
||||||
@@ -161,4 +172,14 @@ describe('WorkspaceitemActionsComponent', () => {
|
|||||||
expect(notificationsServiceStub.error).toHaveBeenCalled();
|
expect(notificationsServiceStub.error).toHaveBeenCalled();
|
||||||
});
|
});
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
it('should clear the object cache by href', async(() => {
|
||||||
|
component.reload();
|
||||||
|
fixture.detectChanges();
|
||||||
|
|
||||||
|
fixture.whenStable().then(() => {
|
||||||
|
expect(searchService.getEndpoint).toHaveBeenCalled();
|
||||||
|
expect(requestServce.removeByHrefSubstring).toHaveBeenCalledWith('discover/search/objects');
|
||||||
|
});
|
||||||
|
}));
|
||||||
});
|
});
|
||||||
|
@@ -1,4 +1,4 @@
|
|||||||
import { Component, Injector, Input } from '@angular/core';
|
import { Component, Injector, Input, OnDestroy } from '@angular/core';
|
||||||
import { Router } from '@angular/router';
|
import { Router } from '@angular/router';
|
||||||
|
|
||||||
import { BehaviorSubject } from 'rxjs';
|
import { BehaviorSubject } from 'rxjs';
|
||||||
@@ -10,6 +10,8 @@ import { MyDSpaceActionsComponent } from '../mydspace-actions';
|
|||||||
import { WorkspaceitemDataService } from '../../../core/submission/workspaceitem-data.service';
|
import { WorkspaceitemDataService } from '../../../core/submission/workspaceitem-data.service';
|
||||||
import { ResourceType } from '../../../core/shared/resource-type';
|
import { ResourceType } from '../../../core/shared/resource-type';
|
||||||
import { NotificationsService } from '../../notifications/notifications.service';
|
import { NotificationsService } from '../../notifications/notifications.service';
|
||||||
|
import { SearchService } from '../../../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../../../core/data/request.service';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* This component represents mydspace actions related to WorkspaceItem object.
|
* This component represents mydspace actions related to WorkspaceItem object.
|
||||||
@@ -40,13 +42,17 @@ export class WorkspaceitemActionsComponent extends MyDSpaceActionsComponent<Work
|
|||||||
* @param {NgbModal} modalService
|
* @param {NgbModal} modalService
|
||||||
* @param {NotificationsService} notificationsService
|
* @param {NotificationsService} notificationsService
|
||||||
* @param {TranslateService} translate
|
* @param {TranslateService} translate
|
||||||
|
* @param {SearchService} searchService
|
||||||
|
* @param {RequestService} requestService
|
||||||
*/
|
*/
|
||||||
constructor(protected injector: Injector,
|
constructor(protected injector: Injector,
|
||||||
protected router: Router,
|
protected router: Router,
|
||||||
protected modalService: NgbModal,
|
protected modalService: NgbModal,
|
||||||
protected notificationsService: NotificationsService,
|
protected notificationsService: NotificationsService,
|
||||||
protected translate: TranslateService) {
|
protected translate: TranslateService,
|
||||||
super(WorkspaceItem.type, injector, router, notificationsService, translate);
|
protected searchService: SearchService,
|
||||||
|
protected requestService: RequestService) {
|
||||||
|
super(WorkspaceItem.type, injector, router, notificationsService, translate, searchService, requestService);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@@ -45,6 +45,10 @@ import {
|
|||||||
createSuccessfulRemoteDataObject,
|
createSuccessfulRemoteDataObject,
|
||||||
createSuccessfulRemoteDataObject$
|
createSuccessfulRemoteDataObject$
|
||||||
} from '../shared/testing/utils';
|
} from '../shared/testing/utils';
|
||||||
|
import { getMockSearchService } from '../shared/mocks/mock-search-service';
|
||||||
|
import { getMockRequestService } from '../shared/mocks/mock-request.service';
|
||||||
|
import { SearchService } from '../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../core/data/request.service';
|
||||||
|
|
||||||
describe('SubmissionService test suite', () => {
|
describe('SubmissionService test suite', () => {
|
||||||
const config = MOCK_SUBMISSION_CONFIG;
|
const config = MOCK_SUBMISSION_CONFIG;
|
||||||
@@ -349,7 +353,12 @@ describe('SubmissionService test suite', () => {
|
|||||||
let scheduler: TestScheduler;
|
let scheduler: TestScheduler;
|
||||||
let service: SubmissionService;
|
let service: SubmissionService;
|
||||||
|
|
||||||
|
const searchService = getMockSearchService();
|
||||||
|
|
||||||
|
const requestServce = getMockRequestService();
|
||||||
|
|
||||||
beforeEach(async(() => {
|
beforeEach(async(() => {
|
||||||
|
|
||||||
TestBed.configureTestingModule({
|
TestBed.configureTestingModule({
|
||||||
imports: [
|
imports: [
|
||||||
StoreModule.forRoot({ submissionReducers } as any),
|
StoreModule.forRoot({ submissionReducers } as any),
|
||||||
@@ -365,6 +374,8 @@ describe('SubmissionService test suite', () => {
|
|||||||
{ provide: Router, useValue: router },
|
{ provide: Router, useValue: router },
|
||||||
{ provide: SubmissionRestService, useValue: restService },
|
{ provide: SubmissionRestService, useValue: restService },
|
||||||
{ provide: ActivatedRoute, useValue: new MockActivatedRoute() },
|
{ provide: ActivatedRoute, useValue: new MockActivatedRoute() },
|
||||||
|
{ provide: SearchService, useValue: searchService },
|
||||||
|
{ provide: RequestService, useValue: requestServce },
|
||||||
NotificationsService,
|
NotificationsService,
|
||||||
RouteService,
|
RouteService,
|
||||||
SubmissionService,
|
SubmissionService,
|
||||||
|
@@ -4,13 +4,12 @@ import { Router } from '@angular/router';
|
|||||||
|
|
||||||
import { Observable, of as observableOf, Subscription, timer as observableTimer } from 'rxjs';
|
import { Observable, of as observableOf, Subscription, timer as observableTimer } from 'rxjs';
|
||||||
import {
|
import {
|
||||||
catchError,
|
catchError, concatMap,
|
||||||
distinctUntilChanged,
|
distinctUntilChanged,
|
||||||
filter,
|
filter,
|
||||||
find,
|
find,
|
||||||
first,
|
|
||||||
map,
|
map,
|
||||||
startWith
|
startWith, take, tap
|
||||||
} from 'rxjs/operators';
|
} from 'rxjs/operators';
|
||||||
import { Store } from '@ngrx/store';
|
import { Store } from '@ngrx/store';
|
||||||
import { TranslateService } from '@ngx-translate/core';
|
import { TranslateService } from '@ngx-translate/core';
|
||||||
@@ -56,6 +55,8 @@ import {
|
|||||||
createSuccessfulRemoteDataObject,
|
createSuccessfulRemoteDataObject,
|
||||||
createSuccessfulRemoteDataObject$
|
createSuccessfulRemoteDataObject$
|
||||||
} from '../shared/testing/utils';
|
} from '../shared/testing/utils';
|
||||||
|
import { SearchService } from '../+search-page/search-service/search.service';
|
||||||
|
import { RequestService } from '../core/data/request.service';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* A service that provides methods used in submission process.
|
* A service that provides methods used in submission process.
|
||||||
@@ -82,6 +83,8 @@ export class SubmissionService {
|
|||||||
* @param {RouteService} routeService
|
* @param {RouteService} routeService
|
||||||
* @param {Store<SubmissionState>} store
|
* @param {Store<SubmissionState>} store
|
||||||
* @param {TranslateService} translate
|
* @param {TranslateService} translate
|
||||||
|
* @param {SearchService} searchService
|
||||||
|
* @param {RequestService} requestService
|
||||||
*/
|
*/
|
||||||
constructor(@Inject(GLOBAL_CONFIG) protected EnvConfig: GlobalConfig,
|
constructor(@Inject(GLOBAL_CONFIG) protected EnvConfig: GlobalConfig,
|
||||||
protected notificationsService: NotificationsService,
|
protected notificationsService: NotificationsService,
|
||||||
@@ -89,7 +92,9 @@ export class SubmissionService {
|
|||||||
protected router: Router,
|
protected router: Router,
|
||||||
protected routeService: RouteService,
|
protected routeService: RouteService,
|
||||||
protected store: Store<SubmissionState>,
|
protected store: Store<SubmissionState>,
|
||||||
protected translate: TranslateService) {
|
protected translate: TranslateService,
|
||||||
|
protected searchService: SearchService,
|
||||||
|
protected requestService: RequestService) {
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -460,16 +465,23 @@ export class SubmissionService {
|
|||||||
* Redirect to MyDspace page
|
* Redirect to MyDspace page
|
||||||
*/
|
*/
|
||||||
redirectToMyDSpace() {
|
redirectToMyDSpace() {
|
||||||
this.routeService.getPreviousUrl().pipe(
|
// This assures that the cache is empty before redirecting to mydspace.
|
||||||
first()
|
// See https://github.com/DSpace/dspace-angular/pull/468
|
||||||
).subscribe((previousUrl: string) => {
|
this.searchService.getEndpoint().pipe(
|
||||||
if (isEmpty(previousUrl) || !previousUrl.startsWith('/mydspace')) {
|
take(1),
|
||||||
this.router.navigate(['/mydspace']);
|
tap((url) => this.requestService.removeByHrefSubstring(url)),
|
||||||
} else {
|
// Now, do redirect.
|
||||||
this.router.navigateByUrl(previousUrl);
|
concatMap(
|
||||||
}
|
() => this.routeService.getPreviousUrl().pipe(
|
||||||
});
|
take(1),
|
||||||
|
tap((previousUrl) => {
|
||||||
|
if (isEmpty(previousUrl) || !previousUrl.startsWith('/mydspace')) {
|
||||||
|
this.router.navigate(['/mydspace']);
|
||||||
|
} else {
|
||||||
|
this.router.navigateByUrl(previousUrl);
|
||||||
|
}
|
||||||
|
})))
|
||||||
|
).subscribe();
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
Reference in New Issue
Block a user