Move all config stuff to a single directory

src/app/core/cache/models/normalized-object-factory.ts

@@ -14,9 +14,9 @@ import { NormalizedGroup } from '../../eperson/models/normalized-group.model';
 import { NormalizedWorkflowItem } from '../../submission/models/normalized-workflowitem.model';
 import { NormalizedBitstreamFormat } from './normalized-bitstream-format.model';
 import { SubmissionResourceType } from '../../submission/submission-resource-type';
-import { SubmissionDefinitionsModel } from '../../shared/config/config-submission-definitions.model';
-import { SubmissionFormsModel } from '../../shared/config/config-submission-forms.model';
-import { SubmissionSectionModel } from '../../shared/config/config-submission-section.model';
+import { SubmissionDefinitionsModel } from '../../config/models/config-submission-definitions.model';
+import { SubmissionFormsModel } from '../../config/models/config-submission-forms.model';
+import { SubmissionSectionModel } from '../../config/models/config-submission-section.model';
 
 export class NormalizedObjectFactory {
   public static getConstructor(type: ResourceType): GenericConstructor<NormalizedObject> {

src/app/core/cache/response-cache.models.ts

@@ -1,7 +1,7 @@
 import { SearchQueryResponse } from '../../+search-page/search-service/search-query-response.model';
 import { RequestError } from '../data/request.models';
 import { PageInfo } from '../shared/page-info.model';
-import { ConfigObject } from '../shared/config/config.model';
+import { ConfigObject } from '../config/models/config.model';
 import { FacetValue } from '../../+search-page/search-service/facet-value.model';
 import { SearchFilterConfig } from '../../+search-page/search-service/search-filter-config.model';
 import { IntegrationModel } from '../integration/models/integration.model';

src/app/core/config/config-data.ts

@@ -1,5 +1,5 @@
 import { PageInfo } from '../shared/page-info.model';
-import { ConfigObject } from '../shared/config/config.model';
+import { ConfigObject } from './models/config.model';
 
 /**
  * A class to represent the data retrieved by a configuration service

src/app/core/config/config-response-parsing.service.spec.ts

@@ -2,14 +2,14 @@ import { ConfigSuccessResponse, ErrorResponse } from '../cache/response-cache.mo
 import { ConfigResponseParsingService } from './config-response-parsing.service';
 import { ObjectCacheService } from '../cache/object-cache.service';
 import { GlobalConfig } from '../../../config/global-config.interface';
-import { ConfigRequest } from './request.models';
+import { ConfigRequest } from '../data/request.models';
 
 import { Store } from '@ngrx/store';
 import { CoreState } from '../core.reducers';
-import { SubmissionDefinitionsModel } from '../shared/config/config-submission-definitions.model';
-import { PaginatedList } from './paginated-list';
+import { SubmissionDefinitionsModel } from './models/config-submission-definitions.model';
+import { PaginatedList } from '../data/paginated-list';
 import { PageInfo } from '../shared/page-info.model';
-import { SubmissionSectionModel } from '../shared/config/config-submission-section.model';
+import { SubmissionSectionModel } from './models/config-submission-section.model';
 
 describe('ConfigResponseParsingService', () => {
   let service: ConfigResponseParsingService;

src/app/core/config/config-response-parsing.service.ts

@@ -1,15 +1,15 @@
 import { Inject, Injectable } from '@angular/core';
 
-import { ResponseParsingService } from './parsing.service';
-import { RestRequest } from './request.models';
+import { ResponseParsingService } from '../data/parsing.service';
+import { RestRequest } from '../data/request.models';
 import { DSpaceRESTV2Response } from '../dspace-rest-v2/dspace-rest-v2-response.model';
 import { ConfigSuccessResponse, ErrorResponse, RestResponse } from '../cache/response-cache.models';
 import { isNotEmpty } from '../../shared/empty.util';
-import { ConfigObjectFactory } from '../shared/config/config-object-factory';
+import { ConfigObjectFactory } from './models/config-object-factory';
 
-import { ConfigObject } from '../shared/config/config.model';
-import { ConfigType } from '../shared/config/config-type';
-import { BaseResponseParsingService } from './base-response-parsing.service';
+import { ConfigObject } from './models/config.model';
+import { ConfigType } from './models/config-type';
+import { BaseResponseParsingService } from '../data/base-response-parsing.service';
 import { GLOBAL_CONFIG } from '../../../config';
 import { GlobalConfig } from '../../../config/global-config.interface';
 import { ObjectCacheService } from '../cache/object-cache.service';

src/app/core/config/models/config-object-factory.ts

@@ -1,4 +1,4 @@
-import { GenericConstructor } from '../generic-constructor';
+import { GenericConstructor } from '../../shared/generic-constructor';
 
 import { SubmissionSectionModel } from './config-submission-section.model';
 import { SubmissionFormsModel } from './config-submission-forms.model';

src/app/core/config/models/config.model.ts

@@ -1,4 +1,4 @@
-import { autoserialize, autoserializeAs } from 'cerialize';
+import { autoserialize } from 'cerialize';
 import { NormalizedObject } from '../../cache/models/normalized-object.model';
 
 export abstract class ConfigObject extends  NormalizedObject {
@@ -12,7 +12,7 @@ export abstract class ConfigObject extends  NormalizedObject{
   @autoserialize
   public _links: {
     [name: string]: string
-  }
+  };
 
   /**
    * The link to the rest endpoint where this config object can be found

src/app/core/core.module.ts

@@ -40,7 +40,7 @@ import { ServerResponseService } from '../shared/services/server-response.servic
 import { NativeWindowFactory, NativeWindowService } from '../shared/services/window.service';
 import { BrowseService } from './browse/browse.service';
 import { BrowseResponseParsingService } from './data/browse-response-parsing.service';
-import { ConfigResponseParsingService } from './data/config-response-parsing.service';
+import { ConfigResponseParsingService } from './config/config-response-parsing.service';
 import { RouteService } from '../shared/services/route.service';
 import { SubmissionDefinitionsConfigService } from './config/submission-definitions-config.service';
 import { SubmissionFormsConfigService } from './config/submission-forms-config.service';

src/app/core/data/request.models.ts

@@ -5,7 +5,7 @@ import { DSOResponseParsingService } from './dso-response-parsing.service';
 import { ResponseParsingService } from './parsing.service';
 import { EndpointMapResponseParsingService } from './endpoint-map-response-parsing.service';
 import { BrowseResponseParsingService } from './browse-response-parsing.service';
-import { ConfigResponseParsingService } from './config-response-parsing.service';
+import { ConfigResponseParsingService } from '../config/config-response-parsing.service';
 import { AuthResponseParsingService } from '../auth/auth-response-parsing.service';
 import { HttpOptions } from '../dspace-rest-v2/dspace-rest-v2.service';
 import { SubmissionResponseParsingService } from '../submission/submission-response-parsing.service';

src/app/core/submission/models/submission-object.model.ts

@@ -7,7 +7,7 @@ import { EPerson } from '../../eperson/models/eperson.model';
 import { RemoteData } from '../../data/remote-data';
 import { Collection } from '../../shared/collection.model';
 import { Item } from '../../shared/item.model';
-import { SubmissionDefinitionsModel } from '../../shared/config/config-submission-definitions.model';
+import { SubmissionDefinitionsModel } from '../../config/models/config-submission-definitions.model';
 import { WorkspaceitemSectionsObject } from './workspaceitem-sections.model';
 
 export interface SubmissionObjectError {

src/app/core/submission/normalized-submission-object-factory.ts

@@ -1,6 +1,6 @@
-import { SubmissionDefinitionsModel } from '../shared/config/config-submission-definitions.model';
-import { SubmissionFormsModel } from '../shared/config/config-submission-forms.model';
-import { SubmissionSectionModel } from '../shared/config/config-submission-section.model';
+import { SubmissionDefinitionsModel } from '../config/models/config-submission-definitions.model';
+import { SubmissionFormsModel } from '../config/models/config-submission-forms.model';
+import { SubmissionSectionModel } from '../config/models/config-submission-section.model';
 import { GenericConstructor } from '../shared/generic-constructor';
 import { NormalizedBitstream } from '../cache/models/normalized-bitstream.model';
 import { NormalizedBundle } from '../cache/models/normalized-bundle.model';
@@ -10,7 +10,7 @@ import { NormalizedItem } from '../cache/models/normalized-item.model';
 import { NormalizedLicense } from '../cache/models/normalized-license.model';
 import { NormalizedWorkspaceItem } from './models/normalized-workspaceitem.model';
 import { NormalizedObject } from '../cache/models/normalized-object.model';
-import { ConfigObject } from '../shared/config/config.model';
+import { ConfigObject } from '../config/models/config.model';
 import { SubmissionResourceType } from './submission-resource-type';
 import { NormalizedResourcePolicy } from '../cache/models/normalized-resource-policy.model';
 import { NormalizedWorkflowItem } from './models/normalized-workflowitem.model';

src/app/core/submission/submission-response-parsing.service.ts

@@ -6,7 +6,7 @@ import { DSpaceRESTV2Response } from '../dspace-rest-v2/dspace-rest-v2-response.
 import { ErrorResponse, RestResponse, SubmissionSuccessResponse } from '../cache/response-cache.models';
 import { isEmpty, isNotEmpty, isNotNull } from '../../shared/empty.util';
 
-import { ConfigObject } from '../shared/config/config.model';
+import { ConfigObject } from '../config/models/config.model';
 import { BaseResponseParsingService } from '../data/base-response-parsing.service';
 import { GLOBAL_CONFIG } from '../../../config';
 import { GlobalConfig } from '../../../config/global-config.interface';

src/app/shared/form/builder/ds-dynamic-form-ui/models/dynamic-group/dynamic-group.component.spec.ts

@@ -12,7 +12,7 @@ import { NgbModule } from '@ng-bootstrap/ng-bootstrap';
 
 import { DsDynamicGroupComponent } from './dynamic-group.components';
 import { DynamicGroupModel, DynamicGroupModelConfig } from './dynamic-group.model';
-import { FormRowModel, SubmissionFormsModel } from '../../../../../../core/shared/config/config-submission-forms.model';
+import { FormRowModel, SubmissionFormsModel } from '../../../../../../core/config/models/config-submission-forms.model';
 import { FormFieldModel } from '../../../models/form-field.model';
 import { FormBuilderService } from '../../../form-builder.service';
 import { FormService } from '../../../../form.service';

src/app/shared/form/builder/ds-dynamic-form-ui/models/dynamic-group/dynamic-group.components.ts

@@ -16,7 +16,7 @@ import { isEqual } from 'lodash';
 
 import { DynamicGroupModel, PLACEHOLDER_PARENT_METADATA } from './dynamic-group.model';
 import { FormBuilderService } from '../../../form-builder.service';
-import { SubmissionFormsModel } from '../../../../../../core/shared/config/config-submission-forms.model';
+import { SubmissionFormsModel } from '../../../../../../core/config/models/config-submission-forms.model';
 import { FormService } from '../../../../form.service';
 import { FormComponent } from '../../../../form.component';
 import { Chips } from '../../../../../chips/models/chips.model';

src/app/shared/form/builder/ds-dynamic-form-ui/models/dynamic-group/dynamic-group.model.ts

@@ -1,5 +1,5 @@
 import { DynamicFormControlLayout, serializable } from '@ng-dynamic-forms/core';
-import { FormRowModel } from '../../../../../../core/shared/config/config-submission-forms.model';
+import { FormRowModel } from '../../../../../../core/config/models/config-submission-forms.model';
 import { DsDynamicInputModel, DsDynamicInputModelConfig } from '../ds-dynamic-input.model';
 import { AuthorityValue } from '../../../../../../core/integration/models/authority.value';
 import { isEmpty, isNull } from '../../../../../empty.util';

src/app/shared/form/builder/form-builder.service.spec.ts

@@ -41,7 +41,7 @@ import { DynamicTypeaheadModel } from './ds-dynamic-form-ui/models/typeahead/dyn
 import { DynamicListRadioGroupModel } from './ds-dynamic-form-ui/models/list/dynamic-list-radio-group.model';
 import { AuthorityOptions } from '../../../core/integration/models/authority-options.model';
 import { FormFieldModel } from './models/form-field.model';
-import { FormRowModel, SubmissionFormsModel } from '../../../core/shared/config/config-submission-forms.model';
+import { FormRowModel, SubmissionFormsModel } from '../../../core/config/models/config-submission-forms.model';
 import { FormBuilderService } from './form-builder.service';
 import { DynamicRowGroupModel } from './ds-dynamic-form-ui/models/ds-dynamic-row-group-model';
 import { DsDynamicInputModel } from './ds-dynamic-form-ui/models/ds-dynamic-input.model';
@@ -373,7 +373,7 @@ describe('FormBuilderService test suite', () => {
       _links: {
         self: 'testFormConfiguration.url'
       }
-    }
+    } as any;
   });
 
   beforeEach(inject([FormBuilderService], (formService: FormBuilderService) => service = formService));

src/app/shared/form/builder/form-builder.service.ts

@@ -17,7 +17,7 @@ import { isObject, isString, mergeWith } from 'lodash';
 
 import { hasValue, isEmpty, isNotEmpty, isNotNull, isNotUndefined, isNull } from '../../empty.util';
 import { DynamicQualdropModel } from './ds-dynamic-form-ui/models/ds-dynamic-qualdrop.model';
-import { SubmissionFormsModel } from '../../../core/shared/config/config-submission-forms.model';
+import { SubmissionFormsModel } from '../../../core/config/models/config-submission-forms.model';
 import {
   DYNAMIC_FORM_CONTROL_TYPE_RELATION_GROUP,
   DynamicGroupModel

src/app/shared/form/builder/models/form-field.model.ts

@@ -1,5 +1,5 @@
 import { autoserialize } from 'cerialize';
-import { FormRowModel } from '../../../../core/shared/config/config-submission-forms.model';
+import { FormRowModel } from '../../../../core/config/models/config-submission-forms.model';
 import { LanguageCode } from './form-field-language-value.model';
 import { FormFieldMetadataValueObject } from './form-field-metadata-value.model';
 

src/app/shared/form/builder/parsers/group-field-parser.ts

@@ -7,7 +7,7 @@ import {
   PLACEHOLDER_PARENT_METADATA
 } from '../ds-dynamic-form-ui/models/dynamic-group/dynamic-group.model';
 import { isNotEmpty } from '../../../empty.util';
-import { FormRowModel } from '../../../../core/shared/config/config-submission-forms.model';
+import { FormRowModel } from '../../../../core/config/models/config-submission-forms.model';
 
 export class GroupFieldParser extends FieldParser {
 

src/app/shared/form/builder/parsers/row-parser.spec.ts

@@ -1,5 +1,5 @@
 import { FormFieldModel } from '../models/form-field.model';
-import { FormRowModel } from '../../../../core/shared/config/config-submission-forms.model';
+import { FormRowModel } from '../../../../core/config/models/config-submission-forms.model';
 import { RowParser } from './row-parser';
 import { DynamicRowGroupModel } from '../ds-dynamic-form-ui/models/ds-dynamic-row-group-model';
 import { DynamicRowArrayModel } from '../ds-dynamic-form-ui/models/ds-dynamic-row-array-model';

src/app/submission/edit/submission-edit.component.ts

@@ -5,7 +5,7 @@ import { Subscription } from 'rxjs/Subscription';
 
 import { WorkspaceitemSectionsObject } from '../../core/submission/models/workspaceitem-sections.model';
 import { hasValue, isEmpty, isNotNull } from '../../shared/empty.util';
-import { SubmissionDefinitionsModel } from '../../core/shared/config/config-submission-definitions.model';
+import { SubmissionDefinitionsModel } from '../../core/config/models/config-submission-definitions.model';
 import { SubmissionService } from '../submission.service';
 import { NotificationsService } from '../../shared/notifications/notifications.service';
 import { TranslateService } from '@ngx-translate/core';

src/app/submission/form/submission-form.component.ts

@@ -2,7 +2,7 @@ import { ChangeDetectorRef, Component, Input, OnChanges, OnDestroy, SimpleChange
 import { hasValue, isNotEmpty } from '../../shared/empty.util';
 import { SubmissionObjectEntry } from '../objects/submission-objects.reducer';
 import { WorkspaceitemSectionsObject } from '../../core/submission/models/workspaceitem-sections.model';
-import { SubmissionDefinitionsModel } from '../../core/shared/config/config-submission-definitions.model';
+import { SubmissionDefinitionsModel } from '../../core/config/models/config-submission-definitions.model';
 import { Workspaceitem } from '../../core/submission/models/workspaceitem.model';
 import { SubmissionService } from '../submission.service';
 import { Subscription } from 'rxjs/Subscription';

src/app/submission/objects/submission-objects.actions.ts

@@ -8,7 +8,7 @@ import {
   WorkspaceitemSectionsObject
 } from '../../core/submission/models/workspaceitem-sections.model';
 import { SubmissionObject } from '../../core/submission/models/submission-object.model';
-import { SubmissionDefinitionsModel } from '../../core/shared/config/config-submission-definitions.model';
+import { SubmissionDefinitionsModel } from '../../core/config/models/config-submission-definitions.model';
 import { SectionsType } from '../sections/sections-type';
 
 /**

src/app/submission/objects/submission-objects.effects.ts

@@ -39,7 +39,7 @@ import { SubmissionObject } from '../../core/submission/models/submission-object
 import { TranslateService } from '@ngx-translate/core';
 import { SubmissionState } from '../submission.reducers';
 import { SubmissionObjectEntry } from './submission-objects.reducer';
-import { SubmissionSectionModel } from '../../core/shared/config/config-submission-section.model';
+import { SubmissionSectionModel } from '../../core/config/models/config-submission-section.model';
 import parseSectionErrors from '../utils/parseSectionErrors';
 import { WorkspaceitemSectionsObject } from '../../core/submission/models/workspaceitem-sections.model';
 

src/app/submission/sections/container/section-container.component.spec.ts

@@ -30,9 +30,7 @@ import { ScrollToService } from '@nicky-lenaers/ngx-scroll-to';
 describe('SectionContainerComponent test suite', () => {
 
   let testComp: TestComponent;
-  let sectionContainerComponent: SectionContainerComponent;
   let testFixture: ComponentFixture<TestComponent>;
-  let sectionContainerComponentComponentFixture: ComponentFixture<SectionContainerComponent>;
   let html;
 
   const config = {

src/app/submission/sections/form/section-form.component.ts

@@ -14,7 +14,7 @@ import { SubmissionFormsConfigService } from '../../../core/config/submission-fo
 import { hasValue, isNotEmpty, isUndefined } from '../../../shared/empty.util';
 import { ConfigData } from '../../../core/config/config-data';
 import { JsonPatchOperationPathCombiner } from '../../../core/json-patch/builder/json-patch-operation-path-combiner';
-import { SubmissionFormsModel } from '../../../core/shared/config/config-submission-forms.model';
+import { SubmissionFormsModel } from '../../../core/config/models/config-submission-forms.model';
 import { SubmissionSectionError, SubmissionSectionObject } from '../../objects/submission-objects.reducer';
 import { FormFieldPreviousValueObject } from '../../../shared/form/builder/models/form-field-previous-value-object';
 import { WorkspaceitemSectionDataType } from '../../../core/submission/models/workspaceitem-sections.model';

src/app/submission/sections/upload/file/edit/file-edit.component.ts

@@ -29,9 +29,9 @@ import {
 } from './files-edit.model';
 import { POLICY_DEFAULT_WITH_LIST } from '../../section-upload.component';
 import { isNotEmpty, isNotUndefined } from '../../../../../shared/empty.util';
-import { SubmissionFormsModel } from '../../../../../core/shared/config/config-submission-forms.model';
+import { SubmissionFormsModel } from '../../../../../core/config/models/config-submission-forms.model';
 import { FormFieldModel } from '../../../../../shared/form/builder/models/form-field.model';
-import { AccessConditionOption } from '../../../../../core/shared/config/config-access-condition-option.model';
+import { AccessConditionOption } from '../../../../../core/config/models/config-access-condition-option.model';
 import { SubmissionService } from '../../../../submission.service';
 
 @Component({

src/app/submission/sections/upload/file/file.component.ts

@@ -9,7 +9,7 @@ import { JsonPatchOperationsBuilder } from '../../../../core/json-patch/builder/
 import { JsonPatchOperationPathCombiner } from '../../../../core/json-patch/builder/json-patch-operation-path-combiner';
 
 import { WorkspaceitemSectionUploadFileObject } from '../../../../core/submission/models/workspaceitem-section-upload-file.model';
-import { SubmissionFormsModel } from '../../../../core/shared/config/config-submission-forms.model';
+import { SubmissionFormsModel } from '../../../../core/config/models/config-submission-forms.model';
 import { deleteProperty } from '../../../../shared/object.util';
 import { dateToGMTString } from '../../../../shared/date.util';
 import { JsonPatchOperationsService } from '../../../../core/json-patch/json-patch-operations.service';

src/app/submission/sections/upload/section-upload.component.ts

@@ -8,8 +8,8 @@ import { SectionUploadService } from './section-upload.service';
 import { CollectionDataService } from '../../../core/data/collection-data.service';
 import { GroupEpersonService } from '../../../core/eperson/group-eperson.service';
 import { SubmissionUploadsConfigService } from '../../../core/config/submission-uploads-config.service';
-import { SubmissionUploadsModel } from '../../../core/shared/config/config-submission-uploads.model';
-import { SubmissionFormsModel } from '../../../core/shared/config/config-submission-forms.model';
+import { SubmissionUploadsModel } from '../../../core/config/models/config-submission-uploads.model';
+import { SubmissionFormsModel } from '../../../core/config/models/config-submission-forms.model';
 import { SectionsType } from '../sections-type';
 import { renderSectionFor } from '../sections-decorator';
 import { SectionDataObject } from '../models/section-data.model';
@@ -22,7 +22,7 @@ import { SubmissionService } from '../../submission.service';
 import { Collection } from '../../../core/shared/collection.model';
 import { PaginatedList } from '../../../core/data/paginated-list';
 import { ResourcePolicy } from '../../../core/shared/resource-policy.model';
-import { AccessConditionOption } from '../../../core/shared/config/config-access-condition-option.model';
+import { AccessConditionOption } from '../../../core/config/models/config-access-condition-option.model';
 
 export const POLICY_DEFAULT_NO_LIST = 1; // Banner1
 export const POLICY_DEFAULT_WITH_LIST = 2; // Banner2

src/app/submission/submission.service.ts

@@ -35,7 +35,7 @@ import { SectionsType } from './sections/sections-type';
 import { TranslateService } from '@ngx-translate/core';
 import { NotificationsService } from '../shared/notifications/notifications.service';
 import { ScrollToService } from '@nicky-lenaers/ngx-scroll-to';
-import { SubmissionDefinitionsModel } from '../core/shared/config/config-submission-definitions.model';
+import { SubmissionDefinitionsModel } from '../core/config/models/config-submission-definitions.model';
 import { WorkspaceitemSectionsObject } from '../core/submission/models/workspaceitem-sections.model';
 
 @Injectable()

src/app/submission/submit/submission-submit.component.ts

@@ -4,7 +4,7 @@ import { Router } from '@angular/router';
 import { Subscription } from 'rxjs/Subscription';
 
 import { hasValue, isEmpty, isNotNull } from '../../shared/empty.util';
-import { SubmissionDefinitionsModel } from '../../core/shared/config/config-submission-definitions.model';
+import { SubmissionDefinitionsModel } from '../../core/config/models/config-submission-definitions.model';
 import { TranslateService } from '@ngx-translate/core';
 import { NotificationsService } from '../../shared/notifications/notifications.service';
 import { SubmissionService } from '../submission.service';