hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 01:54:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1984 from tdonohue/fix_1983

Browse Source 
Fix email validation regex to use email validation regex from HTML5 specs
This commit is contained in:
Art Lowel
2022-12-08 19:29:59 +01:00
committed by GitHub
parent 23279017ca 1215a7ee7a
commit ee6ab3e3b2
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/register-email-form/register-email-form.component.spec.ts
View File

@@ -95,6 +95,10 @@ describe('RegisterEmailComponent', () => {
comp.form.patchValue({email: 'valid@email.org'}); comp.form.patchValue({email: 'valid@email.org'});
expect(comp.form.invalid).toBeFalse(); expect(comp.form.invalid).toBeFalse();
}); });
it('should be valid when uppercase letters are used', () => {
comp.form.patchValue({email: 'VALID@email.org'});
expect(comp.form.invalid).toBeFalse();
});
}); });
describe('register', () => { describe('register', () => {
it('should send a registration to the service and on success display a message and return to home', () => { it('should send a registration to the service and on success display a message and return to home', () => {

4
src/app/register-email-form/register-email-form.component.ts
View File

@@ -79,7 +79,9 @@ export class RegisterEmailFormComponent implements OnInit {
this.form = this.formBuilder.group({ this.form = this.formBuilder.group({
email: new FormControl('', { email: new FormControl('', {
validators: [Validators.required, validators: [Validators.required,
Validators.pattern('^[a-z0-9._%+-]+@[a-z0-9.-]+\.[a-z]{2,4}$') // Regex pattern borrowed from HTML5 specs for a valid email address:
// https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address
Validators.pattern('^[a-zA-Z0-9.!#$%&\'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$')
], ],
}) })
}); });