From f00664b281ee44ca83d18080a35e8bf9f9312ede Mon Sep 17 00:00:00 2001
From: Jens Vannerum <jens.vannerum@atmire.com>
Date: Thu, 17 Mar 2022 11:49:53 +0100
Subject: [PATCH] 88507 Improved test - Refactored the test for the download
 button - This way we're checking the actual href on the button, not the
 component's property

---
 .../item-edit-bitstream/item-edit-bitstream.component.html | 3 ++-
 .../item-edit-bitstream.component.spec.ts                  | 7 +++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream/item-edit-bitstream.component.html b/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream/item-edit-bitstream.component.html
index d2f2f9d99d..bbfbd5b304 100644
--- a/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream/item-edit-bitstream.component.html
+++ b/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream/item-edit-bitstream.component.html
@@ -20,7 +20,8 @@
       <div class="btn-group relationship-action-buttons">
         <a *ngIf="bitstreamDownloadUrl != null" [href]="bitstreamDownloadUrl"
                 class="btn btn-outline-primary btn-sm"
-                title="{{'item.edit.bitstreams.edit.buttons.download' | translate}}">
+                title="{{'item.edit.bitstreams.edit.buttons.download' | translate}}"
+                data-test="download-button">
           <i class="fas fa-download fa-fw"></i>
         </a>
         <button [routerLink]="['/bitstreams/', bitstream.id, 'edit']" class="btn btn-outline-primary btn-sm"
diff --git a/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream/item-edit-bitstream.component.spec.ts b/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream/item-edit-bitstream.component.spec.ts
index b201cb1f88..ddc807a71f 100644
--- a/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream/item-edit-bitstream.component.spec.ts
+++ b/src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream/item-edit-bitstream.component.spec.ts
@@ -11,6 +11,7 @@ import { ResponsiveTableSizes } from '../../../../shared/responsive-table-sizes/
 import { ResponsiveColumnSizes } from '../../../../shared/responsive-table-sizes/responsive-column-sizes';
 import { createSuccessfulRemoteDataObject$ } from '../../../../shared/remote-data.utils';
 import { getBitstreamDownloadRoute } from '../../../../app-routing-paths';
+import { By } from '@angular/platform-browser';
 
 let comp: ItemEditBitstreamComponent;
 let fixture: ComponentFixture<ItemEditBitstreamComponent>;
@@ -119,8 +120,10 @@ describe('ItemEditBitstreamComponent', () => {
   });
 
   describe('when the component loads', () => {
-    it('should contain bitstreamDownloadUrl with the correct url to the bitstream\'s download page', () => {
-      expect(comp.bitstreamDownloadUrl).toEqual(getBitstreamDownloadRoute(bitstream));
+    it('the download button should contain the link to the bitstreams download page', () => {
+      fixture.detectChanges();
+      const downloadBtnHref = fixture.debugElement.query(By.css('[data-test="download-button"]')).nativeElement.getAttribute('href');
+      expect(downloadBtnHref).toEqual(comp.bitstreamDownloadUrl);
     });
   });
 });