From f1686f3de1b7c8f853a5509573fbd5ab61540ea8 Mon Sep 17 00:00:00 2001 From: lotte Date: Mon, 11 Mar 2019 12:40:29 +0100 Subject: [PATCH] applied feedback --- src/app/+search-page/search-page.module.ts | 9 +++------ .../create-collection-parent-selector.component.ts | 5 +++++ .../create-community-parent-selector.component.ts | 7 +++++++ .../create-item-parent-selector.component.ts | 5 +++++ .../dso-selector-modal-wrapper.component.ts | 4 ++++ .../edit-collection-selector.component.ts | 5 +++++ .../edit-community-selector.component.ts | 5 +++++ .../edit-item-selector/edit-item-selector.component.ts | 5 +++++ 8 files changed, 39 insertions(+), 6 deletions(-) diff --git a/src/app/+search-page/search-page.module.ts b/src/app/+search-page/search-page.module.ts index 4cd0c9428b..505065e44c 100644 --- a/src/app/+search-page/search-page.module.ts +++ b/src/app/+search-page/search-page.module.ts @@ -45,9 +45,6 @@ const effects = [ SearchResultsComponent, SearchSidebarComponent, SearchSettingsComponent, - // ItemSearchResultListElementComponent, - // CollectionSearchResultListElementComponent, - // CommunitySearchResultListElementComponent, ItemSearchResultGridElementComponent, CollectionSearchResultGridElementComponent, CommunitySearchResultGridElementComponent, @@ -68,9 +65,9 @@ const effects = [ SearchConfigurationService ], entryComponents: [ - // ItemSearchResultListElementComponent, - // CollectionSearchResultListElementComponent, - // CommunitySearchResultListElementComponent, + ItemSearchResultListElementComponent, + CollectionSearchResultListElementComponent, + CommunitySearchResultListElementComponent, ItemSearchResultGridElementComponent, CollectionSearchResultGridElementComponent, CommunitySearchResultGridElementComponent, diff --git a/src/app/shared/dso-selector/modal-wrappers/create-collection-parent-selector/create-collection-parent-selector.component.ts b/src/app/shared/dso-selector/modal-wrappers/create-collection-parent-selector/create-collection-parent-selector.component.ts index 20968456b3..1e129c0dbe 100644 --- a/src/app/shared/dso-selector/modal-wrappers/create-collection-parent-selector/create-collection-parent-selector.component.ts +++ b/src/app/shared/dso-selector/modal-wrappers/create-collection-parent-selector/create-collection-parent-selector.component.ts @@ -14,6 +14,11 @@ import { SelectorActionType } from '../dso-selector-modal-wrapper.component'; +/** + * Component to wrap a list of existing communities inside a modal + * Used to choose a community from to create a new collection in + */ + @Component({ selector: 'ds-create-collection-parent-selector', templateUrl: '../dso-selector-modal-wrapper.component.html', diff --git a/src/app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component.ts b/src/app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component.ts index b8cc28b9fc..914dc7582f 100644 --- a/src/app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component.ts +++ b/src/app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component.ts @@ -13,6 +13,13 @@ import { SelectorActionType } from '../dso-selector-modal-wrapper.component'; +/** + * Component to wrap a button - for top communities - + * and a list of parent communities - for sub communities + * inside a modal + * Used to create a new community + */ + @Component({ selector: 'ds-create-community-parent-selector', styleUrls: ['./create-community-parent-selector.component.scss'], diff --git a/src/app/shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component.ts b/src/app/shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component.ts index 5dc6e4fe78..dac5888bf7 100644 --- a/src/app/shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component.ts +++ b/src/app/shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component.ts @@ -14,6 +14,11 @@ import { SelectorActionType } from '../dso-selector-modal-wrapper.component'; +/** + * Component to wrap a list of existing collections inside a modal + * Used to choose a collection from to create a new item in + */ + @Component({ selector: 'ds-create-item-parent-selector', // styleUrls: ['./create-item-parent-selector.component.scss'], diff --git a/src/app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.ts b/src/app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.ts index 8414f00830..351a92302c 100644 --- a/src/app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.ts +++ b/src/app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.ts @@ -12,6 +12,10 @@ export enum SelectorActionType { EDIT = 'edit' } +/** + * Abstract base class that represents a wrapper for modal content used to select a DSpace Object + */ + @Injectable() export abstract class DSOSelectorModalWrapperComponent implements OnInit { /** diff --git a/src/app/shared/dso-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component.ts b/src/app/shared/dso-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component.ts index dab5b8eea3..79660b9589 100644 --- a/src/app/shared/dso-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component.ts +++ b/src/app/shared/dso-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component.ts @@ -9,6 +9,11 @@ import { SelectorActionType } from '../dso-selector-modal-wrapper.component'; +/** + * Component to wrap a list of existing collections inside a modal + * Used to choose a collection from to edit + */ + @Component({ selector: 'ds-edit-collection-selector', templateUrl: '../dso-selector-modal-wrapper.component.html', diff --git a/src/app/shared/dso-selector/modal-wrappers/edit-community-selector/edit-community-selector.component.ts b/src/app/shared/dso-selector/modal-wrappers/edit-community-selector/edit-community-selector.component.ts index ce688d17ae..6b9efc1ff4 100644 --- a/src/app/shared/dso-selector/modal-wrappers/edit-community-selector/edit-community-selector.component.ts +++ b/src/app/shared/dso-selector/modal-wrappers/edit-community-selector/edit-community-selector.component.ts @@ -9,6 +9,11 @@ import { SelectorActionType } from '../dso-selector-modal-wrapper.component'; +/** + * Component to wrap a list of existing communities inside a modal + * Used to choose a community from to edit + */ + @Component({ selector: 'ds-edit-community-selector', templateUrl: '../dso-selector-modal-wrapper.component.html', diff --git a/src/app/shared/dso-selector/modal-wrappers/edit-item-selector/edit-item-selector.component.ts b/src/app/shared/dso-selector/modal-wrappers/edit-item-selector/edit-item-selector.component.ts index e14be10435..9182df8045 100644 --- a/src/app/shared/dso-selector/modal-wrappers/edit-item-selector/edit-item-selector.component.ts +++ b/src/app/shared/dso-selector/modal-wrappers/edit-item-selector/edit-item-selector.component.ts @@ -15,6 +15,11 @@ import { SelectorActionType } from '../dso-selector-modal-wrapper.component'; +/** + * Component to wrap a list of existing items inside a modal + * Used to choose an item from to edit + */ + @Component({ selector: 'ds-edit-item-selector', templateUrl: '../dso-selector-modal-wrapper.component.html',