93803: Ensure data services are called *DataService

This commit is contained in:
Yura Bondarenko
2022-08-24 18:56:08 +02:00
parent 05b131edb9
commit fbaab69121
102 changed files with 296 additions and 295 deletions

View File

@@ -16,7 +16,7 @@ import { CommunityDataService } from '../../core/data/community-data.service';
import { AuthService } from '../../core/auth/auth.service'; import { AuthService } from '../../core/auth/auth.service';
import { RequestService } from '../../core/data/request.service'; import { RequestService } from '../../core/data/request.service';
import { ObjectCacheService } from '../../core/cache/object-cache.service'; import { ObjectCacheService } from '../../core/cache/object-cache.service';
import { EntityTypeService } from '../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../core/data/entity-type-data.service';
import { ItemType } from '../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../core/shared/item-relationships/item-type.model';
import { MetadataValue } from '../../core/shared/metadata.models'; import { MetadataValue } from '../../core/shared/metadata.models';
import { getFirstSucceededRemoteListPayload } from '../../core/shared/operators'; import { getFirstSucceededRemoteListPayload } from '../../core/shared/operators';
@@ -61,7 +61,7 @@ export class CollectionFormComponent extends ComColFormComponent<Collection> imp
protected dsoService: CommunityDataService, protected dsoService: CommunityDataService,
protected requestService: RequestService, protected requestService: RequestService,
protected objectCache: ObjectCacheService, protected objectCache: ObjectCacheService,
protected entityTypeService: EntityTypeService) { protected entityTypeService: EntityTypeDataService) {
super(formService, translate, notificationsService, authService, requestService, objectCache); super(formService, translate, notificationsService, authService, requestService, objectCache);
} }

View File

@@ -1,7 +1,7 @@
import { getTestScheduler } from 'jasmine-marbles'; import { getTestScheduler } from 'jasmine-marbles';
import { TestScheduler } from 'rxjs/testing'; import { TestScheduler } from 'rxjs/testing';
import { getMockRequestService } from '../../shared/mocks/request.service.mock'; import { getMockRequestService } from '../../shared/mocks/request.service.mock';
import { ConfigService } from './config.service'; import { ConfigDataService } from './config-data.service';
import { RequestService } from '../data/request.service'; import { RequestService } from '../data/request.service';
import { GetRequest } from '../data/request.models'; import { GetRequest } from '../data/request.models';
import { HALEndpointService } from '../shared/hal-endpoint.service'; import { HALEndpointService } from '../shared/hal-endpoint.service';
@@ -14,7 +14,7 @@ import { ObjectCacheService } from '../cache/object-cache.service';
const LINK_NAME = 'test'; const LINK_NAME = 'test';
const BROWSE = 'search/findByCollection'; const BROWSE = 'search/findByCollection';
class TestService extends ConfigService { class TestService extends ConfigDataService {
protected linkPath = LINK_NAME; protected linkPath = LINK_NAME;
protected browseEndpoint = BROWSE; protected browseEndpoint = BROWSE;
@@ -28,7 +28,7 @@ class TestService extends ConfigService {
} }
} }
describe('ConfigService', () => { describe('ConfigDataService', () => {
let scheduler: TestScheduler; let scheduler: TestScheduler;
let service: TestService; let service: TestService;
let requestService: RequestService; let requestService: RequestService;

View File

@@ -6,7 +6,7 @@ import { getFirstCompletedRemoteData } from '../shared/operators';
import { map } from 'rxjs/operators'; import { map } from 'rxjs/operators';
import { BaseDataService } from '../data/base/base-data.service'; import { BaseDataService } from '../data/base/base-data.service';
export abstract class ConfigService extends BaseDataService<ConfigObject> { export abstract class ConfigDataService extends BaseDataService<ConfigObject> {
public findByHref(href: string, useCachedVersionIfAvailable = true, reRequestOnStale = true, ...linksToFollow: FollowLinkConfig<ConfigObject>[]): Observable<RemoteData<ConfigObject>> { public findByHref(href: string, useCachedVersionIfAvailable = true, reRequestOnStale = true, ...linksToFollow: FollowLinkConfig<ConfigObject>[]): Observable<RemoteData<ConfigObject>> {
return super.findByHref(href, useCachedVersionIfAvailable, reRequestOnStale, ...linksToFollow).pipe( return super.findByHref(href, useCachedVersionIfAvailable, reRequestOnStale, ...linksToFollow).pipe(
getFirstCompletedRemoteData(), getFirstCompletedRemoteData(),

View File

@@ -1,20 +1,15 @@
import { Injectable } from '@angular/core'; import { Injectable } from '@angular/core';
import { ConfigService } from './config.service'; import { ConfigDataService } from './config-data.service';
import { RequestService } from '../data/request.service'; import { RequestService } from '../data/request.service';
import { HALEndpointService } from '../shared/hal-endpoint.service'; import { HALEndpointService } from '../shared/hal-endpoint.service';
import { ObjectCacheService } from '../cache/object-cache.service'; import { ObjectCacheService } from '../cache/object-cache.service';
import { SUBMISSION_ACCESSES_TYPE } from './models/config-type'; import { SUBMISSION_ACCESSES_TYPE } from './models/config-type';
import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service'; import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service';
import { Store } from '@ngrx/store';
import { NotificationsService } from '../../shared/notifications/notifications.service';
import { HttpClient } from '@angular/common/http';
import { DefaultChangeAnalyzer } from '../data/default-change-analyzer.service';
import { ConfigObject } from './models/config.model'; import { ConfigObject } from './models/config.model';
import { SubmissionAccessesModel } from './models/config-submission-accesses.model'; import { SubmissionAccessesModel } from './models/config-submission-accesses.model';
import { RemoteData } from '../data/remote-data'; import { RemoteData } from '../data/remote-data';
import { Observable } from 'rxjs'; import { Observable } from 'rxjs';
import { FollowLinkConfig } from '../../shared/utils/follow-link-config.model'; import { FollowLinkConfig } from '../../shared/utils/follow-link-config.model';
import { CoreState } from '../core-state.model';
import { dataService } from '../data/base/data-service.decorator'; import { dataService } from '../data/base/data-service.decorator';
/** /**
@@ -22,7 +17,7 @@ import { dataService } from '../data/base/data-service.decorator';
*/ */
@Injectable() @Injectable()
@dataService(SUBMISSION_ACCESSES_TYPE) @dataService(SUBMISSION_ACCESSES_TYPE)
export class SubmissionAccessesConfigService extends ConfigService { export class SubmissionAccessesConfigDataService extends ConfigDataService {
constructor( constructor(
protected requestService: RequestService, protected requestService: RequestService,
protected rdbService: RemoteDataBuildService, protected rdbService: RemoteDataBuildService,

View File

@@ -1,6 +1,5 @@
import { Injectable } from '@angular/core'; import { Injectable } from '@angular/core';
import { ConfigDataService } from './config-data.service';
import { ConfigService } from './config.service';
import { RequestService } from '../data/request.service'; import { RequestService } from '../data/request.service';
import { HALEndpointService } from '../shared/hal-endpoint.service'; import { HALEndpointService } from '../shared/hal-endpoint.service';
import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service'; import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service';
@@ -15,7 +14,7 @@ import { dataService } from '../data/base/data-service.decorator';
@Injectable() @Injectable()
@dataService(SUBMISSION_FORMS_TYPE) @dataService(SUBMISSION_FORMS_TYPE)
export class SubmissionFormsConfigService extends ConfigService { export class SubmissionFormsConfigDataService extends ConfigDataService {
constructor( constructor(
protected requestService: RequestService, protected requestService: RequestService,
protected rdbService: RemoteDataBuildService, protected rdbService: RemoteDataBuildService,

View File

@@ -1,5 +1,5 @@
import { Injectable } from '@angular/core'; import { Injectable } from '@angular/core';
import { ConfigService } from './config.service'; import { ConfigDataService } from './config-data.service';
import { RequestService } from '../data/request.service'; import { RequestService } from '../data/request.service';
import { HALEndpointService } from '../shared/hal-endpoint.service'; import { HALEndpointService } from '../shared/hal-endpoint.service';
import { ObjectCacheService } from '../cache/object-cache.service'; import { ObjectCacheService } from '../cache/object-cache.service';
@@ -17,7 +17,7 @@ import { dataService } from '../data/base/data-service.decorator';
*/ */
@Injectable() @Injectable()
@dataService(SUBMISSION_UPLOADS_TYPE) @dataService(SUBMISSION_UPLOADS_TYPE)
export class SubmissionUploadsConfigService extends ConfigService { export class SubmissionUploadsConfigDataService extends ConfigDataService {
constructor( constructor(
protected requestService: RequestService, protected requestService: RequestService,
protected rdbService: RemoteDataBuildService, protected rdbService: RemoteDataBuildService,

View File

@@ -36,7 +36,7 @@ import { SubmissionDefinitionsModel } from './config/models/config-submission-de
import { SubmissionFormsModel } from './config/models/config-submission-forms.model'; import { SubmissionFormsModel } from './config/models/config-submission-forms.model';
import { SubmissionSectionModel } from './config/models/config-submission-section.model'; import { SubmissionSectionModel } from './config/models/config-submission-section.model';
import { SubmissionUploadsModel } from './config/models/config-submission-uploads.model'; import { SubmissionUploadsModel } from './config/models/config-submission-uploads.model';
import { SubmissionFormsConfigService } from './config/submission-forms-config.service'; import { SubmissionFormsConfigDataService } from './config/submission-forms-config-data.service';
import { coreEffects } from './core.effects'; import { coreEffects } from './core.effects';
import { coreReducers } from './core.reducers'; import { coreReducers } from './core.reducers';
import { BitstreamFormatDataService } from './data/bitstream-format-data.service'; import { BitstreamFormatDataService } from './data/bitstream-format-data.service';
@@ -49,8 +49,8 @@ import { DSOChangeAnalyzer } from './data/dso-change-analyzer.service';
import { DSOResponseParsingService } from './data/dso-response-parsing.service'; import { DSOResponseParsingService } from './data/dso-response-parsing.service';
import { DSpaceObjectDataService } from './data/dspace-object-data.service'; import { DSpaceObjectDataService } from './data/dspace-object-data.service';
import { EndpointMapResponseParsingService } from './data/endpoint-map-response-parsing.service'; import { EndpointMapResponseParsingService } from './data/endpoint-map-response-parsing.service';
import { EntityTypeService } from './data/entity-type.service'; import { EntityTypeDataService } from './data/entity-type-data.service';
import { ExternalSourceService } from './data/external-source.service'; import { ExternalSourceDataService } from './data/external-source-data.service';
import { FacetConfigResponseParsingService } from './data/facet-config-response-parsing.service'; import { FacetConfigResponseParsingService } from './data/facet-config-response-parsing.service';
import { FacetValueResponseParsingService } from './data/facet-value-response-parsing.service'; import { FacetValueResponseParsingService } from './data/facet-value-response-parsing.service';
import { FilteredDiscoveryPageResponseParsingService } from './data/filtered-discovery-page-response-parsing.service'; import { FilteredDiscoveryPageResponseParsingService } from './data/filtered-discovery-page-response-parsing.service';
@@ -58,9 +58,9 @@ import { ItemDataService } from './data/item-data.service';
import { LookupRelationService } from './data/lookup-relation.service'; import { LookupRelationService } from './data/lookup-relation.service';
import { MyDSpaceResponseParsingService } from './data/mydspace-response-parsing.service'; import { MyDSpaceResponseParsingService } from './data/mydspace-response-parsing.service';
import { ObjectUpdatesService } from './data/object-updates/object-updates.service'; import { ObjectUpdatesService } from './data/object-updates/object-updates.service';
import { RelationshipTypeService } from './data/relationship-type.service'; import { RelationshipTypeDataService } from './data/relationship-type-data.service';
import { RelationshipService } from './data/relationship.service'; import { RelationshipDataService } from './data/relationship-data.service';
import { ResourcePolicyService } from './resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from './resource-policy/resource-policy-data.service';
import { SearchResponseParsingService } from './data/search-response-parsing.service'; import { SearchResponseParsingService } from './data/search-response-parsing.service';
import { SiteDataService } from './data/site-data.service'; import { SiteDataService } from './data/site-data.service';
import { DspaceRestService } from './dspace-rest/dspace-rest.service'; import { DspaceRestService } from './dspace-rest/dspace-rest.service';
@@ -170,10 +170,10 @@ import { SubmissionAccessesModel } from './config/models/config-submission-acces
import { AccessStatusObject } from '../shared/object-list/access-status-badge/access-status.model'; import { AccessStatusObject } from '../shared/object-list/access-status-badge/access-status.model';
import { AccessStatusDataService } from './data/access-status-data.service'; import { AccessStatusDataService } from './data/access-status-data.service';
import { LinkHeadService } from './services/link-head.service'; import { LinkHeadService } from './services/link-head.service';
import { ResearcherProfileService } from './profile/researcher-profile.service'; import { ResearcherProfileDataService } from './profile/researcher-profile-data.service';
import { ProfileClaimService } from '../profile-page/profile-claim/profile-claim.service'; import { ProfileClaimService } from '../profile-page/profile-claim/profile-claim.service';
import { ResearcherProfile } from './profile/model/researcher-profile.model'; import { ResearcherProfile } from './profile/model/researcher-profile.model';
import { OrcidQueueService } from './orcid/orcid-queue.service'; import { OrcidQueueDataService } from './orcid/orcid-queue-data.service';
import { OrcidHistoryDataService } from './orcid/orcid-history-data.service'; import { OrcidHistoryDataService } from './orcid/orcid-history-data.service';
import { OrcidQueue } from './orcid/model/orcid-queue.model'; import { OrcidQueue } from './orcid/model/orcid-queue.model';
import { OrcidHistory } from './orcid/model/orcid-history.model'; import { OrcidHistory } from './orcid/model/orcid-history.model';
@@ -225,7 +225,7 @@ const PROVIDERS = [
MetadataService, MetadataService,
ObjectCacheService, ObjectCacheService,
PaginationComponentOptions, PaginationComponentOptions,
ResourcePolicyService, ResourcePolicyDataService,
RegistryService, RegistryService,
BitstreamFormatDataService, BitstreamFormatDataService,
RemoteDataBuildService, RemoteDataBuildService,
@@ -240,7 +240,7 @@ const PROVIDERS = [
AccessStatusDataService, AccessStatusDataService,
SubmissionCcLicenseDataService, SubmissionCcLicenseDataService,
SubmissionCcLicenseUrlDataService, SubmissionCcLicenseUrlDataService,
SubmissionFormsConfigService, SubmissionFormsConfigDataService,
SubmissionRestService, SubmissionRestService,
SubmissionResponseParsingService, SubmissionResponseParsingService,
SubmissionJsonPatchOperationsService, SubmissionJsonPatchOperationsService,
@@ -261,7 +261,7 @@ const PROVIDERS = [
MenuService, MenuService,
ObjectUpdatesService, ObjectUpdatesService,
SearchService, SearchService,
RelationshipService, RelationshipDataService,
MyDSpaceGuard, MyDSpaceGuard,
RoleService, RoleService,
TaskResponseParsingService, TaskResponseParsingService,
@@ -269,7 +269,7 @@ const PROVIDERS = [
PoolTaskDataService, PoolTaskDataService,
BitstreamDataService, BitstreamDataService,
DsDynamicTypeBindRelationService, DsDynamicTypeBindRelationService,
EntityTypeService, EntityTypeDataService,
ContentSourceResponseParsingService, ContentSourceResponseParsingService,
ItemTemplateDataService, ItemTemplateDataService,
SearchService, SearchService,
@@ -278,8 +278,8 @@ const PROVIDERS = [
SearchFilterService, SearchFilterService,
SearchConfigurationService, SearchConfigurationService,
SelectableListService, SelectableListService,
RelationshipTypeService, RelationshipTypeDataService,
ExternalSourceService, ExternalSourceDataService,
LookupRelationService, LookupRelationService,
VersionDataService, VersionDataService,
VersionHistoryDataService, VersionHistoryDataService,
@@ -308,10 +308,10 @@ const PROVIDERS = [
SequenceService, SequenceService,
GroupDataService, GroupDataService,
FeedbackDataService, FeedbackDataService,
ResearcherProfileService, ResearcherProfileDataService,
ProfileClaimService, ProfileClaimService,
OrcidAuthService, OrcidAuthService,
OrcidQueueService, OrcidQueueDataService,
OrcidHistoryDataService, OrcidHistoryDataService,
]; ];

View File

@@ -25,7 +25,7 @@ import { getDSORoute } from '../../app-routing-paths';
const ID_ENDPOINT = 'pid'; const ID_ENDPOINT = 'pid';
const UUID_ENDPOINT = 'dso'; const UUID_ENDPOINT = 'dso';
class DsoByIdOrUUIDService extends IdentifiableDataService<DSpaceObject> { class DsoByIdOrUUIDDataService extends IdentifiableDataService<DSpaceObject> {
constructor( constructor(
protected requestService: RequestService, protected requestService: RequestService,
protected rdbService: RemoteDataBuildService, protected rdbService: RemoteDataBuildService,
@@ -58,7 +58,7 @@ class DsoByIdOrUUIDService extends IdentifiableDataService<DSpaceObject> {
@Injectable() @Injectable()
export class DsoRedirectService { export class DsoRedirectService {
private dataService: DsoByIdOrUUIDService; private dataService: DsoByIdOrUUIDDataService;
constructor( constructor(
protected requestService: RequestService, protected requestService: RequestService,
@@ -67,7 +67,7 @@ export class DsoRedirectService {
protected halService: HALEndpointService, protected halService: HALEndpointService,
private router: Router, private router: Router,
) { ) {
this.dataService = new DsoByIdOrUUIDService(requestService, rdbService, objectCache, halService); this.dataService = new DsoByIdOrUUIDDataService(requestService, rdbService, objectCache, halService);
} }
findByIdAndIDType(id: string, identifierType = IdentifierType.UUID): Observable<RemoteData<DSpaceObject>> { findByIdAndIDType(id: string, identifierType = IdentifierType.UUID): Observable<RemoteData<DSpaceObject>> {

View File

@@ -11,7 +11,7 @@ import { RelationshipType } from '../shared/item-relationships/relationship-type
import { PaginatedList } from './paginated-list.model'; import { PaginatedList } from './paginated-list.model';
import { ItemType } from '../shared/item-relationships/item-type.model'; import { ItemType } from '../shared/item-relationships/item-type.model';
import { getFirstSucceededRemoteData, getRemoteDataPayload } from '../shared/operators'; import { getFirstSucceededRemoteData, getRemoteDataPayload } from '../shared/operators';
import { RelationshipTypeService } from './relationship-type.service'; import { RelationshipTypeDataService } from './relationship-type-data.service';
import { FindListOptions } from './find-list-options.model'; import { FindListOptions } from './find-list-options.model';
import { BaseDataService } from './base/base-data.service'; import { BaseDataService } from './base/base-data.service';
import { SearchData, SearchDataImpl } from './base/search-data'; import { SearchData, SearchDataImpl } from './base/search-data';
@@ -21,7 +21,7 @@ import { FindAllData, FindAllDataImpl } from './base/find-all-data';
* Service handling all ItemType requests * Service handling all ItemType requests
*/ */
@Injectable() @Injectable()
export class EntityTypeService extends BaseDataService<ItemType> implements FindAllData<ItemType>, SearchData<ItemType> { export class EntityTypeDataService extends BaseDataService<ItemType> implements FindAllData<ItemType>, SearchData<ItemType> {
private findAllData: FindAllData<ItemType>; private findAllData: FindAllData<ItemType>;
private searchData: SearchDataImpl<ItemType>; private searchData: SearchDataImpl<ItemType>;
@@ -30,7 +30,7 @@ export class EntityTypeService extends BaseDataService<ItemType> implements Find
protected rdbService: RemoteDataBuildService, protected rdbService: RemoteDataBuildService,
protected objectCache: ObjectCacheService, protected objectCache: ObjectCacheService,
protected halService: HALEndpointService, protected halService: HALEndpointService,
protected relationshipTypeService: RelationshipTypeService, protected relationshipTypeService: RelationshipTypeDataService,
) { ) {
super('entitytypes', requestService, rdbService, objectCache, halService); super('entitytypes', requestService, rdbService, objectCache, halService);

View File

@@ -1,4 +1,4 @@
import { ExternalSourceService } from './external-source.service'; import { ExternalSourceDataService } from './external-source-data.service';
import { createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils';
import { createPaginatedList } from '../../shared/testing/utils.test'; import { createPaginatedList } from '../../shared/testing/utils.test';
import { ExternalSourceEntry } from '../shared/external-source-entry.model'; import { ExternalSourceEntry } from '../shared/external-source-entry.model';
@@ -6,7 +6,7 @@ import { of as observableOf } from 'rxjs';
import { GetRequest } from './request.models'; import { GetRequest } from './request.models';
describe('ExternalSourceService', () => { describe('ExternalSourceService', () => {
let service: ExternalSourceService; let service: ExternalSourceDataService;
let requestService; let requestService;
let rdbService; let rdbService;
@@ -50,7 +50,7 @@ describe('ExternalSourceService', () => {
halService = jasmine.createSpyObj('halService', { halService = jasmine.createSpyObj('halService', {
getEndpoint: observableOf('external-sources-REST-endpoint'), getEndpoint: observableOf('external-sources-REST-endpoint'),
}); });
service = new ExternalSourceService(requestService, rdbService, undefined, halService); service = new ExternalSourceDataService(requestService, rdbService, undefined, halService);
} }
beforeEach(() => { beforeEach(() => {

View File

@@ -20,7 +20,7 @@ import { SearchData, SearchDataImpl } from './base/search-data';
* A service handling all external source requests * A service handling all external source requests
*/ */
@Injectable() @Injectable()
export class ExternalSourceService extends IdentifiableDataService<ExternalSource> implements SearchData<ExternalSource> { export class ExternalSourceDataService extends IdentifiableDataService<ExternalSource> implements SearchData<ExternalSource> {
private searchData: SearchData<ExternalSource>; private searchData: SearchData<ExternalSource>;
constructor( constructor(

View File

@@ -1,5 +1,5 @@
import { LookupRelationService } from './lookup-relation.service'; import { LookupRelationService } from './lookup-relation.service';
import { ExternalSourceService } from './external-source.service'; import { ExternalSourceDataService } from './external-source-data.service';
import { SearchService } from '../shared/search/search.service'; import { SearchService } from '../shared/search/search.service';
import { createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils';
import { createPaginatedList } from '../../shared/testing/utils.test'; import { createPaginatedList } from '../../shared/testing/utils.test';
@@ -16,7 +16,7 @@ import { of as observableOf } from 'rxjs';
describe('LookupRelationService', () => { describe('LookupRelationService', () => {
let service: LookupRelationService; let service: LookupRelationService;
let externalSourceService: ExternalSourceService; let externalSourceService: ExternalSourceDataService;
let searchService: SearchService; let searchService: SearchService;
let requestService: RequestService; let requestService: RequestService;

View File

@@ -1,4 +1,4 @@
import { ExternalSourceService } from './external-source.service'; import { ExternalSourceDataService } from './external-source-data.service';
import { SearchService } from '../shared/search/search.service'; import { SearchService } from '../shared/search/search.service';
import { concat, distinctUntilChanged, map, multicast, startWith, take, takeWhile } from 'rxjs/operators'; import { concat, distinctUntilChanged, map, multicast, startWith, take, takeWhile } from 'rxjs/operators';
import { PaginatedSearchOptions } from '../../shared/search/models/paginated-search-options.model'; import { PaginatedSearchOptions } from '../../shared/search/models/paginated-search-options.model';
@@ -34,7 +34,7 @@ export class LookupRelationService {
pageSize: 1 pageSize: 1
}); });
constructor(protected externalSourceService: ExternalSourceService, constructor(protected externalSourceService: ExternalSourceDataService,
protected searchService: SearchService, protected searchService: SearchService,
protected requestService: RequestService) { protected requestService: RequestService) {
} }

View File

@@ -7,7 +7,7 @@ import { Item } from '../shared/item.model';
import { PageInfo } from '../shared/page-info.model'; import { PageInfo } from '../shared/page-info.model';
import { buildPaginatedList } from './paginated-list.model'; import { buildPaginatedList } from './paginated-list.model';
import { DeleteRequest } from './request.models'; import { DeleteRequest } from './request.models';
import { RelationshipService } from './relationship.service'; import { RelationshipDataService } from './relationship-data.service';
import { RequestService } from './request.service'; import { RequestService } from './request.service';
import { HALEndpointServiceStub } from '../../shared/testing/hal-endpoint-service.stub'; import { HALEndpointServiceStub } from '../../shared/testing/hal-endpoint-service.stub';
import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils';
@@ -17,8 +17,8 @@ import { createPaginatedList } from '../../shared/testing/utils.test';
import { RequestEntry } from './request-entry.model'; import { RequestEntry } from './request-entry.model';
import { FindListOptions } from './find-list-options.model'; import { FindListOptions } from './find-list-options.model';
describe('RelationshipService', () => { describe('RelationshipDataService', () => {
let service: RelationshipService; let service: RelationshipDataService;
let requestService: RequestService; let requestService: RequestService;
const restEndpointURL = 'https://rest.api/core'; const restEndpointURL = 'https://rest.api/core';
@@ -122,7 +122,7 @@ describe('RelationshipService', () => {
}); });
function initTestService() { function initTestService() {
return new RelationshipService( return new RelationshipDataService(
requestService, requestService,
rdbService, rdbService,
halService, halService,

View File

@@ -74,7 +74,7 @@ const compareItemsByUUID = (itemCheck: Item) =>
*/ */
@Injectable() @Injectable()
@dataService(RELATIONSHIP) @dataService(RELATIONSHIP)
export class RelationshipService extends IdentifiableDataService<Relationship> implements SearchData<Relationship> { export class RelationshipDataService extends IdentifiableDataService<Relationship> implements SearchData<Relationship> {
private searchData: SearchData<Relationship>; private searchData: SearchData<Relationship>;
private putData: PutData<Relationship>; private putData: PutData<Relationship>;
@@ -547,6 +547,15 @@ export class RelationshipService extends IdentifiableDataService<Relationship> i
return this.searchData.searchBy(searchMethod, options, useCachedVersionIfAvailable, reRequestOnStale, ...linksToFollow); return this.searchData.searchBy(searchMethod, options, useCachedVersionIfAvailable, reRequestOnStale, ...linksToFollow);
} }
/**
* Create the HREF for a specific object's search method with given options object
*
* @param searchMethod The search method for the object
* @param options The [[FindListOptions]] object
* @return {Observable<string>}
* Return an observable that emits created HREF
* @param linksToFollow List of {@link FollowLinkConfig} that indicate which {@link HALLink}s should be automatically resolved
*/
getSearchByHref(searchMethod: string, options: FindListOptions, ...linksToFollow: FollowLinkConfig<Relationship>[]): Observable<string> { getSearchByHref(searchMethod: string, options: FindListOptions, ...linksToFollow: FollowLinkConfig<Relationship>[]): Observable<string> {
return this.searchData.getSearchByHref(searchMethod, options, ...linksToFollow); return this.searchData.getSearchByHref(searchMethod, options, ...linksToFollow);
} }

View File

@@ -5,14 +5,14 @@ import { HALEndpointServiceStub } from '../../shared/testing/hal-endpoint-servic
import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils';
import { ItemType } from '../shared/item-relationships/item-type.model'; import { ItemType } from '../shared/item-relationships/item-type.model';
import { RelationshipType } from '../shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../shared/item-relationships/relationship-type.model';
import { RelationshipTypeService } from './relationship-type.service'; import { RelationshipTypeDataService } from './relationship-type-data.service';
import { RequestService } from './request.service'; import { RequestService } from './request.service';
import { createPaginatedList } from '../../shared/testing/utils.test'; import { createPaginatedList } from '../../shared/testing/utils.test';
import { hasValueOperator } from '../../shared/empty.util'; import { hasValueOperator } from '../../shared/empty.util';
import { ObjectCacheService } from '../cache/object-cache.service'; import { ObjectCacheService } from '../cache/object-cache.service';
describe('RelationshipTypeService', () => { describe('RelationshipTypeDataService', () => {
let service: RelationshipTypeService; let service: RelationshipTypeDataService;
let requestService: RequestService; let requestService: RequestService;
let restEndpointURL; let restEndpointURL;
let halService: any; let halService: any;
@@ -71,7 +71,7 @@ describe('RelationshipTypeService', () => {
} }
function initTestService() { function initTestService() {
return new RelationshipTypeService( return new RelationshipTypeDataService(
requestService, requestService,
rdbService, rdbService,
objectCache, objectCache,

View File

@@ -32,7 +32,7 @@ const checkSide = (typeRd: RemoteData<ItemType>, label: string): boolean =>
*/ */
@Injectable() @Injectable()
@dataService(RELATIONSHIP_TYPE) @dataService(RELATIONSHIP_TYPE)
export class RelationshipTypeService extends BaseDataService<RelationshipType> { export class RelationshipTypeDataService extends BaseDataService<RelationshipType> {
private searchData: SearchDataImpl<RelationshipType>; private searchData: SearchDataImpl<RelationshipType>;
private findAllData: FindAllDataImpl<RelationshipType>; private findAllData: FindAllDataImpl<RelationshipType>;

View File

@@ -11,14 +11,14 @@ import { createPaginatedList } from '../../shared/testing/utils.test';
import { NativeWindowRefMock } from '../../shared/mocks/mock-native-window-ref'; import { NativeWindowRefMock } from '../../shared/mocks/mock-native-window-ref';
import { URLCombiner } from '../url-combiner/url-combiner'; import { URLCombiner } from '../url-combiner/url-combiner';
import { OrcidAuthService } from './orcid-auth.service'; import { OrcidAuthService } from './orcid-auth.service';
import { ResearcherProfileService } from '../profile/researcher-profile.service'; import { ResearcherProfileDataService } from '../profile/researcher-profile-data.service';
describe('OrcidAuthService', () => { describe('OrcidAuthService', () => {
let scheduler: TestScheduler; let scheduler: TestScheduler;
let service: OrcidAuthService; let service: OrcidAuthService;
let serviceAsAny: any; let serviceAsAny: any;
let researcherProfileService: jasmine.SpyObj<ResearcherProfileService>; let researcherProfileService: jasmine.SpyObj<ResearcherProfileDataService>;
let configurationDataService: ConfigurationDataService; let configurationDataService: ConfigurationDataService;
let nativeWindowService: NativeWindowRefMock; let nativeWindowService: NativeWindowRefMock;
let routerStub: any; let routerStub: any;

View File

@@ -5,7 +5,7 @@ import { combineLatest, Observable } from 'rxjs';
import { map, switchMap } from 'rxjs/operators'; import { map, switchMap } from 'rxjs/operators';
import { AddOperation, RemoveOperation } from 'fast-json-patch'; import { AddOperation, RemoveOperation } from 'fast-json-patch';
import { ResearcherProfileService } from '../profile/researcher-profile.service'; import { ResearcherProfileDataService } from '../profile/researcher-profile-data.service';
import { Item } from '../shared/item.model'; import { Item } from '../shared/item.model';
import { isNotEmpty } from '../../shared/empty.util'; import { isNotEmpty } from '../../shared/empty.util';
import { getFirstCompletedRemoteData, getFirstSucceededRemoteDataPayload } from '../shared/operators'; import { getFirstCompletedRemoteData, getFirstSucceededRemoteDataPayload } from '../shared/operators';
@@ -22,7 +22,7 @@ export class OrcidAuthService {
constructor( constructor(
@Inject(NativeWindowService) protected _window: NativeWindowRef, @Inject(NativeWindowService) protected _window: NativeWindowRef,
private configurationService: ConfigurationDataService, private configurationService: ConfigurationDataService,
private researcherProfileService: ResearcherProfileService, private researcherProfileService: ResearcherProfileDataService,
private router: Router) { private router: Router) {
} }

View File

@@ -22,7 +22,7 @@ import { dataService } from '../data/base/data-service.decorator';
*/ */
@Injectable() @Injectable()
@dataService(ORCID_QUEUE) @dataService(ORCID_QUEUE)
export class OrcidQueueService extends IdentifiableDataService<OrcidQueue> { export class OrcidQueueDataService extends IdentifiableDataService<OrcidQueue> {
private searchData: SearchData<OrcidQueue>; private searchData: SearchData<OrcidQueue>;
private deleteData: DeleteData<OrcidQueue>; private deleteData: DeleteData<OrcidQueue>;

View File

@@ -18,7 +18,7 @@ import {
} from '../../shared/remote-data.utils'; } from '../../shared/remote-data.utils';
import { RestResponse } from '../cache/response.models'; import { RestResponse } from '../cache/response.models';
import { RequestEntry } from '../data/request-entry.model'; import { RequestEntry } from '../data/request-entry.model';
import { ResearcherProfileService } from './researcher-profile.service'; import { ResearcherProfileDataService } from './researcher-profile-data.service';
import { RouterMock } from '../../shared/mocks/router.mock'; import { RouterMock } from '../../shared/mocks/router.mock';
import { ResearcherProfile } from './model/researcher-profile.model'; import { ResearcherProfile } from './model/researcher-profile.model';
import { Item } from '../shared/item.model'; import { Item } from '../shared/item.model';
@@ -31,7 +31,7 @@ import { createPaginatedList } from '../../shared/testing/utils.test';
describe('ResearcherProfileService', () => { describe('ResearcherProfileService', () => {
let scheduler: TestScheduler; let scheduler: TestScheduler;
let service: ResearcherProfileService; let service: ResearcherProfileDataService;
let serviceAsAny: any; let serviceAsAny: any;
let requestService: RequestService; let requestService: RequestService;
let rdbService: RemoteDataBuildService; let rdbService: RemoteDataBuildService;
@@ -247,7 +247,7 @@ describe('ResearcherProfileService', () => {
findByHref: jasmine.createSpy('findByHref') findByHref: jasmine.createSpy('findByHref')
}); });
service = new ResearcherProfileService( service = new ResearcherProfileDataService(
requestService, requestService,
rdbService, rdbService,
objectCache, objectCache,

View File

@@ -39,7 +39,7 @@ import { dataService } from '../data/base/data-service.decorator';
*/ */
@Injectable() @Injectable()
@dataService(RESEARCHER_PROFILE) @dataService(RESEARCHER_PROFILE)
export class ResearcherProfileService extends IdentifiableDataService<ResearcherProfile> implements CreateData<ResearcherProfile>, SearchData<ResearcherProfile>, PatchData<ResearcherProfile>, DeleteData<ResearcherProfile> { export class ResearcherProfileDataService extends IdentifiableDataService<ResearcherProfile> implements CreateData<ResearcherProfile>, SearchData<ResearcherProfile>, PatchData<ResearcherProfile>, DeleteData<ResearcherProfile> {
private createData: CreateDataImpl<ResearcherProfile>; private createData: CreateDataImpl<ResearcherProfile>;
private searchData: SearchDataImpl<ResearcherProfile>; private searchData: SearchDataImpl<ResearcherProfile>;
private patchData: PatchDataImpl<ResearcherProfile>; private patchData: PatchDataImpl<ResearcherProfile>;

View File

@@ -1,5 +1,3 @@
import { HttpClient } from '@angular/common/http';
import { cold, getTestScheduler, hot } from 'jasmine-marbles'; import { cold, getTestScheduler, hot } from 'jasmine-marbles';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { TestScheduler } from 'rxjs/testing'; import { TestScheduler } from 'rxjs/testing';
@@ -9,7 +7,7 @@ import { RemoteDataBuildService } from '../cache/builders/remote-data-build.serv
import { ObjectCacheService } from '../cache/object-cache.service'; import { ObjectCacheService } from '../cache/object-cache.service';
import { HALEndpointService } from '../shared/hal-endpoint.service'; import { HALEndpointService } from '../shared/hal-endpoint.service';
import { RequestService } from '../data/request.service'; import { RequestService } from '../data/request.service';
import { ResourcePolicyService } from './resource-policy.service'; import { ResourcePolicyDataService } from './resource-policy-data.service';
import { PolicyType } from './models/policy-type.model'; import { PolicyType } from './models/policy-type.model';
import { ActionType } from './models/action-type.model'; import { ActionType } from './models/action-type.model';
import { RequestParam } from '../cache/models/request-param.model'; import { RequestParam } from '../cache/models/request-param.model';
@@ -24,7 +22,7 @@ import { GroupDataService } from '../eperson/group-data.service';
describe('ResourcePolicyService', () => { describe('ResourcePolicyService', () => {
let scheduler: TestScheduler; let scheduler: TestScheduler;
let service: ResourcePolicyService; let service: ResourcePolicyDataService;
let requestService: RequestService; let requestService: RequestService;
let rdbService: RemoteDataBuildService; let rdbService: RemoteDataBuildService;
let objectCache: ObjectCacheService; let objectCache: ObjectCacheService;
@@ -133,7 +131,7 @@ describe('ResourcePolicyService', () => {
const notificationsService = {} as NotificationsService; const notificationsService = {} as NotificationsService;
const comparator = {} as any; const comparator = {} as any;
service = new ResourcePolicyService( service = new ResourcePolicyDataService(
requestService, requestService,
rdbService, rdbService,
objectCache, objectCache,

View File

@@ -40,7 +40,7 @@ import { dataService } from '../data/base/data-service.decorator';
*/ */
@Injectable() @Injectable()
@dataService(RESOURCE_POLICY) @dataService(RESOURCE_POLICY)
export class ResourcePolicyService extends IdentifiableDataService<ResourcePolicy> { export class ResourcePolicyDataService extends IdentifiableDataService<ResourcePolicy> {
protected searchByEPersonMethod = 'eperson'; protected searchByEPersonMethod = 'eperson';
protected searchByGroupMethod = 'group'; protected searchByGroupMethod = 'group';
protected searchByResourceMethod = 'resource'; protected searchByResourceMethod = 'resource';

View File

@@ -21,7 +21,7 @@ import { dataService } from '../data/base/data-service.decorator';
*/ */
@Injectable() @Injectable()
@dataService(USAGE_REPORT) @dataService(USAGE_REPORT)
export class UsageReportService extends IdentifiableDataService<UsageReport> implements SearchData<UsageReport> { export class UsageReportDataService extends IdentifiableDataService<UsageReport> implements SearchData<UsageReport> {
private searchData: SearchDataImpl<UsageReport>; private searchData: SearchDataImpl<UsageReport>;
constructor( constructor(

View File

@@ -14,7 +14,7 @@ import { DefaultChangeAnalyzer } from '../../../../core/data/default-change-anal
import { DSOChangeAnalyzer } from '../../../../core/data/dso-change-analyzer.service'; import { DSOChangeAnalyzer } from '../../../../core/data/dso-change-analyzer.service';
import { ItemDataService } from '../../../../core/data/item-data.service'; import { ItemDataService } from '../../../../core/data/item-data.service';
import { buildPaginatedList } from '../../../../core/data/paginated-list.model'; import { buildPaginatedList } from '../../../../core/data/paginated-list.model';
import { RelationshipService } from '../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../core/data/relationship-data.service';
import { RemoteData } from '../../../../core/data/remote-data'; import { RemoteData } from '../../../../core/data/remote-data';
import { Bitstream } from '../../../../core/shared/bitstream.model'; import { Bitstream } from '../../../../core/shared/bitstream.model';
import { HALEndpointService } from '../../../../core/shared/hal-endpoint.service'; import { HALEndpointService } from '../../../../core/shared/hal-endpoint.service';
@@ -83,7 +83,7 @@ describe('JournalComponent', () => {
providers: [ providers: [
{ provide: ItemDataService, useValue: {} }, { provide: ItemDataService, useValue: {} },
{ provide: TruncatableService, useValue: {} }, { provide: TruncatableService, useValue: {} },
{ provide: RelationshipService, useValue: {} }, { provide: RelationshipDataService, useValue: {} },
{ provide: ObjectCacheService, useValue: {} }, { provide: ObjectCacheService, useValue: {} },
{ provide: UUIDService, useValue: {} }, { provide: UUIDService, useValue: {} },
{ provide: Store, useValue: {} }, { provide: Store, useValue: {} },

View File

@@ -14,7 +14,7 @@ import { DefaultChangeAnalyzer } from '../../../../../core/data/default-change-a
import { DSOChangeAnalyzer } from '../../../../../core/data/dso-change-analyzer.service'; import { DSOChangeAnalyzer } from '../../../../../core/data/dso-change-analyzer.service';
import { ItemDataService } from '../../../../../core/data/item-data.service'; import { ItemDataService } from '../../../../../core/data/item-data.service';
import { buildPaginatedList } from '../../../../../core/data/paginated-list.model'; import { buildPaginatedList } from '../../../../../core/data/paginated-list.model';
import { RelationshipService } from '../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../core/data/relationship-data.service';
import { RemoteData } from '../../../../../core/data/remote-data'; import { RemoteData } from '../../../../../core/data/remote-data';
import { Bitstream } from '../../../../../core/shared/bitstream.model'; import { Bitstream } from '../../../../../core/shared/bitstream.model';
import { HALEndpointService } from '../../../../../core/shared/hal-endpoint.service'; import { HALEndpointService } from '../../../../../core/shared/hal-endpoint.service';
@@ -101,7 +101,7 @@ describe('OrgUnitSearchResultListSubmissionElementComponent', () => {
declarations: [OrgUnitSearchResultListSubmissionElementComponent, TruncatePipe], declarations: [OrgUnitSearchResultListSubmissionElementComponent, TruncatePipe],
providers: [ providers: [
{ provide: TruncatableService, useValue: {} }, { provide: TruncatableService, useValue: {} },
{ provide: RelationshipService, useValue: mockRelationshipService }, { provide: RelationshipDataService, useValue: mockRelationshipService },
{ provide: NotificationsService, useValue: {} }, { provide: NotificationsService, useValue: {} },
{ provide: TranslateService, useValue: {} }, { provide: TranslateService, useValue: {} },
{ provide: NgbModal, useValue: {} }, { provide: NgbModal, useValue: {} },

View File

@@ -6,7 +6,7 @@ import { listableObjectComponent } from '../../../../../shared/object-collection
import { ViewMode } from '../../../../../core/shared/view-mode.model'; import { ViewMode } from '../../../../../core/shared/view-mode.model';
import { Item } from '../../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { Context } from '../../../../../core/shared/context.model'; import { Context } from '../../../../../core/shared/context.model';
import { RelationshipService } from '../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../core/data/relationship-data.service';
import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service'; import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service';
import { take } from 'rxjs/operators'; import { take } from 'rxjs/operators';
import { NotificationsService } from '../../../../../shared/notifications/notifications.service'; import { NotificationsService } from '../../../../../shared/notifications/notifications.service';
@@ -36,7 +36,7 @@ export class OrgUnitSearchResultListSubmissionElementComponent extends SearchRes
useNameVariants = false; useNameVariants = false;
constructor(protected truncatableService: TruncatableService, constructor(protected truncatableService: TruncatableService,
private relationshipService: RelationshipService, private relationshipService: RelationshipDataService,
private notificationsService: NotificationsService, private notificationsService: NotificationsService,
private translateService: TranslateService, private translateService: TranslateService,
private modalService: NgbModal, private modalService: NgbModal,

View File

@@ -14,7 +14,7 @@ import { DefaultChangeAnalyzer } from '../../../../../core/data/default-change-a
import { DSOChangeAnalyzer } from '../../../../../core/data/dso-change-analyzer.service'; import { DSOChangeAnalyzer } from '../../../../../core/data/dso-change-analyzer.service';
import { ItemDataService } from '../../../../../core/data/item-data.service'; import { ItemDataService } from '../../../../../core/data/item-data.service';
import { buildPaginatedList } from '../../../../../core/data/paginated-list.model'; import { buildPaginatedList } from '../../../../../core/data/paginated-list.model';
import { RelationshipService } from '../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../core/data/relationship-data.service';
import { RemoteData } from '../../../../../core/data/remote-data'; import { RemoteData } from '../../../../../core/data/remote-data';
import { Bitstream } from '../../../../../core/shared/bitstream.model'; import { Bitstream } from '../../../../../core/shared/bitstream.model';
import { HALEndpointService } from '../../../../../core/shared/hal-endpoint.service'; import { HALEndpointService } from '../../../../../core/shared/hal-endpoint.service';
@@ -93,7 +93,7 @@ describe('PersonSearchResultListElementSubmissionComponent', () => {
declarations: [PersonSearchResultListSubmissionElementComponent, TruncatePipe], declarations: [PersonSearchResultListSubmissionElementComponent, TruncatePipe],
providers: [ providers: [
{ provide: TruncatableService, useValue: {} }, { provide: TruncatableService, useValue: {} },
{ provide: RelationshipService, useValue: mockRelationshipService }, { provide: RelationshipDataService, useValue: mockRelationshipService },
{ provide: NotificationsService, useValue: {} }, { provide: NotificationsService, useValue: {} },
{ provide: TranslateService, useValue: {} }, { provide: TranslateService, useValue: {} },
{ provide: NgbModal, useValue: {} }, { provide: NgbModal, useValue: {} },

View File

@@ -6,7 +6,7 @@ import { listableObjectComponent } from '../../../../../shared/object-collection
import { ViewMode } from '../../../../../core/shared/view-mode.model'; import { ViewMode } from '../../../../../core/shared/view-mode.model';
import { Item } from '../../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { Context } from '../../../../../core/shared/context.model'; import { Context } from '../../../../../core/shared/context.model';
import { RelationshipService } from '../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../core/data/relationship-data.service';
import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service'; import { TruncatableService } from '../../../../../shared/truncatable/truncatable.service';
import { take } from 'rxjs/operators'; import { take } from 'rxjs/operators';
import { NotificationsService } from '../../../../../shared/notifications/notifications.service'; import { NotificationsService } from '../../../../../shared/notifications/notifications.service';
@@ -34,7 +34,7 @@ export class PersonSearchResultListSubmissionElementComponent extends SearchResu
alternativeField = 'dc.title.alternative'; alternativeField = 'dc.title.alternative';
constructor(protected truncatableService: TruncatableService, constructor(protected truncatableService: TruncatableService,
private relationshipService: RelationshipService, private relationshipService: RelationshipDataService,
private notificationsService: NotificationsService, private notificationsService: NotificationsService,
private translateService: TranslateService, private translateService: TranslateService,
private modalService: NgbModal, private modalService: NgbModal,

View File

@@ -19,12 +19,12 @@ import { ItemDeleteComponent } from './item-delete.component';
import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
import { VarDirective } from '../../../shared/utils/var.directive'; import { VarDirective } from '../../../shared/utils/var.directive';
import { ObjectUpdatesService } from '../../../core/data/object-updates/object-updates.service'; import { ObjectUpdatesService } from '../../../core/data/object-updates/object-updates.service';
import { RelationshipService } from '../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../core/data/relationship-data.service';
import { RelationshipType } from '../../../core/shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../../../core/shared/item-relationships/relationship-type.model';
import { EntityTypeService } from '../../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../../core/data/entity-type-data.service';
import { getItemEditRoute } from '../../item-page-routing-paths'; import { getItemEditRoute } from '../../item-page-routing-paths';
import { createPaginatedList } from '../../../shared/testing/utils.test'; import { createPaginatedList } from '../../../shared/testing/utils.test';
import { RelationshipTypeService } from '../../../core/data/relationship-type.service'; import { RelationshipTypeDataService } from '../../../core/data/relationship-type-data.service';
import { LinkService } from '../../../core/cache/builders/link.service'; import { LinkService } from '../../../core/cache/builders/link.service';
let comp: ItemDeleteComponent; let comp: ItemDeleteComponent;
@@ -154,9 +154,9 @@ describe('ItemDeleteComponent', () => {
{ provide: ItemDataService, useValue: mockItemDataService }, { provide: ItemDataService, useValue: mockItemDataService },
{ provide: NotificationsService, useValue: notificationsServiceStub }, { provide: NotificationsService, useValue: notificationsServiceStub },
{ provide: ObjectUpdatesService, useValue: objectUpdatesServiceStub }, { provide: ObjectUpdatesService, useValue: objectUpdatesServiceStub },
{ provide: RelationshipService, useValue: relationshipService }, { provide: RelationshipDataService, useValue: relationshipService },
{ provide: EntityTypeService, useValue: entityTypeService }, { provide: EntityTypeDataService, useValue: entityTypeService },
{ provide: RelationshipTypeService, useValue: {} }, { provide: RelationshipTypeDataService, useValue: {} },
{ provide: LinkService, useValue: linkService }, { provide: LinkService, useValue: linkService },
], schemas: [ ], schemas: [
CUSTOM_ELEMENTS_SCHEMA CUSTOM_ELEMENTS_SCHEMA

View File

@@ -29,8 +29,8 @@ import { NotificationsService } from '../../../shared/notifications/notification
import { ItemDataService } from '../../../core/data/item-data.service'; import { ItemDataService } from '../../../core/data/item-data.service';
import { TranslateService } from '@ngx-translate/core'; import { TranslateService } from '@ngx-translate/core';
import { ObjectUpdatesService } from '../../../core/data/object-updates/object-updates.service'; import { ObjectUpdatesService } from '../../../core/data/object-updates/object-updates.service';
import { RelationshipService } from '../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../core/data/relationship-data.service';
import { EntityTypeService } from '../../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../../core/data/entity-type-data.service';
import { LinkService } from '../../../core/cache/builders/link.service'; import { LinkService } from '../../../core/cache/builders/link.service';
import { followLink } from '../../../shared/utils/follow-link-config.model'; import { followLink } from '../../../shared/utils/follow-link-config.model';
import { getItemEditRoute } from '../../item-page-routing-paths'; import { getItemEditRoute } from '../../item-page-routing-paths';
@@ -100,8 +100,8 @@ export class ItemDeleteComponent
protected translateService: TranslateService, protected translateService: TranslateService,
protected modalService: NgbModal, protected modalService: NgbModal,
protected objectUpdatesService: ObjectUpdatesService, protected objectUpdatesService: ObjectUpdatesService,
protected relationshipService: RelationshipService, protected relationshipService: RelationshipDataService,
protected entityTypeService: EntityTypeService, protected entityTypeService: EntityTypeDataService,
protected linkService: LinkService, protected linkService: LinkService,
) { ) {
super( super(

View File

@@ -5,7 +5,7 @@ import { TranslateModule } from '@ngx-translate/core';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { LinkService } from '../../../../core/cache/builders/link.service'; import { LinkService } from '../../../../core/cache/builders/link.service';
import { ObjectUpdatesService } from '../../../../core/data/object-updates/object-updates.service'; import { ObjectUpdatesService } from '../../../../core/data/object-updates/object-updates.service';
import { RelationshipService } from '../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../core/data/relationship-data.service';
import { ItemType } from '../../../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../../../core/shared/item-relationships/item-type.model';
import { RelationshipType } from '../../../../core/shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../../../../core/shared/item-relationships/relationship-type.model';
import { Relationship } from '../../../../core/shared/item-relationships/relationship.model'; import { Relationship } from '../../../../core/shared/item-relationships/relationship.model';
@@ -21,7 +21,7 @@ import { HostWindowService } from '../../../../shared/host-window.service';
import { HostWindowServiceStub } from '../../../../shared/testing/host-window-service.stub'; import { HostWindowServiceStub } from '../../../../shared/testing/host-window-service.stub';
import { PaginationComponent } from '../../../../shared/pagination/pagination.component'; import { PaginationComponent } from '../../../../shared/pagination/pagination.component';
import { PaginationComponentOptions } from '../../../../shared/pagination/pagination-component-options.model'; import { PaginationComponentOptions } from '../../../../shared/pagination/pagination-component-options.model';
import { RelationshipTypeService } from '../../../../core/data/relationship-type.service'; import { RelationshipTypeDataService } from '../../../../core/data/relationship-type-data.service';
import { FieldChangeType } from '../../../../core/data/object-updates/field-change-type.model'; import { FieldChangeType } from '../../../../core/data/object-updates/field-change-type.model';
import { GroupDataService } from '../../../../core/eperson/group-data.service'; import { GroupDataService } from '../../../../core/eperson/group-data.service';
import { ConfigurationDataService } from '../../../../core/data/configuration-data.service'; import { ConfigurationDataService } from '../../../../core/data/configuration-data.service';
@@ -206,12 +206,12 @@ describe('EditRelationshipListComponent', () => {
declarations: [EditRelationshipListComponent], declarations: [EditRelationshipListComponent],
providers: [ providers: [
{ provide: ObjectUpdatesService, useValue: objectUpdatesService }, { provide: ObjectUpdatesService, useValue: objectUpdatesService },
{ provide: RelationshipService, useValue: relationshipService }, { provide: RelationshipDataService, useValue: relationshipService },
{ provide: SelectableListService, useValue: selectableListService }, { provide: SelectableListService, useValue: selectableListService },
{ provide: LinkService, useValue: linkService }, { provide: LinkService, useValue: linkService },
{ provide: PaginationService, useValue: paginationService }, { provide: PaginationService, useValue: paginationService },
{ provide: HostWindowService, useValue: hostWindowService }, { provide: HostWindowService, useValue: hostWindowService },
{ provide: RelationshipTypeService, useValue: relationshipTypeService }, { provide: RelationshipTypeDataService, useValue: relationshipTypeService },
{ provide: GroupDataService, useValue: groupDataService }, { provide: GroupDataService, useValue: groupDataService },
{ provide: Router, useValue: new RouterMock() }, { provide: Router, useValue: new RouterMock() },
{ provide: LinkHeadService, useValue: linkHeadService }, { provide: LinkHeadService, useValue: linkHeadService },

View File

@@ -12,7 +12,7 @@ import {
import { import {
RelationshipIdentifiable RelationshipIdentifiable
} from '../../../../core/data/object-updates/object-updates.reducer'; } from '../../../../core/data/object-updates/object-updates.reducer';
import { RelationshipService } from '../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../core/data/relationship-data.service';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../core/shared/item.model';
import { defaultIfEmpty, map, mergeMap, startWith, switchMap, take, tap, toArray } from 'rxjs/operators'; import { defaultIfEmpty, map, mergeMap, startWith, switchMap, take, tap, toArray } from 'rxjs/operators';
import { hasNoValue, hasValue, hasValueOperator } from '../../../../shared/empty.util'; import { hasNoValue, hasValue, hasValueOperator } from '../../../../shared/empty.util';
@@ -35,7 +35,7 @@ import { RemoteData } from '../../../../core/data/remote-data';
import { Collection } from '../../../../core/shared/collection.model'; import { Collection } from '../../../../core/shared/collection.model';
import { PaginationComponentOptions } from '../../../../shared/pagination/pagination-component-options.model'; import { PaginationComponentOptions } from '../../../../shared/pagination/pagination-component-options.model';
import { PaginationService } from '../../../../core/pagination/pagination.service'; import { PaginationService } from '../../../../core/pagination/pagination.service';
import { RelationshipTypeService } from '../../../../core/data/relationship-type.service'; import { RelationshipTypeDataService } from '../../../../core/data/relationship-type-data.service';
import { FieldUpdate } from '../../../../core/data/object-updates/field-update.model'; import { FieldUpdate } from '../../../../core/data/object-updates/field-update.model';
import { FieldUpdates } from '../../../../core/data/object-updates/field-updates.model'; import { FieldUpdates } from '../../../../core/data/object-updates/field-updates.model';
import { FieldChangeType } from '../../../../core/data/object-updates/field-change-type.model'; import { FieldChangeType } from '../../../../core/data/object-updates/field-change-type.model';
@@ -142,8 +142,8 @@ export class EditRelationshipListComponent implements OnInit, OnDestroy {
constructor( constructor(
protected objectUpdatesService: ObjectUpdatesService, protected objectUpdatesService: ObjectUpdatesService,
protected linkService: LinkService, protected linkService: LinkService,
protected relationshipService: RelationshipService, protected relationshipService: RelationshipDataService,
protected relationshipTypeService: RelationshipTypeService, protected relationshipTypeService: RelationshipTypeDataService,
protected modalService: NgbModal, protected modalService: NgbModal,
protected paginationService: PaginationService, protected paginationService: PaginationService,
protected selectableListService: SelectableListService, protected selectableListService: SelectableListService,

View File

@@ -7,10 +7,10 @@ import { combineLatest as observableCombineLatest, of as observableOf } from 'rx
import { TestScheduler } from 'rxjs/testing'; import { TestScheduler } from 'rxjs/testing';
import { ObjectCacheService } from '../../../core/cache/object-cache.service'; import { ObjectCacheService } from '../../../core/cache/object-cache.service';
import { RestResponse } from '../../../core/cache/response.models'; import { RestResponse } from '../../../core/cache/response.models';
import { EntityTypeService } from '../../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../../core/data/entity-type-data.service';
import { ItemDataService } from '../../../core/data/item-data.service'; import { ItemDataService } from '../../../core/data/item-data.service';
import { ObjectUpdatesService } from '../../../core/data/object-updates/object-updates.service'; import { ObjectUpdatesService } from '../../../core/data/object-updates/object-updates.service';
import { RelationshipService } from '../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../core/data/relationship-data.service';
import { RequestService } from '../../../core/data/request.service'; import { RequestService } from '../../../core/data/request.service';
import { ItemType } from '../../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../../core/shared/item-relationships/item-type.model';
import { RelationshipType } from '../../../core/shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../../../core/shared/item-relationships/relationship-type.model';
@@ -25,7 +25,7 @@ import { ItemRelationshipsComponent } from './item-relationships.component';
import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
import { createPaginatedList } from '../../../shared/testing/utils.test'; import { createPaginatedList } from '../../../shared/testing/utils.test';
import { FieldChangeType } from '../../../core/data/object-updates/field-change-type.model'; import { FieldChangeType } from '../../../core/data/object-updates/field-change-type.model';
import { RelationshipTypeService } from '../../../core/data/relationship-type.service'; import { RelationshipTypeDataService } from '../../../core/data/relationship-type-data.service';
import { relationshipTypes } from '../../../shared/testing/relationship-types.mock'; import { relationshipTypes } from '../../../shared/testing/relationship-types.mock';
import { ThemeService } from '../../../shared/theme-support/theme.service'; import { ThemeService } from '../../../shared/theme-support/theme.service';
import { getMockThemeService } from '../../../shared/mocks/theme-service.mock'; import { getMockThemeService } from '../../../shared/mocks/theme-service.mock';
@@ -219,11 +219,11 @@ describe('ItemRelationshipsComponent', () => {
{ provide: Router, useValue: router }, { provide: Router, useValue: router },
{ provide: ActivatedRoute, useValue: routeStub }, { provide: ActivatedRoute, useValue: routeStub },
{ provide: NotificationsService, useValue: notificationsService }, { provide: NotificationsService, useValue: notificationsService },
{ provide: RelationshipService, useValue: relationshipService }, { provide: RelationshipDataService, useValue: relationshipService },
{ provide: EntityTypeService, useValue: entityTypeService }, { provide: EntityTypeDataService, useValue: entityTypeService },
{ provide: ObjectCacheService, useValue: objectCache }, { provide: ObjectCacheService, useValue: objectCache },
{ provide: RequestService, useValue: requestService }, { provide: RequestService, useValue: requestService },
{ provide: RelationshipTypeService, useValue: relationshipTypeService }, { provide: RelationshipTypeDataService, useValue: relationshipTypeService },
ChangeDetectorRef ChangeDetectorRef
], schemas: [ ], schemas: [
NO_ERRORS_SCHEMA NO_ERRORS_SCHEMA

View File

@@ -13,21 +13,21 @@ import { ObjectUpdatesService } from '../../../core/data/object-updates/object-u
import { ActivatedRoute, Router } from '@angular/router'; import { ActivatedRoute, Router } from '@angular/router';
import { NotificationsService } from '../../../shared/notifications/notifications.service'; import { NotificationsService } from '../../../shared/notifications/notifications.service';
import { TranslateService } from '@ngx-translate/core'; import { TranslateService } from '@ngx-translate/core';
import { RelationshipService } from '../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../core/data/relationship-data.service';
import { RemoteData } from '../../../core/data/remote-data'; import { RemoteData } from '../../../core/data/remote-data';
import { ObjectCacheService } from '../../../core/cache/object-cache.service'; import { ObjectCacheService } from '../../../core/cache/object-cache.service';
import { getFirstSucceededRemoteData, getRemoteDataPayload } from '../../../core/shared/operators'; import { getFirstSucceededRemoteData, getRemoteDataPayload } from '../../../core/shared/operators';
import { RequestService } from '../../../core/data/request.service'; import { RequestService } from '../../../core/data/request.service';
import { RelationshipType } from '../../../core/shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../../../core/shared/item-relationships/relationship-type.model';
import { ItemType } from '../../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../../core/shared/item-relationships/item-type.model';
import { EntityTypeService } from '../../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../../core/data/entity-type-data.service';
import { Relationship } from '../../../core/shared/item-relationships/relationship.model'; import { Relationship } from '../../../core/shared/item-relationships/relationship.model';
import { NoContent } from '../../../core/shared/NoContent.model'; import { NoContent } from '../../../core/shared/NoContent.model';
import { hasValue } from '../../../shared/empty.util'; import { hasValue } from '../../../shared/empty.util';
import { FieldUpdate } from '../../../core/data/object-updates/field-update.model'; import { FieldUpdate } from '../../../core/data/object-updates/field-update.model';
import { FieldUpdates } from '../../../core/data/object-updates/field-updates.model'; import { FieldUpdates } from '../../../core/data/object-updates/field-updates.model';
import { FieldChangeType } from '../../../core/data/object-updates/field-change-type.model'; import { FieldChangeType } from '../../../core/data/object-updates/field-change-type.model';
import { RelationshipTypeService } from '../../../core/data/relationship-type.service'; import { RelationshipTypeDataService } from '../../../core/data/relationship-type-data.service';
import { PaginatedList } from '../../../core/data/paginated-list.model'; import { PaginatedList } from '../../../core/data/paginated-list.model';
import { NgbModal } from '@ng-bootstrap/ng-bootstrap'; import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
@@ -59,11 +59,11 @@ export class ItemRelationshipsComponent extends AbstractItemUpdateComponent {
public notificationsService: NotificationsService, public notificationsService: NotificationsService,
public translateService: TranslateService, public translateService: TranslateService,
public route: ActivatedRoute, public route: ActivatedRoute,
public relationshipService: RelationshipService, public relationshipService: RelationshipDataService,
public objectCache: ObjectCacheService, public objectCache: ObjectCacheService,
public requestService: RequestService, public requestService: RequestService,
public entityTypeService: EntityTypeService, public entityTypeService: EntityTypeDataService,
protected relationshipTypeService: RelationshipTypeService, protected relationshipTypeService: RelationshipTypeDataService,
public cdr: ChangeDetectorRef, public cdr: ChangeDetectorRef,
protected modalService: NgbModal, protected modalService: NgbModal,
) { ) {

View File

@@ -4,7 +4,7 @@ import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
import { TranslateLoaderMock } from '../../../shared/mocks/translate-loader.mock'; import { TranslateLoaderMock } from '../../../shared/mocks/translate-loader.mock';
import { RouterTestingModule } from '@angular/router/testing'; import { RouterTestingModule } from '@angular/router/testing';
import { DebugElement, NO_ERRORS_SCHEMA } from '@angular/core'; import { DebugElement, NO_ERRORS_SCHEMA } from '@angular/core';
import { OrcidQueueService } from '../../../core/orcid/orcid-queue.service'; import { OrcidQueueDataService } from '../../../core/orcid/orcid-queue-data.service';
import { PaginationService } from '../../../core/pagination/pagination.service'; import { PaginationService } from '../../../core/pagination/pagination.service';
import { PaginationServiceStub } from '../../../shared/testing/pagination-service.stub'; import { PaginationServiceStub } from '../../../shared/testing/pagination-service.stub';
import { NotificationsService } from '../../../shared/notifications/notifications.service'; import { NotificationsService } from '../../../shared/notifications/notifications.service';
@@ -22,7 +22,7 @@ describe('OrcidQueueComponent test suite', () => {
let component: OrcidQueueComponent; let component: OrcidQueueComponent;
let fixture: ComponentFixture<OrcidQueueComponent>; let fixture: ComponentFixture<OrcidQueueComponent>;
let debugElement: DebugElement; let debugElement: DebugElement;
let orcidQueueService: OrcidQueueService; let orcidQueueService: OrcidQueueDataService;
let orcidAuthService: jasmine.SpyObj<OrcidAuthService>; let orcidAuthService: jasmine.SpyObj<OrcidAuthService>;
const testProfileItemId = 'test-owner-id'; const testProfileItemId = 'test-owner-id';
@@ -120,7 +120,7 @@ describe('OrcidQueueComponent test suite', () => {
declarations: [OrcidQueueComponent], declarations: [OrcidQueueComponent],
providers: [ providers: [
{ provide: OrcidAuthService, useValue: orcidAuthService }, { provide: OrcidAuthService, useValue: orcidAuthService },
{ provide: OrcidQueueService, useValue: orcidQueueServiceSpy }, { provide: OrcidQueueDataService, useValue: orcidQueueServiceSpy },
{ provide: OrcidHistoryDataService, useValue: {} }, { provide: OrcidHistoryDataService, useValue: {} },
{ provide: PaginationService, useValue: new PaginationServiceStub() }, { provide: PaginationService, useValue: new PaginationServiceStub() },
{ provide: NotificationsService, useValue: new NotificationsServiceStub() }, { provide: NotificationsService, useValue: new NotificationsServiceStub() },
@@ -128,7 +128,7 @@ describe('OrcidQueueComponent test suite', () => {
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA]
}).compileComponents(); }).compileComponents();
orcidQueueService = TestBed.inject(OrcidQueueService); orcidQueueService = TestBed.inject(OrcidQueueDataService);
})); }));
beforeEach(() => { beforeEach(() => {

View File

@@ -9,7 +9,7 @@ import { RemoteData } from '../../../core/data/remote-data';
import { OrcidHistory } from '../../../core/orcid/model/orcid-history.model'; import { OrcidHistory } from '../../../core/orcid/model/orcid-history.model';
import { OrcidQueue } from '../../../core/orcid/model/orcid-queue.model'; import { OrcidQueue } from '../../../core/orcid/model/orcid-queue.model';
import { OrcidHistoryDataService } from '../../../core/orcid/orcid-history-data.service'; import { OrcidHistoryDataService } from '../../../core/orcid/orcid-history-data.service';
import { OrcidQueueService } from '../../../core/orcid/orcid-queue.service'; import { OrcidQueueDataService } from '../../../core/orcid/orcid-queue-data.service';
import { PaginationService } from '../../../core/pagination/pagination.service'; import { PaginationService } from '../../../core/pagination/pagination.service';
import { getFirstCompletedRemoteData } from '../../../core/shared/operators'; import { getFirstCompletedRemoteData } from '../../../core/shared/operators';
import { hasValue } from '../../../shared/empty.util'; import { hasValue } from '../../../shared/empty.util';
@@ -62,7 +62,7 @@ export class OrcidQueueComponent implements OnInit, OnDestroy {
private subs: Subscription[] = []; private subs: Subscription[] = [];
constructor(private orcidAuthService: OrcidAuthService, constructor(private orcidAuthService: OrcidAuthService,
private orcidQueueService: OrcidQueueService, private orcidQueueService: OrcidQueueDataService,
protected translateService: TranslateService, protected translateService: TranslateService,
private paginationService: PaginationService, private paginationService: PaginationService,
private notificationsService: NotificationsService, private notificationsService: NotificationsService,

View File

@@ -10,7 +10,7 @@ import { TestScheduler } from 'rxjs/testing';
import { TranslateLoader, TranslateModule } from '@ngx-translate/core'; import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
import { Operation } from 'fast-json-patch'; import { Operation } from 'fast-json-patch';
import { ResearcherProfileService } from '../../../core/profile/researcher-profile.service'; import { ResearcherProfileDataService } from '../../../core/profile/researcher-profile-data.service';
import { createFailedRemoteDataObject$, createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils'; import { createFailedRemoteDataObject$, createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
import { Item } from '../../../core/shared/item.model'; import { Item } from '../../../core/shared/item.model';
import { createPaginatedList } from '../../../shared/testing/utils.test'; import { createPaginatedList } from '../../../shared/testing/utils.test';
@@ -24,7 +24,7 @@ describe('OrcidSyncSettingsComponent test suite', () => {
let comp: OrcidSyncSettingsComponent; let comp: OrcidSyncSettingsComponent;
let fixture: ComponentFixture<OrcidSyncSettingsComponent>; let fixture: ComponentFixture<OrcidSyncSettingsComponent>;
let scheduler: TestScheduler; let scheduler: TestScheduler;
let researcherProfileService: jasmine.SpyObj<ResearcherProfileService>; let researcherProfileService: jasmine.SpyObj<ResearcherProfileDataService>;
let notificationsService; let notificationsService;
let formGroup: FormGroup; let formGroup: FormGroup;
@@ -149,7 +149,7 @@ describe('OrcidSyncSettingsComponent test suite', () => {
declarations: [OrcidSyncSettingsComponent], declarations: [OrcidSyncSettingsComponent],
providers: [ providers: [
{ provide: NotificationsService, useClass: NotificationsServiceStub }, { provide: NotificationsService, useClass: NotificationsServiceStub },
{ provide: ResearcherProfileService, useValue: researcherProfileService } { provide: ResearcherProfileDataService, useValue: researcherProfileService }
], ],
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(OrcidSyncSettingsComponent, { }).overrideComponent(OrcidSyncSettingsComponent, {

View File

@@ -7,7 +7,7 @@ import { of } from 'rxjs';
import { switchMap } from 'rxjs/operators'; import { switchMap } from 'rxjs/operators';
import { RemoteData } from '../../../core/data/remote-data'; import { RemoteData } from '../../../core/data/remote-data';
import { ResearcherProfileService } from '../../../core/profile/researcher-profile.service'; import { ResearcherProfileDataService } from '../../../core/profile/researcher-profile-data.service';
import { Item } from '../../../core/shared/item.model'; import { Item } from '../../../core/shared/item.model';
import { getFirstCompletedRemoteData } from '../../../core/shared/operators'; import { getFirstCompletedRemoteData } from '../../../core/shared/operators';
import { NotificationsService } from '../../../shared/notifications/notifications.service'; import { NotificationsService } from '../../../shared/notifications/notifications.service';
@@ -70,7 +70,7 @@ export class OrcidSyncSettingsComponent implements OnInit {
*/ */
@Output() settingsUpdated: EventEmitter<void> = new EventEmitter<void>(); @Output() settingsUpdated: EventEmitter<void> = new EventEmitter<void>();
constructor(private researcherProfileService: ResearcherProfileService, constructor(private researcherProfileService: ResearcherProfileDataService,
private notificationsService: NotificationsService, private notificationsService: NotificationsService,
private translateService: TranslateService) { private translateService: TranslateService) {
} }

View File

@@ -12,7 +12,7 @@ import { CommunityDataService } from '../../../../core/data/community-data.servi
import { DefaultChangeAnalyzer } from '../../../../core/data/default-change-analyzer.service'; import { DefaultChangeAnalyzer } from '../../../../core/data/default-change-analyzer.service';
import { DSOChangeAnalyzer } from '../../../../core/data/dso-change-analyzer.service'; import { DSOChangeAnalyzer } from '../../../../core/data/dso-change-analyzer.service';
import { ItemDataService } from '../../../../core/data/item-data.service'; import { ItemDataService } from '../../../../core/data/item-data.service';
import { RelationshipService } from '../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../core/data/relationship-data.service';
import { RemoteData } from '../../../../core/data/remote-data'; import { RemoteData } from '../../../../core/data/remote-data';
import { Bitstream } from '../../../../core/shared/bitstream.model'; import { Bitstream } from '../../../../core/shared/bitstream.model';
import { HALEndpointService } from '../../../../core/shared/hal-endpoint.service'; import { HALEndpointService } from '../../../../core/shared/hal-endpoint.service';
@@ -71,7 +71,7 @@ describe('PublicationComponent', () => {
providers: [ providers: [
{ provide: ItemDataService, useValue: {} }, { provide: ItemDataService, useValue: {} },
{ provide: TruncatableService, useValue: {} }, { provide: TruncatableService, useValue: {} },
{ provide: RelationshipService, useValue: {} }, { provide: RelationshipDataService, useValue: {} },
{ provide: ObjectCacheService, useValue: {} }, { provide: ObjectCacheService, useValue: {} },
{ provide: UUIDService, useValue: {} }, { provide: UUIDService, useValue: {} },
{ provide: Store, useValue: {} }, { provide: Store, useValue: {} },

View File

@@ -12,7 +12,7 @@ import { CommunityDataService } from '../../../../core/data/community-data.servi
import { DefaultChangeAnalyzer } from '../../../../core/data/default-change-analyzer.service'; import { DefaultChangeAnalyzer } from '../../../../core/data/default-change-analyzer.service';
import { DSOChangeAnalyzer } from '../../../../core/data/dso-change-analyzer.service'; import { DSOChangeAnalyzer } from '../../../../core/data/dso-change-analyzer.service';
import { ItemDataService } from '../../../../core/data/item-data.service'; import { ItemDataService } from '../../../../core/data/item-data.service';
import { RelationshipService } from '../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../core/data/relationship-data.service';
import { RemoteData } from '../../../../core/data/remote-data'; import { RemoteData } from '../../../../core/data/remote-data';
import { Bitstream } from '../../../../core/shared/bitstream.model'; import { Bitstream } from '../../../../core/shared/bitstream.model';
import { HALEndpointService } from '../../../../core/shared/hal-endpoint.service'; import { HALEndpointService } from '../../../../core/shared/hal-endpoint.service';
@@ -38,7 +38,7 @@ import { VersionDataService } from '../../../../core/data/version-data.service';
import { VersionHistoryDataService } from '../../../../core/data/version-history-data.service'; import { VersionHistoryDataService } from '../../../../core/data/version-history-data.service';
import { RouterTestingModule } from '@angular/router/testing'; import { RouterTestingModule } from '@angular/router/testing';
import { AuthorizationDataService } from '../../../../core/data/feature-authorization/authorization-data.service'; import { AuthorizationDataService } from '../../../../core/data/feature-authorization/authorization-data.service';
import { ResearcherProfileService } from '../../../../core/profile/researcher-profile.service'; import { ResearcherProfileDataService } from '../../../../core/profile/researcher-profile-data.service';
export function getIIIFSearchEnabled(enabled: boolean): MetadataValue { export function getIIIFSearchEnabled(enabled: boolean): MetadataValue {
return Object.assign(new MetadataValue(), { return Object.assign(new MetadataValue(), {
@@ -99,7 +99,7 @@ export function getItemPageFieldsTest(mockItem: Item, component) {
providers: [ providers: [
{ provide: ItemDataService, useValue: {} }, { provide: ItemDataService, useValue: {} },
{ provide: TruncatableService, useValue: {} }, { provide: TruncatableService, useValue: {} },
{ provide: RelationshipService, useValue: {} }, { provide: RelationshipDataService, useValue: {} },
{ provide: ObjectCacheService, useValue: {} }, { provide: ObjectCacheService, useValue: {} },
{ provide: UUIDService, useValue: {} }, { provide: UUIDService, useValue: {} },
{ provide: Store, useValue: {} }, { provide: Store, useValue: {} },
@@ -117,7 +117,7 @@ export function getItemPageFieldsTest(mockItem: Item, component) {
{ provide: SearchService, useValue: {} }, { provide: SearchService, useValue: {} },
{ provide: RouteService, useValue: {} }, { provide: RouteService, useValue: {} },
{ provide: AuthorizationDataService, useValue: authorizationService }, { provide: AuthorizationDataService, useValue: authorizationService },
{ provide: ResearcherProfileService, useValue: {} } { provide: ResearcherProfileDataService, useValue: {} }
], ],
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA]

View File

@@ -12,7 +12,7 @@ import { CommunityDataService } from '../../../../core/data/community-data.servi
import { DefaultChangeAnalyzer } from '../../../../core/data/default-change-analyzer.service'; import { DefaultChangeAnalyzer } from '../../../../core/data/default-change-analyzer.service';
import { DSOChangeAnalyzer } from '../../../../core/data/dso-change-analyzer.service'; import { DSOChangeAnalyzer } from '../../../../core/data/dso-change-analyzer.service';
import { ItemDataService } from '../../../../core/data/item-data.service'; import { ItemDataService } from '../../../../core/data/item-data.service';
import { RelationshipService } from '../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../core/data/relationship-data.service';
import { RemoteData } from '../../../../core/data/remote-data'; import { RemoteData } from '../../../../core/data/remote-data';
import { Bitstream } from '../../../../core/shared/bitstream.model'; import { Bitstream } from '../../../../core/shared/bitstream.model';
import { HALEndpointService } from '../../../../core/shared/hal-endpoint.service'; import { HALEndpointService } from '../../../../core/shared/hal-endpoint.service';
@@ -72,7 +72,7 @@ describe('UntypedItemComponent', () => {
providers: [ providers: [
{ provide: ItemDataService, useValue: {} }, { provide: ItemDataService, useValue: {} },
{ provide: TruncatableService, useValue: {} }, { provide: TruncatableService, useValue: {} },
{ provide: RelationshipService, useValue: {} }, { provide: RelationshipDataService, useValue: {} },
{ provide: ObjectCacheService, useValue: {} }, { provide: ObjectCacheService, useValue: {} },
{ provide: UUIDService, useValue: {} }, { provide: UUIDService, useValue: {} },
{ provide: Store, useValue: {} }, { provide: Store, useValue: {} },

View File

@@ -2,7 +2,7 @@ import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core'; import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { MetadataRepresentationListComponent } from './metadata-representation-list.component'; import { MetadataRepresentationListComponent } from './metadata-representation-list.component';
import { RelationshipService } from '../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../core/data/relationship-data.service';
import { Item } from '../../../core/shared/item.model'; import { Item } from '../../../core/shared/item.model';
import { Relationship } from '../../../core/shared/item-relationships/relationship.model'; import { Relationship } from '../../../core/shared/item-relationships/relationship.model';
import { createSuccessfulRemoteDataObject$, createFailedRemoteDataObject$ } from '../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$, createFailedRemoteDataObject$ } from '../../../shared/remote-data.utils';
@@ -110,7 +110,7 @@ describe('MetadataRepresentationListComponent', () => {
imports: [TranslateModule.forRoot()], imports: [TranslateModule.forRoot()],
declarations: [MetadataRepresentationListComponent, VarDirective], declarations: [MetadataRepresentationListComponent, VarDirective],
providers: [ providers: [
{ provide: RelationshipService, useValue: relationshipService } { provide: RelationshipDataService, useValue: relationshipService }
], ],
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(MetadataRepresentationListComponent, { }).overrideComponent(MetadataRepresentationListComponent, {

View File

@@ -6,7 +6,7 @@ import {
of as observableOf, of as observableOf,
zip as observableZip zip as observableZip
} from 'rxjs'; } from 'rxjs';
import { RelationshipService } from '../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../core/data/relationship-data.service';
import { MetadataValue } from '../../../core/shared/metadata.models'; import { MetadataValue } from '../../../core/shared/metadata.models';
import { getFirstSucceededRemoteData } from '../../../core/shared/operators'; import { getFirstSucceededRemoteData } from '../../../core/shared/operators';
import { filter, map, switchMap } from 'rxjs/operators'; import { filter, map, switchMap } from 'rxjs/operators';
@@ -61,7 +61,7 @@ export class MetadataRepresentationListComponent extends AbstractIncrementalList
*/ */
total: number; total: number;
constructor(public relationshipService: RelationshipService) { constructor(public relationshipService: RelationshipDataService) {
super(); super();
} }

View File

@@ -4,7 +4,7 @@ import { Observable } from 'rxjs';
import { RemoteData } from '../../../core/data/remote-data'; import { RemoteData } from '../../../core/data/remote-data';
import { PaginatedList } from '../../../core/data/paginated-list.model'; import { PaginatedList } from '../../../core/data/paginated-list.model';
import { ViewMode } from '../../../core/shared/view-mode.model'; import { ViewMode } from '../../../core/shared/view-mode.model';
import { RelationshipService } from '../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../core/data/relationship-data.service';
import { AbstractIncrementalListComponent } from '../abstract-incremental-list/abstract-incremental-list.component'; import { AbstractIncrementalListComponent } from '../abstract-incremental-list/abstract-incremental-list.component';
import { FindListOptions } from '../../../core/data/find-list-options.model'; import { FindListOptions } from '../../../core/data/find-list-options.model';
@@ -53,7 +53,7 @@ export class RelatedItemsComponent extends AbstractIncrementalListComponent<Obse
*/ */
viewMode = ViewMode.ListElement; viewMode = ViewMode.ListElement;
constructor(public relationshipService: RelationshipService) { constructor(public relationshipService: RelationshipDataService) {
super(); super();
} }

View File

@@ -5,7 +5,7 @@ import { Item } from '../../../core/shared/item.model';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { createRelationshipsObservable } from '../item-types/shared/item.component.spec'; import { createRelationshipsObservable } from '../item-types/shared/item.component.spec';
import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
import { RelationshipService } from '../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../core/data/relationship-data.service';
import { TranslateModule } from '@ngx-translate/core'; import { TranslateModule } from '@ngx-translate/core';
import { VarDirective } from '../../../shared/utils/var.directive'; import { VarDirective } from '../../../shared/utils/var.directive';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
@@ -28,7 +28,7 @@ const mockItem2: Item = Object.assign(new Item(), {
}); });
const mockItems = [mockItem1, mockItem2]; const mockItems = [mockItem1, mockItem2];
const relationType = 'isItemOfItem'; const relationType = 'isItemOfItem';
let relationshipService: RelationshipService; let relationshipService: RelationshipDataService;
describe('RelatedItemsComponent', () => { describe('RelatedItemsComponent', () => {
let comp: RelatedItemsComponent; let comp: RelatedItemsComponent;
@@ -45,7 +45,7 @@ describe('RelatedItemsComponent', () => {
imports: [TranslateModule.forRoot()], imports: [TranslateModule.forRoot()],
declarations: [RelatedItemsComponent, VarDirective], declarations: [RelatedItemsComponent, VarDirective],
providers: [ providers: [
{ provide: RelationshipService, useValue: relationshipService } { provide: RelationshipDataService, useValue: relationshipService }
], ],
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(RelatedItemsComponent, { }).overrideComponent(RelatedItemsComponent, {

View File

@@ -7,7 +7,7 @@ import { TranslateModule } from '@ngx-translate/core';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { createPaginatedList, createTestComponent } from '../../../shared/testing/utils.test'; import { createPaginatedList, createTestComponent } from '../../../shared/testing/utils.test';
import { MyDSpaceNewExternalDropdownComponent } from './my-dspace-new-external-dropdown.component'; import { MyDSpaceNewExternalDropdownComponent } from './my-dspace-new-external-dropdown.component';
import { EntityTypeService } from '../../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../../core/data/entity-type-data.service';
import { ItemType } from '../../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../../core/shared/item-relationships/item-type.model';
import { ResourceType } from '../../../core/shared/resource-type'; import { ResourceType } from '../../../core/shared/resource-type';
import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
@@ -15,7 +15,7 @@ import { PageInfo } from '../../../core/shared/page-info.model';
import { RouterStub } from '../../../shared/testing/router.stub'; import { RouterStub } from '../../../shared/testing/router.stub';
import { BrowserOnlyMockPipe } from '../../../shared/testing/browser-only-mock.pipe'; import { BrowserOnlyMockPipe } from '../../../shared/testing/browser-only-mock.pipe';
export function getMockEntityTypeService(): EntityTypeService { export function getMockEntityTypeService(): EntityTypeDataService {
const pageInfo = { elementsPerPage: 20, totalElements: 4, totalPages: 1, currentPage: 0 } as PageInfo; const pageInfo = { elementsPerPage: 20, totalElements: 4, totalPages: 1, currentPage: 0 } as PageInfo;
const type1: ItemType = { const type1: ItemType = {
id: '1', id: '1',
@@ -45,7 +45,7 @@ export function getMockEntityTypeService(): EntityTypeService {
}); });
} }
export function getMockEmptyEntityTypeService(): EntityTypeService { export function getMockEmptyEntityTypeService(): EntityTypeDataService {
const pageInfo = { elementsPerPage: 20, totalElements: 1, totalPages: 1, currentPage: 0 } as PageInfo; const pageInfo = { elementsPerPage: 20, totalElements: 1, totalPages: 1, currentPage: 0 } as PageInfo;
const type1: ItemType = { const type1: ItemType = {
id: '1', id: '1',
@@ -88,7 +88,7 @@ describe('MyDSpaceNewExternalDropdownComponent test', () => {
BrowserOnlyMockPipe BrowserOnlyMockPipe
], ],
providers: [ providers: [
{ provide: EntityTypeService, useValue: getMockEmptyEntityTypeService() }, { provide: EntityTypeDataService, useValue: getMockEmptyEntityTypeService() },
{ provide: Router, useValue: new RouterStub() }, { provide: Router, useValue: new RouterStub() },
MyDSpaceNewExternalDropdownComponent MyDSpaceNewExternalDropdownComponent
], ],
@@ -140,7 +140,7 @@ describe('MyDSpaceNewExternalDropdownComponent test', () => {
BrowserOnlyMockPipe, BrowserOnlyMockPipe,
], ],
providers: [ providers: [
{ provide: EntityTypeService, useValue: getMockEntityTypeService() }, { provide: EntityTypeDataService, useValue: getMockEntityTypeService() },
{ provide: Router, useValue: new RouterStub() }, { provide: Router, useValue: new RouterStub() },
MyDSpaceNewExternalDropdownComponent MyDSpaceNewExternalDropdownComponent
], ],

View File

@@ -4,7 +4,7 @@ import { Router } from '@angular/router';
import { Observable, of as observableOf, Subscription } from 'rxjs'; import { Observable, of as observableOf, Subscription } from 'rxjs';
import { map, mergeMap, take } from 'rxjs/operators'; import { map, mergeMap, take } from 'rxjs/operators';
import { EntityTypeService } from '../../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../../core/data/entity-type-data.service';
import { ItemType } from '../../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../../core/shared/item-relationships/item-type.model';
import { hasValue } from '../../../shared/empty.util'; import { hasValue } from '../../../shared/empty.util';
import { RemoteData } from '../../../core/data/remote-data'; import { RemoteData } from '../../../core/data/remote-data';
@@ -50,10 +50,10 @@ export class MyDSpaceNewExternalDropdownComponent implements OnInit, OnDestroy {
/** /**
* Initialize instance variables * Initialize instance variables
* *
* @param {EntityTypeService} entityTypeService * @param {EntityTypeDataService} entityTypeService
* @param {Router} router * @param {Router} router
*/ */
constructor(private entityTypeService: EntityTypeService, constructor(private entityTypeService: EntityTypeDataService,
private router: Router) { } private router: Router) { }
/** /**

View File

@@ -7,14 +7,14 @@ import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { createPaginatedList, createTestComponent } from '../../../shared/testing/utils.test'; import { createPaginatedList, createTestComponent } from '../../../shared/testing/utils.test';
import { MyDSpaceNewSubmissionDropdownComponent } from './my-dspace-new-submission-dropdown.component'; import { MyDSpaceNewSubmissionDropdownComponent } from './my-dspace-new-submission-dropdown.component';
import { EntityTypeService } from '../../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../../core/data/entity-type-data.service';
import { ItemType } from '../../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../../core/shared/item-relationships/item-type.model';
import { ResourceType } from '../../../core/shared/resource-type'; import { ResourceType } from '../../../core/shared/resource-type';
import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../../shared/remote-data.utils';
import { PageInfo } from '../../../core/shared/page-info.model'; import { PageInfo } from '../../../core/shared/page-info.model';
import { BrowserOnlyMockPipe } from '../../../shared/testing/browser-only-mock.pipe'; import { BrowserOnlyMockPipe } from '../../../shared/testing/browser-only-mock.pipe';
export function getMockEntityTypeService(): EntityTypeService { export function getMockEntityTypeService(): EntityTypeDataService {
const type1: ItemType = { const type1: ItemType = {
id: '1', id: '1',
label: 'Publication', label: 'Publication',
@@ -43,7 +43,7 @@ export function getMockEntityTypeService(): EntityTypeService {
}); });
} }
export function getMockEmptyEntityTypeService(): EntityTypeService { export function getMockEmptyEntityTypeService(): EntityTypeDataService {
const pageInfo = { elementsPerPage: 20, totalElements: 1, totalPages: 1, currentPage: 0 } as PageInfo; const pageInfo = { elementsPerPage: 20, totalElements: 1, totalPages: 1, currentPage: 0 } as PageInfo;
const type1: ItemType = { const type1: ItemType = {
id: '1', id: '1',
@@ -92,7 +92,7 @@ describe('MyDSpaceNewSubmissionDropdownComponent test', () => {
BrowserOnlyMockPipe, BrowserOnlyMockPipe,
], ],
providers: [ providers: [
{ provide: EntityTypeService, useValue: getMockEmptyEntityTypeService() }, { provide: EntityTypeDataService, useValue: getMockEmptyEntityTypeService() },
{ provide: NgbModal, useValue: modalStub }, { provide: NgbModal, useValue: modalStub },
MyDSpaceNewSubmissionDropdownComponent MyDSpaceNewSubmissionDropdownComponent
], ],
@@ -144,7 +144,7 @@ describe('MyDSpaceNewSubmissionDropdownComponent test', () => {
BrowserOnlyMockPipe, BrowserOnlyMockPipe,
], ],
providers: [ providers: [
{ provide: EntityTypeService, useValue: getMockEntityTypeService() }, { provide: EntityTypeDataService, useValue: getMockEntityTypeService() },
{ provide: NgbModal, useValue: modalStub }, { provide: NgbModal, useValue: modalStub },
MyDSpaceNewSubmissionDropdownComponent MyDSpaceNewSubmissionDropdownComponent
], ],

View File

@@ -4,7 +4,7 @@ import { Observable, of as observableOf, Subscription } from 'rxjs';
import { map, mergeMap, take } from 'rxjs/operators'; import { map, mergeMap, take } from 'rxjs/operators';
import { NgbModal } from '@ng-bootstrap/ng-bootstrap'; import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
import { EntityTypeService } from '../../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../../core/data/entity-type-data.service';
import { ItemType } from '../../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../../core/shared/item-relationships/item-type.model';
import { hasValue } from '../../../shared/empty.util'; import { hasValue } from '../../../shared/empty.util';
import { CreateItemParentSelectorComponent } from '../../../shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component'; import { CreateItemParentSelectorComponent } from '../../../shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component';
@@ -51,10 +51,10 @@ export class MyDSpaceNewSubmissionDropdownComponent implements OnInit, OnDestroy
/** /**
* Initialize instance variables * Initialize instance variables
* *
* @param {EntityTypeService} entityTypeService * @param {EntityTypeDataService} entityTypeService
* @param {NgbModal} modalService * @param {NgbModal} modalService
*/ */
constructor(private entityTypeService: EntityTypeService, constructor(private entityTypeService: EntityTypeDataService,
private modalService: NgbModal) { } private modalService: NgbModal) { }
/** /**

View File

@@ -25,7 +25,7 @@ import { CookieService } from '../../core/services/cookie.service';
import { CookieServiceMock } from '../../shared/mocks/cookie.service.mock'; import { CookieServiceMock } from '../../shared/mocks/cookie.service.mock';
import { HttpXsrfTokenExtractorMock } from '../../shared/mocks/http-xsrf-token-extractor.mock'; import { HttpXsrfTokenExtractorMock } from '../../shared/mocks/http-xsrf-token-extractor.mock';
import { getMockEntityTypeService } from './my-dspace-new-submission-dropdown/my-dspace-new-submission-dropdown.component.spec'; import { getMockEntityTypeService } from './my-dspace-new-submission-dropdown/my-dspace-new-submission-dropdown.component.spec';
import { EntityTypeService } from '../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../core/data/entity-type-data.service';
describe('MyDSpaceNewSubmissionComponent test', () => { describe('MyDSpaceNewSubmissionComponent test', () => {
@@ -63,7 +63,7 @@ describe('MyDSpaceNewSubmissionComponent test', () => {
{ provide: HttpXsrfTokenExtractor, useValue: new HttpXsrfTokenExtractorMock('mock-token') }, { provide: HttpXsrfTokenExtractor, useValue: new HttpXsrfTokenExtractorMock('mock-token') },
{ provide: CookieService, useValue: new CookieServiceMock() }, { provide: CookieService, useValue: new CookieServiceMock() },
{ provide: HostWindowService, useValue: new HostWindowServiceStub(800) }, { provide: HostWindowService, useValue: new HostWindowServiceStub(800) },
{ provide: EntityTypeService, useValue: getMockEntityTypeService() }, { provide: EntityTypeDataService, useValue: getMockEntityTypeService() },
], ],
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA]
}).compileComponents(); }).compileComponents();

View File

@@ -11,7 +11,7 @@ import { NotificationsService } from '../../shared/notifications/notifications.s
import { NotificationsServiceStub } from '../../shared/testing/notifications-service.stub'; import { NotificationsServiceStub } from '../../shared/testing/notifications-service.stub';
import { EPerson } from '../../core/eperson/models/eperson.model'; import { EPerson } from '../../core/eperson/models/eperson.model';
import { ResearcherProfile } from '../../core/profile/model/researcher-profile.model'; import { ResearcherProfile } from '../../core/profile/model/researcher-profile.model';
import { ResearcherProfileService } from '../../core/profile/researcher-profile.service'; import { ResearcherProfileDataService } from '../../core/profile/researcher-profile-data.service';
import { VarDirective } from '../../shared/utils/var.directive'; import { VarDirective } from '../../shared/utils/var.directive';
import { ProfilePageResearcherFormComponent } from './profile-page-researcher-form.component'; import { ProfilePageResearcherFormComponent } from './profile-page-researcher-form.component';
import { ProfileClaimService } from '../profile-claim/profile-claim.service'; import { ProfileClaimService } from '../profile-claim/profile-claim.service';
@@ -28,7 +28,7 @@ describe('ProfilePageResearcherFormComponent', () => {
let user: EPerson; let user: EPerson;
let profile: ResearcherProfile; let profile: ResearcherProfile;
let researcherProfileService: jasmine.SpyObj<ResearcherProfileService>; let researcherProfileService: jasmine.SpyObj<ResearcherProfileDataService>;
let notificationsServiceStub: NotificationsServiceStub; let notificationsServiceStub: NotificationsServiceStub;
@@ -75,7 +75,7 @@ describe('ProfilePageResearcherFormComponent', () => {
imports: [TranslateModule.forRoot(), RouterTestingModule.withRoutes([])], imports: [TranslateModule.forRoot(), RouterTestingModule.withRoutes([])],
providers: [ providers: [
NgbModal, NgbModal,
{ provide: ResearcherProfileService, useValue: researcherProfileService }, { provide: ResearcherProfileDataService, useValue: researcherProfileService },
{ provide: NotificationsService, useValue: notificationsServiceStub }, { provide: NotificationsService, useValue: notificationsServiceStub },
{ provide: ProfileClaimService, useValue: profileClaimService }, { provide: ProfileClaimService, useValue: profileClaimService },
{ provide: AuthService, useValue: authService } { provide: AuthService, useValue: authService }

View File

@@ -12,7 +12,7 @@ import { NotificationsService } from '../../shared/notifications/notifications.s
import { AuthService } from '../../core/auth/auth.service'; import { AuthService } from '../../core/auth/auth.service';
import { EPerson } from '../../core/eperson/models/eperson.model'; import { EPerson } from '../../core/eperson/models/eperson.model';
import { ResearcherProfile } from '../../core/profile/model/researcher-profile.model'; import { ResearcherProfile } from '../../core/profile/model/researcher-profile.model';
import { ResearcherProfileService } from '../../core/profile/researcher-profile.service'; import { ResearcherProfileDataService } from '../../core/profile/researcher-profile-data.service';
import { ProfileClaimService } from '../profile-claim/profile-claim.service'; import { ProfileClaimService } from '../profile-claim/profile-claim.service';
import { RemoteData } from '../../core/data/remote-data'; import { RemoteData } from '../../core/data/remote-data';
import { isNotEmpty } from '../../shared/empty.util'; import { isNotEmpty } from '../../shared/empty.util';
@@ -56,7 +56,7 @@ export class ProfilePageResearcherFormComponent implements OnInit {
*/ */
researcherProfileItemId: string; researcherProfileItemId: string;
constructor(protected researcherProfileService: ResearcherProfileService, constructor(protected researcherProfileService: ResearcherProfileDataService,
protected profileClaimService: ProfileClaimService, protected profileClaimService: ProfileClaimService,
protected translationService: TranslateService, protected translationService: TranslateService,
protected notificationService: NotificationsService, protected notificationService: NotificationsService,

View File

@@ -9,7 +9,7 @@ import { AuthorizationDataService } from '../../../core/data/feature-authorizati
import { NotificationsService } from '../../notifications/notifications.service'; import { NotificationsService } from '../../notifications/notifications.service';
import { NotificationsServiceStub } from '../../testing/notifications-service.stub'; import { NotificationsServiceStub } from '../../testing/notifications-service.stub';
import { TranslateLoaderMock } from '../../mocks/translate-loader.mock'; import { TranslateLoaderMock } from '../../mocks/translate-loader.mock';
import { ResearcherProfileService } from '../../../core/profile/researcher-profile.service'; import { ResearcherProfileDataService } from '../../../core/profile/researcher-profile-data.service';
import { RouteService } from '../../../core/services/route.service'; import { RouteService } from '../../../core/services/route.service';
import { routeServiceStub } from '../../testing/route-service.stub'; import { routeServiceStub } from '../../testing/route-service.stub';
import { Item } from '../../../core/shared/item.model'; import { Item } from '../../../core/shared/item.model';
@@ -102,7 +102,7 @@ describe('PersonPageClaimButtonComponent', () => {
providers: [ providers: [
{ provide: AuthorizationDataService, useValue: authorizationDataService }, { provide: AuthorizationDataService, useValue: authorizationDataService },
{ provide: NotificationsService, useValue: notificationsService }, { provide: NotificationsService, useValue: notificationsService },
{ provide: ResearcherProfileService, useValue: researcherProfileService }, { provide: ResearcherProfileDataService, useValue: researcherProfileService },
{ provide: RouteService, useValue: routeServiceStub }, { provide: RouteService, useValue: routeServiceStub },
] ]
}) })

View File

@@ -7,7 +7,7 @@ import { TranslateService } from '@ngx-translate/core';
import { RouteService } from '../../../core/services/route.service'; import { RouteService } from '../../../core/services/route.service';
import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service'; import { AuthorizationDataService } from '../../../core/data/feature-authorization/authorization-data.service';
import { NotificationsService } from '../../notifications/notifications.service'; import { NotificationsService } from '../../notifications/notifications.service';
import { ResearcherProfileService } from '../../../core/profile/researcher-profile.service'; import { ResearcherProfileDataService } from '../../../core/profile/researcher-profile-data.service';
import { FeatureID } from '../../../core/data/feature-authorization/feature-id'; import { FeatureID } from '../../../core/data/feature-authorization/feature-id';
import { getFirstCompletedRemoteData } from '../../../core/shared/operators'; import { getFirstCompletedRemoteData } from '../../../core/shared/operators';
import { RemoteData } from '../../../core/data/remote-data'; import { RemoteData } from '../../../core/data/remote-data';
@@ -36,7 +36,7 @@ export class PersonPageClaimButtonComponent implements OnInit {
protected authorizationService: AuthorizationDataService, protected authorizationService: AuthorizationDataService,
protected notificationsService: NotificationsService, protected notificationsService: NotificationsService,
protected translate: TranslateService, protected translate: TranslateService,
protected researcherProfileService: ResearcherProfileService) { protected researcherProfileService: ResearcherProfileDataService) {
} }
ngOnInit(): void { ngOnInit(): void {

View File

@@ -4,7 +4,7 @@ import { getTestScheduler } from 'jasmine-marbles';
import { createSuccessfulRemoteDataObject$ } from '../remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../remote-data.utils';
import { ItemType } from '../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../core/shared/item-relationships/item-type.model';
import { ChangeDetectorRef, NO_ERRORS_SCHEMA, Pipe, PipeTransform } from '@angular/core'; import { ChangeDetectorRef, NO_ERRORS_SCHEMA, Pipe, PipeTransform } from '@angular/core';
import { EntityTypeService } from '../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../core/data/entity-type-data.service';
import { TestScheduler } from 'rxjs/testing'; import { TestScheduler } from 'rxjs/testing';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { createPaginatedList } from '../testing/utils.test'; import { createPaginatedList } from '../testing/utils.test';
@@ -75,7 +75,7 @@ describe('EntityDropdownComponent', () => {
imports: [], imports: [],
declarations: [EntityDropdownComponent, MockTranslatePipe], declarations: [EntityDropdownComponent, MockTranslatePipe],
providers: [ providers: [
{ provide: EntityTypeService, useValue: entityTypeServiceMock }, { provide: EntityTypeDataService, useValue: entityTypeServiceMock },
ChangeDetectorRef ChangeDetectorRef
], ],
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA]

View File

@@ -14,7 +14,7 @@ import { hasValue } from '../empty.util';
import { reduce, startWith, switchMap } from 'rxjs/operators'; import { reduce, startWith, switchMap } from 'rxjs/operators';
import { RemoteData } from '../../core/data/remote-data'; import { RemoteData } from '../../core/data/remote-data';
import { PaginatedList } from '../../core/data/paginated-list.model'; import { PaginatedList } from '../../core/data/paginated-list.model';
import { EntityTypeService } from '../../core/data/entity-type.service'; import { EntityTypeDataService } from '../../core/data/entity-type-data.service';
import { ItemType } from '../../core/shared/item-relationships/item-type.model'; import { ItemType } from '../../core/shared/item-relationships/item-type.model';
import { getFirstSucceededRemoteWithNotEmptyData } from '../../core/shared/operators'; import { getFirstSucceededRemoteWithNotEmptyData } from '../../core/shared/operators';
import { FindListOptions } from '../../core/data/find-list-options.model'; import { FindListOptions } from '../../core/data/find-list-options.model';
@@ -83,12 +83,12 @@ export class EntityDropdownComponent implements OnInit, OnDestroy {
* Initialize instance variables * Initialize instance variables
* *
* @param {ChangeDetectorRef} changeDetectorRef * @param {ChangeDetectorRef} changeDetectorRef
* @param {EntityTypeService} entityTypeService * @param {EntityTypeDataService} entityTypeService
* @param {ElementRef} el * @param {ElementRef} el
*/ */
constructor( constructor(
private changeDetectorRef: ChangeDetectorRef, private changeDetectorRef: ChangeDetectorRef,
private entityTypeService: EntityTypeService, private entityTypeService: EntityTypeDataService,
private el: ElementRef private el: ElementRef
) { } ) { }

View File

@@ -66,7 +66,7 @@ import { DsDynamicFormGroupComponent } from './models/form-group/dynamic-form-gr
import { DsDynamicRelationGroupComponent } from './models/relation-group/dynamic-relation-group.components'; import { DsDynamicRelationGroupComponent } from './models/relation-group/dynamic-relation-group.components';
import { DsDatePickerInlineComponent } from './models/date-picker-inline/dynamic-date-picker-inline.component'; import { DsDatePickerInlineComponent } from './models/date-picker-inline/dynamic-date-picker-inline.component';
import { DsDynamicTypeBindRelationService } from './ds-dynamic-type-bind-relation.service'; import { DsDynamicTypeBindRelationService } from './ds-dynamic-type-bind-relation.service';
import { RelationshipService } from '../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../core/data/relationship-data.service';
import { SelectableListService } from '../../../object-list/selectable-list/selectable-list.service'; import { SelectableListService } from '../../../object-list/selectable-list/selectable-list.service';
import { ItemDataService } from '../../../../core/data/item-data.service'; import { ItemDataService } from '../../../../core/data/item-data.service';
import { Store } from '@ngrx/store'; import { Store } from '@ngrx/store';
@@ -215,11 +215,11 @@ describe('DsDynamicFormControlContainerComponent test suite', () => {
DsDynamicFormControlContainerComponent, DsDynamicFormControlContainerComponent,
DynamicFormService, DynamicFormService,
{ provide: DsDynamicTypeBindRelationService, useValue: getMockDsDynamicTypeBindRelationService() }, { provide: DsDynamicTypeBindRelationService, useValue: getMockDsDynamicTypeBindRelationService() },
{ provide: RelationshipService, useValue: {} }, { provide: RelationshipDataService, useValue: {} },
{ provide: SelectableListService, useValue: {} }, { provide: SelectableListService, useValue: {} },
{ provide: ItemDataService, useValue: {} }, { provide: ItemDataService, useValue: {} },
{ provide: Store, useValue: {} }, { provide: Store, useValue: {} },
{ provide: RelationshipService, useValue: {} }, { provide: RelationshipDataService, useValue: {} },
{ provide: SelectableListService, useValue: {} }, { provide: SelectableListService, useValue: {} },
{ provide: FormService, useValue: {} }, { provide: FormService, useValue: {} },
{ provide: FormBuilderService, useValue: {} }, { provide: FormBuilderService, useValue: {} },

View File

@@ -85,7 +85,7 @@ import { DsDynamicTypeBindRelationService } from './ds-dynamic-type-bind-relatio
import { SearchResult } from '../../../search/models/search-result.model'; import { SearchResult } from '../../../search/models/search-result.model';
import { DSpaceObject } from '../../../../core/shared/dspace-object.model'; import { DSpaceObject } from '../../../../core/shared/dspace-object.model';
import { NgbModal, NgbModalRef } from '@ng-bootstrap/ng-bootstrap'; import { NgbModal, NgbModalRef } from '@ng-bootstrap/ng-bootstrap';
import { RelationshipService } from '../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../core/data/relationship-data.service';
import { SelectableListService } from '../../../object-list/selectable-list/selectable-list.service'; import { SelectableListService } from '../../../object-list/selectable-list/selectable-list.service';
import { DsDynamicDisabledComponent } from './models/disabled/dynamic-disabled.component'; import { DsDynamicDisabledComponent } from './models/disabled/dynamic-disabled.component';
import { DYNAMIC_FORM_CONTROL_TYPE_DISABLED } from './models/disabled/dynamic-disabled.model'; import { DYNAMIC_FORM_CONTROL_TYPE_DISABLED } from './models/disabled/dynamic-disabled.model';
@@ -244,7 +244,7 @@ export class DsDynamicFormControlContainerComponent extends DynamicFormControlCo
protected translateService: TranslateService, protected translateService: TranslateService,
protected relationService: DynamicFormRelationService, protected relationService: DynamicFormRelationService,
private modalService: NgbModal, private modalService: NgbModal,
private relationshipService: RelationshipService, private relationshipService: RelationshipDataService,
private selectableListService: SelectableListService, private selectableListService: SelectableListService,
private itemService: ItemDataService, private itemService: ItemDataService,
private zone: NgZone, private zone: NgZone,

View File

@@ -6,8 +6,8 @@ import { of as observableOf, Subscription } from 'rxjs';
import { DsDynamicLookupRelationModalComponent } from './dynamic-lookup-relation-modal.component'; import { DsDynamicLookupRelationModalComponent } from './dynamic-lookup-relation-modal.component';
import { NgbActiveModal, NgbModule } from '@ng-bootstrap/ng-bootstrap'; import { NgbActiveModal, NgbModule } from '@ng-bootstrap/ng-bootstrap';
import { SelectableListService } from '../../../../object-list/selectable-list/selectable-list.service'; import { SelectableListService } from '../../../../object-list/selectable-list/selectable-list.service';
import { RelationshipService } from '../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../core/data/relationship-data.service';
import { RelationshipTypeService } from '../../../../../core/data/relationship-type.service'; import { RelationshipTypeDataService } from '../../../../../core/data/relationship-type-data.service';
import { Store } from '@ngrx/store'; import { Store } from '@ngrx/store';
import { Item } from '../../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { ItemSearchResult } from '../../../../object-collection/shared/item-search-result.model'; import { ItemSearchResult } from '../../../../object-collection/shared/item-search-result.model';
@@ -18,7 +18,7 @@ import { PaginatedSearchOptions } from '../../../../search/models/paginated-sear
import { ExternalSource } from '../../../../../core/shared/external-source.model'; import { ExternalSource } from '../../../../../core/shared/external-source.model';
import { createSuccessfulRemoteDataObject$ } from '../../../../remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../../../remote-data.utils';
import { createPaginatedList } from '../../../../testing/utils.test'; import { createPaginatedList } from '../../../../testing/utils.test';
import { ExternalSourceService } from '../../../../../core/data/external-source.service'; import { ExternalSourceDataService } from '../../../../../core/data/external-source-data.service';
import { LookupRelationService } from '../../../../../core/data/lookup-relation.service'; import { LookupRelationService } from '../../../../../core/data/lookup-relation.service';
import { RemoteDataBuildService } from '../../../../../core/cache/builders/remote-data-build.service'; import { RemoteDataBuildService } from '../../../../../core/cache/builders/remote-data-build.service';
import { WorkspaceItem } from '../../../../../core/submission/models/workspaceitem.model'; import { WorkspaceItem } from '../../../../../core/submission/models/workspaceitem.model';
@@ -111,15 +111,15 @@ describe('DsDynamicLookupRelationModalComponent', () => {
paginatedSearchOptions: observableOf(pSearchOptions) paginatedSearchOptions: observableOf(pSearchOptions)
} }
}, },
{ provide: ExternalSourceService, useValue: externalSourceService }, { provide: ExternalSourceDataService, useValue: externalSourceService },
{ provide: LookupRelationService, useValue: lookupRelationService }, { provide: LookupRelationService, useValue: lookupRelationService },
{ {
provide: SelectableListService, useValue: selectableListService provide: SelectableListService, useValue: selectableListService
}, },
{ {
provide: RelationshipService, useValue: { getNameVariant: () => observableOf(nameVariant) } provide: RelationshipDataService, useValue: { getNameVariant: () => observableOf(nameVariant) }
}, },
{ provide: RelationshipTypeService, useValue: {} }, { provide: RelationshipTypeDataService, useValue: {} },
{ provide: RemoteDataBuildService, useValue: rdbService }, { provide: RemoteDataBuildService, useValue: rdbService },
{ {
provide: Store, useValue: { provide: Store, useValue: {

View File

@@ -16,14 +16,14 @@ import {
RemoveRelationshipAction, RemoveRelationshipAction,
UpdateRelationshipNameVariantAction, UpdateRelationshipNameVariantAction,
} from './relationship.actions'; } from './relationship.actions';
import { RelationshipService } from '../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../core/data/relationship-data.service';
import { RelationshipTypeService } from '../../../../../core/data/relationship-type.service'; import { RelationshipTypeDataService } from '../../../../../core/data/relationship-type-data.service';
import { Store } from '@ngrx/store'; import { Store } from '@ngrx/store';
import { AppState } from '../../../../../app.reducer'; import { AppState } from '../../../../../app.reducer';
import { Context } from '../../../../../core/shared/context.model'; import { Context } from '../../../../../core/shared/context.model';
import { LookupRelationService } from '../../../../../core/data/lookup-relation.service'; import { LookupRelationService } from '../../../../../core/data/lookup-relation.service';
import { ExternalSource } from '../../../../../core/shared/external-source.model'; import { ExternalSource } from '../../../../../core/shared/external-source.model';
import { ExternalSourceService } from '../../../../../core/data/external-source.service'; import { ExternalSourceDataService } from '../../../../../core/data/external-source-data.service';
import { Router } from '@angular/router'; import { Router } from '@angular/router';
import { RemoteDataBuildService } from '../../../../../core/cache/builders/remote-data-build.service'; import { RemoteDataBuildService } from '../../../../../core/cache/builders/remote-data-build.service';
import { getAllSucceededRemoteDataPayload } from '../../../../../core/shared/operators'; import { getAllSucceededRemoteDataPayload } from '../../../../../core/shared/operators';
@@ -156,9 +156,9 @@ export class DsDynamicLookupRelationModalComponent implements OnInit, OnDestroy
constructor( constructor(
public modal: NgbActiveModal, public modal: NgbActiveModal,
private selectableListService: SelectableListService, private selectableListService: SelectableListService,
private relationshipService: RelationshipService, private relationshipService: RelationshipDataService,
private relationshipTypeService: RelationshipTypeService, private relationshipTypeService: RelationshipTypeDataService,
private externalSourceService: ExternalSourceService, private externalSourceService: ExternalSourceDataService,
private lookupRelationService: LookupRelationService, private lookupRelationService: LookupRelationService,
private searchConfigService: SearchConfigurationService, private searchConfigService: SearchConfigurationService,
private rdbService: RemoteDataBuildService, private rdbService: RemoteDataBuildService,

View File

@@ -12,7 +12,7 @@ import {
createPendingRemoteDataObject$, createPendingRemoteDataObject$,
createSuccessfulRemoteDataObject$ createSuccessfulRemoteDataObject$
} from '../../../../../remote-data.utils'; } from '../../../../../remote-data.utils';
import { ExternalSourceService } from '../../../../../../core/data/external-source.service'; import { ExternalSourceDataService } from '../../../../../../core/data/external-source-data.service';
import { ExternalSource } from '../../../../../../core/shared/external-source.model'; import { ExternalSource } from '../../../../../../core/shared/external-source.model';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
@@ -107,7 +107,7 @@ describe('DsDynamicLookupRelationExternalSourceTabComponent', () => {
paginatedSearchOptions: observableOf(pSearchOptions) paginatedSearchOptions: observableOf(pSearchOptions)
} }
}, },
{ provide: ExternalSourceService, useValue: externalSourceService }, { provide: ExternalSourceDataService, useValue: externalSourceService },
{ provide: SelectableListService, useValue: selectableListService }, { provide: SelectableListService, useValue: selectableListService },
{ provide: PaginationService, useValue: new PaginationServiceStub() } { provide: PaginationService, useValue: new PaginationServiceStub() }
], ],

View File

@@ -2,7 +2,7 @@ import { Component, EventEmitter, Input, OnDestroy, OnInit, Output } from '@angu
import { SEARCH_CONFIG_SERVICE } from '../../../../../../my-dspace-page/my-dspace-page.component'; import { SEARCH_CONFIG_SERVICE } from '../../../../../../my-dspace-page/my-dspace-page.component';
import { SearchConfigurationService } from '../../../../../../core/shared/search/search-configuration.service'; import { SearchConfigurationService } from '../../../../../../core/shared/search/search-configuration.service';
import { Router } from '@angular/router'; import { Router } from '@angular/router';
import { ExternalSourceService } from '../../../../../../core/data/external-source.service'; import { ExternalSourceDataService } from '../../../../../../core/data/external-source-data.service';
import { RemoteData } from '../../../../../../core/data/remote-data'; import { RemoteData } from '../../../../../../core/data/remote-data';
import { PaginatedList } from '../../../../../../core/data/paginated-list.model'; import { PaginatedList } from '../../../../../../core/data/paginated-list.model';
import { ExternalSourceEntry } from '../../../../../../core/shared/external-source-entry.model'; import { ExternalSourceEntry } from '../../../../../../core/shared/external-source-entry.model';
@@ -125,7 +125,7 @@ export class DsDynamicLookupRelationExternalSourceTabComponent implements OnInit
constructor(private router: Router, constructor(private router: Router,
public searchConfigService: SearchConfigurationService, public searchConfigService: SearchConfigurationService,
private externalSourceService: ExternalSourceService, private externalSourceService: ExternalSourceDataService,
private modalService: NgbModal, private modalService: NgbModal,
private selectableListService: SelectableListService, private selectableListService: SelectableListService,
private paginationService: PaginationService private paginationService: PaginationService

View File

@@ -6,8 +6,8 @@ import { RelationshipEffects } from './relationship.effects';
import { AddRelationshipAction, RelationshipActionTypes, RemoveRelationshipAction } from './relationship.actions'; import { AddRelationshipAction, RelationshipActionTypes, RemoveRelationshipAction } from './relationship.actions';
import { Item } from '../../../../../core/shared/item.model'; import { Item } from '../../../../../core/shared/item.model';
import { MetadataValue } from '../../../../../core/shared/metadata.models'; import { MetadataValue } from '../../../../../core/shared/metadata.models';
import { RelationshipTypeService } from '../../../../../core/data/relationship-type.service'; import { RelationshipTypeDataService } from '../../../../../core/data/relationship-type-data.service';
import { RelationshipService } from '../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../core/data/relationship-data.service';
import { Relationship } from '../../../../../core/shared/item-relationships/relationship.model'; import { Relationship } from '../../../../../core/shared/item-relationships/relationship.model';
import { createSuccessfulRemoteDataObject$ } from '../../../../remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../../../../remote-data.utils';
import { RelationshipType } from '../../../../../core/shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../../../../../core/shared/item-relationships/relationship-type.model';
@@ -116,8 +116,8 @@ describe('RelationshipEffects', () => {
providers: [ providers: [
RelationshipEffects, RelationshipEffects,
provideMockActions(() => actions), provideMockActions(() => actions),
{ provide: RelationshipTypeService, useValue: mockRelationshipTypeService }, { provide: RelationshipTypeDataService, useValue: mockRelationshipTypeService },
{ provide: RelationshipService, useValue: mockRelationshipService }, { provide: RelationshipDataService, useValue: mockRelationshipService },
{ {
provide: SubmissionObjectDataService, useValue: { provide: SubmissionObjectDataService, useValue: {
findById: () => createSuccessfulRemoteDataObject$(new WorkspaceItem()) findById: () => createSuccessfulRemoteDataObject$(new WorkspaceItem())

View File

@@ -2,7 +2,7 @@ import { Inject, Injectable } from '@angular/core';
import { Actions, createEffect, ofType } from '@ngrx/effects'; import { Actions, createEffect, ofType } from '@ngrx/effects';
import { filter, map, mergeMap, switchMap, take } from 'rxjs/operators'; import { filter, map, mergeMap, switchMap, take } from 'rxjs/operators';
import { BehaviorSubject, Observable } from 'rxjs'; import { BehaviorSubject, Observable } from 'rxjs';
import { RelationshipService } from '../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../core/data/relationship-data.service';
import { import {
getRemoteDataPayload, getRemoteDataPayload,
getFirstSucceededRemoteData, DEBOUNCE_TIME_OPERATOR getFirstSucceededRemoteData, DEBOUNCE_TIME_OPERATOR
@@ -18,7 +18,7 @@ import { Item } from '../../../../../core/shared/item.model';
import { hasNoValue, hasValue, hasValueOperator } from '../../../../empty.util'; import { hasNoValue, hasValue, hasValueOperator } from '../../../../empty.util';
import { Relationship } from '../../../../../core/shared/item-relationships/relationship.model'; import { Relationship } from '../../../../../core/shared/item-relationships/relationship.model';
import { RelationshipType } from '../../../../../core/shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../../../../../core/shared/item-relationships/relationship-type.model';
import { RelationshipTypeService } from '../../../../../core/data/relationship-type.service'; import { RelationshipTypeDataService } from '../../../../../core/data/relationship-type-data.service';
import { SubmissionObjectDataService } from '../../../../../core/submission/submission-object-data.service'; import { SubmissionObjectDataService } from '../../../../../core/submission/submission-object-data.service';
import { SaveSubmissionSectionFormSuccessAction } from '../../../../../submission/objects/submission-objects.actions'; import { SaveSubmissionSectionFormSuccessAction } from '../../../../../submission/objects/submission-objects.actions';
import { SubmissionObject } from '../../../../../core/submission/models/submission-object.model'; import { SubmissionObject } from '../../../../../core/submission/models/submission-object.model';
@@ -150,8 +150,8 @@ export class RelationshipEffects {
)); ));
constructor(private actions$: Actions, constructor(private actions$: Actions,
private relationshipService: RelationshipService, private relationshipService: RelationshipDataService,
private relationshipTypeService: RelationshipTypeService, private relationshipTypeService: RelationshipTypeDataService,
private submissionObjectService: SubmissionObjectDataService, private submissionObjectService: SubmissionObjectDataService,
private store: Store<SubmissionState>, private store: Store<SubmissionState>,
private objectCache: ObjectCacheService, private objectCache: ObjectCacheService,

View File

@@ -17,7 +17,7 @@ import { Item } from '../../../../../../core/shared/item.model';
import { LookupRelationService } from '../../../../../../core/data/lookup-relation.service'; import { LookupRelationService } from '../../../../../../core/data/lookup-relation.service';
import { PaginationService } from '../../../../../../core/pagination/pagination.service'; import { PaginationService } from '../../../../../../core/pagination/pagination.service';
import { PaginationServiceStub } from '../../../../../testing/pagination-service.stub'; import { PaginationServiceStub } from '../../../../../testing/pagination-service.stub';
import { RelationshipService } from '../../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../../core/data/relationship-data.service';
import { relatedRelationships } from '../../../../../testing/related-relationships.mock'; import { relatedRelationships } from '../../../../../testing/related-relationships.mock';
import { RelationshipType } from '../../../../../../core/shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../../../../../../core/shared/item-relationships/relationship-type.model';
import { SearchObjects } from '../../../../../search/models/search-objects.model'; import { SearchObjects } from '../../../../../search/models/search-objects.model';
@@ -106,7 +106,7 @@ describe('DsDynamicLookupRelationSearchTabComponent', () => {
}, },
{ provide: LookupRelationService, useValue: lookupRelationService }, { provide: LookupRelationService, useValue: lookupRelationService },
{ provide: PaginationService, useValue: new PaginationServiceStub() }, { provide: PaginationService, useValue: new PaginationServiceStub() },
{ provide: RelationshipService, useValue: relationshipService } { provide: RelationshipDataService, useValue: relationshipService }
], ],
schemas: [NO_ERRORS_SCHEMA] schemas: [NO_ERRORS_SCHEMA]

View File

@@ -17,7 +17,7 @@ import { CollectionElementLinkType } from '../../../../../object-collection/coll
import { Context } from '../../../../../../core/shared/context.model'; import { Context } from '../../../../../../core/shared/context.model';
import { LookupRelationService } from '../../../../../../core/data/lookup-relation.service'; import { LookupRelationService } from '../../../../../../core/data/lookup-relation.service';
import { PaginationService } from '../../../../../../core/pagination/pagination.service'; import { PaginationService } from '../../../../../../core/pagination/pagination.service';
import { RelationshipService } from '../../../../../../core/data/relationship.service'; import { RelationshipDataService } from '../../../../../../core/data/relationship-data.service';
import { RelationshipType } from '../../../../../../core/shared/item-relationships/relationship-type.model'; import { RelationshipType } from '../../../../../../core/shared/item-relationships/relationship-type.model';
import { Relationship } from '../../../../../../core/shared/item-relationships/relationship.model'; import { Relationship } from '../../../../../../core/shared/item-relationships/relationship.model';
@@ -151,7 +151,7 @@ export class DsDynamicLookupRelationSearchTabComponent implements OnInit, OnDest
private selectableListService: SelectableListService, private selectableListService: SelectableListService,
public searchConfigService: SearchConfigurationService, public searchConfigService: SearchConfigurationService,
public lookupRelationService: LookupRelationService, public lookupRelationService: LookupRelationService,
private relationshipService: RelationshipService, private relationshipService: RelationshipDataService,
private paginationService: PaginationService private paginationService: PaginationService
) { ) {
} }

View File

@@ -1,4 +1,4 @@
import { ExternalSourceService } from '../../core/data/external-source.service'; import { ExternalSourceDataService } from '../../core/data/external-source-data.service';
import { ExternalSource } from '../../core/shared/external-source.model'; import { ExternalSource } from '../../core/shared/external-source.model';
import { ResourceType } from '../../core/shared/resource-type'; import { ResourceType } from '../../core/shared/resource-type';
@@ -59,7 +59,7 @@ export const externalSourceMyStaffDb: ExternalSource = {
/** /**
* Mock for [[ExternalSourceService]] * Mock for [[ExternalSourceService]]
*/ */
export function getMockExternalSourceService(): ExternalSourceService { export function getMockExternalSourceService(): ExternalSourceDataService {
return jasmine.createSpyObj('ExternalSourceService', { return jasmine.createSpyObj('ExternalSourceService', {
findAll: jasmine.createSpy('findAll'), findAll: jasmine.createSpy('findAll'),
searchBy: jasmine.createSpy('searchBy'), searchBy: jasmine.createSpy('searchBy'),

View File

@@ -1,6 +1,6 @@
import { ResourcePolicyService } from '../../core/resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from '../../core/resource-policy/resource-policy-data.service';
export function getMockResourcePolicyService(): ResourcePolicyService { export function getMockResourcePolicyService(): ResourcePolicyDataService {
return jasmine.createSpyObj('resourcePolicyService', { return jasmine.createSpyObj('resourcePolicyService', {
searchByResource: jasmine.createSpy('searchByResource'), searchByResource: jasmine.createSpy('searchByResource'),
create: jasmine.createSpy('create'), create: jasmine.createSpy('create'),

View File

@@ -1,4 +1,4 @@
import { SubmissionFormsConfigService } from '../../core/config/submission-forms-config.service'; import { SubmissionFormsConfigDataService } from '../../core/config/submission-forms-config-data.service';
import { SubmissionFormsModel } from '../../core/config/models/config-submission-forms.model'; import { SubmissionFormsModel } from '../../core/config/models/config-submission-forms.model';
import { createSuccessfulRemoteDataObject$ } from '../remote-data.utils'; import { createSuccessfulRemoteDataObject$ } from '../remote-data.utils';
@@ -73,14 +73,14 @@ const configResNotChangeDiscoverable = Object.assign(new SubmissionFormsModel(),
} }
}); });
export function getSubmissionAccessesConfigService(): SubmissionFormsConfigService { export function getSubmissionAccessesConfigService(): SubmissionFormsConfigDataService {
return jasmine.createSpyObj('SubmissionAccessesConfigService', { return jasmine.createSpyObj('SubmissionAccessesConfigService', {
findByHref: createSuccessfulRemoteDataObject$(configRes), findByHref: createSuccessfulRemoteDataObject$(configRes),
}); });
} }
export function getSubmissionAccessesConfigNotChangeDiscoverableService(): SubmissionFormsConfigService { export function getSubmissionAccessesConfigNotChangeDiscoverableService(): SubmissionFormsConfigDataService {
return jasmine.createSpyObj('SubmissionAccessesConfigService', { return jasmine.createSpyObj('SubmissionAccessesConfigService', {
findByHref: createSuccessfulRemoteDataObject$(configResNotChangeDiscoverable), findByHref: createSuccessfulRemoteDataObject$(configResNotChangeDiscoverable),
}); });

View File

@@ -1,9 +1,9 @@
import { SubmissionFormsConfigService } from '../../core/config/submission-forms-config.service'; import { SubmissionFormsConfigDataService } from '../../core/config/submission-forms-config-data.service';
/** /**
* Mock for [[SubmissionFormsConfigService]] * Mock for [[SubmissionFormsConfigService]]
*/ */
export function getMockSectionUploadService(): SubmissionFormsConfigService { export function getMockSectionUploadService(): SubmissionFormsConfigDataService {
return jasmine.createSpyObj('SectionUploadService', { return jasmine.createSpyObj('SectionUploadService', {
getUploadedFileList: jasmine.createSpy('getUploadedFileList'), getUploadedFileList: jasmine.createSpy('getUploadedFileList'),
getFileData: jasmine.createSpy('getFileData'), getFileData: jasmine.createSpy('getFileData'),

View File

@@ -17,7 +17,7 @@ import { ResourcePolicyCreateComponent } from './resource-policy-create.componen
import { LinkService } from '../../../core/cache/builders/link.service'; import { LinkService } from '../../../core/cache/builders/link.service';
import { NotificationsService } from '../../notifications/notifications.service'; import { NotificationsService } from '../../notifications/notifications.service';
import { NotificationsServiceStub } from '../../testing/notifications-service.stub'; import { NotificationsServiceStub } from '../../testing/notifications-service.stub';
import { ResourcePolicyService } from '../../../core/resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from '../../../core/resource-policy/resource-policy-data.service';
import { getMockResourcePolicyService } from '../../mocks/mock-resource-policy-service'; import { getMockResourcePolicyService } from '../../mocks/mock-resource-policy-service';
import { getMockLinkService } from '../../mocks/link-service.mock'; import { getMockLinkService } from '../../mocks/link-service.mock';
import { RouterStub } from '../../testing/router.stub'; import { RouterStub } from '../../testing/router.stub';
@@ -100,7 +100,7 @@ describe('ResourcePolicyCreateComponent test suite', () => {
{ provide: LinkService, useValue: linkService }, { provide: LinkService, useValue: linkService },
{ provide: ActivatedRoute, useValue: routeStub }, { provide: ActivatedRoute, useValue: routeStub },
{ provide: NotificationsService, useValue: new NotificationsServiceStub() }, { provide: NotificationsService, useValue: new NotificationsServiceStub() },
{ provide: ResourcePolicyService, useValue: resourcePolicyService }, { provide: ResourcePolicyDataService, useValue: resourcePolicyService },
{ provide: Router, useValue: routerStub }, { provide: Router, useValue: routerStub },
ResourcePolicyCreateComponent, ResourcePolicyCreateComponent,
ChangeDetectorRef, ChangeDetectorRef,

View File

@@ -6,7 +6,7 @@ import { map, take } from 'rxjs/operators';
import { TranslateService } from '@ngx-translate/core'; import { TranslateService } from '@ngx-translate/core';
import { DSpaceObject } from '../../../core/shared/dspace-object.model'; import { DSpaceObject } from '../../../core/shared/dspace-object.model';
import { ResourcePolicyService } from '../../../core/resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from '../../../core/resource-policy/resource-policy-data.service';
import { NotificationsService } from '../../notifications/notifications.service'; import { NotificationsService } from '../../notifications/notifications.service';
import { RemoteData } from '../../../core/data/remote-data'; import { RemoteData } from '../../../core/data/remote-data';
import { ResourcePolicy } from '../../../core/resource-policy/models/resource-policy.model'; import { ResourcePolicy } from '../../../core/resource-policy/models/resource-policy.model';
@@ -42,7 +42,7 @@ export class ResourcePolicyCreateComponent implements OnInit {
* *
* @param {DSONameService} dsoNameService * @param {DSONameService} dsoNameService
* @param {NotificationsService} notificationsService * @param {NotificationsService} notificationsService
* @param {ResourcePolicyService} resourcePolicyService * @param {ResourcePolicyDataService} resourcePolicyService
* @param {ActivatedRoute} route * @param {ActivatedRoute} route
* @param {Router} router * @param {Router} router
* @param {TranslateService} translate * @param {TranslateService} translate
@@ -50,7 +50,7 @@ export class ResourcePolicyCreateComponent implements OnInit {
constructor( constructor(
private dsoNameService: DSONameService, private dsoNameService: DSONameService,
private notificationsService: NotificationsService, private notificationsService: NotificationsService,
private resourcePolicyService: ResourcePolicyService, private resourcePolicyService: ResourcePolicyDataService,
private route: ActivatedRoute, private route: ActivatedRoute,
private router: Router, private router: Router,
private translate: TranslateService) { private translate: TranslateService) {

View File

@@ -12,7 +12,7 @@ import { createTestComponent } from '../../testing/utils.test';
import { LinkService } from '../../../core/cache/builders/link.service'; import { LinkService } from '../../../core/cache/builders/link.service';
import { NotificationsService } from '../../notifications/notifications.service'; import { NotificationsService } from '../../notifications/notifications.service';
import { NotificationsServiceStub } from '../../testing/notifications-service.stub'; import { NotificationsServiceStub } from '../../testing/notifications-service.stub';
import { ResourcePolicyService } from '../../../core/resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from '../../../core/resource-policy/resource-policy-data.service';
import { getMockResourcePolicyService } from '../../mocks/mock-resource-policy-service'; import { getMockResourcePolicyService } from '../../mocks/mock-resource-policy-service';
import { getMockLinkService } from '../../mocks/link-service.mock'; import { getMockLinkService } from '../../mocks/link-service.mock';
import { RouterStub } from '../../testing/router.stub'; import { RouterStub } from '../../testing/router.stub';
@@ -82,7 +82,7 @@ describe('ResourcePolicyEditComponent test suite', () => {
{ provide: LinkService, useValue: linkService }, { provide: LinkService, useValue: linkService },
{ provide: ActivatedRoute, useValue: routeStub }, { provide: ActivatedRoute, useValue: routeStub },
{ provide: NotificationsService, useValue: new NotificationsServiceStub() }, { provide: NotificationsService, useValue: new NotificationsServiceStub() },
{ provide: ResourcePolicyService, useValue: resourcePolicyService }, { provide: ResourcePolicyDataService, useValue: resourcePolicyService },
{ provide: Router, useValue: routerStub }, { provide: Router, useValue: routerStub },
ResourcePolicyEditComponent, ResourcePolicyEditComponent,
ChangeDetectorRef, ChangeDetectorRef,

View File

@@ -5,7 +5,7 @@ import { BehaviorSubject, Observable, of, combineLatest as observableCombineLate
import { map, take } from 'rxjs/operators'; import { map, take } from 'rxjs/operators';
import { TranslateService } from '@ngx-translate/core'; import { TranslateService } from '@ngx-translate/core';
import { ResourcePolicyService } from '../../../core/resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from '../../../core/resource-policy/resource-policy-data.service';
import { NotificationsService } from '../../notifications/notifications.service'; import { NotificationsService } from '../../notifications/notifications.service';
import { RemoteData } from '../../../core/data/remote-data'; import { RemoteData } from '../../../core/data/remote-data';
import { ResourcePolicy } from '../../../core/resource-policy/models/resource-policy.model'; import { ResourcePolicy } from '../../../core/resource-policy/models/resource-policy.model';
@@ -35,14 +35,14 @@ export class ResourcePolicyEditComponent implements OnInit {
* Initialize instance variables * Initialize instance variables
* *
* @param {NotificationsService} notificationsService * @param {NotificationsService} notificationsService
* @param {ResourcePolicyService} resourcePolicyService * @param {ResourcePolicyDataService} resourcePolicyService
* @param {ActivatedRoute} route * @param {ActivatedRoute} route
* @param {Router} router * @param {Router} router
* @param {TranslateService} translate * @param {TranslateService} translate
*/ */
constructor( constructor(
private notificationsService: NotificationsService, private notificationsService: NotificationsService,
private resourcePolicyService: ResourcePolicyService, private resourcePolicyService: ResourcePolicyDataService,
private route: ActivatedRoute, private route: ActivatedRoute,
private router: Router, private router: Router,
private translate: TranslateService) { private translate: TranslateService) {

View File

@@ -6,7 +6,7 @@ import { Observable } from 'rxjs';
import { isEmpty } from '../../empty.util'; import { isEmpty } from '../../empty.util';
import { RemoteData } from '../../../core/data/remote-data'; import { RemoteData } from '../../../core/data/remote-data';
import { ResourcePolicy } from '../../../core/resource-policy/models/resource-policy.model'; import { ResourcePolicy } from '../../../core/resource-policy/models/resource-policy.model';
import { ResourcePolicyService } from '../../../core/resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from '../../../core/resource-policy/resource-policy-data.service';
import { followLink } from '../../utils/follow-link-config.model'; import { followLink } from '../../utils/follow-link-config.model';
import { getFirstCompletedRemoteData } from '../../../core/shared/operators'; import { getFirstCompletedRemoteData } from '../../../core/shared/operators';
@@ -16,7 +16,7 @@ import { getFirstCompletedRemoteData } from '../../../core/shared/operators';
@Injectable() @Injectable()
export class ResourcePolicyResolver implements Resolve<RemoteData<ResourcePolicy>> { export class ResourcePolicyResolver implements Resolve<RemoteData<ResourcePolicy>> {
constructor(private resourcePolicyService: ResourcePolicyService, private router: Router) { constructor(private resourcePolicyService: ResourcePolicyDataService, private router: Router) {
} }
/** /**

View File

@@ -20,7 +20,7 @@ import { createPaginatedList, createTestComponent } from '../testing/utils.test'
import { EPersonDataService } from '../../core/eperson/eperson-data.service'; import { EPersonDataService } from '../../core/eperson/eperson-data.service';
import { NotificationsService } from '../notifications/notifications.service'; import { NotificationsService } from '../notifications/notifications.service';
import { NotificationsServiceStub } from '../testing/notifications-service.stub'; import { NotificationsServiceStub } from '../testing/notifications-service.stub';
import { ResourcePolicyService } from '../../core/resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from '../../core/resource-policy/resource-policy-data.service';
import { getMockResourcePolicyService } from '../mocks/mock-resource-policy-service'; import { getMockResourcePolicyService } from '../mocks/mock-resource-policy-service';
import { GroupDataService } from '../../core/eperson/group-data.service'; import { GroupDataService } from '../../core/eperson/group-data.service';
import { RequestService } from '../../core/data/request.service'; import { RequestService } from '../../core/data/request.service';
@@ -206,7 +206,7 @@ describe('ResourcePoliciesComponent test suite', () => {
{ provide: EPersonDataService, useValue: epersonService }, { provide: EPersonDataService, useValue: epersonService },
{ provide: GroupDataService, useValue: groupService }, { provide: GroupDataService, useValue: groupService },
{ provide: NotificationsService, useValue: notificationsServiceStub }, { provide: NotificationsService, useValue: notificationsServiceStub },
{ provide: ResourcePolicyService, useValue: resourcePolicyService }, { provide: ResourcePolicyDataService, useValue: resourcePolicyService },
{ provide: RequestService, useValue: getMockRequestService() }, { provide: RequestService, useValue: getMockRequestService() },
{ provide: Router, useValue: routerStub }, { provide: Router, useValue: routerStub },
ChangeDetectorRef, ChangeDetectorRef,

View File

@@ -14,7 +14,7 @@ import {
} from 'rxjs/operators'; } from 'rxjs/operators';
import { TranslateService } from '@ngx-translate/core'; import { TranslateService } from '@ngx-translate/core';
import { ResourcePolicyService } from '../../core/resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from '../../core/resource-policy/resource-policy-data.service';
import { import {
getFirstSucceededRemoteDataPayload, getFirstSucceededRemoteDataPayload,
getFirstSucceededRemoteDataWithNotEmptyPayload, getFirstSucceededRemoteDataWithNotEmptyPayload,
@@ -102,7 +102,7 @@ export class ResourcePoliciesComponent implements OnInit, OnDestroy {
* @param {GroupDataService} groupService * @param {GroupDataService} groupService
* @param {NotificationsService} notificationsService * @param {NotificationsService} notificationsService
* @param {RequestService} requestService * @param {RequestService} requestService
* @param {ResourcePolicyService} resourcePolicyService * @param {ResourcePolicyDataService} resourcePolicyService
* @param {ActivatedRoute} route * @param {ActivatedRoute} route
* @param {Router} router * @param {Router} router
* @param {TranslateService} translate * @param {TranslateService} translate
@@ -114,7 +114,7 @@ export class ResourcePoliciesComponent implements OnInit, OnDestroy {
private groupService: GroupDataService, private groupService: GroupDataService,
private notificationsService: NotificationsService, private notificationsService: NotificationsService,
private requestService: RequestService, private requestService: RequestService,
private resourcePolicyService: ResourcePolicyService, private resourcePolicyService: ResourcePolicyDataService,
private route: ActivatedRoute, private route: ActivatedRoute,
private router: Router, private router: Router,
private translate: TranslateService private translate: TranslateService

View File

@@ -3,7 +3,7 @@ import { CollectionStatisticsPageComponent } from './collection-statistics-page.
import { StatisticsTableComponent } from '../statistics-table/statistics-table.component'; import { StatisticsTableComponent } from '../statistics-table/statistics-table.component';
import { TranslateModule } from '@ngx-translate/core'; import { TranslateModule } from '@ngx-translate/core';
import { ActivatedRoute, Router } from '@angular/router'; import { ActivatedRoute, Router } from '@angular/router';
import { UsageReportService } from '../../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../../core/statistics/usage-report-data.service';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Collection } from '../../core/shared/collection.model'; import { Collection } from '../../core/shared/collection.model';
import { DebugElement } from '@angular/core'; import { DebugElement } from '@angular/core';
@@ -74,7 +74,7 @@ describe('CollectionStatisticsPageComponent', () => {
providers: [ providers: [
{ provide: ActivatedRoute, useValue: activatedRoute }, { provide: ActivatedRoute, useValue: activatedRoute },
{ provide: Router, useValue: router }, { provide: Router, useValue: router },
{ provide: UsageReportService, useValue: usageReportService }, { provide: UsageReportDataService, useValue: usageReportService },
{ provide: DSpaceObjectDataService, useValue: {} }, { provide: DSpaceObjectDataService, useValue: {} },
{ provide: DSONameService, useValue: nameService }, { provide: DSONameService, useValue: nameService },
{ provide: AuthService, useValue: authService }, { provide: AuthService, useValue: authService },

View File

@@ -1,6 +1,6 @@
import { Component } from '@angular/core'; import { Component } from '@angular/core';
import { StatisticsPageComponent } from '../statistics-page/statistics-page.component'; import { StatisticsPageComponent } from '../statistics-page/statistics-page.component';
import { UsageReportService } from '../../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../../core/statistics/usage-report-data.service';
import { ActivatedRoute , Router} from '@angular/router'; import { ActivatedRoute , Router} from '@angular/router';
import { Collection } from '../../core/shared/collection.model'; import { Collection } from '../../core/shared/collection.model';
import { DSONameService } from '../../core/breadcrumbs/dso-name.service'; import { DSONameService } from '../../core/breadcrumbs/dso-name.service';
@@ -29,7 +29,7 @@ export class CollectionStatisticsPageComponent extends StatisticsPageComponent<C
constructor( constructor(
protected route: ActivatedRoute, protected route: ActivatedRoute,
protected router: Router, protected router: Router,
protected usageReportService: UsageReportService, protected usageReportService: UsageReportDataService,
protected nameService: DSONameService, protected nameService: DSONameService,
protected authService: AuthService protected authService: AuthService
) { ) {

View File

@@ -3,7 +3,7 @@ import { CommunityStatisticsPageComponent } from './community-statistics-page.co
import { StatisticsTableComponent } from '../statistics-table/statistics-table.component'; import { StatisticsTableComponent } from '../statistics-table/statistics-table.component';
import { TranslateModule } from '@ngx-translate/core'; import { TranslateModule } from '@ngx-translate/core';
import { ActivatedRoute, Router } from '@angular/router'; import { ActivatedRoute, Router } from '@angular/router';
import { UsageReportService } from '../../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../../core/statistics/usage-report-data.service';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Community } from '../../core/shared/community.model'; import { Community } from '../../core/shared/community.model';
import { DebugElement } from '@angular/core'; import { DebugElement } from '@angular/core';
@@ -74,7 +74,7 @@ describe('CommunityStatisticsPageComponent', () => {
providers: [ providers: [
{ provide: ActivatedRoute, useValue: activatedRoute }, { provide: ActivatedRoute, useValue: activatedRoute },
{ provide: Router, useValue: router }, { provide: Router, useValue: router },
{ provide: UsageReportService, useValue: usageReportService }, { provide: UsageReportDataService, useValue: usageReportService },
{ provide: DSpaceObjectDataService, useValue: {} }, { provide: DSpaceObjectDataService, useValue: {} },
{ provide: DSONameService, useValue: nameService }, { provide: DSONameService, useValue: nameService },
{ provide: AuthService, useValue: authService }, { provide: AuthService, useValue: authService },

View File

@@ -1,6 +1,6 @@
import { Component } from '@angular/core'; import { Component } from '@angular/core';
import { StatisticsPageComponent } from '../statistics-page/statistics-page.component'; import { StatisticsPageComponent } from '../statistics-page/statistics-page.component';
import { UsageReportService } from '../../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../../core/statistics/usage-report-data.service';
import { ActivatedRoute, Router } from '@angular/router'; import { ActivatedRoute, Router } from '@angular/router';
import { Community } from '../../core/shared/community.model'; import { Community } from '../../core/shared/community.model';
import { DSONameService } from '../../core/breadcrumbs/dso-name.service'; import { DSONameService } from '../../core/breadcrumbs/dso-name.service';
@@ -29,7 +29,7 @@ export class CommunityStatisticsPageComponent extends StatisticsPageComponent<Co
constructor( constructor(
protected route: ActivatedRoute, protected route: ActivatedRoute,
protected router: Router, protected router: Router,
protected usageReportService: UsageReportService, protected usageReportService: UsageReportDataService,
protected nameService: DSONameService, protected nameService: DSONameService,
protected authService: AuthService, protected authService: AuthService,
) { ) {

View File

@@ -3,7 +3,7 @@ import { ItemStatisticsPageComponent } from './item-statistics-page.component';
import { StatisticsTableComponent } from '../statistics-table/statistics-table.component'; import { StatisticsTableComponent } from '../statistics-table/statistics-table.component';
import { TranslateModule } from '@ngx-translate/core'; import { TranslateModule } from '@ngx-translate/core';
import { ActivatedRoute, Router } from '@angular/router'; import { ActivatedRoute, Router } from '@angular/router';
import { UsageReportService } from '../../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../../core/statistics/usage-report-data.service';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Item } from '../../core/shared/item.model'; import { Item } from '../../core/shared/item.model';
import { DebugElement } from '@angular/core'; import { DebugElement } from '@angular/core';
@@ -74,7 +74,7 @@ describe('ItemStatisticsPageComponent', () => {
providers: [ providers: [
{ provide: ActivatedRoute, useValue: activatedRoute }, { provide: ActivatedRoute, useValue: activatedRoute },
{ provide: Router, useValue: router }, { provide: Router, useValue: router },
{ provide: UsageReportService, useValue: usageReportService }, { provide: UsageReportDataService, useValue: usageReportService },
{ provide: DSpaceObjectDataService, useValue: {} }, { provide: DSpaceObjectDataService, useValue: {} },
{ provide: DSONameService, useValue: nameService }, { provide: DSONameService, useValue: nameService },
{ provide: AuthService, useValue: authService }, { provide: AuthService, useValue: authService },

View File

@@ -1,6 +1,6 @@
import { Component } from '@angular/core'; import { Component } from '@angular/core';
import { StatisticsPageComponent } from '../statistics-page/statistics-page.component'; import { StatisticsPageComponent } from '../statistics-page/statistics-page.component';
import { UsageReportService } from '../../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../../core/statistics/usage-report-data.service';
import { ActivatedRoute, Router } from '@angular/router'; import { ActivatedRoute, Router } from '@angular/router';
import { Item } from '../../core/shared/item.model'; import { Item } from '../../core/shared/item.model';
import { DSONameService } from '../../core/breadcrumbs/dso-name.service'; import { DSONameService } from '../../core/breadcrumbs/dso-name.service';
@@ -30,7 +30,7 @@ export class ItemStatisticsPageComponent extends StatisticsPageComponent<Item> {
constructor( constructor(
protected route: ActivatedRoute, protected route: ActivatedRoute,
protected router: Router, protected router: Router,
protected usageReportService: UsageReportService, protected usageReportService: UsageReportDataService,
protected nameService: DSONameService, protected nameService: DSONameService,
protected authService: AuthService protected authService: AuthService
) { ) {

View File

@@ -3,7 +3,7 @@ import { SiteStatisticsPageComponent } from './site-statistics-page.component';
import { StatisticsTableComponent } from '../statistics-table/statistics-table.component'; import { StatisticsTableComponent } from '../statistics-table/statistics-table.component';
import { TranslateModule } from '@ngx-translate/core'; import { TranslateModule } from '@ngx-translate/core';
import { ActivatedRoute, Router } from '@angular/router'; import { ActivatedRoute, Router } from '@angular/router';
import { UsageReportService } from '../../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../../core/statistics/usage-report-data.service';
import { of as observableOf } from 'rxjs'; import { of as observableOf } from 'rxjs';
import { Site } from '../../core/shared/site.model'; import { Site } from '../../core/shared/site.model';
import { DebugElement } from '@angular/core'; import { DebugElement } from '@angular/core';
@@ -74,7 +74,7 @@ describe('SiteStatisticsPageComponent', () => {
providers: [ providers: [
{ provide: ActivatedRoute, useValue: activatedRoute }, { provide: ActivatedRoute, useValue: activatedRoute },
{ provide: Router, useValue: router }, { provide: Router, useValue: router },
{ provide: UsageReportService, useValue: usageReportService }, { provide: UsageReportDataService, useValue: usageReportService },
{ provide: DSpaceObjectDataService, useValue: {} }, { provide: DSpaceObjectDataService, useValue: {} },
{ provide: DSONameService, useValue: nameService }, { provide: DSONameService, useValue: nameService },
{ provide: SiteDataService, useValue: siteService }, { provide: SiteDataService, useValue: siteService },

View File

@@ -1,7 +1,7 @@
import { Component } from '@angular/core'; import { Component } from '@angular/core';
import { StatisticsPageComponent } from '../statistics-page/statistics-page.component'; import { StatisticsPageComponent } from '../statistics-page/statistics-page.component';
import { SiteDataService } from '../../core/data/site-data.service'; import { SiteDataService } from '../../core/data/site-data.service';
import { UsageReportService } from '../../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../../core/statistics/usage-report-data.service';
import { ActivatedRoute, Router } from '@angular/router'; import { ActivatedRoute, Router } from '@angular/router';
import { Site } from '../../core/shared/site.model'; import { Site } from '../../core/shared/site.model';
import { DSONameService } from '../../core/breadcrumbs/dso-name.service'; import { DSONameService } from '../../core/breadcrumbs/dso-name.service';
@@ -28,7 +28,7 @@ export class SiteStatisticsPageComponent extends StatisticsPageComponent<Site> {
constructor( constructor(
protected route: ActivatedRoute, protected route: ActivatedRoute,
protected router: Router, protected router: Router,
protected usageReportService: UsageReportService, protected usageReportService: UsageReportDataService,
protected nameService: DSONameService, protected nameService: DSONameService,
protected siteService: SiteDataService, protected siteService: SiteDataService,
protected authService: AuthService, protected authService: AuthService,

View File

@@ -4,7 +4,7 @@ import { CommonModule } from '@angular/common';
import { CoreModule } from '../core/core.module'; import { CoreModule } from '../core/core.module';
import { SharedModule } from '../shared/shared.module'; import { SharedModule } from '../shared/shared.module';
import { StatisticsModule } from '../statistics/statistics.module'; import { StatisticsModule } from '../statistics/statistics.module';
import { UsageReportService } from '../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../core/statistics/usage-report-data.service';
import { SiteStatisticsPageComponent } from './site-statistics-page/site-statistics-page.component'; import { SiteStatisticsPageComponent } from './site-statistics-page/site-statistics-page.component';
import { StatisticsTableComponent } from './statistics-table/statistics-table.component'; import { StatisticsTableComponent } from './statistics-table/statistics-table.component';
import { ItemStatisticsPageComponent } from './item-statistics-page/item-statistics-page.component'; import { ItemStatisticsPageComponent } from './item-statistics-page/item-statistics-page.component';
@@ -36,7 +36,7 @@ const components = [
], ],
declarations: components, declarations: components,
providers: [ providers: [
UsageReportService, UsageReportDataService,
], ],
exports: components exports: components
}) })

View File

@@ -1,6 +1,6 @@
import { Component, OnInit } from '@angular/core'; import { Component, OnInit } from '@angular/core';
import { combineLatest, Observable } from 'rxjs'; import { combineLatest, Observable } from 'rxjs';
import { UsageReportService } from '../../core/statistics/usage-report-data.service'; import { UsageReportDataService } from '../../core/statistics/usage-report-data.service';
import { map, switchMap } from 'rxjs/operators'; import { map, switchMap } from 'rxjs/operators';
import { UsageReport } from '../../core/statistics/models/usage-report.model'; import { UsageReport } from '../../core/statistics/models/usage-report.model';
import { RemoteData } from '../../core/data/remote-data'; import { RemoteData } from '../../core/data/remote-data';
@@ -43,7 +43,7 @@ export abstract class StatisticsPageComponent<T extends DSpaceObject> implements
constructor( constructor(
protected route: ActivatedRoute, protected route: ActivatedRoute,
protected router: Router, protected router: Router,
protected usageReportService: UsageReportService, protected usageReportService: UsageReportDataService,
protected nameService: DSONameService, protected nameService: DSONameService,
protected authService: AuthService, protected authService: AuthService,
) { ) {

View File

@@ -6,7 +6,7 @@ import {
SourceElement, SourceElement,
SubmissionImportExternalSearchbarComponent SubmissionImportExternalSearchbarComponent
} from './submission-import-external-searchbar.component'; } from './submission-import-external-searchbar.component';
import { ExternalSourceService } from '../../../core/data/external-source.service'; import { ExternalSourceDataService } from '../../../core/data/external-source-data.service';
import { createTestComponent } from '../../../shared/testing/utils.test'; import { createTestComponent } from '../../../shared/testing/utils.test';
import { import {
externalSourceCiencia, externalSourceCiencia,
@@ -48,7 +48,7 @@ describe('SubmissionImportExternalSearchbarComponent test suite', () => {
TestComponent, TestComponent,
], ],
providers: [ providers: [
{ provide: ExternalSourceService, useValue: mockExternalSourceService }, { provide: ExternalSourceDataService, useValue: mockExternalSourceService },
ChangeDetectorRef, ChangeDetectorRef,
{ provide: HostWindowService, useValue: new HostWindowServiceStub(800) }, { provide: HostWindowService, useValue: new HostWindowServiceStub(800) },
SubmissionImportExternalSearchbarComponent SubmissionImportExternalSearchbarComponent

View File

@@ -4,7 +4,7 @@ import { Observable, of as observableOf, Subscription } from 'rxjs';
import { catchError, tap } from 'rxjs/operators'; import { catchError, tap } from 'rxjs/operators';
import { RequestParam } from '../../../core/cache/models/request-param.model'; import { RequestParam } from '../../../core/cache/models/request-param.model';
import { ExternalSourceService } from '../../../core/data/external-source.service'; import { ExternalSourceDataService } from '../../../core/data/external-source-data.service';
import { ExternalSource } from '../../../core/shared/external-source.model'; import { ExternalSource } from '../../../core/shared/external-source.model';
import { buildPaginatedList, PaginatedList } from '../../../core/data/paginated-list.model'; import { buildPaginatedList, PaginatedList } from '../../../core/data/paginated-list.model';
import { RemoteData } from '../../../core/data/remote-data'; import { RemoteData } from '../../../core/data/remote-data';
@@ -86,12 +86,12 @@ export class SubmissionImportExternalSearchbarComponent implements OnInit, OnDes
/** /**
* Initialize the component variables. * Initialize the component variables.
* @param {ExternalSourceService} externalService * @param {ExternalSourceDataService} externalService
* @param {ChangeDetectorRef} cdr * @param {ChangeDetectorRef} cdr
* @param {HostWindowService} windowService * @param {HostWindowService} windowService
*/ */
constructor( constructor(
private externalService: ExternalSourceService, private externalService: ExternalSourceDataService,
private cdr: ChangeDetectorRef, private cdr: ChangeDetectorRef,
protected windowService: HostWindowService protected windowService: HostWindowService
) { ) {

View File

@@ -9,7 +9,7 @@ import { of as observableOf } from 'rxjs';
import { TestScheduler } from 'rxjs/testing'; import { TestScheduler } from 'rxjs/testing';
import { SubmissionImportExternalComponent } from './submission-import-external.component'; import { SubmissionImportExternalComponent } from './submission-import-external.component';
import { ExternalSourceService } from '../../core/data/external-source.service'; import { ExternalSourceDataService } from '../../core/data/external-source-data.service';
import { getMockExternalSourceService } from '../../shared/mocks/external-source.service.mock'; import { getMockExternalSourceService } from '../../shared/mocks/external-source.service.mock';
import { SearchConfigurationService } from '../../core/shared/search/search-configuration.service'; import { SearchConfigurationService } from '../../core/shared/search/search-configuration.service';
import { RouteService } from '../../core/services/route.service'; import { RouteService } from '../../core/services/route.service';
@@ -52,7 +52,7 @@ describe('SubmissionImportExternalComponent test suite', () => {
VarDirective VarDirective
], ],
providers: [ providers: [
{ provide: ExternalSourceService, useValue: mockExternalSourceService }, { provide: ExternalSourceDataService, useValue: mockExternalSourceService },
{ provide: SearchConfigurationService, useValue: searchConfigServiceStub }, { provide: SearchConfigurationService, useValue: searchConfigServiceStub },
{ provide: RouteService, useValue: routeServiceStub }, { provide: RouteService, useValue: routeServiceStub },
{ provide: Router, useValue: new RouterStub() }, { provide: Router, useValue: new RouterStub() },

View File

@@ -5,7 +5,7 @@ import { BehaviorSubject, combineLatest, Subscription } from 'rxjs';
import { filter, mergeMap, switchMap, take, tap } from 'rxjs/operators'; import { filter, mergeMap, switchMap, take, tap } from 'rxjs/operators';
import { NgbModal, NgbModalRef } from '@ng-bootstrap/ng-bootstrap'; import { NgbModal, NgbModalRef } from '@ng-bootstrap/ng-bootstrap';
import { ExternalSourceService } from '../../core/data/external-source.service'; import { ExternalSourceDataService } from '../../core/data/external-source-data.service';
import { ExternalSourceData } from './import-external-searchbar/submission-import-external-searchbar.component'; import { ExternalSourceData } from './import-external-searchbar/submission-import-external-searchbar.component';
import { RemoteData } from '../../core/data/remote-data'; import { RemoteData } from '../../core/data/remote-data';
import { buildPaginatedList, PaginatedList } from '../../core/data/paginated-list.model'; import { buildPaginatedList, PaginatedList } from '../../core/data/paginated-list.model';
@@ -93,14 +93,14 @@ export class SubmissionImportExternalComponent implements OnInit, OnDestroy {
/** /**
* Initialize the component variables. * Initialize the component variables.
* @param {SearchConfigurationService} searchConfigService * @param {SearchConfigurationService} searchConfigService
* @param {ExternalSourceService} externalService * @param {ExternalSourceDataService} externalService
* @param {RouteService} routeService * @param {RouteService} routeService
* @param {Router} router * @param {Router} router
* @param {NgbModal} modalService * @param {NgbModal} modalService
*/ */
constructor( constructor(
public searchConfigService: SearchConfigurationService, public searchConfigService: SearchConfigurationService,
private externalService: ExternalSourceService, private externalService: ExternalSourceDataService,
private routeService: RouteService, private routeService: RouteService,
private router: Router, private router: Router,
private modalService: NgbModal, private modalService: NgbModal,

View File

@@ -7,7 +7,7 @@ import { SectionsServiceStub } from '../../../shared/testing/sections-service.st
import { FormBuilderService } from '../../../shared/form/builder/form-builder.service'; import { FormBuilderService } from '../../../shared/form/builder/form-builder.service';
import { getMockFormBuilderService } from '../../../shared/mocks/form-builder-service.mock'; import { getMockFormBuilderService } from '../../../shared/mocks/form-builder-service.mock';
import { SubmissionAccessesConfigService } from '../../../core/config/submission-accesses-config.service'; import { SubmissionAccessesConfigDataService } from '../../../core/config/submission-accesses-config-data.service';
import { import {
getSubmissionAccessesConfigNotChangeDiscoverableService, getSubmissionAccessesConfigNotChangeDiscoverableService,
getSubmissionAccessesConfigService getSubmissionAccessesConfigService
@@ -89,7 +89,7 @@ describe('SubmissionSectionAccessesComponent', () => {
declarations: [SubmissionSectionAccessesComponent, FormComponent], declarations: [SubmissionSectionAccessesComponent, FormComponent],
providers: [ providers: [
{ provide: SectionsService, useValue: sectionsServiceStub }, { provide: SectionsService, useValue: sectionsServiceStub },
{ provide: SubmissionAccessesConfigService, useValue: submissionAccessesConfigService }, { provide: SubmissionAccessesConfigDataService, useValue: submissionAccessesConfigService },
{ provide: SectionAccessesService, useValue: sectionAccessesService }, { provide: SectionAccessesService, useValue: sectionAccessesService },
{ provide: SectionFormOperationsService, useValue: sectionFormOperationsService }, { provide: SectionFormOperationsService, useValue: sectionFormOperationsService },
{ provide: JsonPatchOperationsBuilder, useValue: operationsBuilder }, { provide: JsonPatchOperationsBuilder, useValue: operationsBuilder },
@@ -181,7 +181,7 @@ describe('SubmissionSectionAccessesComponent', () => {
providers: [ providers: [
{ provide: SectionsService, useValue: sectionsServiceStub }, { provide: SectionsService, useValue: sectionsServiceStub },
{ provide: FormBuilderService, useValue: builderService }, { provide: FormBuilderService, useValue: builderService },
{ provide: SubmissionAccessesConfigService, useValue: getSubmissionAccessesConfigNotChangeDiscoverableService() }, { provide: SubmissionAccessesConfigDataService, useValue: getSubmissionAccessesConfigNotChangeDiscoverableService() },
{ provide: SectionAccessesService, useValue: sectionAccessesService }, { provide: SectionAccessesService, useValue: sectionAccessesService },
{ provide: SectionFormOperationsService, useValue: sectionFormOperationsService }, { provide: SectionFormOperationsService, useValue: sectionFormOperationsService },
{ provide: JsonPatchOperationsBuilder, useValue: operationsBuilder }, { provide: JsonPatchOperationsBuilder, useValue: operationsBuilder },

View File

@@ -44,7 +44,7 @@ import { hasValue, isNotEmpty, isNotNull } from '../../../shared/empty.util';
import { import {
WorkspaceitemSectionAccessesObject WorkspaceitemSectionAccessesObject
} from '../../../core/submission/models/workspaceitem-section-accesses.model'; } from '../../../core/submission/models/workspaceitem-section-accesses.model';
import { SubmissionAccessesConfigService } from '../../../core/config/submission-accesses-config.service'; import { SubmissionAccessesConfigDataService } from '../../../core/config/submission-accesses-config-data.service';
import { getFirstSucceededRemoteData } from '../../../core/shared/operators'; import { getFirstSucceededRemoteData } from '../../../core/shared/operators';
import { FormComponent } from '../../../shared/form/form.component'; import { FormComponent } from '../../../shared/form/form.component';
import { FormService } from '../../../shared/form/form.service'; import { FormService } from '../../../shared/form/form.service';
@@ -125,7 +125,7 @@ export class SubmissionSectionAccessesComponent extends SectionModelComponent {
* @param {SectionFormOperationsService} formOperationsService * @param {SectionFormOperationsService} formOperationsService
* @param {FormBuilderService} formBuilderService * @param {FormBuilderService} formBuilderService
* @param {TranslateService} translate * @param {TranslateService} translate
* @param {SubmissionAccessesConfigService} accessesConfigService * @param {SubmissionAccessesConfigDataService} accessesConfigService
* @param {SectionAccessesService} accessesService * @param {SectionAccessesService} accessesService
* @param {SubmissionJsonPatchOperationsService} operationsService * @param {SubmissionJsonPatchOperationsService} operationsService
* @param {string} injectedSubmissionId * @param {string} injectedSubmissionId
@@ -133,7 +133,7 @@ export class SubmissionSectionAccessesComponent extends SectionModelComponent {
constructor( constructor(
protected sectionService: SectionsService, protected sectionService: SectionsService,
private formBuilderService: FormBuilderService, private formBuilderService: FormBuilderService,
private accessesConfigService: SubmissionAccessesConfigService, private accessesConfigService: SubmissionAccessesConfigDataService,
private accessesService: SectionAccessesService, private accessesService: SectionAccessesService,
protected formOperationsService: SectionFormOperationsService, protected formOperationsService: SectionFormOperationsService,
protected operationsBuilder: JsonPatchOperationsBuilder, protected operationsBuilder: JsonPatchOperationsBuilder,

View File

@@ -19,7 +19,7 @@ import { getMockFormOperationsService } from '../../../shared/mocks/form-operati
import { SectionFormOperationsService } from './section-form-operations.service'; import { SectionFormOperationsService } from './section-form-operations.service';
import { getMockFormService } from '../../../shared/mocks/form-service.mock'; import { getMockFormService } from '../../../shared/mocks/form-service.mock';
import { FormService } from '../../../shared/form/form.service'; import { FormService } from '../../../shared/form/form.service';
import { SubmissionFormsConfigService } from '../../../core/config/submission-forms-config.service'; import { SubmissionFormsConfigDataService } from '../../../core/config/submission-forms-config-data.service';
import { SectionDataObject } from '../models/section-data.model'; import { SectionDataObject } from '../models/section-data.model';
import { SectionsType } from '../sections-type'; import { SectionsType } from '../sections-type';
import { import {
@@ -45,7 +45,7 @@ import { cold } from 'jasmine-marbles';
import { WorkflowItem } from '../../../core/submission/models/workflowitem.model'; import { WorkflowItem } from '../../../core/submission/models/workflowitem.model';
import { SubmissionSectionError } from '../../objects/submission-section-error.model'; import { SubmissionSectionError } from '../../objects/submission-section-error.model';
function getMockSubmissionFormsConfigService(): SubmissionFormsConfigService { function getMockSubmissionFormsConfigService(): SubmissionFormsConfigDataService {
return jasmine.createSpyObj('FormOperationsService', { return jasmine.createSpyObj('FormOperationsService', {
getConfigAll: jasmine.createSpy('getConfigAll'), getConfigAll: jasmine.createSpy('getConfigAll'),
getConfigByHref: jasmine.createSpy('getConfigByHref'), getConfigByHref: jasmine.createSpy('getConfigByHref'),
@@ -173,7 +173,7 @@ describe('SubmissionSectionFormComponent test suite', () => {
{ provide: FormBuilderService, useValue: getMockFormBuilderService() }, { provide: FormBuilderService, useValue: getMockFormBuilderService() },
{ provide: SectionFormOperationsService, useValue: getMockFormOperationsService() }, { provide: SectionFormOperationsService, useValue: getMockFormOperationsService() },
{ provide: FormService, useValue: formService }, { provide: FormService, useValue: formService },
{ provide: SubmissionFormsConfigService, useValue: formConfigService }, { provide: SubmissionFormsConfigDataService, useValue: formConfigService },
{ provide: NotificationsService, useClass: NotificationsServiceStub }, { provide: NotificationsService, useClass: NotificationsServiceStub },
{ provide: SectionsService, useValue: sectionsServiceStub }, { provide: SectionsService, useValue: sectionsServiceStub },
{ provide: SubmissionService, useClass: SubmissionServiceStub }, { provide: SubmissionService, useClass: SubmissionServiceStub },

View File

@@ -10,7 +10,7 @@ import { FormBuilderService } from '../../../shared/form/builder/form-builder.se
import { FormComponent } from '../../../shared/form/form.component'; import { FormComponent } from '../../../shared/form/form.component';
import { FormService } from '../../../shared/form/form.service'; import { FormService } from '../../../shared/form/form.service';
import { SectionModelComponent } from '../models/section.model'; import { SectionModelComponent } from '../models/section.model';
import { SubmissionFormsConfigService } from '../../../core/config/submission-forms-config.service'; import { SubmissionFormsConfigDataService } from '../../../core/config/submission-forms-config-data.service';
import { hasValue, isEmpty, isNotEmpty, isUndefined } from '../../../shared/empty.util'; import { hasValue, isEmpty, isNotEmpty, isUndefined } from '../../../shared/empty.util';
import { JsonPatchOperationPathCombiner } from '../../../core/json-patch/builder/json-patch-operation-path-combiner'; import { JsonPatchOperationPathCombiner } from '../../../core/json-patch/builder/json-patch-operation-path-combiner';
import { SubmissionFormsModel } from '../../../core/config/models/config-submission-forms.model'; import { SubmissionFormsModel } from '../../../core/config/models/config-submission-forms.model';
@@ -129,7 +129,7 @@ export class SubmissionSectionFormComponent extends SectionModelComponent {
* @param {FormBuilderService} formBuilderService * @param {FormBuilderService} formBuilderService
* @param {SectionFormOperationsService} formOperationsService * @param {SectionFormOperationsService} formOperationsService
* @param {FormService} formService * @param {FormService} formService
* @param {SubmissionFormsConfigService} formConfigService * @param {SubmissionFormsConfigDataService} formConfigService
* @param {NotificationsService} notificationsService * @param {NotificationsService} notificationsService
* @param {SectionsService} sectionService * @param {SectionsService} sectionService
* @param {SubmissionService} submissionService * @param {SubmissionService} submissionService
@@ -145,7 +145,7 @@ export class SubmissionSectionFormComponent extends SectionModelComponent {
protected formBuilderService: FormBuilderService, protected formBuilderService: FormBuilderService,
protected formOperationsService: SectionFormOperationsService, protected formOperationsService: SectionFormOperationsService,
protected formService: FormService, protected formService: FormService,
protected formConfigService: SubmissionFormsConfigService, protected formConfigService: SubmissionFormsConfigDataService,
protected notificationsService: NotificationsService, protected notificationsService: NotificationsService,
protected sectionService: SectionsService, protected sectionService: SectionsService,
protected submissionService: SubmissionService, protected submissionService: SubmissionService,

View File

@@ -20,7 +20,7 @@ import { FormBuilderService } from '../../../shared/form/builder/form-builder.se
import { getMockFormOperationsService } from '../../../shared/mocks/form-operations-service.mock'; import { getMockFormOperationsService } from '../../../shared/mocks/form-operations-service.mock';
import { getMockFormService } from '../../../shared/mocks/form-service.mock'; import { getMockFormService } from '../../../shared/mocks/form-service.mock';
import { FormService } from '../../../shared/form/form.service'; import { FormService } from '../../../shared/form/form.service';
import { SubmissionFormsConfigService } from '../../../core/config/submission-forms-config.service'; import { SubmissionFormsConfigDataService } from '../../../core/config/submission-forms-config-data.service';
import { SectionDataObject } from '../models/section-data.model'; import { SectionDataObject } from '../models/section-data.model';
import { SectionsType } from '../sections-type'; import { SectionsType } from '../sections-type';
import { import {
@@ -53,7 +53,7 @@ const mockCollection = Object.assign(new Collection(), {
license: createSuccessfulRemoteDataObject$(Object.assign(new License(), { text: licenseText })) license: createSuccessfulRemoteDataObject$(Object.assign(new License(), { text: licenseText }))
}); });
function getMockSubmissionFormsConfigService(): SubmissionFormsConfigService { function getMockSubmissionFormsConfigService(): SubmissionFormsConfigDataService {
return jasmine.createSpyObj('FormOperationsService', { return jasmine.createSpyObj('FormOperationsService', {
getConfigAll: jasmine.createSpy('getConfigAll'), getConfigAll: jasmine.createSpy('getConfigAll'),
getConfigByHref: jasmine.createSpy('getConfigByHref'), getConfigByHref: jasmine.createSpy('getConfigByHref'),
@@ -130,7 +130,7 @@ describe('SubmissionSectionLicenseComponent test suite', () => {
{ provide: SectionFormOperationsService, useValue: getMockFormOperationsService() }, { provide: SectionFormOperationsService, useValue: getMockFormOperationsService() },
{ provide: FormService, useValue: getMockFormService() }, { provide: FormService, useValue: getMockFormService() },
{ provide: JsonPatchOperationsBuilder, useValue: jsonPatchOpBuilder }, { provide: JsonPatchOperationsBuilder, useValue: jsonPatchOpBuilder },
{ provide: SubmissionFormsConfigService, useValue: getMockSubmissionFormsConfigService() }, { provide: SubmissionFormsConfigDataService, useValue: getMockSubmissionFormsConfigService() },
{ provide: NotificationsService, useClass: NotificationsServiceStub }, { provide: NotificationsService, useClass: NotificationsServiceStub },
{ provide: SectionsService, useValue: sectionsServiceStub }, { provide: SectionsService, useValue: sectionsServiceStub },
{ provide: SubmissionService, useClass: SubmissionServiceStub }, { provide: SubmissionService, useClass: SubmissionServiceStub },

View File

@@ -14,7 +14,7 @@ import { SubmissionService } from '../../submission.service';
import { SubmissionServiceStub } from '../../../shared/testing/submission-service.stub'; import { SubmissionServiceStub } from '../../../shared/testing/submission-service.stub';
import { SectionsService } from '../sections.service'; import { SectionsService } from '../sections.service';
import { SectionsServiceStub } from '../../../shared/testing/sections-service.stub'; import { SectionsServiceStub } from '../../../shared/testing/sections-service.stub';
import { SubmissionFormsConfigService } from '../../../core/config/submission-forms-config.service'; import { SubmissionFormsConfigDataService } from '../../../core/config/submission-forms-config-data.service';
import { SectionDataObject } from '../models/section-data.model'; import { SectionDataObject } from '../models/section-data.model';
import { SectionsType } from '../sections-type'; import { SectionsType } from '../sections-type';
import { import {
@@ -26,21 +26,21 @@ import {
mockUploadConfigResponseNotRequired, mockUploadConfigResponseNotRequired,
mockUploadFiles, mockUploadFiles,
} from '../../../shared/mocks/submission.mock'; } from '../../../shared/mocks/submission.mock';
import { SubmissionUploadsConfigService } from '../../../core/config/submission-uploads-config.service'; import { SubmissionUploadsConfigDataService } from '../../../core/config/submission-uploads-config-data.service';
import { SectionUploadService } from './section-upload.service'; import { SectionUploadService } from './section-upload.service';
import { SubmissionSectionUploadComponent } from './section-upload.component'; import { SubmissionSectionUploadComponent } from './section-upload.component';
import { CollectionDataService } from '../../../core/data/collection-data.service'; import { CollectionDataService } from '../../../core/data/collection-data.service';
import { GroupDataService } from '../../../core/eperson/group-data.service'; import { GroupDataService } from '../../../core/eperson/group-data.service';
import { Collection } from '../../../core/shared/collection.model'; import { Collection } from '../../../core/shared/collection.model';
import { ResourcePolicy } from '../../../core/resource-policy/models/resource-policy.model'; import { ResourcePolicy } from '../../../core/resource-policy/models/resource-policy.model';
import { ResourcePolicyService } from '../../../core/resource-policy/resource-policy.service'; import { ResourcePolicyDataService } from '../../../core/resource-policy/resource-policy-data.service';
import { Group } from '../../../core/eperson/models/group.model'; import { Group } from '../../../core/eperson/models/group.model';
import { getMockSectionUploadService } from '../../../shared/mocks/section-upload.service.mock'; import { getMockSectionUploadService } from '../../../shared/mocks/section-upload.service.mock';
import { SubmissionUploadsModel } from '../../../core/config/models/config-submission-uploads.model'; import { SubmissionUploadsModel } from '../../../core/config/models/config-submission-uploads.model';
import { buildPaginatedList } from '../../../core/data/paginated-list.model'; import { buildPaginatedList } from '../../../core/data/paginated-list.model';
import { PageInfo } from '../../../core/shared/page-info.model'; import { PageInfo } from '../../../core/shared/page-info.model';
function getMockSubmissionUploadsConfigService(): SubmissionFormsConfigService { function getMockSubmissionUploadsConfigService(): SubmissionFormsConfigDataService {
return jasmine.createSpyObj('SubmissionUploadsConfigService', { return jasmine.createSpyObj('SubmissionUploadsConfigService', {
getConfigAll: jasmine.createSpy('getConfigAll'), getConfigAll: jasmine.createSpy('getConfigAll'),
getConfigByHref: jasmine.createSpy('getConfigByHref'), getConfigByHref: jasmine.createSpy('getConfigByHref'),
@@ -63,7 +63,7 @@ function getMockGroupEpersonService(): GroupDataService {
}); });
} }
function getMockResourcePolicyService(): ResourcePolicyService { function getMockResourcePolicyService(): ResourcePolicyDataService {
return jasmine.createSpyObj('ResourcePolicyService', { return jasmine.createSpyObj('ResourcePolicyService', {
findByHref: jasmine.createSpy('findByHref') findByHref: jasmine.createSpy('findByHref')
}); });
@@ -175,8 +175,8 @@ describe('SubmissionSectionUploadComponent test suite', () => {
providers: [ providers: [
{ provide: CollectionDataService, useValue: collectionDataService }, { provide: CollectionDataService, useValue: collectionDataService },
{ provide: GroupDataService, useValue: groupService }, { provide: GroupDataService, useValue: groupService },
{ provide: ResourcePolicyService, useValue: resourcePolicyService }, { provide: ResourcePolicyDataService, useValue: resourcePolicyService },
{ provide: SubmissionUploadsConfigService, useValue: uploadsConfigService }, { provide: SubmissionUploadsConfigDataService, useValue: uploadsConfigService },
{ provide: SectionsService, useClass: SectionsServiceStub }, { provide: SectionsService, useClass: SectionsServiceStub },
{ provide: SubmissionService, useValue: submissionServiceStub }, { provide: SubmissionService, useValue: submissionServiceStub },
{ provide: SectionUploadService, useValue: bitstreamService }, { provide: SectionUploadService, useValue: bitstreamService },

Some files were not shown because too many files have changed in this diff Show More