hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-17 23:13:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for PR#1822 - Fix is in section-form-component.ts. Adjusted two equality checks for scope type which always returned false.

Browse Source
This commit is contained in:
Félix Jolin-Nicol
2022-09-15 14:48:57 -04:00
parent 6d361beb88
commit fcae738db6
4 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/submission/sections/form/section-form.component.spec.ts
View File

@@ -357,7 +357,7 @@ describe('SubmissionSectionFormComponent test suite', () => {
describe('in workspace scope', () => {
beforeEach(() => {
// @ts-ignore
comp.submissionObject = { type: WorkspaceItem.type };
comp.submissionObject = { type: WorkspaceItem.type.value };
});
it('should return true for unscoped fields', () => {
@@ -376,7 +376,7 @@ describe('SubmissionSectionFormComponent test suite', () => {
describe('in workflow scope', () => {
beforeEach(() => {
// @ts-ignore
comp.submissionObject = { type: WorkflowItem.type };
comp.submissionObject = { type: WorkflowItem.type.value };
});
it('should return true when field is unscoped', () => {

4
src/app/submission/sections/form/section-form.component.ts
View File

@@ -261,10 +261,10 @@ export class SubmissionSectionFormComponent extends SectionModelComponent {
switch (scope) {
case SubmissionScopeType.WorkspaceItem: {
return this.submissionObject.type === WorkspaceItem.type;
return (this.submissionObject as any).type === WorkspaceItem.type.value;
}
case SubmissionScopeType.WorkflowItem: {
return this.submissionObject.type === WorkflowItem.type;
return (this.submissionObject as any).type === WorkflowItem.type.value;
}
default: {
return true;