From 47f05bf11db435229b513daf3af0f57b376925b7 Mon Sep 17 00:00:00 2001 From: Kristof De Langhe Date: Tue, 31 Jan 2023 13:33:29 +0100 Subject: [PATCH] 97742: Feedback 2023-01-27 - Table roles and aria attributes + additional feedback changes --- ...-edit-metadata-field-values.component.html | 5 +- ...edit-metadata-value-headers.component.html | 5 ++ ...edit-metadata-value-headers.component.scss | 0 ...o-edit-metadata-value-headers.component.ts | 17 ++++ .../dso-edit-metadata-value.component.html | 60 ++++++++------ .../dso-edit-metadata-value.component.scss | 2 +- .../dso-edit-metadata.component.html | 82 +++++++++++-------- src/app/dso-shared/dso-shared.module.ts | 2 + src/assets/i18n/en.json5 | 2 - src/styles/_global-styles.scss | 12 +++ 10 files changed, 123 insertions(+), 64 deletions(-) create mode 100644 src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value-headers/dso-edit-metadata-value-headers.component.html create mode 100644 src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value-headers/dso-edit-metadata-value-headers.component.scss create mode 100644 src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value-headers/dso-edit-metadata-value-headers.component.ts diff --git a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-field-values/dso-edit-metadata-field-values.component.html b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-field-values/dso-edit-metadata-field-values.component.html index cfa457580f..9f74216d54 100644 --- a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-field-values/dso-edit-metadata-field-values.component.html +++ b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-field-values/dso-edit-metadata-field-values.component.html @@ -1,5 +1,6 @@ -
- + + +
{{ dsoType + '.edit.metadata.headers.value' | translate }}
+
{{ dsoType + '.edit.metadata.headers.language' | translate }}
+
{{ dsoType + '.edit.metadata.headers.edit' | translate }}
+
diff --git a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value-headers/dso-edit-metadata-value-headers.component.scss b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value-headers/dso-edit-metadata-value-headers.component.scss new file mode 100644 index 0000000000..e69de29bb2 diff --git a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value-headers/dso-edit-metadata-value-headers.component.ts b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value-headers/dso-edit-metadata-value-headers.component.ts new file mode 100644 index 0000000000..dfda2a50d1 --- /dev/null +++ b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value-headers/dso-edit-metadata-value-headers.component.ts @@ -0,0 +1,17 @@ +import { Component, Input } from '@angular/core'; + +@Component({ + selector: 'ds-dso-edit-metadata-value-headers', + styleUrls: ['./dso-edit-metadata-value-headers.component.scss', '../dso-edit-metadata-shared/dso-edit-metadata-cells.scss'], + templateUrl: './dso-edit-metadata-value-headers.component.html', +}) +/** + * Component displaying invisible headers for a list of metadata values using table roles for accessibility + */ +export class DsoEditMetadataValueHeadersComponent { + /** + * Type of DSO we're displaying values for + * Determines i18n messages + */ + @Input() dsoType: string; +} diff --git a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value/dso-edit-metadata-value.component.html b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value/dso-edit-metadata-value.component.html index aa3c242511..f54dde4971 100644 --- a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value/dso-edit-metadata-value.component.html +++ b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value/dso-edit-metadata-value.component.html @@ -1,7 +1,7 @@ -
-
+
{{ mdValue.newValue.value }}
@@ -10,33 +10,45 @@
-
+
{{ mdValue.newValue.language }}
-
-
-
- - - - +
+
+
+
+ + + + +
-
diff --git a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value/dso-edit-metadata-value.component.scss b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value/dso-edit-metadata-value.component.scss index bcf491b9ce..4a207ee1a4 100644 --- a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value/dso-edit-metadata-value.component.scss +++ b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata-value/dso-edit-metadata-value.component.scss @@ -7,7 +7,7 @@ cursor: grab; } -::ng-deep .tooltip-inner { +::ng-deep .edit-field>ngb-tooltip-window .tooltip-inner { min-width: var(--ds-dso-edit-virtual-tooltip-min-width); } diff --git a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata.component.html b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata.component.html index 51f347e163..24c3dc5cd7 100644 --- a/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata.component.html +++ b/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata.component.html @@ -1,61 +1,70 @@