Commit Graph

72 Commits

Author SHA1 Message Date
Yury Bondarenko
c4b2565373 Workaround: don't use form-global data for check
Note: we're balancing multiple bugs against eachother here, not ideal!
  - the diff doesn't catch removed Relationship fields; instead, form reload is triggered by a dspace.entity.type change
  - if we add the original `this.sectionMetadata.includes(key)` check, we filter out this change and the form fails to update
  - if we add `relation.*` fields to `this.sectionMetadata`, newly added Relationship entries are duplicated

As of this commit, the form _seems_ to work in a stable way, but these issues shoud really investigated in more detail.
2023-06-09 13:39:33 +02:00
Alexandre Vryghem
d4efd85cc5 Merge remote-tracking branch 'upstream/main' into issue-1671_fix-relationships-not-updating-view-on-submission-form_contribute-main 2023-05-12 17:52:37 +02:00
Alexandre Vryghem
b318d7281a 101654: Fixed relationship fields not being hidden when they are out of scope 2023-05-12 17:52:03 +02:00
Alexandre Vryghem
a6a10200d2 Merge remote-tracking branch 'templates/dspace-7.4' into issue-1671_fix-relationships-not-updating-view-on-submission-form_contribute-7.4
# Conflicts:
#	src/app/submission/sections/form/section-form.component.spec.ts
#	src/app/submission/sections/form/section-form.component.ts
2023-05-12 17:36:19 +02:00
samuel
14fb379419 96598: Test feedback pt. 3: submission - repair auto-refresh 2023-05-12 14:51:26 +02:00
Yury Bondarenko
47ae04986d 96252: Make existing lodash imports tree-shakeable 2022-10-25 17:25:34 +02:00
Tim Donohue
9305705ab6 Merge pull request #1828 from FelixNicol/Virtual-metadatas-visibility-workflow-not-updated
Fix for PR#1822 - Adjusted two equality checks for scope type which always return false.
2022-10-03 17:15:26 -05:00
Félix Jolin-Nicol
fcae738db6 Fix for PR#1822 - Fix is in section-form-component.ts. Adjusted two equality checks for scope type which always returned false. 2022-09-15 14:48:57 -04:00
Yura Bondarenko
fbaab69121 93803: Ensure data services are called *DataService 2022-08-25 10:28:45 +02:00
lotte
30b7e8eb39 Merge branch 'main' into w2p-87382_circular-dependency-fixes 2022-04-05 16:35:00 +02:00
lotte
143b7c3e0d 87382: fixing circular dependencies 2022-02-16 13:52:32 +01:00
Yura Bondarenko
a698610043 87242: Refactor workspaceItem to submissionObject 2022-02-15 13:21:27 +01:00
Yura Bondarenko
f4b8d4fe41 87242: Fix forced re-init due to out-of-scope fields 2022-02-15 11:53:21 +01:00
Giuseppe Digilio
532d8fb9a3 [CST-4506] fix SubmissionSectionFormComponent name 2022-01-20 18:30:29 +01:00
Giuseppe Digilio
44d2310cdb Changes in order to keep server side validation errors into the submission form state 2021-06-25 15:23:56 +02:00
Alessandro Martelli
5201b4a31d [CST-3782] qualdrop move restored 2021-03-04 18:26:03 +01:00
Alessandro Martelli
5eb0a8744f [CSTPER-3782] custom move events handled correctly 2021-03-04 12:36:57 +01:00
Alessandro Martelli
d208cf16fa [CST-3782] Drag drop restored 2021-02-17 17:57:29 +01:00
Art Lowel
c66de4fe91 Cache redesign part 2 2021-01-20 17:43:40 +01:00
Giuseppe Digilio
4d4e920f0d Merge remote-tracking branch 'origin/main' into upgrade_angular10
# Conflicts:
#	src/app/+admin/admin-access-control/epeople-registry/epeople-registry.component.spec.ts
#	src/app/+admin/admin-access-control/epeople-registry/epeople-registry.component.ts
#	src/app/+admin/admin-access-control/epeople-registry/eperson-form/eperson-form.component.spec.ts
#	src/app/+admin/admin-access-control/group-registry/group-form/group-form.component.spec.ts
#	src/app/+admin/admin-access-control/group-registry/group-form/members-list/members-list.component.spec.ts
#	src/app/+admin/admin-access-control/group-registry/group-form/subgroup-list/subgroups-list.component.spec.ts
#	src/app/+admin/admin-access-control/group-registry/groups-registry.component.ts
#	src/app/+admin/admin-import-metadata-page/metadata-import-page.component.ts
#	src/app/+admin/admin-registries/metadata-registry/metadata-registry.component.ts
#	src/app/+admin/admin-registries/metadata-schema/metadata-schema.component.ts
#	src/app/+admin/admin-search-page/admin-search-results/admin-search-result-grid-element/item-search-result/item-admin-search-result-grid-element.component.spec.ts
#	src/app/+admin/admin-search-page/admin-search-results/admin-search-result-list-element/item-search-result/item-admin-search-result-list-element.component.spec.ts
#	src/app/+bitstream-page/bitstream-page.resolver.ts
#	src/app/+bitstream-page/edit-bitstream-page/edit-bitstream-page.component.spec.ts
#	src/app/+bitstream-page/edit-bitstream-page/edit-bitstream-page.component.ts
#	src/app/+collection-page/collection-item-mapper/collection-item-mapper.component.ts
#	src/app/+collection-page/collection-page.component.ts
#	src/app/+collection-page/edit-collection-page/collection-roles/collection-roles.component.ts
#	src/app/+collection-page/edit-item-template-page/item-template-page.resolver.spec.ts
#	src/app/+collection-page/edit-item-template-page/item-template-page.resolver.ts
#	src/app/+item-page/edit-item-page/item-authorizations/item-authorizations.component.ts
#	src/app/+item-page/edit-item-page/item-bitstreams/item-bitstreams.component.spec.ts
#	src/app/+item-page/edit-item-page/item-bitstreams/item-bitstreams.component.ts
#	src/app/+item-page/edit-item-page/item-collection-mapper/item-collection-mapper.component.ts
#	src/app/+item-page/edit-item-page/item-private/item-private.component.ts
#	src/app/+item-page/edit-item-page/item-public/item-public.component.ts
#	src/app/+item-page/edit-item-page/item-reinstate/item-reinstate.component.ts
#	src/app/+item-page/edit-item-page/item-relationships/edit-relationship-list/edit-relationship-list.component.ts
#	src/app/+item-page/edit-item-page/item-relationships/item-relationships.component.ts
#	src/app/+item-page/edit-item-page/item-withdraw/item-withdraw.component.ts
#	src/app/+item-page/simple/item-types/shared/item-relationships-utils.ts
#	src/app/+my-dspace-page/collection-selector/collection-selector.component.spec.ts
#	src/app/+search-page/search-tracker.component.ts
#	src/app/app-routing.module.ts
#	src/app/community-list-page/community-list-service.ts
#	src/app/community-list-page/community-list.reducer.spec.ts
#	src/app/core/auth/auth-response-parsing.service.spec.ts
#	src/app/core/auth/auth.interceptor.spec.ts
#	src/app/core/browse/browse.service.spec.ts
#	src/app/core/browse/browse.service.ts
#	src/app/core/cache/builders/link.service.spec.ts
#	src/app/core/cache/builders/remote-data-build.service.ts
#	src/app/core/cache/object-cache.service.spec.ts
#	src/app/core/cache/response.models.ts
#	src/app/core/data/base-response-parsing.service.ts
#	src/app/core/data/bitstream-data.service.ts
#	src/app/core/data/bitstream-format-data.service.ts
#	src/app/core/data/bundle-data.service.spec.ts
#	src/app/core/data/bundle-data.service.ts
#	src/app/core/data/change-analyzer.ts
#	src/app/core/data/collection-data.service.spec.ts
#	src/app/core/data/collection-data.service.ts
#	src/app/core/data/comcol-data.service.spec.ts
#	src/app/core/data/comcol-data.service.ts
#	src/app/core/data/data.service.ts
#	src/app/core/data/entity-type-data.service.ts
#	src/app/core/data/entity-type.service.ts
#	src/app/core/data/feature-authorization/authorization-data.service.ts
#	src/app/core/data/feature-authorization/feature-data.service.ts
#	src/app/core/data/item-template-data.service.ts
#	src/app/core/data/license-data.service.ts
#	src/app/core/data/metadata-field-data.service.ts
#	src/app/core/data/processes/process-data.service.ts
#	src/app/core/data/processes/script-data.service.ts
#	src/app/core/data/relationship.service.spec.ts
#	src/app/core/data/relationship.service.ts
#	src/app/core/data/remote-data.ts
#	src/app/core/data/request.actions.ts
#	src/app/core/data/request.effects.ts
#	src/app/core/data/request.reducer.spec.ts
#	src/app/core/data/request.reducer.ts
#	src/app/core/data/request.service.spec.ts
#	src/app/core/data/request.service.ts
#	src/app/core/dspace-rest/dspace-rest.service.spec.ts
#	src/app/core/eperson/eperson-data.service.spec.ts
#	src/app/core/eperson/eperson-data.service.ts
#	src/app/core/eperson/group-data.service.spec.ts
#	src/app/core/eperson/group-data.service.ts
#	src/app/core/forward-client-ip/forward-client-ip.interceptor.spec.ts
#	src/app/core/index/index.reducer.ts
#	src/app/core/json-patch/json-patch-operations.service.spec.ts
#	src/app/core/json-patch/json-patch-operations.service.ts
#	src/app/core/locale/locale.interceptor.spec.ts
#	src/app/core/registry/registry.service.ts
#	src/app/core/resource-policy/resource-policy.service.ts
#	src/app/core/shared/operators.ts
#	src/app/core/shared/search/search.service.ts
#	src/app/core/submission/submission-object-data.service.ts
#	src/app/core/submission/submission-rest.service.ts
#	src/app/core/submission/vocabularies/vocabulary-entries-response-parsing.service.spec.ts
#	src/app/core/submission/vocabularies/vocabulary.service.spec.ts
#	src/app/core/submission/vocabularies/vocabulary.service.ts
#	src/app/core/submission/workflowitem-data.service.ts
#	src/app/core/tasks/tasks.service.ts
#	src/app/curation-form/curation-form.component.ts
#	src/app/process-page/process-page.resolver.ts
#	src/app/shared/collection-dropdown/collection-dropdown.component.spec.ts
#	src/app/shared/collection-dropdown/collection-dropdown.component.ts
#	src/app/shared/comcol-forms/create-comcol-page/create-comcol-page.component.spec.ts
#	src/app/shared/comcol-forms/create-comcol-page/create-comcol-page.component.ts
#	src/app/shared/comcol-forms/edit-comcol-page/comcol-metadata/comcol-metadata.component.spec.ts
#	src/app/shared/comcol-forms/edit-comcol-page/comcol-role/comcol-role.component.spec.ts
#	src/app/shared/comcol-forms/edit-comcol-page/comcol-role/comcol-role.component.ts
#	src/app/shared/dso-selector/dso-selector/dso-selector.component.ts
#	src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.ts
#	src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/relationship.effects.ts
#	src/app/shared/form/builder/form-builder.service.ts
#	src/app/shared/item/item-versions/item-versions.component.ts
#	src/app/shared/mocks/remote-data-build.service.mock.ts
#	src/app/shared/mydspace-actions/workspaceitem/workspaceitem-actions.component.ts
#	src/app/shared/object-detail/my-dspace-result-detail-element/item-detail-preview/item-detail-preview.component.spec.ts
#	src/app/shared/object-select/collection-select/collection-select.component.spec.ts
#	src/app/shared/object-select/item-select/item-select.component.spec.ts
#	src/app/shared/pagination-drag-and-drop/abstract-paginated-drag-and-drop-list.component.spec.ts
#	src/app/shared/pagination-drag-and-drop/abstract-paginated-drag-and-drop-list.component.ts
#	src/app/shared/resource-policies/form/eperson-group-list/eperson-group-list.component.ts
#	src/app/shared/search/search-query-response.model.ts
#	src/app/statistics/statistics.module.ts
#	src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.spec.ts
#	src/app/submission/sections/form/section-form.component.ts
#	src/app/submission/sections/upload/section-upload.component.spec.ts
#	src/app/submission/sections/upload/section-upload.component.ts
#	src/app/submission/submission.service.spec.ts
#	src/app/submission/submission.service.ts
2021-01-07 19:17:19 +01:00
Alessandro Martelli
6cf6dee5e6 [835] Auto-save in new Item Submission form breaks the form
Fixed unused imports.
2020-12-22 08:33:23 +01:00
Alessandro Martelli
8e77fac638 [835] Auto-save in new Item Submission form breaks the form
Minor fixes and method computeSectionConfiguredMetadata tested
2020-12-21 19:21:49 +01:00
Alessandro Martelli
0794c50d19 [835] Auto-save in new Item Submission form breaks the form
Fixed unused imports.
2020-12-21 17:27:59 +01:00
Alessandro Martelli
0acaa3e57f [835] Auto-save in new Item Submission form breaks the form
Section metadata dispatched to the store and retrieved in subscription.
Added test case for hasMetadataEnrichment.
2020-12-21 17:23:03 +01:00
Alessandro Martelli
55bcdf0a25 [835] Auto-save in new Item Submission form breaks the form
Minor changes and cleanup.
2020-12-21 17:23:03 +01:00
Alessandro Martelli
875a43a14e [835] Auto-save in new Item Submission form breaks the form
Section formId added to the section state.
Error filtering during the parsing of the submission response.
2020-12-21 17:23:03 +01:00
Alessandro Martelli
8111bdd3ce [835] Auto-save in new Item Submission form breaks the form
Store additions:
1. Form AdditionalData: contains the list of the touched metadata
2. Submission metadata: contains the list of the metadata ids assignable for each section

We keep also track whether a section ha focused fields or not.
2020-12-21 17:22:33 +01:00
Art Lowel
4e18fa35ca Cache redesign part 1, and add support for alternative links 2020-12-14 16:09:33 +01:00
Giuseppe Digilio
20b5721e3c Fixed lint errors and add lint fix script 2020-12-04 10:32:46 +01:00
Giuseppe Digilio
9f5204992d Replaced deprecated rxjs flatMap operator 2020-11-23 15:38:02 +01:00
Giuseppe Digilio
1b21af3191 updated to the latest 9.x version 2020-11-18 19:02:55 +01:00
Art Lowel
f167d5a629 fix issue where combining entities and authority control in the same field wouldn't work 2020-09-01 14:25:50 +02:00
Giuseppe Digilio
a25ab5620f Merge remote-tracking branch 'remotes/origin/main' into authorities_and_controlled_vocabularies 2020-07-23 11:41:03 +02:00
Art Lowel
a281583f6e fix test and lint issues after merge 2020-06-22 12:26:30 +02:00
lotte
aa9570c776 Merge branch 'master' into metadata-and-relationships-combined-in-submission 2020-05-12 17:19:08 +02:00
Art Lowel
dd7fc2aa6f fix issue where editing template rows caused invald patch requests 2020-04-22 15:13:12 +02:00
Art Lowel
53fd559a7c fix issues with deleting of reorderable array items 2020-04-22 09:49:32 +02:00
lotte
dd0396465e fixed tests except for iterator issue in data services 2020-03-18 17:03:19 +01:00
lotte
8bf241c182 angular cli 2020-03-18 16:03:40 +01:00
Giuseppe Digilio
98d44fd42e Fixed issue with workflowitem edit 2020-03-03 17:38:03 +01:00
Art Lowel
a8d5ad9c37 fix adding of metadata only fields, and styling 2020-02-25 17:01:44 +01:00
Art Lowel
9d059e190e Merge branch 'master' into metadata-and-relationships-combined-in-submission 2020-02-24 11:42:55 +01:00
lotte
04cb75e786 upgraded to angular 8 2020-02-13 11:09:20 +01:00
lotte
6cfcff5503 fixed tests in relaitonship service 2020-02-05 16:53:39 +01:00
lotte
360abb78de intermediate commit 2020-02-03 12:58:24 +01:00
lotte
01ba97af7a applied feedback 2019-12-20 14:13:31 +01:00
lotte
19510a88ef fixed functionality after merge 2019-11-08 10:59:52 +01:00
lotte
7e62ce80c2 Merge branch 'refactor-submission-parsers' into clean-relationships-in-submission 2019-11-08 08:49:12 +01:00
Art Lowel
d255838265 add submissionId to fieldparser, and refactor to create fieldparsers using DI 2019-11-05 15:53:41 +01:00
lotte
5925b50141 65711: implemented retrieval and initial saving of name variants 2019-10-24 16:41:11 +02:00