Commit Graph

6583 Commits

Author SHA1 Message Date
Marie Verdonck
32676fc500 90263: issue 8205 - check if downloadable before citation_pdf_url to source 2022-04-13 15:50:08 +02:00
Alexandre Vryghem
e3172fd6e8 90768: Updated tests for search.util and created test for SearchHierarchyFilterComponent 2022-04-13 10:01:50 +02:00
Alexandre Vryghem
8924b2c92c 90768: Prevent empty filters from being added 2022-04-13 09:46:14 +02:00
Alexandre Vryghem
b3f010974d 90768: Removing and adding filter could break filter 2022-04-12 21:54:22 +02:00
Alexandre Vryghem
2ef9c1db18 90768: Appended query operator to the filter 2022-04-11 09:48:07 +02:00
Alexandre Vryghem
61650df492 90768: Fixed dropdown position bug 2022-04-11 09:41:55 +02:00
Yura Bondarenko
f8297218ad 87968: Fix unstyled link issue 2022-04-08 17:58:25 +02:00
Yura Bondarenko
3f340c18f2 87968: Fix spacing issues via custom CSS 2022-04-08 17:58:23 +02:00
Yura Bondarenko
042a0dd389 87968: Revert previous spacing fixes 2022-04-08 17:57:16 +02:00
Yura Bondarenko
c736ebaebf Revert "87968: Increase Node --max_old_space_size"
This reverts commit 62e7615f1fa9b680120e7ab7dbef173a5e4679dc.
2022-04-08 17:57:16 +02:00
Art Lowel
708375593d add margin to compensate for the switch to preserveWhiteSpaces = false 2022-04-08 17:57:16 +02:00
Yura Bondarenko
0115c5217b 87968: Turn off preserveWhitespaces by default
And set to true explicitly for MyDSpace action components to preserve look
(see https://github.com/DSpace/dspace-angular/issues/903#issuecomment-713013310)
2022-04-08 17:57:16 +02:00
Yura Bondarenko
a14cc6fde2 87968: Run CI ESLint in --quiet mode 2022-04-08 17:57:16 +02:00
Yura Bondarenko
22ac66787a 87968: Kill app if still up after e2e tests 2022-04-08 17:57:16 +02:00
Yura Bondarenko
99c41b9e80 87968: Minor code changes to pass lint 2022-04-08 17:57:16 +02:00
Yura Bondarenko
bb51609af9 87968: Update ESLint disable/enable comments
eslint-disable max-classes-per-file only works at the top of the file now
2022-04-08 17:57:16 +02:00
Yura Bondarenko
b5911b8536 87968: Manual ESLint configuration
Extend recommended ESLint rulesets, disable rules that are too noisy or would require major code changes to resolve errors
Restore TSLint configuration as closely as possible
2022-04-08 17:57:16 +02:00
Yura Bondarenko
245977a432 87968: Automatic migration from TSLint to ESLint
Via `ng g @angular-eslint/schematics:convert-tslint-to-eslint`
2022-04-08 17:57:16 +02:00
Yura Bondarenko
ec6327edc2 87968: Automatic ESLint install
Via CLI suggestion when running `ng lint` w/o ESLint on Angular 13
2022-04-08 17:57:16 +02:00
Yura Bondarenko
cad76ff378 87968: Increase Node --max_old_space_size 2022-04-08 17:57:16 +02:00
Yura Bondarenko
59d46ffbdf 87968: Upgrade ng-bootstrap to v11
Some tests involving NgbModal now fail if setup with mock Injector without `get` method
2022-04-08 17:57:16 +02:00
Yura Bondarenko
5488d0f83a 87968: Remove unused import 2022-04-08 17:57:16 +02:00
Yura Bondarenko
48efccb53b 87968: Upgrade ngx-gallery 2022-04-08 17:57:16 +02:00
Yura Bondarenko
bfdda43a48 87968: Update devServer configuration 2022-04-08 17:57:16 +02:00
Yura Bondarenko
d78019cd39 87968: Fix unit tests 2022-04-08 17:57:15 +02:00
Yura Bondarenko
563956c5df 87968: Manual fixes after NgRx migration
Selector typing

Restored pre-13 behaviour where mock stores were reset after every test.
The upgrade caused multiple tests to start failing; we could solve this
by adjusting all of these one by one but that would take some time.
(see https://ngrx.io/guide/migration/v13#testing-reset-mock-store)
2022-04-08 17:57:15 +02:00
Yura Bondarenko
8e4f1993bf 87968: Automatic upgrade to NgRx 13 2022-04-08 17:57:15 +02:00
Yura Bondarenko
8f7389c83a 87968: Fix JSON5 parsing in Universal loader
Failed ~
  Error: export 'parse' (imported as 'JSON5') was not found in 'json5' (possible exports: default)

Only affected SSR: once CSR kicked in translations were loaded properly
2022-04-08 17:57:15 +02:00
Yura Bondarenko
49f470c07b 87968: Various dependency changes
Upgraded:
  zone.js
  ng-mocks
  @angular/cdk
  @ngtools/webpack
  @angular-builders/custom-webpack
  @nguniversal

Added:
 postcss-preset-env: fix spurious CSS warnings
 sass-loader: fix "can't resolve 'sass-loader'" & "the loader didn't return a string" errors
2022-04-08 17:57:15 +02:00
Yura Bondarenko
c1d870c32d 87968: Clean up after automatic upgrade
- Get rid of missed empty routerLinks
- Fix abstract property initializers
- Specify coverage reporter
2022-04-08 17:57:15 +02:00
Yura Bondarenko
1b460fe1d3 87968: Automatic upgrade to Angular 13 2022-04-08 17:57:15 +02:00
Yura Bondarenko
47c8ca7342 87968: Lift readyState complete check from Universal 12 2022-04-08 17:57:15 +02:00
Yura Bondarenko
ae89571519 87968: Fix unit tests 2022-04-08 17:57:15 +02:00
Yura Bondarenko
26d45fd5e7 87968: Remove angular2-text-mask dependency 2022-04-08 17:57:15 +02:00
Yura Bondarenko
3eb3afcc96 87968: Fix rxjs/internal imports 2022-04-08 17:57:15 +02:00
Yura Bondarenko
5476062648 87968: Add unmet peer dependencies 2022-04-08 17:57:15 +02:00
Yura Bondarenko
0e178ce1bc 87968: Fix missing theme assets
Adapt to changes in https://github.com/webpack-contrib/copy-webpack-plugin
2022-04-08 17:57:15 +02:00
Art Lowel
808d4e925a Enable source maps in dev mode 2022-04-08 17:57:15 +02:00
Art Lowel
a47d7dd846 Upgrade ng-dynamic forms 2022-04-08 17:57:15 +02:00
Yura Bondarenko
621a874b29 87968: Include theme modules in tsconfig.spec.ts
Without this, Webpack errors out when building tests due to theme components missing from the TS compilation
2022-04-08 17:57:15 +02:00
Yura Bondarenko
9093ef4ae9 87968: Karma needs ts-node 10.2.1
Otherwise tests error out with
  Uncaught ReferenceError: sourceMapSupport is not defined

Check just-jeb/angular-builders issue 1046 for more info
2022-04-08 17:57:15 +02:00
Yura Bondarenko
29d8dd68f4 87968: Remove html-webpack-plugin
After updating to Angular 12, it causes ng serve to fail with
  Conflict: Multiple assets emit different content to the same filename index.html

Confirmed that the application still builds and runs properly without it.

This plugin isn't used by @angular-builders/custom-webpack since Angular 8 (see https://www.justjeb.com/post/customizing-angular-cli-build#viewer-51npg), this is just the first time it's actually causing problems for us.

Removed script-ext-html-webpack-plugin as well since that's an extension to html-webpack-plugin & can't run without it.
2022-04-08 17:57:15 +02:00
Yura Bondarenko
22c5976095 87968: Upgrade to Angular 12 2022-04-08 17:57:15 +02:00
Tim Donohue
45887154b6 Merge pull request #1582 from louiserumpf/translation-de
Updated German translation
2022-04-06 12:08:28 -05:00
Tim Donohue
8a6fd925b4 Merge pull request #1580 from BibNumUMontreal/main
French translation reviewed and updated
2022-04-05 13:51:18 -05:00
lotte
6d3ef58ecc Removed unused imports 2022-04-05 17:27:45 +02:00
lotte
bcf2560ee7 Merge branch 'main' into Removing-unnecessary-circular-dependencies 2022-04-05 16:40:02 +02:00
lotte
53c67ac878 fixed after merge 2022-04-05 16:35:24 +02:00
lotte
30b7e8eb39 Merge branch 'main' into w2p-87382_circular-dependency-fixes 2022-04-05 16:35:00 +02:00
Jens Vannerum
8fad82c549 90155: Added queryParams to link menu options
- Made it possible to add queryParams to a link in the menu
2022-04-05 16:00:10 +02:00