Giuseppe Digilio
32f1d1096a
Merge branch 'main' into DURACOM-234
...
# Conflicts:
# src/app/core/data/request.service.ts
# src/modules/app/browser-app.config.ts
# src/modules/app/server-app.config.ts
2024-04-04 09:32:38 +02:00
Tim Donohue
86ddd45dc1
Merge pull request #2886 from tdonohue/csrf_fixes
...
Ensures CSRF token is initialized prior to first modifying (non-`GET`) request
2024-04-03 14:43:40 -05:00
Tim Donohue
bbab56a7da
Update build script to use "docker compose" instead of "docker-compose". Fixes random failures starting e2e test backend via Docker
2024-04-03 14:00:42 -05:00
lotte
bff5de066b
Merge branch 'w2p-113500_submission-describe-warning-7.6' into w2p-113500_submission-describe-warning_contribution
2024-04-03 19:05:34 +02:00
Giuseppe Digilio
35714b7a45
[DURACOM-234] rename guards in order to be complaint to function name convention
2024-04-03 18:57:11 +02:00
Giuseppe Digilio
f1686d5499
[DURACOM-234] rename resolvers in order to be complaint to function name convention
2024-04-03 18:48:14 +02:00
Tim Donohue
f7d31fd341
Fix tests. Add XSRFService to all specs which need it to be initialized
2024-04-03 11:48:13 -05:00
Tim Donohue
cc6b159a8a
Update code to use GET request. Cleanup lint errors & add in basic TypeDocs
2024-04-03 10:25:43 -05:00
Art Lowel
617c7d8756
make a call to ensure a correct XSRF token before performing any non-GET requests
2024-04-03 09:46:45 -05:00
Yury Bondarenko
b99d9030cd
Fix stray Angular 17 dependency
2024-04-03 12:36:46 +02:00
Giuseppe Digilio
aba04913ce
[DURACOM-234] Replace Observable with BehaviorSubject
2024-04-02 18:54:39 +02:00
Giuseppe Digilio
660cf7e4dd
[DURACOM-234] Remove assertions on isResponsePending in favour of remote data operators
2024-04-02 18:54:00 +02:00
Giuseppe Digilio
b49d883e0b
[DURACOM-234] fix my-dspace.guard
2024-04-02 18:51:00 +02:00
Giuseppe Digilio
b8c26a71c3
[DURACOM-234] Fixes after migrating to functional guards
2024-04-02 18:45:57 +02:00
Alexandre Vryghem
fb8733ca0b
113901: Store the retrieved Relationships in the store
...
This needs to be done here too, since tilted relationships won't be returned by the api/core/items/{uuid}/relationships endpoint
2024-04-02 17:39:44 +02:00
Giuseppe Digilio
026e16ffd9
[DURACOM-234] Fix tests
2024-04-02 15:28:19 +02:00
Giuseppe Digilio
32b816c1aa
[DURACOM-234] Made use of mapToCanActivate for all the guards which are still Class
2024-04-02 13:13:25 +02:00
Giuseppe Digilio
19548fc6d4
[DURACOM-234] Move resolver dependency to relate functional one
2024-04-02 12:31:32 +02:00
Giuseppe Digilio
6a4ad7bdb4
[DURACOM-234] Fix resolver name
2024-04-02 12:28:49 +02:00
Giuseppe Digilio
29f5a17528
[DURACOM-234] Migrate to functional guards WIP
2024-03-29 18:28:32 +01:00
Tim Donohue
2dfa075423
Merge pull request #2832 from alexandrevryghem/patch_2808
...
[Port dspace-7_x] Refactored community & collection pages
2024-03-29 10:04:08 -05:00
Giuseppe Digilio
5dbc6ce7a8
[DURACOM-237] Fix issue on drag end
2024-03-29 12:47:03 +01:00
Yury Bondarenko
c4b32febc1
Explain themed-component-classes rule
2024-03-29 10:52:55 +01:00
Yury Bondarenko
08a5443cc2
Add generated docs to source
2024-03-29 10:47:04 +01:00
Yury Bondarenko
515e5f00cf
Improve documentation
2024-03-29 10:46:20 +01:00
Yury Bondarenko
2c68589416
Move generated documentation to docs/lint/
2024-03-29 10:12:57 +01:00
Giuseppe Digilio
1f4aca800b
[DURACOM-234] Migrate fo functional resolver
2024-03-28 23:34:37 +01:00
Yury Bondarenko
a6e093038c
Manual fix: use base components in unit test templates
...
`Themed*` components should be used in the actual codebase to ensure we retain theme support.
However, in unit tests these components won't work without a fully-functional `ThemeService` & `Store`.
For this reason, the lint plugin allows `ds-base-*` selectors in unit test templates.
2024-03-28 18:52:06 +01:00
Yury Bondarenko
762e4616cc
Manual fix: sync removed imports between tests and components
...
The automatic migration made it so HTML always uses the `Themed*` component, and it must therefore be imported in all standalone components that use it.
Afterwards, many unit tests fail because the removed imports no longer match up (can't inject `ThemeService`).
While we could try to support this as part of the automatic migration, there are too many edge cases for this to be consistent.
2024-03-28 18:52:06 +01:00
Yury Bondarenko
0b9741d252
Manual fix: update i/o for ThemedConfigurationSearchPageComponent
...
Fixes compile-time errors due to out-of-sync inputs and outputs between ThemedConfigurationSearchPageComponent and SearchComponent
(note that this is was an existing problem in the source code that flew under the radar until we flipped the selector convention!)
2024-03-28 18:52:06 +01:00
Yury Bondarenko
6051b82821
Automatically migrate to new themeable component convention
2024-03-28 18:33:46 +01:00
Yury Bondarenko
e40b6ae612
Update plugins to support standalone components
...
- ThemedComponent wrappers should always import their base component. This ensures that it's always enough to only import the wrapper when we use it.
- This implies that all themeable components must be standalone
→ added rules to enforce this
→ updated usage rule to improve declaration/import handling
2024-03-28 18:33:46 +01:00
Giuseppe Digilio
549609e2ea
[DURACOM-234] Fix Markdown Config
2024-03-28 16:49:14 +01:00
Giuseppe Digilio
abae9b9246
[DURACOM-234] WIP fix SSR
2024-03-28 16:37:42 +01:00
Giuseppe Digilio
3cb000db7c
Merge branch 'DURACOM-234' into DURACOM-234-ANGULAR-17
...
# Conflicts:
# src/main.server.ts
2024-03-27 14:22:42 +01:00
lotte
722bd6f7f5
113500: Fixed lint error
2024-03-27 14:15:20 +01:00
lotte
4e0046022b
113500: Fixed tests after bugfix
2024-03-27 14:07:55 +01:00
lotte
993ce1ab16
113500: Fix for warning on first describe step
2024-03-27 13:27:44 +01:00
Giuseppe Digilio
a8c3af097d
[DURACOM-234] Switch to standalone bootstrapping API
2024-03-26 20:52:26 +01:00
Giuseppe Digilio
0c3e9b1535
[DURACOM-234] Fix NG0600 error
2024-03-26 18:42:29 +01:00
Alan Orth
43137fe676
Merge pull request #2879 from DSpace/backport-2877-to-dspace-7_x
...
[Port dspace-7_x] System-wide alert shouldn't be created when the message is empty
2024-03-26 11:26:31 +03:00
Alexandre Vryghem
d05438dc3e
Prevent system-wide alert to be activated with empty message
...
(cherry picked from commit 767de4b5c8
2024-03-26 07:12:03 +00:00
Alan Orth
b3b3ef8203
Merge pull request #2877 from alexandrevryghem/fix-systemwidealert-form-validation_contribute-main
...
System-wide alert shouldn't be created when the message is empty
2024-03-26 10:11:45 +03:00
Alexandre Vryghem
c476c4b343
Merge branch 'main' into minor-themed-component-fixes_contribute-main
2024-03-25 00:14:45 +01:00
Alexandre Vryghem
147b9f2efb
Merge branch 'main' into minor-themed-component-fixes_contribute-main
2024-03-24 23:56:23 +01:00
Alexandre Vryghem
25cb0455e2
Fixed bug in BrowseService where findListByHref was called with null instead of undefined, which prevented its default values from being used
...
(cherry picked from commit e6bf2f0ca7
2024-03-24 19:12:48 +01:00
Alexandre Vryghem
babe936c30
Merge branch 'w2p-109964_fix-vocabulary-options-with-url-as-stored-value_contribute-7.6' into w2p-109964_fix-vocabulary-options-with-url-as-stored-value_contribute-main
...
# Conflicts:
# src/app/core/data/relationship-data.service.ts
# src/app/core/data/relationship-type-data.service.ts
# src/app/core/eperson/eperson-data.service.spec.ts
# src/app/core/statistics/usage-report-data.service.ts
# src/app/core/submission/submission-cc-license-url-data.service.ts
# src/app/core/submission/workspaceitem-data.service.ts
2024-03-24 15:17:57 +01:00
Alexandre Vryghem
d5cf236938
Refactored code to always encode the RequestParams
2024-03-24 13:32:25 +01:00
Alexandre Vryghem
03e49907c1
Merge branch 'fix-systemwidealert-form-validation_contribute-7.6' into fix-systemwidealert-form-validation_contribute-main
2024-03-23 16:04:25 +01:00
Alexandre Vryghem
767de4b5c8
Prevent system-wide alert to be activated with empty message
2024-03-23 15:12:48 +01:00
