Yury Bondarenko
c0f43bc585
ESLint: fix rxjs/no-implicit-any-catch
...
In most cases we can deal with the untyped errors by introducing an explicit instanceof check
DspaceRestService includes an unsafe catch/rethrow → made it explicitly typed as `any`, but it should be revisited at some point
2023-06-28 16:30:38 +02:00
Yury Bondarenko
a11be65f95
ESlint: fix imports
2023-06-27 17:20:06 +02:00
Yury Bondarenko
917c36dbe7
ESLint: fix dangling commas
2023-06-27 17:19:58 +02:00
Yury Bondarenko
0690a201dc
ESLint: fix indentation
2023-06-27 17:19:55 +02:00
Yury Bondarenko
47ae04986d
96252: Make existing lodash imports tree-shakeable
2022-10-25 17:25:34 +02:00
Giuseppe Digilio
b023a5a03c
[CST-5270] Fix submission-objects.effects sherpa romeo customization
2022-04-28 18:58:35 +02:00
Rezart Vata
a754a20ec6
[CST-5270] Fixing ISSN removal and unit testing
2022-04-28 18:12:15 +02:00
Tim Donohue
afbd31a138
Merge pull request #1607 from 4Science/CST-5418-improve-cannot-deposit-notification
...
[CST-5418] Improve notification when cannot deposit
2022-04-26 14:28:08 -05:00
Giuseppe Digilio
0506c5596a
[CST-5418] Use different param for notifications and errors in the parseSaveResponse method
2022-04-21 11:30:15 +02:00
Giuseppe Digilio
c250408382
[CST-5418] Improve notification when cannot deposit
2022-04-20 16:10:18 +02:00
lotte
6784ac39f6
Merge branch 'main' into Removing-unnecessary-circular-dependencies
2022-04-20 14:47:55 +02:00
Yura Bondarenko
99c41b9e80
87968: Minor code changes to pass lint
2022-04-08 17:57:16 +02:00
Yura Bondarenko
8e4f1993bf
87968: Automatic upgrade to NgRx 13
2022-04-08 17:57:15 +02:00
lotte
30b7e8eb39
Merge branch 'main' into w2p-87382_circular-dependency-fixes
2022-04-05 16:35:00 +02:00
lotte
143b7c3e0d
87382: fixing circular dependencies
2022-02-16 13:52:32 +01:00
Giuseppe Digilio
eca9088337
[CST-5198] fix issue with uploaded file that disappear on deposit
2022-01-27 17:59:31 +01:00
Kristof De Langhe
549529c889
85262: Get submission object instead of sending empty patch + revert empty patch code
2021-12-10 14:18:51 +01:00
Kristof De Langhe
ed2c774d86
85262: Allow empty patch requests
2021-12-02 12:39:07 +01:00
Kristof De Langhe
5e17a4e958
85262: Always enable deposit button
2021-11-30 13:27:16 +01:00
Giuseppe Digilio
44d2310cdb
Changes in order to keep server side validation errors into the submission form state
2021-06-25 15:23:56 +02:00
Art Lowel
c66de4fe91
Cache redesign part 2
2021-01-20 17:43:40 +01:00
Giuseppe Digilio
4d4e920f0d
Merge remote-tracking branch 'origin/main' into upgrade_angular10
...
# Conflicts:
# src/app/+admin/admin-access-control/epeople-registry/epeople-registry.component.spec.ts
# src/app/+admin/admin-access-control/epeople-registry/epeople-registry.component.ts
# src/app/+admin/admin-access-control/epeople-registry/eperson-form/eperson-form.component.spec.ts
# src/app/+admin/admin-access-control/group-registry/group-form/group-form.component.spec.ts
# src/app/+admin/admin-access-control/group-registry/group-form/members-list/members-list.component.spec.ts
# src/app/+admin/admin-access-control/group-registry/group-form/subgroup-list/subgroups-list.component.spec.ts
# src/app/+admin/admin-access-control/group-registry/groups-registry.component.ts
# src/app/+admin/admin-import-metadata-page/metadata-import-page.component.ts
# src/app/+admin/admin-registries/metadata-registry/metadata-registry.component.ts
# src/app/+admin/admin-registries/metadata-schema/metadata-schema.component.ts
# src/app/+admin/admin-search-page/admin-search-results/admin-search-result-grid-element/item-search-result/item-admin-search-result-grid-element.component.spec.ts
# src/app/+admin/admin-search-page/admin-search-results/admin-search-result-list-element/item-search-result/item-admin-search-result-list-element.component.spec.ts
# src/app/+bitstream-page/bitstream-page.resolver.ts
# src/app/+bitstream-page/edit-bitstream-page/edit-bitstream-page.component.spec.ts
# src/app/+bitstream-page/edit-bitstream-page/edit-bitstream-page.component.ts
# src/app/+collection-page/collection-item-mapper/collection-item-mapper.component.ts
# src/app/+collection-page/collection-page.component.ts
# src/app/+collection-page/edit-collection-page/collection-roles/collection-roles.component.ts
# src/app/+collection-page/edit-item-template-page/item-template-page.resolver.spec.ts
# src/app/+collection-page/edit-item-template-page/item-template-page.resolver.ts
# src/app/+item-page/edit-item-page/item-authorizations/item-authorizations.component.ts
# src/app/+item-page/edit-item-page/item-bitstreams/item-bitstreams.component.spec.ts
# src/app/+item-page/edit-item-page/item-bitstreams/item-bitstreams.component.ts
# src/app/+item-page/edit-item-page/item-collection-mapper/item-collection-mapper.component.ts
# src/app/+item-page/edit-item-page/item-private/item-private.component.ts
# src/app/+item-page/edit-item-page/item-public/item-public.component.ts
# src/app/+item-page/edit-item-page/item-reinstate/item-reinstate.component.ts
# src/app/+item-page/edit-item-page/item-relationships/edit-relationship-list/edit-relationship-list.component.ts
# src/app/+item-page/edit-item-page/item-relationships/item-relationships.component.ts
# src/app/+item-page/edit-item-page/item-withdraw/item-withdraw.component.ts
# src/app/+item-page/simple/item-types/shared/item-relationships-utils.ts
# src/app/+my-dspace-page/collection-selector/collection-selector.component.spec.ts
# src/app/+search-page/search-tracker.component.ts
# src/app/app-routing.module.ts
# src/app/community-list-page/community-list-service.ts
# src/app/community-list-page/community-list.reducer.spec.ts
# src/app/core/auth/auth-response-parsing.service.spec.ts
# src/app/core/auth/auth.interceptor.spec.ts
# src/app/core/browse/browse.service.spec.ts
# src/app/core/browse/browse.service.ts
# src/app/core/cache/builders/link.service.spec.ts
# src/app/core/cache/builders/remote-data-build.service.ts
# src/app/core/cache/object-cache.service.spec.ts
# src/app/core/cache/response.models.ts
# src/app/core/data/base-response-parsing.service.ts
# src/app/core/data/bitstream-data.service.ts
# src/app/core/data/bitstream-format-data.service.ts
# src/app/core/data/bundle-data.service.spec.ts
# src/app/core/data/bundle-data.service.ts
# src/app/core/data/change-analyzer.ts
# src/app/core/data/collection-data.service.spec.ts
# src/app/core/data/collection-data.service.ts
# src/app/core/data/comcol-data.service.spec.ts
# src/app/core/data/comcol-data.service.ts
# src/app/core/data/data.service.ts
# src/app/core/data/entity-type-data.service.ts
# src/app/core/data/entity-type.service.ts
# src/app/core/data/feature-authorization/authorization-data.service.ts
# src/app/core/data/feature-authorization/feature-data.service.ts
# src/app/core/data/item-template-data.service.ts
# src/app/core/data/license-data.service.ts
# src/app/core/data/metadata-field-data.service.ts
# src/app/core/data/processes/process-data.service.ts
# src/app/core/data/processes/script-data.service.ts
# src/app/core/data/relationship.service.spec.ts
# src/app/core/data/relationship.service.ts
# src/app/core/data/remote-data.ts
# src/app/core/data/request.actions.ts
# src/app/core/data/request.effects.ts
# src/app/core/data/request.reducer.spec.ts
# src/app/core/data/request.reducer.ts
# src/app/core/data/request.service.spec.ts
# src/app/core/data/request.service.ts
# src/app/core/dspace-rest/dspace-rest.service.spec.ts
# src/app/core/eperson/eperson-data.service.spec.ts
# src/app/core/eperson/eperson-data.service.ts
# src/app/core/eperson/group-data.service.spec.ts
# src/app/core/eperson/group-data.service.ts
# src/app/core/forward-client-ip/forward-client-ip.interceptor.spec.ts
# src/app/core/index/index.reducer.ts
# src/app/core/json-patch/json-patch-operations.service.spec.ts
# src/app/core/json-patch/json-patch-operations.service.ts
# src/app/core/locale/locale.interceptor.spec.ts
# src/app/core/registry/registry.service.ts
# src/app/core/resource-policy/resource-policy.service.ts
# src/app/core/shared/operators.ts
# src/app/core/shared/search/search.service.ts
# src/app/core/submission/submission-object-data.service.ts
# src/app/core/submission/submission-rest.service.ts
# src/app/core/submission/vocabularies/vocabulary-entries-response-parsing.service.spec.ts
# src/app/core/submission/vocabularies/vocabulary.service.spec.ts
# src/app/core/submission/vocabularies/vocabulary.service.ts
# src/app/core/submission/workflowitem-data.service.ts
# src/app/core/tasks/tasks.service.ts
# src/app/curation-form/curation-form.component.ts
# src/app/process-page/process-page.resolver.ts
# src/app/shared/collection-dropdown/collection-dropdown.component.spec.ts
# src/app/shared/collection-dropdown/collection-dropdown.component.ts
# src/app/shared/comcol-forms/create-comcol-page/create-comcol-page.component.spec.ts
# src/app/shared/comcol-forms/create-comcol-page/create-comcol-page.component.ts
# src/app/shared/comcol-forms/edit-comcol-page/comcol-metadata/comcol-metadata.component.spec.ts
# src/app/shared/comcol-forms/edit-comcol-page/comcol-role/comcol-role.component.spec.ts
# src/app/shared/comcol-forms/edit-comcol-page/comcol-role/comcol-role.component.ts
# src/app/shared/dso-selector/dso-selector/dso-selector.component.ts
# src/app/shared/dso-selector/modal-wrappers/export-metadata-selector/export-metadata-selector.component.ts
# src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/relationship.effects.ts
# src/app/shared/form/builder/form-builder.service.ts
# src/app/shared/item/item-versions/item-versions.component.ts
# src/app/shared/mocks/remote-data-build.service.mock.ts
# src/app/shared/mydspace-actions/workspaceitem/workspaceitem-actions.component.ts
# src/app/shared/object-detail/my-dspace-result-detail-element/item-detail-preview/item-detail-preview.component.spec.ts
# src/app/shared/object-select/collection-select/collection-select.component.spec.ts
# src/app/shared/object-select/item-select/item-select.component.spec.ts
# src/app/shared/pagination-drag-and-drop/abstract-paginated-drag-and-drop-list.component.spec.ts
# src/app/shared/pagination-drag-and-drop/abstract-paginated-drag-and-drop-list.component.ts
# src/app/shared/resource-policies/form/eperson-group-list/eperson-group-list.component.ts
# src/app/shared/search/search-query-response.model.ts
# src/app/statistics/statistics.module.ts
# src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.spec.ts
# src/app/submission/sections/form/section-form.component.ts
# src/app/submission/sections/upload/section-upload.component.spec.ts
# src/app/submission/sections/upload/section-upload.component.ts
# src/app/submission/submission.service.spec.ts
# src/app/submission/submission.service.ts
2021-01-07 19:17:19 +01:00
Alessandro Martelli
8e77fac638
[835] Auto-save in new Item Submission form breaks the form
...
Minor fixes and method computeSectionConfiguredMetadata tested
2020-12-21 19:21:49 +01:00
Alessandro Martelli
042d2e71f0
[835] Auto-save in new Item Submission form breaks the form
...
Improved form touched state in ngrx store.
2020-12-21 17:27:59 +01:00
Alessandro Martelli
9b752b443e
[835] Auto-save in new Item Submission form breaks the form
...
Lint corrections.
2020-12-21 17:23:03 +01:00
Alessandro Martelli
999993734f
[835] Auto-save in new Item Submission form breaks the form
...
Tests fixed.
2020-12-21 17:23:03 +01:00
Alessandro Martelli
875a43a14e
[835] Auto-save in new Item Submission form breaks the form
...
Section formId added to the section state.
Error filtering during the parsing of the submission response.
2020-12-21 17:23:03 +01:00
Alessandro Martelli
8111bdd3ce
[835] Auto-save in new Item Submission form breaks the form
...
Store additions:
1. Form AdditionalData: contains the list of the touched metadata
2. Submission metadata: contains the list of the metadata ids assignable for each section
We keep also track whether a section ha focused fields or not.
2020-12-21 17:22:33 +01:00
Alessandro Martelli
82b7b8aa6f
[835] Auto-save in new Item Submission form breaks the form
...
Notifications are enable only for manual submission savings.
2020-12-21 17:14:36 +01:00
Alessandro Martelli
6136162a21
[835] Auto-save in new Item Submission form breaks the form
...
Notifications are disabled for submission section savings.
2020-12-21 17:14:36 +01:00
Art Lowel
4e18fa35ca
Cache redesign part 1, and add support for alternative links
2020-12-14 16:09:33 +01:00
Giuseppe Digilio
20b5721e3c
Fixed lint errors and add lint fix script
2020-12-04 10:32:46 +01:00
Art Lowel
f167d5a629
fix issue where combining entities and authority control in the same field wouldn't work
2020-09-01 14:25:50 +02:00
Giuseppe Digilio
9ced3530ab
Added inline comments
2020-07-30 19:13:59 +02:00
Giuseppe Digilio
090fb94c4d
Normalized submission section data when retrieving them from item object
2020-07-30 18:50:47 +02:00
lotte
091ec6c917
added missing typedoc + removed console.logs
2020-07-22 10:27:57 +02:00
lotte
b29161988d
fixed broken tests
2020-04-17 11:06:02 +02:00
lotte
cb61b0adda
fixed issue in effects and removed unnecessary console logs
2020-04-16 14:23:23 +02:00
Art Lowel
d6087e3620
remove logs, fix lint issues
2020-04-15 11:24:24 +02:00
Art Lowel
44801701c9
populate submission sections with metadata from single effect
2020-04-10 10:12:21 +02:00
Art Lowel
6b0f76c012
fix nullpointer
2020-04-09 10:30:20 +02:00
Art Lowel
e0d4eb7c9c
ensure submissionsection state also contains all metadata after a save
2020-04-08 18:14:29 +02:00
lotte
74db9030b0
working on fixes for OrgUnit field in submission
2020-04-07 18:17:37 +02:00
Art Lowel
2989ca4d96
fix issues with repeatable fields
2020-04-01 11:06:31 +02:00
Art Lowel
bc8bacab54
Merge branch 'followlink-refactor' into metadata-and-relationships-combined-in-submission
2020-02-24 14:59:28 +01:00
Marie Verdonck
fb153b7b13
68405: test fixes; tbc
2020-02-17 18:17:23 +01:00
Art Lowel
b2f966eb83
fix links for relationships
2020-02-17 18:13:51 +01:00
Art Lowel
44facb8dcb
followlinks
2020-02-17 18:12:13 +01:00
lotte
6053d0691f
bug fix
2020-02-13 08:49:24 +01:00
lotte
0f539ea7d7
trying to fix query in submission entities
2020-02-06 16:28:39 +01:00
