hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-12 04:23:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,292 Commits 23 Branches 25 Tags
c0f43bc585a424cd279f3ee306f00e13f916217d
Commit Graph

383 Commits

Author SHA1 Message Date
Yury Bondarenko
c0f43bc585 ESLint: fix rxjs/no-implicit-any-catch 
In most cases we can deal with the untyped errors by introducing an explicit instanceof check

DspaceRestService includes an unsafe catch/rethrow → made it explicitly typed as `any`, but it should be revisited at some point
 2023-06-28 16:30:38 +02:00
Yury Bondarenko
0633460107 ESLint: fix object-curly-spacing 2023-06-27 17:30:02 +02:00
Yury Bondarenko
a11be65f95 ESlint: fix imports 2023-06-27 17:20:06 +02:00
Yury Bondarenko
917c36dbe7 ESLint: fix dangling commas 2023-06-27 17:19:58 +02:00
Yury Bondarenko
0690a201dc ESLint: fix indentation 2023-06-27 17:19:55 +02:00
Yury Bondarenko
8a650a2fb5 ESlint: fix eqeqeq violations 2023-06-27 17:19:45 +02:00
Yury Bondarenko
741c6009f4 ESLint: fix no-negated-async violations 2023-06-27 17:19:01 +02:00
Yury Bondarenko
6f0c1e003d ESLint: fix no-extra-boolean-cast violations 2023-06-27 16:47:09 +02:00
Tim Donohue
c903df80d8 Merge pull request #2297 from 4Science/DURACOM-152 
Fixed read-only visibility for submission form fields
 2023-06-16 14:08:47 -05:00
Tim Donohue
91027094ed Merge pull request #2252 from alexandrevryghem/issue-1671_fix-relationships-not-updating-view-on-submission-form_contribute-main 
Adding/removing relationships in the submission form does not update the view automatically
 2023-06-15 11:47:04 -05:00
Alisa Ismailati
fda4ef77e4 [DURACOM-152] Section visibility read-only 2023-06-15 12:42:29 +02:00
Yury Bondarenko
c4b2565373 Workaround: don't use form-global data for check 
Note: we're balancing multiple bugs against eachother here, not ideal!
  - the diff doesn't catch removed Relationship fields; instead, form reload is triggered by a dspace.entity.type change
  - if we add the original `this.sectionMetadata.includes(key)` check, we filter out this change and the form fails to update
  - if we add `relation.*` fields to `this.sectionMetadata`, newly added Relationship entries are duplicated

As of this commit, the form _seems_ to work in a stable way, but these issues shoud really investigated in more detail.
 2023-06-09 13:39:33 +02:00
Mark H. Wood
10899aa22c Merge branch 'main' into themeable-section-upload-file 2023-06-01 16:36:09 -04:00
Tim Donohue
aa7409051b Merge pull request #2243 from 4Science/DURACOM-145 
Handled collection step visibility on a submission form
 2023-06-01 11:32:08 -05:00
Tim Donohue
828f2586b1 Merge pull request #2261 from tdonohue/fix_unsafe_links 
Fix several "potentially unsafe external link" warnings
 2023-06-01 10:57:41 -05:00
Mark H. Wood
172f7e527f Merge remote-tracking branch 'upstream/main' into embargo-date 2023-05-25 14:57:25 -04:00
Tim Donohue
d5198659a9 Merge pull request #2129 from alexandrevryghem/retrieve-name-with-dsonameservice-main 
Use the DSONameService to display DSpaceObjects names
 2023-05-22 15:55:47 -05:00
Tim Donohue
edeea00c75 Fix several "potentially unsafe external link" warnings 2023-05-19 16:02:30 -05:00
Mark H. Wood
055ed9ba6e Fix spec broken by signature change. 2023-05-19 14:00:21 -04:00
Mark H. Wood
d54754f78a Conform to expected ngOnChanges signature; tidy up. 2023-05-19 13:36:04 -04:00
Mark H. Wood
f466d0b67c Merge remote-tracking branch 'upstream/main' into themeable-section-upload-file 2023-05-19 13:31:05 -04:00
Alisa Ismailati
9ca04b4b63 [DURACOM-145] Handled collection step 
on a submission form
 2023-05-19 18:31:52 +02:00
Alexandre Vryghem
b878f28db6 Merge remote-tracking branch 'upstream/main' into retrieve-name-with-dsonameservice-main 
# Conflicts:
#	src/app/workflowitems-edit-page/advanced-workflow-action/advanced-workflow-action-select-reviewer/reviewers-list/reviewers-list.component.ts
 2023-05-19 15:00:24 +02:00
Alexandre Vryghem
053063d0f4 Merge remote-tracking branch 'upstream/main' into fix-ngonchanges-not-working-for-themed-components_contribute-main 
# Conflicts:
#	src/app/shared/object-list/metadata-representation-list-element/metadata-representation-list-element.component.ts
#	src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.html
#	src/app/shared/object-list/my-dspace-result-list-element/claimed-search-result/claimed-search-result-list-element.component.ts
#	src/app/shared/object-list/my-dspace-result-list-element/pool-search-result/pool-search-result-list-element.component.ts
#	src/app/shared/shared.module.ts
#	src/app/shared/theme-support/themed.component.ts
#	src/themes/custom/lazy-theme.module.ts
 2023-05-19 13:36:41 +02:00
Alexandre Vryghem
190f245635 Merge tag 'dspace-7.4' into fix-ngonchanges-not-working-for-themed-components_contribute-7.4 
# Conflicts:
#	src/app/admin/admin-search-page/admin-search-results/admin-search-result-grid-element/collection-search-result/collection-admin-search-result-grid-element.component.spec.ts
#	src/app/admin/admin-search-page/admin-search-results/admin-search-result-grid-element/community-search-result/community-admin-search-result-grid-element.component.spec.ts
#	src/app/shared/mydspace-actions/claimed-task/switcher/claimed-task-actions-loader.component.ts
#	src/app/shared/object-collection/shared/listable-object/listable-object-component-loader.component.ts
#	src/app/shared/object-grid/collection-grid-element/collection-grid-element.component.html
#	src/app/shared/object-grid/community-grid-element/community-grid-element.component.html
#	src/app/shared/object-grid/search-result-grid-element/collection-search-result/collection-search-result-grid-element.component.html
#	src/app/shared/object-grid/search-result-grid-element/community-search-result/community-search-result-grid-element.component.html
#	src/app/shared/object-grid/search-result-grid-element/item-search-result/item/item-search-result-grid-element.component.html
#	src/app/shared/theme-support/themed.component.ts
#	src/app/thumbnail/thumbnail.component.spec.ts
#	src/app/thumbnail/thumbnail.component.ts
#	src/themes/custom/lazy-theme.module.ts
 2023-05-19 13:17:26 +02:00
Tim Donohue
ba4d652806 Merge pull request #2204 from atmire/Angular-15-upgrade 
Angular 15 upgrade
 2023-05-18 08:48:58 -05:00
Alexandre Vryghem
8e4247c2ac 101577: Themed ThumbnailComponent 2023-05-18 15:01:46 +02:00
Alexandre Vryghem
4be1b57db3 Merge remote-tracking branch 'upstream/main' into retrieve-name-with-dsonameservice-main 
# Conflicts:
#	src/app/shared/object-detail/my-dspace-result-detail-element/claimed-task-search-result/claimed-task-search-result-detail-element.component.spec.ts
#	src/app/shared/object-detail/my-dspace-result-detail-element/claimed-task-search-result/claimed-task-search-result-detail-element.component.ts
#	src/app/shared/object-detail/my-dspace-result-detail-element/item-detail-preview/item-detail-preview.component.ts
#	src/app/shared/object-detail/my-dspace-result-detail-element/item-search-result/item-search-result-detail-element.component.spec.ts
#	src/app/shared/object-detail/my-dspace-result-detail-element/pool-search-result/pool-search-result-detail-element.component.spec.ts
#	src/app/shared/object-detail/my-dspace-result-detail-element/pool-search-result/pool-search-result-detail-element.component.ts
#	src/app/shared/object-detail/my-dspace-result-detail-element/workflow-item-search-result/workflow-item-search-result-detail-element.component.ts
#	src/app/shared/object-detail/my-dspace-result-detail-element/workspace-item-search-result/workspace-item-search-result-detail-element.component.ts
#	src/app/shared/object-grid/search-result-grid-element/collection-search-result/collection-search-result-grid-element.component.html
#	src/app/shared/object-grid/search-result-grid-element/community-search-result/community-search-result-grid-element.component.html
#	src/app/shared/subscriptions/subscription-modal/subscription-modal.component.html
#	src/app/shared/subscriptions/subscription-view/subscription-view.component.html
 2023-05-13 13:42:19 +02:00
Alexandre Vryghem
d4efd85cc5 Merge remote-tracking branch 'upstream/main' into issue-1671_fix-relationships-not-updating-view-on-submission-form_contribute-main 2023-05-12 17:52:37 +02:00
Alexandre Vryghem
b318d7281a 101654: Fixed relationship fields not being hidden when they are out of scope 2023-05-12 17:52:03 +02:00
Alexandre Vryghem
a6a10200d2 Merge remote-tracking branch 'templates/dspace-7.4' into issue-1671_fix-relationships-not-updating-view-on-submission-form_contribute-7.4 
# Conflicts:
#	src/app/submission/sections/form/section-form.component.spec.ts
#	src/app/submission/sections/form/section-form.component.ts
 2023-05-12 17:36:19 +02:00
samuel
dff343f62e 96598: Test feedback pt. 3: submission - repair auto-refresh - repair tests 2023-05-12 14:51:40 +02:00
samuel
14fb379419 96598: Test feedback pt. 3: submission - repair auto-refresh 2023-05-12 14:51:26 +02:00
Mark H. Wood
c21ab0a86f Enable line breaks in deposit license during submission. 2023-05-03 17:13:06 -04:00
Mark H. Wood
6adc9a1742 Make theme-able. 2023-04-21 09:55:18 -04:00
Mark H. Wood
4f83eaa53d Tidy up interface declarations. 2023-04-21 09:47:18 -04:00
Kristof De Langhe
d21ce38011 101108: Automatic ng update @angular/core@14 2023-04-11 16:18:20 +02:00
Mark H. Wood
1e7ede015b Don't allow the date picker to exceed the maximum start or end date for an access option. 2023-03-06 11:19:49 -05:00
Alexandre Vryghem
83155062cf Merge remote-tracking branch 'upstream/main' into retrieve-name-with-dsonameservice-7.4 
# Conflicts:
#	src/app/access-control/epeople-registry/epeople-registry.component.html
#	src/app/access-control/epeople-registry/eperson-form/eperson-form.component.ts
#	src/app/access-control/group-registry/group-form/group-form.component.spec.ts
#	src/app/access-control/group-registry/group-form/group-form.component.ts
#	src/app/access-control/group-registry/group-form/members-list/members-list.component.html
#	src/app/access-control/group-registry/group-form/members-list/members-list.component.ts
#	src/app/collection-page/edit-item-template-page/edit-item-template-page.component.html
#	src/app/item-page/full/field-components/file-section/full-file-section.component.ts
#	src/app/item-page/media-viewer/media-viewer-video/media-viewer-video.component.ts
#	src/app/item-page/simple/field-components/file-section/file-section.component.html
#	src/app/item-page/simple/field-components/file-section/file-section.component.ts
#	src/app/item-page/versions/item-versions.component.ts
#	src/app/shared/auth-nav-menu/user-menu/user-menu.component.html
#	src/app/shared/auth-nav-menu/user-menu/user-menu.component.ts
#	src/app/shared/object-collection/shared/mydspace-item-submitter/item-submitter.component.html
 2023-03-02 22:13:05 +01:00
Alexandre Vryghem
2513f91a1a Use DSONameService to display DSpaceObjects names 2023-03-02 19:40:36 +01:00
Alexandre Vryghem
553002406f Merge branch 'fix-tests-7.4' into fix-tests-upstream 2023-02-19 01:06:21 +01:00
Alexandre Vryghem
4f14d66400 Fixed lint issues 2023-02-19 01:04:25 +01:00
Alexandre Vryghem
b13f7cdf64 Merge remote-tracking branch 'upstream/main' into fix-tests-upstream 2023-02-19 00:49:30 +01:00
Alexandre Vryghem
718db3466d Fixed false positive tests caused by fixture.debugElement.query().toBeDefined() 2023-02-19 00:23:19 +01:00
Alexandre Vryghem
a6be9204e6 Merge remote-tracking branch 'upstream/main' into w2p-98855_themeable-file-download-link_contribute-main 
# Conflicts:
#	src/themes/custom/eager-theme.module.ts
 2023-02-12 23:22:00 +01:00
Kim Shepherd
b779509bf0 [TLC-249] Identifier mock data updated in unit test 2023-02-07 17:03:49 +13:00
Kim Shepherd
b5c6e7f1b7 [TLC-249] Identifier mock data updated in unit test 2023-02-07 17:03:49 +13:00
Kim Shepherd
d6f458863f [TLC-249] Improve model of identifier data in workspace section 2023-02-07 17:03:49 +13:00
Kim Shepherd
39fb61ca85 [TLC-249] Lint fixes (imports, quotes) 2023-02-07 17:03:49 +13:00
Kim Shepherd
52a3776027 [TLC-249] Addressing review feedback #2 
Update WorkspaceitemSectionIdentifiersObject model to include a
display types string array, so identifier types can be included or excluded
from the step as needed.

Update section template to work with the above new data

As per todonohue's feedback on 2022-01-18
 2023-02-07 17:03:49 +13:00