Fix twitter javascript

When you hate twitter/ X after how awful it's got since Musk bought it, the code will throw a fatal error as `twitterIconElement` is `NULL` when unused - so `setAttribute()` isn't callable.
This commit is contained in:
Paul Maddern
2024-06-28 11:19:36 +01:00
committed by GitHub
parent f3f26d78e2
commit 02ac1ba431

View File

@@ -208,13 +208,15 @@ var style = localStorage.getItem('data-color-mode');
iconElement = document.getElementById('github-icon'); iconElement = document.getElementById('github-icon');
twitterIconElement = document.getElementById('twitter-icon'); twitterIconElement = document.getElementById('twitter-icon');
if (style == 'light') { if (style == 'light') {
iconElement.setAttribute('fill', '#24292e'); if (iconElement) iconElement.setAttribute('fill', '#24292e');
twitterIconElement.setAttribute("fill","black") if (twitterIconElement) twitterIconElement.setAttribute("fill","black")
} }
else { else {
iconElement.removeAttribute('fill'); if (iconElement) {
iconElement.setAttribute('class', 'octicon'); iconElement.removeAttribute('fill');
iconElement.setAttribute('color', '#f0f6fc'); iconElement.setAttribute('class', 'octicon');
twitterIconElement.setAttribute("fill","white") iconElement.setAttribute('color', '#f0f6fc');
}
if (twitterIconElement) twitterIconElement.setAttribute("fill","white")
} }
</script> </script>