Merge pull request #922 from gethinode/develop

Restrict external link validation to http(s) scheme only
Merge branch 'main' into develop
2025-10-12 12:33:20 +00:00 · 2024-05-10 12:52:55 +02:00 · 2024-05-10 12:05:26 +02:00 · 2024-05-10 12:04:44 +02:00 · 2024-05-09 13:12:15 +00:00 · 2024-05-09 13:07:57 +00:00
3 changed files with 12 additions and 9 deletions
--- a/layouts/partials/assets/button.html
+++ b/layouts/partials/assets/button.html
@@ -53,7 +53,10 @@
 {{- $clipboard := .clipboard -}}
 {{- $cue := .cue | default site.Params.main.externalLinks.cue -}}
 {{- $tab := .tab | default site.Params.main.externalLinks.tab -}}
-{{- $isExternal := ne (urls.Parse (absURL $href)).Host (urls.Parse site.BaseURL).Host -}}
+{{- $isExternal := false }}
+{{ if in (slice "http" "https") ((urls.Parse (absURL $href)).Scheme) }}
+    {{ $isExternal = ne (urls.Parse (absURL $href)).Host (urls.Parse site.BaseURL).Host -}}
+{{ end }}
 {{- $target := "" -}}
 {{- $rel := "" -}}
 {{- $spacing := .spacing | default true -}}
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
  "name": "@gethinode/hinode",
-  "version": "0.23.15",
+  "version": "0.23.16",
  "lockfileVersion": 3,
  "requires": true,
  "packages": {
    "": {
      "name": "@gethinode/hinode",
-      "version": "0.23.15",
+      "version": "0.23.16",
      "license": "MIT",
      "devDependencies": {
        "@fullhuman/postcss-purgecss": "^6.0.0",
@@ -20,7 +20,7 @@
        "eslint-plugin-import": "^2.29.1",
        "eslint-plugin-n": "^16.6.2",
        "eslint-plugin-promise": "^6.1.1",
-        "hugo-bin": "0.122.7",
+        "hugo-bin": "0.122.8",
        "markdownlint-cli2": "^0.13.0",
        "netlify-plugin-hugo-cache-resources": "^0.2.1",
        "npm-run-all": "^4.1.5",
@@ -4386,9 +4386,9 @@
      "dev": true
    },
    "node_modules/hugo-bin": {
-      "version": "0.122.7",
-      "resolved": "https://registry.npmjs.org/hugo-bin/-/hugo-bin-0.122.7.tgz",
-      "integrity": "sha512-C7FtWyDm6OgEabxCX9tMCvBFd4dA59XC9R+SMDxwEu2HvzyX13ikTi4mQmr3Gl5f90PD7PaRW02tkRMhIYFglQ==",
+      "version": "0.122.8",
+      "resolved": "https://registry.npmjs.org/hugo-bin/-/hugo-bin-0.122.8.tgz",
+      "integrity": "sha512-sdTfsr6awEchbTVzxV4XiajRsKirEf2au59PiNv4SJzygewDK6CPg5kmzcnjNnjnXWROGvtkBQWzLIUrbaxIOQ==",
      "dev": true,
      "funding": [
        {
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@gethinode/hinode",
-  "version": "0.23.15",
+  "version": "0.23.16",
  "description": "Hinode is a clean documentation and blog theme for Hugo, an open-source static site generator",
  "keywords": [
    "hugo",
@@ -78,7 +78,7 @@
    "eslint-plugin-import": "^2.29.1",
    "eslint-plugin-n": "^16.6.2",
    "eslint-plugin-promise": "^6.1.1",
-    "hugo-bin": "0.122.7",
+    "hugo-bin": "0.122.8",
    "markdownlint-cli2": "^0.13.0",
    "netlify-plugin-hugo-cache-resources": "^0.2.1",
    "npm-run-all": "^4.1.5",
Author	SHA1	Message	Date
Mark Dumay	8ad9f92752	Merge pull request #922 from gethinode/develop Restrict external link validation to http(s) scheme only	2024-05-10 12:52:55 +02:00
Mark Dumay	3cf45385db	Merge branch 'main' into develop	2024-05-10 12:05:26 +02:00
Mark Dumay	83c697a7ae	Restrict external link validation to http(s) scheme only	2024-05-10 12:04:44 +02:00
github-actions[bot]	6b62c2c701	Merge pull request #921 from gethinode/dependabot/npm_and_yarn/hugo-bin-0.122.8 Bump hugo-bin from 0.122.7 to 0.122.8	2024-05-09 13:12:15 +00:00
dependabot[bot]	428e10bc5a	Bump hugo-bin from 0.122.7 to 0.122.8 Bumps [hugo-bin](https://github.com/fenneclab/hugo-bin) from 0.122.7 to 0.122.8. - [Release notes](https://github.com/fenneclab/hugo-bin/releases) - [Commits](https://github.com/fenneclab/hugo-bin/compare/v0.122.7...v0.122.8) --- updated-dependencies: - dependency-name: hugo-bin dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2024-05-09 13:07:57 +00:00