hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-14 05:23:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

call legacy notebook matrix entry legacy_notebook

Browse Source 
instead of nbclassic, which is explicitly classic nb ui on jupyter-server (the opposite of these tests)
This commit is contained in:
Min RK
2022-07-13 16:20:40 -07:00
parent dee671b640
commit 001d0c9af1
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
.github/workflows/test.yml vendored
View File

@@ -56,9 +56,9 @@ jobs:
# Tests everything when JupyterHub works against a dedicated mysql or # Tests everything when JupyterHub works against a dedicated mysql or
# postgresql server. # postgresql server.
# #
# nbclassic: # legacy_notebook:
# Tests everything when the user instances are started with # Tests everything when the user instances are started with
# notebook instead of jupyter_server. # the legacy notebook server instead of jupyter_server.
# #
# ssl: # ssl:
# Tests everything using internal SSL connections instead of # Tests everything using internal SSL connections instead of
@@ -74,8 +74,8 @@ jobs:
include: include:
- python: "3.6" - python: "3.6"
oldest_dependencies: oldest_dependencies oldest_dependencies: oldest_dependencies
nbclassic: nbclassic
- python: "3.6" - python: "3.6"
legacy_notebook: legacy_notebook
subdomain: subdomain subdomain: subdomain
- python: "3.7" - python: "3.7"
db: mysql db: mysql
@@ -84,7 +84,7 @@ jobs:
- python: "3.8" - python: "3.8"
db: postgres db: postgres
- python: "3.8" - python: "3.8"
nbclassic: nbclassic legacy_notebook: legacy_notebook
- python: "3.9" - python: "3.9"
main_dependencies: main_dependencies main_dependencies: main_dependencies
@@ -148,9 +148,9 @@ jobs:
if [ "${{ matrix.main_dependencies }}" != "" ]; then if [ "${{ matrix.main_dependencies }}" != "" ]; then
pip install git+https://github.com/ipython/traitlets#egg=traitlets --force pip install git+https://github.com/ipython/traitlets#egg=traitlets --force
fi fi
if [ "${{ matrix.nbclassic }}" != "" ]; then if [ "${{ matrix.legacy_notebook }}" != "" ]; then
pip uninstall jupyter_server --yes pip uninstall jupyter_server --yes
pip install notebook pip install 'notebook<7'
fi fi
if [ "${{ matrix.db }}" == "mysql" ]; then if [ "${{ matrix.db }}" == "mysql" ]; then
pip install mysql-connector-python pip install mysql-connector-python