hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-10 19:43:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3381 from minrk/rm-redundant-args

Browse Source 
Stop specifying `--ip` and `--port` on the command-line
This commit is contained in:
Min RK
2021-05-21 10:09:16 +02:00
committed by GitHub
parent 6be3160d74 401f583c5a
commit 05f47b14f3
6 changed files with 224 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
jupyterhub/tests/test_api.py
View File

@@ -589,10 +589,17 @@ async def test_spawn(app):
r = await async_requests.get(ujoin(url, 'args'), **kwargs)
assert r.status_code == 200
argv = r.json()
assert '--port' in ' '.join(argv)
assert '--port' not in ' '.join(argv)
# we pass no CLI args anymore:
assert len(argv) == 1
r = await async_requests.get(ujoin(url, 'env'), **kwargs)
env = r.json()
for expected in ['JUPYTERHUB_USER', 'JUPYTERHUB_BASE_URL', 'JUPYTERHUB_API_TOKEN']:
for expected in [
'JUPYTERHUB_USER',
'JUPYTERHUB_BASE_URL',
'JUPYTERHUB_API_TOKEN',
'JUPYTERHUB_SERVICE_URL',
]:
assert expected in env
if app.subdomain_host:
assert env['JUPYTERHUB_HOST'] == app.subdomain_host