hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-13 04:53:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

use fully-escaped name in oauth_client_id

Browse Source 
because it will be a cookie key
and @ is not legal there
This commit is contained in:
Min RK
2017-08-11 16:32:54 +02:00
parent 2698b00fb9
commit 0c09bfcafa
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
jupyterhub/user.py
View File

@@ -343,9 +343,11 @@ class User(HasTraits):
# create API and OAuth tokens # create API and OAuth tokens
spawner.api_token = api_token spawner.api_token = api_token
spawner.admin_access = self.settings.get('admin_access', False) spawner.admin_access = self.settings.get('admin_access', False)
client_id = 'user-%s' % self.escaped_name # use fully quoted name for client_id because it will be used in cookie-name
# self.escaped_name may contain @ which is legal in URLs but not cookie keys
client_id = 'user-%s' % quote(self.name)
if server_name: if server_name:
client_id = '%s-%s' % (client_id, server_name) client_id = '%s-%s' % (client_id, quote(server_name))
spawner.oauth_client_id = client_id spawner.oauth_client_id = client_id
oauth_provider = self.settings.get('oauth_provider') oauth_provider = self.settings.get('oauth_provider')
if oauth_provider: if oauth_provider: