From 0c43feee1bf4df1b9fa1611861e9c64db2b44ddb Mon Sep 17 00:00:00 2001 From: Min RK Date: Tue, 17 Nov 2020 12:15:32 +0100 Subject: [PATCH] run tests with oldest-supported versions to catch any cases where we make assumptions about more recent versions than we claim to support --- .github/workflows/test.yml | 10 ++++++++++ .gitignore | 1 + 2 files changed, 11 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 671bf5d6..9b7d5452 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -85,6 +85,8 @@ jobs: # GitHub UI when the workflow run, we avoid using true/false as # values by instead duplicating the name to signal true. include: + - python: "3.6" + oldest_dependencies: oldest_dependencies - python: "3.6" subdomain: subdomain - python: "3.7" @@ -143,6 +145,14 @@ jobs: pip install --upgrade pip pip install --upgrade . -r dev-requirements.txt + if [ "${{ matrix.oldest_dependencies }}" != "" ]; then + # take any dependencies in requirements.txt such as tornado>=5.0 + # and transform them to tornado==5.0 so we can run tests with + # the earliest-supported versions + cat requirements.txt | grep '>=' | sed -e 's@>=@==@g' > oldest-requirements.txt + pip install -r oldest-requirements.txt + fi + if [ "${{ matrix.main_dependencies }}" != "" ]; then pip install git+https://github.com/ipython/traitlets#egg=traitlets --force fi diff --git a/.gitignore b/.gitignore index 44a7b3d4..5ff18d83 100644 --- a/.gitignore +++ b/.gitignore @@ -28,3 +28,4 @@ htmlcov .pytest_cache pip-wheel-metadata docs/source/reference/metrics.rst +oldest-requirements.txt