hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-17 15:03:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add prometheus metric to measure proxy route deletion times

Browse Source
This commit is contained in:
rajat404
2019-10-18 20:13:38 +05:30
parent 66f8d6a626
commit 175c8d0585
2 changed files with 43 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
jupyterhub/handlers/base.py
View File

@@ -33,7 +33,9 @@ from tornado.web import RequestHandler
from .. import __version__
from .. import orm
from ..metrics import PROXY_ADD_DURATION_SECONDS
from ..metrics import PROXY_DELETE_DURATION_SECONDS
from ..metrics import ProxyAddStatus
from ..metrics import ProxyDeleteStatus
from ..metrics import RUNNING_SERVERS
from ..metrics import SERVER_POLL_DURATION_SECONDS
from ..metrics import SERVER_SPAWN_DURATION_SECONDS
@@ -1005,7 +1007,17 @@ class BaseHandler(RequestHandler):
self.log.warning(
"User %s server stopped, with exit code: %s", user.name, status
)
await self.proxy.delete_user(user, server_name)
proxy_deletion_start_time = time.perf_counter()
try:
await self.proxy.delete_user(user, server_name)
PROXY_DELETE_DURATION_SECONDS.labels(
status=ProxyDeleteStatus.success
).observe(time.perf_counter() - proxy_deletion_start_time)
except:
PROXY_DELETE_DURATION_SECONDS.labels(
status=ProxyDeleteStatus.failure
).observe(time.perf_counter() - proxy_deletion_start_time)
await user.stop(server_name)
async def stop_single_user(self, user, server_name=''):
@@ -1028,6 +1040,10 @@ class BaseHandler(RequestHandler):
tic = time.perf_counter()
try:
await self.proxy.delete_user(user, server_name)
PROXY_DELETE_DURATION_SECONDS.labels(
status=ProxyDeleteStatus.success
).observe(time.perf_counter() - tic)
await user.stop(server_name)
toc = time.perf_counter()
self.log.info(
@@ -1047,6 +1063,9 @@ class BaseHandler(RequestHandler):
},
)
except:
PROXY_DELETE_DURATION_SECONDS.labels(
status=ProxyDeleteStatus.failure
).observe(time.perf_counter() - tic)
SERVER_STOP_DURATION_SECONDS.labels(
status=ServerStopStatus.failure
).observe(time.perf_counter() - tic)