hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-17 23:13:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Teach FormSpawner to handle query next=/path/to/landing

Browse Source 
* before, if /user-redirect/ was used, or if ?next=/path/
  and there was a FormSpawner, the query param would be lost
This commit is contained in:
Mike Gevaert
2017-03-17 14:00:14 +01:00
parent 6078b8d9e5
commit 21af37a7a3
5 changed files with 24 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
jupyterhub/tests/test_pages.py
View File

@@ -114,6 +114,10 @@ def test_spawn_page(app):
assert r.url.endswith('/spawn')
assert FormSpawner.options_form in r.text
r = get_page('spawn?next=foo', app, cookies=cookies)
assert r.url.endswith('/spawn?next=foo')
assert FormSpawner.options_form in r.text
def test_spawn_form(app, io_loop):
with mock.patch.dict(app.users.settings, {'spawner_class': FormSpawner}):
base_url = ujoin(public_host(app), app.hub.server.base_url)
@@ -122,11 +126,12 @@ def test_spawn_form(app, io_loop):
u = app.users[orm_u]
io_loop.run_sync(u.stop)
r = requests.post(ujoin(base_url, 'spawn'), cookies=cookies, data={
r = requests.post(ujoin(base_url, 'spawn?next=/user/jones/tree'), cookies=cookies, data={
'bounds': ['-1', '1'],
'energy': '511keV',
})
r.raise_for_status()
assert r.history
print(u.spawner)
print(u.spawner.user_options)
assert u.spawner.user_options == {