hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-13 04:53:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

make sure named server URLs include trailing slash

Browse Source
This commit is contained in:
Min RK
2023-03-30 12:29:56 +02:00
parent e42066f1c9
commit 295e92270b
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
jupyterhub/tests/test_user.py
View File

@@ -53,3 +53,16 @@ def test_sync_groups(app, user, group_names):
assert user.orm_user in group.users assert user.orm_user in group.users
else: else:
assert user.orm_user not in group.users assert user.orm_user not in group.users
@pytest.mark.parametrize(
"server_name, path",
[
("", ""),
("name", "name/"),
("næme", "n%C3%A6me/"),
],
)
def test_server_url(app, user, server_name, path):
user_url = user.url
assert user.server_url(server_name) == user_url + path

2
jupyterhub/user.py
View File

@@ -588,7 +588,7 @@ class User:
if not server_name: if not server_name:
return self.url return self.url
else: else:
return url_path_join(self.url, url_escape_path(server_name)) return url_path_join(self.url, url_escape_path(server_name), "/")
def progress_url(self, server_name=''): def progress_url(self, server_name=''):
"""API URL for progress endpoint for a server with a given name""" """API URL for progress endpoint for a server with a given name"""