From 29d84f41921c9bdefcc2bea1c39c5de735996f8f Mon Sep 17 00:00:00 2001 From: Min RK Date: Tue, 22 Nov 2022 09:41:24 +0100 Subject: [PATCH] selenium: update next_url after waiting for it to change --- jupyterhub/tests/selenium/test_browser.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jupyterhub/tests/selenium/test_browser.py b/jupyterhub/tests/selenium/test_browser.py index 9c52878c..d02348cb 100644 --- a/jupyterhub/tests/selenium/test_browser.py +++ b/jupyterhub/tests/selenium/test_browser.py @@ -88,9 +88,8 @@ def clear(browser, by_locator): # LOGIN PAGE async def test_elements_of_login_page(app, browser): await open_url(app, browser) - logo = is_displayed(browser, LoginPageLocators.LOGO) + assert is_displayed(browser, LoginPageLocators.LOGO) logo_text = browser.find_element(*LoginPageLocators.LOGO).get_attribute("innerHTML") - assert logo == True async def login(browser, user, pass_w): @@ -186,10 +185,11 @@ async def test_open_url_login( assert next_url.endswith("spawn?param=value") assert f"user/{user}/" not in next_url else: - if next_url.endswith(f"/user/{user}/") == False: + if not next_url.endswith(f"/user/{user}/"): await webdriver_wait( browser, EC.url_to_be(ujoin(public_url(app), f"/user/{user}/")) ) + next_url = browser.current_url assert next_url.endswith(f"/user/{user}/")