From 2bc5061e22bff622971d465fb14253fbc5e59d45 Mon Sep 17 00:00:00 2001 From: Simon Li Date: Wed, 1 Jun 2022 22:21:00 +0100 Subject: [PATCH] Don't escape servername in json blobs --- jupyterhub/proxy.py | 2 +- jupyterhub/tests/test_named_servers.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/jupyterhub/proxy.py b/jupyterhub/proxy.py index 8544cdc6..8d01debd 100644 --- a/jupyterhub/proxy.py +++ b/jupyterhub/proxy.py @@ -288,7 +288,7 @@ class Proxy(LoggingConfigurable): await self.add_route( spawner.proxy_spec, spawner.server.host, - {'user': user.name, 'server_name': url_escape_path(server_name)}, + {'user': user.name, 'server_name': server_name}, ) async def delete_user(self, user, server_name=''): diff --git a/jupyterhub/tests/test_named_servers.py b/jupyterhub/tests/test_named_servers.py index 5bd170ad..52cc2e30 100644 --- a/jupyterhub/tests/test_named_servers.py +++ b/jupyterhub/tests/test_named_servers.py @@ -175,7 +175,7 @@ async def test_create_invalid_named_server(app, named_servers): r.raise_for_status() assert exc.value.response.json() == { 'status': 400, - 'message': 'Invalid server_name: a$/b', + 'message': "Invalid server_name (may not contain '/'): a$/b", }