hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-16 14:33:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3261 from minrk/next-append-query

Browse Source 
Only preserve params when ?next= is unspecified
This commit is contained in:
Min RK
2020-11-20 09:47:20 +01:00
committed by GitHub
parent fa61f06fed 87e4f458fb
commit 2e043241fb
3 changed files with 100 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
jupyterhub/handlers/base.py
View File

@@ -634,6 +634,12 @@ class BaseHandler(RequestHandler):
next_url,
)
# this is where we know if next_url is coming from ?next= param or we are using a default url
if next_url:
next_url_from_param = True
else:
next_url_from_param = False
if not next_url:
# custom default URL, usually passed because user landed on that page but was not logged in
if default:
@@ -659,7 +665,10 @@ class BaseHandler(RequestHandler):
else:
next_url = url_path_join(self.hub.base_url, 'home')
next_url = self.append_query_parameters(next_url, exclude=['next'])
if not next_url_from_param:
# when a request made with ?next=... assume all the params have already been encoded
# otherwise, preserve params from the current request across the redirect
next_url = self.append_query_parameters(next_url, exclude=['next'])
return next_url
def append_query_parameters(self, url, exclude=None):