hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-18 15:33:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

GET /users: make sure there's always a join on Spawner

Browse Source 
needed for contains_eager
This commit is contained in:
Min RK
2025-07-23 09:04:16 -07:00
parent 7819b5cc3e
commit 2e66cabe8d
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
jupyterhub/apihandlers/users.py
View File

@@ -162,12 +162,15 @@ class UserListAPIHandler(APIHandler):
) )
elif state_filter: elif state_filter:
raise web.HTTPError(400, f"Unrecognized state filter: {state_filter!r}") raise web.HTTPError(400, f"Unrecognized state filter: {state_filter!r}")
else:
# need a join on Spawner for contains_eager below
query = query.outerjoin(orm.Spawner, orm.User._orm_spawners)
# apply eager load options # apply eager load options
query = query.options( query = query.options(
selectinload(orm.User.roles), selectinload(orm.User.roles),
selectinload(orm.User.groups), selectinload(orm.User.groups),
contains_eager(orm.User._orm_spawners).joinedload(orm.Spawner.user), contains_eager(orm.User._orm_spawners).contains_eager(orm.Spawner.user),
# raiseload here helps us make sure we've loaded everything in one query # raiseload here helps us make sure we've loaded everything in one query
# but since we share a single db session, we can't do this for real # but since we share a single db session, we can't do this for real
# but it's useful in testing # but it's useful in testing