From 786c7039d6dbbd21376bca94aacc4be8a0139c98 Mon Sep 17 00:00:00 2001 From: Jia Junjie <62194633+jiajunjie@users.noreply.github.com> Date: Tue, 13 Apr 2021 08:01:59 +0000 Subject: [PATCH] Log the exception raised in Spawner.post_stop_hook instead of raising it --- jupyterhub/user.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/jupyterhub/user.py b/jupyterhub/user.py index bf8603f8..ce1dc300 100644 --- a/jupyterhub/user.py +++ b/jupyterhub/user.py @@ -826,10 +826,7 @@ class User: try: await maybe_future(spawner.run_post_stop_hook()) except: - spawner.clear_state() - spawner.orm_spawner.state = spawner.get_state() - self.db.commit() - raise + self.log.exception("Error in Spawner.post_stop_hook for %s", self) spawner.clear_state() spawner.orm_spawner.state = spawner.get_state() self.db.commit()