hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-18 15:33:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

consistent submit buttons

Browse Source
This commit is contained in:
Min RK
2024-04-17 15:44:17 +02:00
parent 01e7d00829
commit 7d7db9774f
4 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
jupyterhub/tests/browser/test_share.py
View File

@@ -52,12 +52,12 @@ async def test_share_code_flow_full(app, browser, full_spawn, create_user_with_s
assert f"access {user.name}'s server" in header_text assert f"access {user.name}'s server" in header_text
assert f"You ({share_user.name})" in header_text assert f"You ({share_user.name})" in header_text
# TODO verify form # TODO verify form
submit = browser.locator('//input[@type="submit"]') submit = browser.locator('//button[@type="submit"]')
await submit.click() await submit.click()
# redirects to server, which triggers oauth approval # redirects to server, which triggers oauth approval
await expect(browser).to_have_url(re.compile(r".*/oauth2/authorize")) await expect(browser).to_have_url(re.compile(r".*/oauth2/authorize"))
submit = browser.locator('//input[@type="submit"]') submit = browser.locator('//button[@type="submit"]')
await submit.click() await submit.click()
# finally, we are at the server! # finally, we are at the server!

2
share/jupyterhub/templates/accept-share.html
View File

@@ -45,7 +45,7 @@
<p> <p>
After accepting the invitation, you will be redirected to <a href="{{ next_url | safe }}">{{ next_url }}</a>. After accepting the invitation, you will be redirected to <a href="{{ next_url | safe }}">{{ next_url }}</a>.
</p> </p>
<input type="submit" value="Accept invitation" class="form-control btn-jupyter" /> <button type="submit" class="form-control btn btn-jupyter" >Accept invitation</button>
</form> </form>
</div> </div>
</div></div></div> </div></div></div>

2
share/jupyterhub/templates/spawn.html
View File

@@ -25,7 +25,7 @@
{{spawner_options_form | safe}} {{spawner_options_form | safe}}
<br> <br>
<div class="feedback-container"> <div class="feedback-container">
<input type="submit" value="Start" class="btn btn-jupyter form-control"> <button type="submit" class="btn btn-jupyter form-control">Start</button>
<div class="feedback-widget hidden"> <div class="feedback-widget hidden">
<i class="fa fa-spinner"></i> <i class="fa fa-spinner"></i>
</div> </div>

1
testing/jupyterhub_config.py
View File

@@ -19,6 +19,7 @@ c.JupyterHub.bind_url = 'http://127.0.0.1:8000'
# don't cache static files # don't cache static files
c.JupyterHub.tornado_settings = { c.JupyterHub.tornado_settings = {
"no_cache_static": True, "no_cache_static": True,
"slow_spawn_timeout": 0,
} }
c.JupyterHub.allow_named_servers = True c.JupyterHub.allow_named_servers = True