hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-16 14:33:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't double-check _stop_pending flag

Browse Source 
could cause spurious raises of Timeout errors
This commit is contained in:
Min RK
2018-04-09 15:58:39 +02:00
parent 151acd5bec
commit 7e3fa8c38d
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
jupyterhub/handlers/base.py
View File

@@ -697,11 +697,8 @@ class BaseHandler(RequestHandler):
try: try:
await gen.with_timeout(timedelta(seconds=self.slow_stop_timeout), stop()) await gen.with_timeout(timedelta(seconds=self.slow_stop_timeout), stop())
except gen.TimeoutError: except gen.TimeoutError:
if spawner._stop_pending:
# hit timeout, but stop is still pending # hit timeout, but stop is still pending
self.log.warning("User %s:%s server is slow to stop", user.name, name) self.log.warning("User %s:%s server is slow to stop", user.name, name)
else:
raise
#--------------------------------------------------------------- #---------------------------------------------------------------
# template rendering # template rendering