From 8a1110f2c09f73740af178c766e22bb225d7b13a Mon Sep 17 00:00:00 2001 From: Min RK Date: Tue, 16 Aug 2022 13:48:36 +0200 Subject: [PATCH] admin: avoid redundant client-side username validation username validation is the server-side's responsibility --- jsx/src/components/EditUser/EditUser.jsx | 36 ++++-------------------- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git a/jsx/src/components/EditUser/EditUser.jsx b/jsx/src/components/EditUser/EditUser.jsx index ec9cb70e..211b9c46 100644 --- a/jsx/src/components/EditUser/EditUser.jsx +++ b/jsx/src/components/EditUser/EditUser.jsx @@ -125,38 +125,12 @@ const EditUser = (props) => { if (updatedUsername == "" && admin == has_admin) { noChangeEvent(); return; - } else if (updatedUsername != "") { - if ( - updatedUsername.length > 2 && - /[!@#$%^&*(),.?":{}|<>]/g.test(updatedUsername) == false - ) { - editUser( - username, - updatedUsername != "" ? updatedUsername : username, - admin - ) - .then((data) => { - data.status < 300 - ? updateUsers(0, limit) - .then((data) => dispatchPageChange(data, 0)) - .then(() => history.push("/")) - .catch(() => - setErrorAlert( - `Could not update users list.` - ) - ) - : setErrorAlert(`Failed to edit user.`); - }) - .catch(() => { - setErrorAlert(`Failed to edit user.`); - }); - } else { - setErrorAlert( - `Failed to edit user. Make sure the username does not contain special characters.` - ); - } } else { - editUser(username, username, admin) + editUser( + username, + updatedUsername != "" ? updatedUsername : username, + admin + ) .then((data) => { data.status < 300 ? updateUsers(0, limit)