hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-12 20:43:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add inline comment to test

Browse Source
This commit is contained in:
Erik Sundell
2019-11-18 18:56:08 +01:00
parent ce34c12349
commit 9ec4e6d1d1
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
jupyterhub/tests/test_app.py
View File

@@ -46,16 +46,20 @@ def test_raise_error_on_missing_specified_config():
Using the -f or --config flag when starting JupyterHub should require the Using the -f or --config flag when starting JupyterHub should require the
file to be found and exit if it isn't. file to be found and exit if it isn't.
""" """
# subprocess.run doesn't have a timeout flag, so if this test would fail by
# not letting jupyterhub error out, we would wait forever. subprocess.Popen
# allow us to manually timeout.
process = Popen( process = Popen(
[sys.executable, '-m', 'jupyterhub', '--config', 'not-available.py'] [sys.executable, '-m', 'jupyterhub', '--config', 'not-available.py']
) )
# wait inpatiently for the process to exit # wait inpatiently for the process to exit like we want it to
for i in range(100): for i in range(100):
time.sleep(0.1) time.sleep(0.1)
returncode = process.poll() returncode = process.poll()
if returncode is not None: if returncode is not None:
break break
process.kill() else:
process.kill()
assert returncode == 1 assert returncode == 1